D8168: kcm_input: Refactor the code and add support for libinput under X11

xuetianweng added a comment. ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8361: Add option to change Oxygen's windows decoration shadow intensity

ngraham added reviewers: broulik, aacid. ngraham added a subscriber: aacid. ngraham added a comment. https://phabricator.kde.org/tag/vdg/ is pretty quiet lately. Not much movement may mean that nobody is very excited, but it also means that nobody has a serious objection. :) Let's add a few

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

Zren added a comment. No prob, thanks for accepting it (including the mockup stuff). It'll make it easier to test if I see anything else.  REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8324 To: Zren, ivan Cc: ngraham, plasma-devel, ZrenBot, progwolff,

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

This revision was automatically updated to reflect the committed changes. Closed by commit R845:0ad9e0a1fdc2: Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size (authored by Zren). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE

D8361: Add option to change Oxygen's windows decoration shadow intensity

rpelorosso added a comment. @ngraham Sorry to bother you, but I'm fairly new to this process. As this hasn't gotten any attention, is there any other group that might want to review this beside VDG? (or is it just that there's no interest in something like this? Thanks! REPOSITORY R113

D7047: Wallpaper blur background filling effect feature

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Personally I approve, in and of itself the feature looks fine. I think we should consider the UI though, as adding more background effects exacerbates an existing problem. But I won't

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Looks ok. Sorry for the late response, I was at a conference without access to Phab. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8324 To: Zren, ivan Cc:

D8436: use a single QML engine

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.cpp:106 > !! right, since it keeps track of attached properties in this way, either gets changed or is not possible to use a single engine, damn :/ hmm, maybe using the rootcontext

D1230: GBM remote access support for KWin

Kanedias added a comment. Ok @subdiff, I've got your idea. I'll align my patches with newest sources ASAP, check that they work, then we'll talk about what to do with KDE Daemon and Screen Recorder. I just don't want to spread my efforts too much, maintaining more than one patchset in

D1230: GBM remote access support for KWin

subdiff added a comment. In https://phabricator.kde.org/D1230#159026, @Kanedias wrote: > > On the other side PipeWire is pretty new and its documentation is nearly non-existent. I don't know if with PipeWire it really could work in the way I described above. Your current solution works

D1230: GBM remote access support for KWin

Kanedias added a comment. > On the other side PipeWire is pretty new and its documentation is nearly non-existent. I don't know if with PipeWire it really could work in the way I described above. Your current solution works right now. It might still be an idea if you are interested to check

D1230: GBM remote access support for KWin

subdiff added a task: T5653: [kwin] Screen recording in Wayland session. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, subdiff, #kwin Cc: subdiff, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, bwowk,

D1231: Add Remote Access interface to KWayland

subdiff added a task: T5653: [kwin] Screen recording in Wayland session. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: subdiff, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff,

D1230: GBM remote access support for KWin

subdiff added a comment. In https://phabricator.kde.org/D1230#158987, @Kanedias wrote: > > The thing is I would like to see your solution also be applicable to other apps that need access to the buffer contents, like screen recording tools (SimpleScreenRecorder for example) and so on.

Re: Kirigami/qmake deployment on Android problems

Even more, in my case the combination of: Style=Material and import org.kde.kirigami 2.2 as Kirigami always exists with code 255 on the desktop. On android the error: W/libmedOS_App.so( 5081): qrc:/styles/org.kde.desktop/Units.qml:100 QtQuickControlsPrivate.StyleItem is not a type disappears

D1230: GBM remote access support for KWin

Kanedias added a comment. > The thing is I would like to see your solution also be applicable to other apps that need access to the buffer contents, like screen recording tools (SimpleScreenRecorder for example) and so on. If you say KRfb does the heavy-lifting, I assume such a screen

Re: Kirigami/qmake deployment on Android problems

I've been messing around more and i found out that the minimalqmake example dies on my desktop when in the file qtquickcontrols2.conf is set Style=Material but if instead is set Style=Default it works on the desktop. On android it still crashes 2017-10-23 9:27 GMT-05:00 Camilo Higuita

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

ngraham added a comment. @graesslin, does this still need changes to be merge-worthy? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 To: xuetianweng, davidedmundson Cc: z3ntu, ngraham, knambiar, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8369: Fix rendering issues of subsurfaces by using proper clipping

davidedmundson added a comment. https://bugreports.qt.io/browse/QTBUG-54888 I'll fix that. REPOSITORY R108 KWin BRANCH fix-clipping-subsurfaces-5.11 REVISION DETAIL https://phabricator.kde.org/D8369 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel,

Re: Kirigami/qmake problems (updated)

On Mon, Oct 23, 2017 at 1:56 AM, Camilo Higuita Rodriguez wrote: > Hi, sorry for spamming but in my last message i was missing some > information. > > I'm trying to build an application using Kirigami, but i'm stuck with a few > issues, and i thought maybe you could help

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

z3ntu added a comment. This patch works for me :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 To: xuetianweng, davidedmundson Cc: z3ntu, ngraham, knambiar, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8369: Fix rendering issues of subsurfaces by using proper clipping

graesslin added a comment. In https://phabricator.kde.org/D8369#158912, @davidedmundson wrote: > Seems to fix the issue mentioned. Works fine with scaling. > > It doesn't fix all issues; some system settings modules still paint outside their bounds; but we can address that later.

D8436: use a single QML engine

davidedmundson added inline comments. INLINE COMMENTS > configmodule.cpp:106 > { > ConfigModulePrivate::s_rootObjects.remove(d->_qmlObject->engine()); > !! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8436 To: mart, #plasma Cc:

D8436: use a single QML engine

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY use a shared qml engine for all ConfigModules in the same process this avoids some crashes

D8065: Ensure libinput connection thread uses real time scheduling

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH libinput-rr REVISION DETAIL https://phabricator.kde.org/D8065 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, anthonyfieroni, plasma-devel, kwin, ZrenBot,

D8065: Ensure libinput connection thread uses real time scheduling

davidedmundson added a comment. Why didn't you just call gainRealTime again with reset_on_fork from the connection thread? By creating it without and then changing the main thread after we've created the input thread, we're also putting your DBus thread, and the thread used by the fake

D8369: Fix rendering issues of subsurfaces by using proper clipping

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems to fix the issue mentioned. Works fine with scaling. It doesn't fix all issues; some system settings modules still paint outside their bounds; but we can address

Re: Kirigami/qmake deployment on Android problems

Hi Marco, did you manage to get a simple hello world (new project by qt creator" > to run properly? Yes, i can deploy any qml project with qtcreator to my android device without problems. The minimalqmake example crashes both on desktop and android for me. on desktop: exited with code 255 I

Re: System Settings KCM Tidying

Am 2017-10-23 11:10, schrieb David Edmundson: Andres Betts has done a fantastic job of a tonne of doing an initial mockup of the new KCMs. The mockups are available here: https://phabricator.kde.org/M112 This is going to be a combination of UI redesign, code cleanup and QtQuick porting. We

D8435: Make sure the content of the SwipeListItem doesn't overlap the handle

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 385974 REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

D1231: Add Remote Access interface to KWayland

subdiff added inline comments. INLINE COMMENTS > Kanedias wrote in remote_access_interface.cpp:206 > > Can a rogue client do it though? This would crash the server then? > > Yes, I guess so... What would you propose? Should we send it only to first > bound? Or last one? > > P.S. Even more:

D8397: Align logout screen action buttons to the top

aleksejshilin added a comment. I don't have push access, so could you do that for me, please? :) I've attached the original diff made with 'git format-patch' for your convenience. F5445601: 0001-Align-logout-screen-action-buttons-to-the-top.patch

D1230: GBM remote access support for KWin

subdiff added a comment. In https://phabricator.kde.org/D1230#158816, @Kanedias wrote: > Well, it has `active` property in KWayland that is true only if at least one client is connected (if I remember my code from 6 months back correctly), so I can expose it and use here. Will this

D1231: Add Remote Access interface to KWayland

Kanedias added inline comments. INLINE COMMENTS > subdiff wrote in remote_access_interface.cpp:206 > Can a rogue client do it though? This would crash the server then? > Can a rogue client do it though? This would crash the server then? Yes, I guess so... What would you propose? Should we send

D8339: Drop pre Qt5.9 changes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:473c9a38e2b9: Drop pre Qt5.9 changes (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8339?vs=20881=21173 REVISION DETAIL

D1230: GBM remote access support for KWin

subdiff added a comment. In https://phabricator.kde.org/D1230#158801, @davidedmundson wrote: > > The RemoteAccessManager is active all the time. It would be nice if it would be only active if there are clients who ask for buffers. > > How is a client going to ask for a buffer if

D1230: GBM remote access support for KWin

Kanedias added a comment. In https://phabricator.kde.org/D1230#158795, @subdiff wrote: > Hi Oleg Hi. Haven't been here in a long time. > - Please merge current master. Will do this and fix review comments on weekend (or earlier if I can). > - The RemoteAccessManager

[Plasma Workspace Wallpapers] [Bug 386093] Kubuntu KDE Desktop Icons shown like Memorydump (wild colors) after start from sleep mode

https://bugs.kde.org/show_bug.cgi?id=386093 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

D1230: GBM remote access support for KWin

davidedmundson added a comment. > The RemoteAccessManager is active all the time. It would be nice if it would be only active if there are clients who ask for buffers. How is a client going to ask for a buffer if there is no RemoteAccessManagerInterface? (which this owns) > Then in

D1230: GBM remote access support for KWin

subdiff added reviewers: subdiff, KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, subdiff, #kwin Cc: subdiff, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, bwowk, leezu, ZrenBot, progwolff,

D1230: GBM remote access support for KWin

subdiff added a comment. Hi Oleg, sorry that I haven't given you feedback to your patch series until now. First some smaller points: - Please merge current master. - What about the software cursor dynamically switching? I don't see where it does that. - The RemoteAccessManager

Re: System Settings KCM Tidying

On pondělí 23. října 2017 13:57:52 CEST David Edmundson wrote: > On Mon, Oct 23, 2017 at 1:42 PM, Jan Grulich wrote: > > Hi, > > > > I added myself to "Connection" KCM if you don't mind, > > Awesome. I hoped you would :) > > > but I have a question. > > Do you expect that

D1231: Add Remote Access interface to KWayland

subdiff added inline comments. INLINE COMMENTS > remote_access_interface.cpp:206 > +// no reason for client to bind wl_output multiple times > +Q_ASSERT(boundScreens.size() == 1); > +org_kde_kwin_remote_access_manager_send_buffer_ready(res, buf->fd(), > boundScreens[0]);

D8432: Use nullptr. Initialize pointer

mlaurent added a reviewer: davidedmundson. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D8432 To: mlaurent, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8432: Use nullptr. Initialize pointer

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R110 KScreen Library BRANCH use_nullptr REVISION DETAIL https://phabricator.kde.org/D8432 AFFECTED FILES

Re: System Settings KCM Tidying

On Mon, Oct 23, 2017 at 1:42 PM, Jan Grulich wrote: > Hi, > > I added myself to "Connection" KCM if you don't mind, Awesome. I hoped you would :) > but I have a question. > Do you expect that all KCMs will be completely rewritten in QML? I expect 3 years from now they

Re: System Settings KCM Tidying

Hi, I added myself to "Connection" KCM if you don't mind, but I have a question. Do you expect that all KCMs will be completely rewritten in QML? I'm just afraid that rewriting the editor part into QML will be more than a long process. There is so many kind of connections, not even mentioning

Re: System Settings KCM Tidying

On Mon, Oct 23, 2017 at 12:42 PM, Roman Gilg wrote: > What about reorganizing the categories and rethinking the number of KCMs > first? I remember that this was something many people said should be done > before rewriting all the KCMs in QML. reorganizing categories has been

Re: System Settings KCM Tidying

There is already column of KCMs that Marco and I think should probably die. (click show hidden in the workboard list) I totally agree that we should think about what we're porting when we're going through it. If we decide when looking specifcially at the current clock settings, that timezone

Re: Minutes Monday Plasma Hangout

On Mon, Oct 23, 2017 at 12:26:42PM +0200, Marco Martin wrote: > Notes for today, 23 October 2017 Bhushan: - Tried to investigate the bug with kwayland-integration and the plasma mobile shell along with d_ed, no luck so far pinpointing actual issue, we do know the cause of bug however. -

Re: System Settings KCM Tidying

What about reorganizing the categories and rethinking the number of KCMs first? I remember that this was something many people said should be done before rewriting all the KCMs in QML. Any way the mockups look great, and even if we would decide to do some reorganization first only very few of the

Minutes Monday Plasma Hangout

Notes for today, 23 October 2017 Eike: ‎ * Organized KDE's presence at Qt World Summit 2017 where we demo'd Plasma Mobile and Plasma on ARM, both seemed really well-received * Represented Plasma Mobile (and Konversation) at the first-ever Matrix.org meetup event in Berlin and formed a direct

D7047: Wallpaper blur background filling effect feature

guoyunhe added a comment. In https://phabricator.kde.org/D7047#158496, @ngraham wrote: > It occurs to me that only the "Scaled, Keep Proportions" and "Centered" positioning modes require any kind of background effect or color. With other positioning modes, the existing Background Color

D8399: Fix colours not updating in systemsettings

This revision was automatically updated to reflect the committed changes. Closed by commit R124:d78345a80513: Fix colours not updating in systemsettings (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8399?vs=21097=21162

D8399: Fix colours not updating in systemsettings

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D8399 To: davidedmundson, #plasma, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Re: Kirigami/qmake deployment on Android problems

On Sun, Oct 22, 2017 at 10:10 PM, Camilo Higuita Rodriguez wrote: > Hi, > I've been trying for the past two days to get my Kirigami application up and > working on Android. It all works fine in the desktop, but when i try to > deploy it to an android device the application

Re: Travis CI with kirigami and android build

On Sat, Oct 14, 2017 at 2:24 AM, patrick JP wrote: > HI, > > I am trying to create a Travis CI script to create android apks with > kirigami, > if someone have already done that or want to help me I would appreciate :) > > My best regards the steps more or less are

System Settings KCM Tidying

Andres Betts has done a fantastic job of a tonne of doing an initial mockup of the new KCMs. The mockups are available here: https://phabricator.kde.org/M112 This is going to be a combination of UI redesign, code cleanup and QtQuick porting. We have a workboard to track them all

Re: Travis CI with kirigami and android build

On Mon, Oct 23, 2017 at 9:37 PM, Tomaz Canabrava wrote: > Adding Ben here since he probably knows the answer. Hi all, The first steps to getting this to work would be to get the necessary Frameworks you need building on the CI system, followed by your application itself.

Re: Travis CI with kirigami and android build

Adding Ben here since he probably knows the answer. On Sat, Oct 14, 2017 at 2:24 AM, patrick JP wrote: > HI, > > I am trying to create a Travis CI script to create android apks with > kirigami, > if someone have already done that or want to help me I would appreciate

D8421: Port the dict applet to KF5 and QtQuick 2

broulik added inline comments. INLINE COMMENTS > main.qml:4 > +import org.kde.plasma.components 2.0 as PlasmaComponents > +import org.kde.plasma.plasmoid 2.0 > +import org.kde.plasma.core 2.0 as PlasmaCore Unused? > main.qml:22 > +implicitWidth: 400 > +Keys.onReturnPressed: { >

D8419: Dict Engine: improve error handling.

broulik added a comment. Don't you also need a `Messages.sh` and `TRANSLATION_DOMAIN` define? REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8419 To: dfaure, #plasma, davidedmundson Cc: broulik, plasma-devel, #plasma, ZrenBot,

D8431: Port to autogenerate logging category

This revision was automatically updated to reflect the committed changes. Closed by commit R104:a87cec0bc7a0: Port to autogenerate logging category (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8431?vs=21156=21157 REVISION DETAIL

Travis CI with kirigami and android build

HI, I am trying to create a Travis CI script to create android apks with kirigami, if someone have already done that or want to help me I would appreciate :) My best regards -- Patrick José Pereira Electronics Engineer Skype: patrickelectric434 IRC: patrickelectric +55 (048) 99917-4777

Re: First bridge status: crossed

Thanks Paul! We are beginning interviewing low-level devs next week, and per our collaboration, will be advancing KDE plasma, and should soon (within a month probably) have the proper liaison and tools in place to advance this forward. Also we will begin testing KDE plasma on the development

Kirigami/qmake deployment on Android problems

Hi, I've been trying for the past two days to get my Kirigami application up and working on Android. It all works fine in the desktop, but when i try to deploy it to an android device the application dies. I'm using qmake, because with cmake i haven't been able to get pass this error:

D8431: Port to autogenerate logging category

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH port_logging_category REVISION DETAIL https://phabricator.kde.org/D8431 To: mlaurent, afiestas, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8431: Port to autogenerate logging category

mlaurent added reviewers: afiestas, sebas, davidedmundson. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8431 To: mlaurent, afiestas, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8431: Port to autogenerate logging category

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Auto generate logging category TEST PLAN build/test in kdebugsettings REPOSITORY R104 KScreen BRANCH port_logging_category REVISION

D8424: Folder View location properties: Improve visual layout

hein added a comment. kk, go for it then :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8429: Constify

This revision was automatically updated to reflect the committed changes. Closed by commit R104:8a3be290d845: Constify (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8429?vs=21151=21155 REVISION DETAIL

D8424: Folder View location properties: Improve visual layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:540a90cdeac2: Folder View location properties: Improve visual layout (authored by marten). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Plasma Workspace Wallpapers] [Bug 386093] New: Kubuntu KDE Desktop Icons shown like Memorydump (wild colors) after start from sleep mode

https://bugs.kde.org/show_bug.cgi?id=386093 Bug ID: 386093 Summary: Kubuntu KDE Desktop Icons shown like Memorydump (wild colors) after start from sleep mode Product: Plasma Workspace Wallpapers Version: 5.10.5 Platform:

D8424: Folder View location properties: Improve visual layout

marten added a comment. Thanks! - yes, I have push access. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Good to go. Thank you. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8405 To: Martchus, #plasma, jgrulich Cc: jgrulich, ngraham,

D8402: Support "domain-suffix-match" in Security8021xSetting

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Good to go. Thank you. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks,

D8429: Constify

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH constify REVISION DETAIL https://phabricator.kde.org/D8429 To: mlaurent, afiestas, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8402: Support "domain-suffix-match" in Security8021xSetting

Martchus updated this revision to Diff 21153. Martchus added a comment. Add "domainSuffixMatch" to auto tests REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8402?vs=21149=21153 REVISION DETAIL https://phabricator.kde.org/D8402 AFFECTED FILES

D8429: Constify

mlaurent added reviewers: afiestas, sebas. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8429 To: mlaurent, afiestas, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8429: Constify

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN build :) REPOSITORY R104 KScreen BRANCH constify REVISION DETAIL https://phabricator.kde.org/D8429 AFFECTED FILES kded/device.cpp

D8402: Support "domain-suffix-match" in Security8021xSetting

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Now it looks good. Just one thing I forgot is a unit test for this property. You can add it to autotests/settings/8021xsettingtest.cpp and build the tests with

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

Martchus updated this revision to Diff 21150. Martchus added a comment. Adapt to updated https://phabricator.kde.org/D8402 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8405?vs=21071=21150 REVISION DETAIL

D8402: Support "domain-suffix-match" in Security8021xSetting

Martchus updated this revision to Diff 21149. Martchus added a comment. Changed the method names REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8402?vs=21069=21149 REVISION DETAIL https://phabricator.kde.org/D8402 AFFECTED FILES