D8462: [batterymonitor] Fix brightness resetting to 1 on startup

2017-10-24 Thread Bhushan Shah
bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This was tricky bug to track down, needed to add debug statements in literally every functions.

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R124:149060766795: Fix DBus startup notification (authored by fvogt). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8455?vs=21259=21279 REVISION DETAIL

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D8455#159526, @davidedmundson wrote: > Urgh, Thanks > > Stable branch too please. Not sure what you mean by stable branch - this is diffed on top of Plasma/5.11 which should be enough, the change in main is not part of

D8460: Refactor kcm_input to enable having multiple backends.

2017-10-24 Thread Xuetian Weng
xuetianweng created this revision. xuetianweng added reviewers: subdiff, davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Split patch for https://phabricator.kde.org/D8168. This change only

D8456: Port kcm input to UI File.

2017-10-24 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R119:987b4dec9264: Port kcm input to UI File. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8456?vs=21268=21269 REVISION DETAIL

D8456: Port kcm input to UI File.

2017-10-24 Thread Roman Gilg
subdiff accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8456 To: xuetianweng, subdiff, davidedmundson, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8456: Port kcm input to UI File.

2017-10-24 Thread Xuetian Weng
xuetianweng updated this revision to Diff 21268. xuetianweng added a comment. Merge kmousedlg.ui into kcmmouse.ui. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8456?vs=21262=21268 BRANCH master REVISION DETAIL

D8455: Fix DBus startup notification

2017-10-24 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Urgh, Thanks Stable branch too please. REPOSITORY R124 System Settings BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8455 To: fvogt, #plasma,

D8456: Port kcm input to UI File.

2017-10-24 Thread Xuetian Weng
xuetianweng created this revision. xuetianweng added reviewers: subdiff, davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A split version of https://phabricator.kde.org/D8168. This only refactors

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

2017-10-24 Thread Elmo R
https://bugs.kde.org/show_bug.cgi?id=362988 --- Comment #13 from Elmo R --- Bump, this is still a problem. Name: dolphin Version : 17.08.1 Release : 1.1 Architecture: x86_64 Install Date: Fri Sep 15 20:28:35 2017 Group : Productivity/File utilities Size

[Plasma Workspace Wallpapers] [Bug 386153] plasma is shit

2017-10-24 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=386153 Kai Uwe Broulik changed: What|Removed |Added CC|

[Plasma Workspace Wallpapers] [Bug 386153] New: plasma is shit

2017-10-24 Thread Roman
https://bugs.kde.org/show_bug.cgi?id=386153 Bug ID: 386153 Summary: plasma is shit Product: Plasma Workspace Wallpapers Version: unspecified Platform: Mint (Debian based) OS: Linux Status: UNCONFIRMED

D8455: Fix DBus startup notification

2017-10-24 Thread Kai Uwe Broulik
broulik added a comment. This has been broken for most unique apps ever since Plasma 5.0, most noticeably with Kate. I once tried to look into KStartupInfo stuff but from what I can tell there's a "port me TODO" of some framework (KDBusAddons?) not being able to depend on another

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt
fvogt added a comment. With this the kwin startup notification bounce does not terminate before the timeout if it's already running. How does kwin notice that the application is already there? Apparently not using the dbus service name. REPOSITORY R124 System Settings REVISION DETAIL

D8455: Fix DBus startup notification

2017-10-24 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. REVISION SUMMARY In "Fix colours not updating in systemsettings", the application name got changed from "systemsettings5" (inferred from the binary name) to

D8453: Make tooltips in klipper settings dialog translatable

2017-10-24 Thread Burkhard Lück
lueck created this revision. lueck added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY remove invalid and superfluous markup "" + "" in kcfg file add TranslationSystem=kde to generate i18n() calls

D8168: kcm_input: Refactor the code and add support for libinput under X11

2017-10-24 Thread Roman Gilg
subdiff added a comment. Wow, very nice! I'm still not sure if on Wayland we should combine Touchpad and Mouse KCMs to one "Pointers" KCM how it was proposed years ago, because their properties in libinput are very similar. But since you already did the work for adding multiple backend to

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude added a comment. In https://phabricator.kde.org/D8449#159406, @ivan wrote: > Having a default backend (IMO) has nothing to do with the UI. I'm not sure what else it would have an effect on. Default to me means its just a suggested one and users can still override it.

D8449: Have a default backend (if one available)

2017-10-24 Thread Ivan Čukić
ivan added a comment. p.s. > Do I need to relogin to make a kded module show up? No. You can just `kquitapp5 kded5; kded5` to restart it. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: ngraham, plasma-devel,

D8449: Have a default backend (if one available)

2017-10-24 Thread Ivan Čukić
ivan added a comment. Having a default backend (IMO) has nothing to do with the UI. What is the rationale behind changing a combo-box (a widget designed for multiple choice questions) to a button? As far as CryFS vs EncFS - yes, CryFS is designed to avoid all the problems that EncFS

Re: System Settings KCM Tidying

2017-10-24 Thread Marco Martin
On lunedì 23 ottobre 2017 14:05:26 CEST Jan Grulich wrote: > > As I already wrote in another mail thread, I have a student [1] working on > this. He's not that active as I would like him to be and not progressing > really much, but he is supposed to finish in ~2 months so I expect he will > start

Plasma 5.11.2

2017-10-24 Thread Jonathan Riddell
https://www.kde.org/announcements/plasma-5.11.2.php Plasma 5.11.2 fixes issues in GTK Config and elsewhere in System Settings

D8447: Add unit tests for Folder View

2017-10-24 Thread Laurent Montel
mlaurent added a comment. missing copyright in new file too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8447: Add unit tests for Folder View

2017-10-24 Thread Laurent Montel
mlaurent requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel,

D8446: [Notifications] Allow selecting text with mouse

2017-10-24 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D8446#159345, @ngraham wrote: > +1 IMHO, any text anywhere should always be selectable. You never know when or why the user might want or need to select some text on the system, so this makes sense to me at least. Such generic

D8449: Have a default backend (if one available)

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. That sounds good to me, but yeah, since these differences are super-technical and not really relevant to most users, I think that regardless of our messaging, a good default is important here if multiple backends are available. Based on what you've written, it looks

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude added a comment. In https://phabricator.kde.org/D8449#159337, @ngraham wrote: > I don't think choosing a random backend makes sense without at least some information provided to the user. How about adding a text view below the combobox showing a quick human-friendly summary

Re: System Settings KCM Tidying

2017-10-24 Thread David Edmundson
Hopefully we can base Plasma 5.13 off Qt5.10. Probably deserves a different thread in a few months. Personally, I want to start wtih M111, it's already in QtQuick, and has the best reward to effort ratio. It also defines some components that will get re-used elsewhere. Even if we only get some of

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread David Edmundson
davidedmundson added a comment. Unless I'm misreading things, I think there's one part that's going to appear very confusing. I have my (small) laptop. Lets say I want any new (big) screen to appear on the left. So I save "Extend to left". So I'd expect to see: monitor, laptop.

D8442: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Laurent Montel
mlaurent abandoned this revision. mlaurent added a comment. https://phabricator.kde.org/D8444 was opened. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8442 To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Laurent Montel
mlaurent added a comment. Wierd why it created a new review ??? This one is more recent. I will close 8442 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8447: Add unit tests for Folder View

2017-10-24 Thread Laurent Montel
mlaurent added a comment. Add in toplevel: if(BUILD_TESTING) add_definitions(-DBUILD_TESTING) endif(BUILD_TESTING) + create a folderplugin_private_export.h as #ifndef KSIEVEUIPRIVATE_EXPORT_H #define KSIEVEUIPRIVATE_EXPORT_H #include "ksieveui_export.h" /*

D8446: [Notifications] Allow selecting text with mouse

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. +1 IMHO, any text anywhere should always be selectable. You never know when or why the user might want or need to select some text on the system, so this makes sense to me at least. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. Looks like this was opened by mistake; you've already got https://phabricator.kde.org/D8442. Can this be closed? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. I don't think choosing a random backend makes sense without at least some information provided to the user. How about adding a text view below the combobox showing a quick human-friendly summary of the purported advantage of each backend? like this: "EncFS is

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-24 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I was under the impression this hack was only needed when used on a window that doesn't take focus.

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. Big +1 from me, if we can resolve the potential issue with images that have transparency. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D8441#159329, @ngraham wrote: > Great, thanks! Much better. Any chance you can upload new screenshots? F5447565: Screenshot_20171024_165656.png REPOSITORY R120 Plasma Workspace

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. Great, thanks! Much better. Any chance you can upload new screenshots? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe added a comment. Done. In https://phabricator.kde.org/D8441#159321, @ngraham wrote: > Here's how I would do it: > > Background: * Blur > * Solid color: [color chooser] > REPOSITORY R120 Plasma Workspace REVISION DETAIL

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe updated this revision to Diff 21241. guoyunhe added a comment. - Wallpaper: change label text of blur option REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8441?vs=21240=21241 BRANCH master REVISION DETAIL

D8447: Add unit tests for Folder View

2017-10-24 Thread Andras Mantia
amantia added reviewers: franckarrecot, renatoo, olivierjg. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8449: Have a default backend (if one available)

2017-10-24 Thread Nathaniel Graham
ngraham added reviewers: ivan, Plasma. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

2017-10-24 Thread Aleix Pol Gonzalez
apol added a comment. Well this breaks supporting having configuration over in `/etc`, so indeed this wasn't tested. It's unfortunate that the only solution we always end up in is reverting stuff rather than actual investigation. Oh well, I'll spend some time on this at some point.

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. Here's how I would do it: Background: * Blur * Solid color: [color chooser] REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot,

D8446: [Notifications] Allow selecting text with mouse

2017-10-24 Thread Aleix Pol Gonzalez
apol added a comment. I don't think selecting stuff from a notification should be a use case. It means that the notification is poorly designed. The code shows. That said, you are the maintainer. As for the code, there's no way I can make sense out of this code, I believe you that it

D8449: Have a default backend (if one available)

2017-10-24 Thread Crypto Dude
cryptodude created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The creation of a new vault uses a wizard. The first page of the wizard currently shows a combobox with 2 backends, with one

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe updated this revision to Diff 21240. guoyunhe added a comment. - Wallpaper: change variable name from edgefilling to background REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8441?vs=21239=21240 BRANCH master REVISION DETAIL

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe updated this revision to Diff 21239. guoyunhe added a comment. - Wallpaper: change label name REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8441?vs=21218=21239 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8441

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D8441#159293, @ngraham wrote: > Can we change "Edge filling" to "Background"? I don't know which word is better because I am not a native English speaker. But yeah, I can change it. REPOSITORY R120 Plasma Workspace

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. Can we change "Edge filling" to "Background"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8447: Add unit tests for Folder View

2017-10-24 Thread Andras Mantia
amantia created this revision. amantia added reviewers: Plasma, ervin, hein, mlaurent, aacid, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add some tests for FolderModel and Positioner classes. REPOSITORY

D8168: kcm_input: Refactor the code and add support for libinput under X11

2017-10-24 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > FindXorgLibinput.cmake:8 > +# > +# Copyright (c) 2015 David Edmundson > +# that's not your name... > CMakeLists.txt:58 > > -if (SYNAPTICS_FOUND AND X11_Xinput_FOUND) > +if (SYNAPTICS_FOUND AND XORGLIBINPUT_FOUND

Re: System Settings KCM Tidying

2017-10-24 Thread Marco Martin
On lunedì 23 ottobre 2017 11:10:41 CEST David Edmundson wrote: > Andres Betts has done a fantastic job of a tonne of doing an initial mockup > of the new KCMs. > > The mockups are available here: > https://phabricator.kde.org/M112 having started it, I would put another requirement, that is to

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > guoyunhe wrote in config.qml:161 > Ah, I have never thought about this. Is this use case common? I have never > seen people use transparent image for wallpaper. Usually it is some photos or > JPG images downloaded from internet. > > This brings

D7047: Wallpaper blur background filling effect feature

2017-10-24 Thread Nathaniel Graham
ngraham added a comment. @guoyunhe, Nice! In the future can you use the `arc land` instead of committing manually? That way all the history and details in the Summary here gets added to the commit, and we have a better paper trail. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

2017-10-24 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R99:0d0f812a1704: Revert Make the kde-gtk-config kcm better at checking global gtk settings (authored by fvogt). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D8446: [Notifications] Allow selecting text with mouse

2017-10-24 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8446 To: broulik, #plasma, #vdg, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

2017-10-24 Thread Nathaniel Graham
ngraham edited projects, added Plasma on Wayland; removed Plasma. ngraham added a comment. This is going to be a necessity for Wayland, given that libinput is mandatory. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson,

D8446: [Notifications] Allow selecting text with mouse

2017-10-24 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This was lost by the introduction of the default action as the MouseArea steals events from the

Re: System Settings KCM Tidying

2017-10-24 Thread Jan Grulich
On úterý 24. října 2017 14:11:36 CEST Marco Martin wrote: > On lunedì 23 ottobre 2017 14:05:26 CEST Jan Grulich wrote: > > 3 years from now, that's doable and I believe that even sooner, I was just > > pointing out that it's not something possible for Plasma 5.12 or maybe not > > also for Plasma

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-24 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Ensures the PlasmaComponents.Menu doesn't confuse MouseArea states. TEST PLAN Put a

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Laurent Montel
mlaurent created this revision. mlaurent added a project: Plasma. REVISION SUMMARY Default action when we plug unknown monitor REPOSITORY R104 KScreen BRANCH customize_connect_unknown_monitor REVISION DETAIL https://phabricator.kde.org/D8444 AFFECTED FILES kcm/src/kcm_kscreen.cpp

Re: System Settings KCM Tidying

2017-10-24 Thread Marco Martin
On lunedì 23 ottobre 2017 16:15:57 CEST Martin Flöser wrote: > > As 5.12 is LTS, lets not treat the workboard as a race, there is a > > branch in plasma-desktop called KcmQmlPorts that is worth making use > > of. > > My request for KWin is maximum of one KCM per release cycle. I'm > expecting

Re: System Settings KCM Tidying

2017-10-24 Thread Marco Martin
On lunedì 23 ottobre 2017 14:05:26 CEST Jan Grulich wrote: > 3 years from now, that's doable and I believe that even sooner, I was just > pointing out that it's not something possible for Plasma 5.12 or maybe not > also for Plasma 5.13, but I'll do my best as usual. oh, no, it's a long-term plan,

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

2017-10-24 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Heh, so much for unit tests. Hopefully we can revisit this for master and try and fix whatever the original one was doing. REPOSITORY R99 KDE Gtk Configuration Tool

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

2017-10-24 Thread Rik Mills
rikmills added a comment. I made the same revert to test earlier this morning, and on **brief** testing it seems to have solved the issue, and tests still pass. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D8443 To: fvogt, #plasma, apol Cc:

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

2017-10-24 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, apol. Restricted Application added a project: Plasma. REVISION SUMMARY This reverts commit https://phabricator.kde.org/R99:34357f74ee2d98128ff423b0ec6ddcbf4232c475. Reverting this fixes loading of the actually used GTK settings.

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

2017-10-24 Thread Valeriy Malov
valeriymalov abandoned this revision. valeriymalov added a comment. kcm_input seems to be getting proper refactor in https://phabricator.kde.org/D8168 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7558 To: valeriymalov, #plasma, #vdg Cc: graesslin, mart,

D8436: use a single QML engine

2017-10-24 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8436#159212, @davidedmundson wrote: > Given the fallout we had when we made the similar change in Plasma, please don't merge until the start of the next release cycle. after november first week release? ok > Can you

D8436: use a single QML engine

2017-10-24 Thread David Edmundson
davidedmundson added a comment. Given the fallout we had when we made the similar change in Plasma, please don't merge until the start of the next release cycle. Can you expand your "normal system settings seems unaffected" into something more thorough with a list of the relevant KCMs.

D8436: use a single QML engine

2017-10-24 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.cpp:106 > !! this version now should work, as the context is used now: the way the static attached property function finds it is quite an heuristic, but should be 100% reliable

D8436: use a single QML engine

2017-10-24 Thread Marco Martin
mart updated this revision to Diff 21224. mart added a comment. - use the qmlobject's rootcontext instead of the engine as is now shared REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21223=21224 BRANCH arcpatch-D8436 REVISION DETAIL

D8436: use a single QML engine

2017-10-24 Thread Marco Martin
mart updated this revision to Diff 21223. mart added a comment. - use the qmlobject's rootcontext instead of the engine as is now shared REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21184=21223 BRANCH arcpatch-D8436 REVISION DETAIL

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler
Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi security settings. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-24 Thread Marius Kittler
Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi security settings. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8405 To: Martchus, #plasma, jgrulich Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff,

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-24 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R116:97cd51d30994: Allow to set domain-suffix-match in Wi-Fi settings (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8405?vs=21150=21221#toc REPOSITORY R116 Plasma

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R282:7491ed93c8cb: Support domain-suffix-match in Security8021xSetting (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe added inline comments. INLINE COMMENTS > davidedmundson wrote in config.qml:161 > This used to be the case, then it was changed for some obscure use case with > transparaent images. Ah, I have never thought about this. Is this use case common? I have never seen people use transparent

D8442: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Laurent Montel
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Default action when we plug unknown monitor REPOSITORY R104 KScreen BRANCH customize_connect_unknown_monitor REVISION DETAIL

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler
Martchus added a comment. I don't have commit access so somebody needs to merge this for me. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-24 Thread Marius Kittler
Martchus added a comment. I don't have commit access so somebody needs to merge this for me. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8405 To: Martchus, #plasma, jgrulich Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff,

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe edited the summary of this revision. guoyunhe added a reviewer: ngraham. guoyunhe added a subscriber: ngraham. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > config.qml:161 > id: colorRow > +visible: cfg_FillMode === Image.PreserveAspectFit || cfg_FillMode > === Image.Pad > spacing: units.largeSpacing / 2 This used to be the case, then it was changed for some obscure

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-10-24 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8441 AFFECTED FILES

D7047: Wallpaper blur background filling effect feature

2017-10-24 Thread Yunhe Guo
guoyunhe closed this revision. guoyunhe added a comment. This patch has been committed to master branch. I will add the color/blur-image radio buttons in another patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7047 To: guoyunhe, #plasma_workspaces,

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2017-10-24 Thread Alex Richardson
arichardson updated this revision to Diff 21216. arichardson added a comment. - rebased - removed runtime check REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4193?vs=13383=21216 BRANCH arcpatch-D4193 REVISION DETAIL

D8419: Dict Engine: improve error handling.

2017-10-24 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c2cf81f26bfe: Dict Engine: improve error handling. (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8419?vs=21116=21215#toc REPOSITORY R120 Plasma Workspace CHANGES

D8419: Dict Engine: improve error handling.

2017-10-24 Thread David Faure
dfaure added a comment. In https://phabricator.kde.org/D8419#158645, @broulik wrote: > Don't you also need a `Messages.sh` and `TRANSLATION_DOMAIN` define? Well spotted. The Messages.sh file was there, but not the define. Fixed and pushed. REPOSITORY R120 Plasma Workspace

D7181: [Task Manager] Elide context menu entries

2017-10-24 Thread Eike Hein
hein added a comment. Kai, ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7181 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7481: RFC: Batch window changes events on XCB

2017-10-24 Thread Eike Hein
hein added a comment. David, ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6880: [Folder View] Indicate cut items

2017-10-24 Thread Eike Hein
hein added a comment. Kai, ping? IIRC we determined KDirModel does this already and this is misguided somehow? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6880 To: broulik, #plasma, hein, #vdg, emmanuelp, dfaure Cc: plasma-devel, ZrenBot, progwolff,

D1231: Add Remote Access interface to KWayland

2017-10-24 Thread Oleg Chernovskiy
Kanedias marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: subdiff, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D1231: Add Remote Access interface to KWayland

2017-10-24 Thread Oleg Chernovskiy
Kanedias updated this revision to Diff 21212. Kanedias added a comment. Updated against latest master, fixed review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=16359=21212 REVISION DETAIL https://phabricator.kde.org/D1231

D1230: GBM remote access support for KWin

2017-10-24 Thread Oleg Chernovskiy
Kanedias updated this revision to Diff 21211. Kanedias marked 2 inline comments as done. Kanedias added a comment. Updated against latest master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=18859=21211 REVISION DETAIL

D1230: GBM remote access support for KWin

2017-10-24 Thread Oleg Chernovskiy
Kanedias added a comment. Fixed review comments REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, subdiff, #kwin Cc: subdiff, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, bwowk, leezu, ZrenBot,