D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng updated this revision to Diff 21404. xuetianweng added a comment. Update accroding to subdiff's comment. Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only get a virtual cursor. Thus I just move the condition to check the name of qpa platform for

D8502: Fix brightness not restoring when an inhibition is active

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Wow. Good observation! I bet there's a bug report on Bugzilla about this. Do you have commit access? REPOSITORY R122 Powerdevil BRANCH fix_restore_brightness REVISION DETAIL

D8504: Scaled decorations in QPainter mode

davidedmundson updated this revision to Diff 21398. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. operationmode REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8504?vs=21395=21398 BRANCH

D8504: Scaled decorations in QPainter mode

graesslin added inline comments. INLINE COMMENTS > decorationrenderer.cpp:42 > auto markImageSizesDirty = [this]{ m_imageSizesDirty = true; }; > +if (waylandServer()) { > +connect(client->client(), ::screenChanged, this, > markImageSizesDirty); Please don't check for

D8504: Scaled decorations in QPainter mode

davidedmundson added a reviewer: hetzenecker. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8504 To: davidedmundson, #plasma, hetzenecker Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol,

D8504: Scaled decorations in QPainter mode

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Under wayland we support high DPI putting by putting a separation between the

D8481: Adjusted scrollbars to fit the Qt theme

dos added a comment. Oh, so it's a bug? I hope it doesn't get fixed then, as the tiny scrollbars look way better :D REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D8481 To: dos, #breeze, #plasma Cc: elvisangelaccio, ngraham, apol, plasma-devel, ZrenBot,

D8485: Fix viewport for screenshot on multiple screens

This revision was automatically updated to reflect the committed changes. Closed by commit R108:9cafbb117984: Fix viewport for screenshot on multiple screens (authored by kpiwowarski, committed by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8485: Fix viewport for screenshot on multiple screens

kpiwowarski added a comment. @davidedmundson How can I commit? This is my first contribution here. Could you that? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8485 To: kpiwowarski, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, #kwin,

D8503: Fix glScissor calls with y-offset screens

This revision was automatically updated to reflect the committed changes. Closed by commit R108:019d4bf4257d: Fix glScissor calls with y-offset screens (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8503?vs=21389=21391 REVISION

D8503: Fix glScissor calls with y-offset screens

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8503 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D8503: Fix glScissor calls with y-offset screens

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY As per the glViewport patches yesterday. TEST PLAN Vertically stacked monitors

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin added a comment. I've created a script to demonstrate the issue (attached). It uses VLC to acquire inhibition after the screen is dimmed. Usage: ./test_restore_brightness.sh F5451108: test_restore_brightness.sh REPOSITORY R122

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin created this revision. aleksejshilin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY An active inhibition with ChangeScreenSettings policy won't allow to restore dimmed screen

D8493: Make Folder View screen aware

broulik added inline comments. INLINE COMMENTS > amantia wrote in foldermodel.cpp:1314 > It can be and it is reached. m_screen != -1 means it is a containment, screen > == -1 means there is no screen information stored yet. This happens e.g when > using the updated code with an existing

D8500: Add prefix for private variable

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3d3783eef567: Add prefix for private variable (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8500?vs=21380=21381 REVISION DETAIL

D8500: Add prefix for private variable

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH add_prefix_for_private_variable REVISION DETAIL https://phabricator.kde.org/D8500 To: mlaurent, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D8500: Add prefix for private variable

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8500 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8500: Add prefix for private variable

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH add_prefix_for_private_variable REVISION DETAIL https://phabricator.kde.org/D8500 AFFECTED

D8493: Make Folder View screen aware

amantia added a comment. I've added some comments, I will address the ones I did not comment in a follow-up patch. INLINE COMMENTS > broulik wrote in main.xml:40 > What's the purpose of `hidden=true`? AFAIK it is not used in the GUI config. See also the others in the same file. > broulik

D8499: Constify some methods

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e795b8b721c5: Constify some methods (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8499?vs=21378=21379 REVISION DETAIL

D8499: Constify some methods

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH const_ify_method REVISION DETAIL https://phabricator.kde.org/D8499 To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8499: Constify some methods

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8499 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8499: Constify some methods

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH const_ify_method REVISION DETAIL https://phabricator.kde.org/D8499 AFFECTED FILES

D8447: Add unit tests for Folder View

mlaurent updated this revision to Diff 21377. mlaurent added a comment. - Add more autotest. Test default value. Test menu action REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21376=21377 BRANCH arcpatch-D8447 REVISION DETAIL

D8447: Add unit tests for Folder View

amantia updated this revision to Diff 21376. amantia added a comment. Now add back the generate_export_header for real CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21375=21376 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES

D8447: Add unit tests for Folder View

amantia updated this revision to Diff 21375. amantia added a comment. Add back unintentionally removed generate_export_header CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21287=21375 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES

D8493: Make Folder View screen aware

broulik added a comment. Regardless of whether this is the right way to go, I put some coding style and practise comments on the code, so you know what to look for in the future / in general :) INLINE COMMENTS > main.xml:40 > > + > + What's the purpose of `hidden=true`? >

D8493: Make Folder View screen aware

amantia added a comment. Just to make clear, this is the first step and would not commit before the problems with display removing/additions are solved. The ideas for doing that are: - keep per screen configuration and per desktop setting: e.g a different set of position for icons if

D8493: Make Folder View screen aware

mart added a comment. I think this is really asking for a lot of trouble. what happens when a screen is dinamically added/removed? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid Cc: mart,

D8493: Make Folder View screen aware

amantia created this revision. amantia added reviewers: Plasma, ervin, mlaurent, dvratil, hein, aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When using multiple screen with a Folder View as a desktop

D8469: Use XDG_DATA_HOME and security fix

cryptodude updated this revision to Diff 21364. cryptodude retitled this revision from "Use XDG_DATA_DIR and security fix" to "Use XDG_DATA_HOME and security fix". cryptodude edited the summary of this revision. cryptodude added a comment. Updated git and task comments to use XDG_DATA_HOME.

D8469: Use XDG_DATA_DIR and security fix

cryptodude added a comment. In https://phabricator.kde.org/D8469#160263, @cryptodude wrote: > Updated to use QStandardPaths Hmm, I forgot to test if the XDG_DATA_DIR actually is honoured by the QStandardDirs, and a quick test shows that it doesn't. I'll have to find out

D8481: Adjusted scrollbars to fit the Qt theme

elvisangelaccio added a comment. We recently adjusted the gtk3 scrollbars (see https://phabricator.kde.org/D6688), I'm not sure why your Qt scrollbars are so tiny... (maybe hi-DPI related?) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D8481 To: dos,

D8469: Use XDG_DATA_DIR and security fix

cryptodude updated this revision to Diff 21363. cryptodude added a comment. Updated to use QStandardPaths REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8469?vs=21303=21363 REVISION DETAIL https://phabricator.kde.org/D8469 AFFECTED FILES

D8476: qPort to new connect api + use const'ref

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b706bc73fa63: qPort to new connect api + use constref (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8476?vs=21324=21357 REVISION

D8473: Modernize code. Use nullptr where it's possible

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b95bdf216b8f: Modernize code. Use nullptr where its possible (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8473?vs=21348=21356#toc REPOSITORY R119 Plasma Desktop

D8488: Clean forward declaration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9d0b117f6fed: Clean forward declaration (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8488?vs=21349=21355 REVISION DETAIL

D8489: Clean includes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:12a1360101cf: Clean includes (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8489?vs=21350=21354 REVISION DETAIL

D8473: Modernize code. Use nullptr where it's possible

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH modernize_folderplugin REVISION DETAIL https://phabricator.kde.org/D8473 To: mlaurent, hein Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8476: qPort to new connect api + use const'ref

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH port_to_new_connect_api REVISION DETAIL https://phabricator.kde.org/D8476 To: mlaurent, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8488: Clean forward declaration

hein accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH clean_forward_declaration REVISION DETAIL https://phabricator.kde.org/D8488 To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8489: Clean includes

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH clean_includes REVISION DETAIL https://phabricator.kde.org/D8489 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8488: Clean forward declaration

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH clean_forward_declaration REVISION DETAIL https://phabricator.kde.org/D8488 To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8489: Clean includes

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH clean_includes REVISION DETAIL https://phabricator.kde.org/D8489 AFFECTED FILES

D8489: Clean includes

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8489 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8488: Clean forward declaration

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8488 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8488: Clean forward declaration

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH clean_forward_declaration REVISION DETAIL https://phabricator.kde.org/D8488 AFFECTED FILES

D8473: Modernize code. Use nullptr where it's possible

mlaurent updated this revision to Diff 21348. mlaurent added a comment. - Perhaps gcc/clang can optimize it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8473?vs=21309=21348 BRANCH modernize_folderplugin REVISION DETAIL