D8529: Plasma change icons should exit after its work finished.

xuetianweng created this revision. xuetianweng added reviewers: apol, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Right now plasma-iconchanges may remains on the system after change the icon theme. TEST PLAN

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure added inline comments. INLINE COMMENTS > dfaure wrote in main.qml:33 > `Layout.fillHeight: true` led to a 1-pixel-high webview, not good. > > `Layout.fillWidth: true` is good, it means I don't duplicate the width > anymore. > > OK, and doing that in the TextField makes the applet

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > broulik wrote in main.qml:4 > Unused? Ah, yes. That was for "formFactor" as in https://techbase.kde.org/Development/Tutorials/Plasma5/QML2/GettingStarted#Minimum_size (which I had to fix so the syntax

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

ngraham added a comment. @broulik Any update here? Looks like this is about 99% done, and it would be a shame not to to get it in. I often find myself wishing this information in the Properties window. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To:

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

ngraham edited the summary of this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8493: Make Folder View screen aware

amantia updated this revision to Diff 21447. amantia added a comment. Make ScreenMapper a QML singleton, address the other issues mentioned by Kai-Uwe. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=21365=21447 REVISION DETAIL https://phabricator.kde.org/D8493 AFFECTED

D8526: add a background in ScrollView

davidedmundson added a comment. In general ++. The frame is useful for keyboard focus indication if nothing else. INLINE COMMENTS > ScrollView.qml:47 > +visible: false > +elementType: "edit" > + As in a textedit? The QQC1 code used "frame" which is semantically more

D8291: correct Settings.isMobile usage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:162b877ad4b0: correct Settings.isMobile usage (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8291?vs=20724=21442 REVISION DETAIL

D8447: Add unit tests for Folder View

amantia added a comment. I approved and actually suggested Laurent to update the diff. Sorry for the confusion. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo,

D8526: add a background in ScrollView

mart added a comment. F5452808: Spectacle.X20944.png REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8526: add a background in ScrollView

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY add a background in scrollview similar to what qwidget's scrollviews do hide it by default since is not

D8522: keyboard navigation in and out QML kcms

mart updated this revision to Diff 21440. mart added a comment. - skip widgets that don't accept focus REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21435=21440 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTED

D8524: Add a signal notifying a change in the names of running activities.

hein added a dependent revision: D8525: Refresh when the names of the running activities change.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8525: Refresh when the names of the running activities change.

hein created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG:384001 Depends on https://phabricator.kde.org/D8524. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D8524: Add a signal notifying a change in the names of running activities.

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. REVISION SUMMARY CCBUG:384001 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8524 AFFECTED FILES libtaskmanager/activityinfo.cpp

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin added a comment. @broulik @ngraham Many thanks! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8522: keyboard navigation in and out QML kcms

mart added a reviewer: Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8522: keyboard navigation in and out QML kcms

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QQuickWidget doesn't support keyboard navigation per se, the widget will gain keyboard

D8159: Add API for setting server decoration palettes

graesslin added a comment. In https://phabricator.kde.org/D8159#160808, @davidedmundson wrote: > FYI, I'm deliberately delaying after I heard from Jonas how they might put it in GTK. > Technically they could have a v1 here, and we could have v2 with the added feature set and it would

D8362: Added setting to toggle drawing of title bar separator

ngraham added subscribers: jensreuterberg, abetts, andreaska. ngraham added a comment. @abetts @jensreuterberg @andreaska? Any objections? REPOSITORY R31 Breeze BRANCH titlebar-highlight REVISION DETAIL https://phabricator.kde.org/D8362 To: emateli, #breeze, #vdg, ngraham Cc:

D8502: Fix brightness not restoring when an inhibition is active

broulik added a comment. Thanks for taking care of this! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8502: Fix brightness not restoring when an inhibition is active

This revision was automatically updated to reflect the committed changes. Closed by commit R122:692bb264a812: Fix brightness not restoring when an inhibition is active (authored by aleksejshilin, committed by ngraham). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D8502: Fix brightness not restoring when an inhibition is active

ngraham added a comment. Lovely work. I can land this for you. REPOSITORY R122 Powerdevil BRANCH fix_restore_brightness REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

[Powerdevil] [Bug 357621] Screen cannot be turned on after it has been set to "energy saving" (goes off)

https://bugs.kde.org/show_bug.cgi?id=357621 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE

D8502: Fix brightness not restoring when an inhibition is active

ngraham edited the summary of this revision. REPOSITORY R122 Powerdevil BRANCH fix_restore_brightness REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Powerdevil] [Bug 358588] backlight not restored properly, after it was reduced on inactivity

https://bugs.kde.org/show_bug.cgi?id=358588 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[Powerdevil] [Bug 351693] Screen brightness is not restored after screen unlock (idle time)

https://bugs.kde.org/show_bug.cgi?id=351693 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

D8159: Add API for setting server decoration palettes

davidedmundson added a comment. FYI, I'm deliberately delaying after I heard from Jonas how they might put it in GTK. Technically they could have a v1 here, and we could have v2 with the added feature set and it would be fine, but I want to see how the discussion plays out before

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin added a comment. In https://phabricator.kde.org/D8502#160618, @broulik wrote: > I bet there's a bug report on Bugzilla about this. Yeah, 352497 looks like it. There are also a few suspects: 351693 and 358588 (but they say 'Reproducible: Always'), 357621 (not

Re: flatpak-platform-plugin bugs?

Hi, should be created now and I'm waiting for your bug reports. Jan On pátek 27. října 2017 13:04:02 CEST Harald Sitter wrote: > where do I file bugs against flatpak-platform-plugin it doesn't seem > to be on bugzilla? > > same for xdg-desktop-portal-kde > > > HS

flatpak-platform-plugin bugs?

where do I file bugs against flatpak-platform-plugin it doesn't seem to be on bugzilla? same for xdg-desktop-portal-kde HS

D8517: Test enable status change and perStripe change

mlaurent updated this revision to Diff 21426. mlaurent added a comment. - Add more autotest REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8517?vs=21424=21426 BRANCH add_more_autotest REVISION DETAIL https://phabricator.kde.org/D8517 AFFECTED

D8517: Test enable status change and perStripe change

mlaurent updated this revision to Diff 21424. mlaurent added a comment. - Start to create autotest for viewpropertiesmenu REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8517?vs=21423=21424 BRANCH add_more_autotest REVISION DETAIL

D8517: Test enable status change and perStripe change

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile + launch autotest REPOSITORY R119 Plasma Desktop BRANCH add_more_autotest REVISION DETAIL https://phabricator.kde.org/D8517

D8515: Don't loop twice here

mlaurent updated this revision to Diff 21422. mlaurent added a comment. - Avoid twice loop here too REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8515?vs=21418=21422 BRANCH dont_loop_twice REVISION DETAIL https://phabricator.kde.org/D8515

D8516: Emit signal when we change PerStripe

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8516 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8516: Emit signal when we change PerStripe

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH fix_missing_emit_signal REVISION DETAIL https://phabricator.kde.org/D8516 AFFECTED FILES

D8514: Const'ify method

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d5456864596f: Constify method (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8514?vs=21417=21420 REVISION DETAIL

D8513: Use emit as all other code use emit and not Q_EMIT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:25d2652a7bd2: Use emit as all other code use emit and not Q_EMIT (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8513?vs=21416=21419

D8515: Don't loop twice here

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8515 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8514: Const'ify method

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH use_const_method REVISION DETAIL https://phabricator.kde.org/D8514 To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8514: Const'ify method

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8514 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8514: Const'ify method

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH use_const_method REVISION DETAIL https://phabricator.kde.org/D8514 AFFECTED FILES

D8513: Use emit as all other code use emit and not Q_EMIT

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH use_emit_keyword REVISION DETAIL https://phabricator.kde.org/D8513 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8513: Use emit as all other code use emit and not Q_EMIT

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH use_emit_keyword REVISION DETAIL https://phabricator.kde.org/D8513 AFFECTED FILES

D8513: Use emit as all other code use emit and not Q_EMIT

mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8513 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c681a2f6ef63: Add unit tests for Folder View (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21377=21415 REVISION DETAIL

D8447: Add unit tests for Folder View

hein accepted this revision. hein added a comment. Please don't extend already-accepted review requests with new code without requesting more review. Otherwise the status stays "Accepted" on code that hasn't actually been reviewed, which is confusing and holds things up :) New test

D8504: Scaled decorations in QPainter mode

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH scaled_decs_qpainter REVISION DETAIL https://phabricator.kde.org/D8504 To: davidedmundson, #plasma, hetzenecker, graesslin Cc: ngraham, graesslin, plasma-devel, kwin, #kwin,

D8455: Fix DBus startup notification

arojas added a comment. Shouldn't this come with a kconf_update script? Already existing icons will not be fixed by this, since they use a copy of the desktop file in .local/share/plamsa_icons REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8455 To: fvogt,