xuetianweng added a comment.
In https://phabricator.kde.org/D8460#161613, @subdiff wrote:
> In https://phabricator.kde.org/D8460#160642, @xuetianweng wrote:
>
> > Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will
only
> > get a virtual cursor. Thus I just move
xuetianweng updated this revision to Diff 21675.
xuetianweng marked 8 inline comments as done.
xuetianweng added a comment.
Remove backend check so xwayland settings may be changed.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8460?vs=21674=21675
xuetianweng added inline comments.
INLINE COMMENTS
> subdiff wrote in mousebackend.h:26
> Put this enum class in a separate file, such that you don't have to include
> the full mousebackend.h in other header files like mouse.h
I guess I can put it in mousesettings.h ..
> subdiff wrote in
xuetianweng updated this revision to Diff 21674.
xuetianweng marked 11 inline comments as done.
xuetianweng added a comment.
update based on comments.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8460?vs=21404=21674
BRANCH
master
REVISION
davidedmundson added a comment.
> KIconLoader does, but even Qt's own ones QSvgIconEngine and
QPixmapIconEngine don't currently.
I did fix QPixmapIcon and QSvgIconEngine,
This should mean we can change QIcon::fromTheme to check isNull() which will
then implicitly solve this.
rkflx added subscribers: smartins, rkflx.
rkflx added a comment.
I keep stumbling upon this issue on bugzilla and wonder what we can do here?
- Fix the issue in Qt. @smartins recently opened
https://bugreports.qt.io/browse/QTBUG-63187, but besides triaging to `P3` not
much has happened
graesslin added a comment.
In https://phabricator.kde.org/D8582#162577, @davidedmundson wrote:
> Do you think we'll need a compositor fallback?
>
> *If* we do have a compositor fallback, then I don't see the point of a DRM
specific codepath, it's not going to have any slower having a
davidedmundson added a comment.
Do you think we'll need a compositor fallback?
*If* we do have a compositor fallback, then I don't see the point of a DRM
specific codepath, it's not going to have any slower having a transform in
painting, and will just result in one code path not
graesslin updated this revision to Diff 21667.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Call it "Transformation" instead of "Rotation" and make it proper flags.
After further reading I noticed one needs to combine the flipped and
graesslin updated this revision to Diff 21666.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Incorporate suggested changes
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8582?vs=21659=21666
BRANCH
subdiff added inline comments.
INLINE COMMENTS
> drm_object_plane.cpp:125
> +{
> +if (m_rotation == r) {
> +return;
Check not necessary.
> drm_object_plane.h:107
> uint32_t m_possibleCrtcs;
> +Rotation m_rotation = Rotation::Rotate0;
> };
I wouldn't add an additional
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8581
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
graesslin updated this revision to Diff 21660.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Add guard
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8578?vs=21654=21660
BRANCH
drm-mode-to-output
REVISION
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, subdiff.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
A preparation step to support rotation of outputs. The idea is to rotate
using DRM
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
setGlobalPos sets these, we don't need to call it twice
TEST PLAN
Looked at
davidedmundson added inline comments.
INLINE COMMENTS
> drm_output.cpp:214
> setDpms(DpmsMode::On);
> if (!m_waylandOutput.isNull()) {
> delete m_waylandOutput.data();
This method is coded so that init() can be called twice.
Either:
- that's pointless, and this should just
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
While KWin gained support for changing modes it did not yet forward it
to the Wayland
apol added subscribers: mart, apol.
apol added a comment.
This is specially interesting and it would be important to make it right.
One of the features we lose in Wayland is that we know where to place each
component. because of this number being 0 the primary screen, where the
davidedmundson added a comment.
The only intended use is folderview, and there are some comments there about
whether that's the right approach.
I don't want to have this pushed before we agree on that.
Other than that, code is fine.
REPOSITORY
R120 Plasma Workspace
REVISION
ervin added a comment.
Looks good to me, but I'm giving time for the Plasma team to see it.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
abetts added a comment.
Seems good to me. @jensreuterberg ?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7424
To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg
Cc: abetts, januz, progwolff, broulik, sebas, plasma-devel, ZrenBot,
lesliezhai,
ngraham added a comment.
Is this better now @abetts @jensreuterberg @hpereiradacosta?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7424
To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg
Cc: abetts, januz, progwolff, broulik, sebas,
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:e7b1b68eacc4: Use standard Ok/Cancel buttons for the
connection removal dialog (authored by ngraham).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:33a4cf405071: [drm] Implement changing of modes (authored
by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8398?vs=21065=21628
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:a5b17b222850: Require Qt 5.9 (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8331?vs=20858=21627
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:91d78daac49f: Ensure libinput connection thread uses real
time scheduling (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8065?vs=21011=21626
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> screenmapper.cpp:65
> +
> +void ScreenMapper::handleScreenAdded(QScreen *screen)
> +{
I don't think you want to track QScreens.
We need to
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid
Cc: broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts,
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid
Cc: broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts,
amantia edited the summary of this revision.
amantia added reviewers: Plasma, ervin, dvratil, mlaurent, hein.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff,
mlaurent added inline comments.
INLINE COMMENTS
> foldermodel.h:192
> +ScreenMapper* screenMapper() const;
> +void setScreenMapper(ScreenMapper* screenMapper);
> +
Coding style "space before *"
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
amantia updated this revision to Diff 21619.
amantia added a comment.
Basic handling of screen removal/addition.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21447=21619
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8493
On Tue, Oct 31, 2017 at 10:22:19AM +0100, Martin Flöser wrote:
> First of all: the mouse cursor is only shown if a mouse is connected. I
> assume that you connected one ;-)
>
Btw, for slightly more context, a mouse is hotplugged, given the current
board Matthias have only 1 USB port.
Thanks
--
amantia created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8567
AFFECTED FILES
shell/shellcorona.cpp
Am 2017-10-31 02:56, schrieb Matthias Klumpp:
For a phone we obviously don't need a mouse pointer, but at the moment
I can only interact with the UI by clicking blindly,
If you have a keyboard connected you can use the Mouse Mark effect: Just
press and hold control+meta and you get two
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:d71792378e9a: Fix rendering issues of subsurfaces by
using proper clipping (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8369?vs=20988=21613
davidedmundson added a comment.
consistent with what?
REPOSITORY
R161 KActivity Manager Service
REVISION DETAIL
https://phabricator.kde.org/D8561
To: anthonyfieroni, #plasma, davidedmundson, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts,
emateli added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
graesslin abandoned this revision.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8163
To: graesslin, #kwin, #plasma, mart
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8383
To: graesslin, #frameworks, #kwin, #plasma_on_wayland
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,
Am 2017-10-31 02:56, schrieb Matthias Klumpp:
Hello!
For a phone we obviously don't need a mouse pointer, but at the moment
I can only interact with the UI by clicking blindly, which is not
ideal for testing. So, do you have an idea on what might be wrong
here?
I have ideas...
First of all:
sebas added a comment.
Ow, I might add that we wanted to address a similar thing by providing a
popup when a display is connected that asks the user what do do now, and then
an action can be chosen. Maybe your time is spent better working on that
feature, as we already agreed that this
sebas added a comment.
Once you're done with the code, please also add screenshot so usability can
have a look at it. I'm not sure we should add UI for this, the screen setup is
already very complex and hard to understand. Perhaps a set of clear use-cases
would make this clearer?
No
emateli retitled this revision from "Disallow drop of task manager widgets
outside of plasmoid when locked" to "Disallow drop of task manager icons
outside of plasmoid when widgets are locked".
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli,
emateli created this revision.
emateli added a reviewer: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This patch disallows dropping task manager items outside of the plasmoid when
widgets are locked.
As a user whose primary device is a laptop (with a touch
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
mlaurent edited the test plan for this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
anthonyfieroni added a comment.
In https://phabricator.kde.org/D8561#162062, @davidedmundson wrote:
> Wouldn't it be cleaner to put the quit in:
>
> Resources::Private::~Private
> and/or ResourceScoreMaintainer::Private::~Private
>
> (also I have no idea what the Resource
anthonyfieroni updated this revision to Diff 21603.
anthonyfieroni added a comment.
Correct patch version.
REPOSITORY
R161 KActivity Manager Service
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8561?vs=21589=21603
REVISION DETAIL
https://phabricator.kde.org/D8561
AFFECTED
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I don't see that my comment about extending has been addressed at all.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To:
mlaurent retitled this revision from "WIP: Define default Action when we plug
unknown monitor" to "Define default Action when we plug unknown monitor".
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham,
marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This change is similar to https://phabricator.kde.org/D8424, for the "Icons"
tab of the dialogue. In the
jgrulich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
386360_remove_dialog_buttons
REVISION DETAIL
https://phabricator.kde.org/D8562
To: ngraham, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, progwolff,
55 matches
Mail list logo
