D8849: [Folder View Filter Config] Use TableView for mime types

broulik added a comment. The default sorting is by name. I was just demonstrating in the screenshot that you could also sort by checked in order to quickly find the checked ones, sorry. There //are// hundreds of options. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator

D8441: Wallpaper: hide color or blur filling options for full filling mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:72450a2a49d2: Wallpaper: hide color or blur filling options for full filling mode (authored by guoyunhe). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D84

D8858: Fix testWaylandFullscreenShell.

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Could you please add a message that it is missing? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc: plasma-deve

D8849: [Folder View Filter Config] Use TableView for mime types

abetts added a comment. In https://phabricator.kde.org/D8849#168791, @hein wrote: > I like it, but should the default sort column be the name so that there's no awkward arrow in the header element for the checkboxes? > > I feel like QWidget views or rather QStandardItemDelegate avoid

D8849: [Folder View Filter Config] Use TableView for mime types

hein added a comment. I like it, but should the default sort column be the name so that there's no awkward arrow in the header element for the checkboxes? I feel like QWidget views or rather QStandardItemDelegate avoid this by embedding the checkbox into the column for Qt::DisplayRole or

D8770: Resolve the input method issue by always force focus in search field.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:44d8a7500e36: Resolve the input method issue by always force focus in search field. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D8858: Fix testWaylandFullscreenShell.

cgiboudeaux created this revision. cgiboudeaux added a reviewer: graesslin. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This test needs the weston executable. Skip the test if the progr

D8006: Add edit button to desktop theme

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8006 To: davidedmundson, #plasma, apol Cc: apol, abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha

D8856: Add support for new IdleInhibition protocol

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY A small helper class is added which manages inhibiting idle for the ShellClients. So far only v

D8661: Allow a cross-process check for same applications

This revision was automatically updated to reflect the committed changes. Closed by commit R108:1ae7990a959c: Allow a cross-process check for same applications (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8661?vs=21895&id=22483 REVISIO

D8396: Add support for zwp_idle_inhibit_manager_v1

This revision was automatically updated to reflect the committed changes. Closed by commit R127:9520c2f292d0: Add support for zwp_idle_inhibit_manager_v1 (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8396?vs=21046&id=22482#toc REPOSITORY R127 KWayland CHANGES

D8854: Add enclosure registeration config for mycroft skills manager

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Added system wide mycroft configuration that registers the enclosure to be able to fetch enclosure specific skills

D8854: Add enclosure registeration config for mycroft skills manager

This revision was automatically updated to reflect the committed changes. Closed by commit R846:9b29a1bd83c7: Add enclosure registeration config for mycroft skills manager (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D88

D8845: Create tooltipManager on demand

graesslin added a comment. In https://phabricator.kde.org/D8845#168632, @broulik wrote: > Look in the constructor, kept it consistent ah I just made this as a proposal as you had to change unrelated lines. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kd

D8845: Create tooltipManager on demand

broulik added a comment. Look in the constructor, kept it consistent REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8845 To: broulik, mart Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8845: Create tooltipManager on demand

davidedmundson added a comment. I think you've identified something, (well, 0.2% on my PC) , which is good, but I think we should delve deeper into the issue. KTooltipManager isn't slow, it's the platform window being created in KTooltipWidget constructor that is. We can just move that

D8845: Create tooltipManager on demand

graesslin added inline comments. INLINE COMMENTS > SidebarMode.cpp:236 > > ToolTipManager *toolTipManager; > QQuickWidget * quickWidget; toolTipManager = nullptr; REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8845 To: broulik, mart Cc: graesslin,

D8850: WIP: support drag and drop between shared folder view containments

broulik added a comment. I think only drops between //containments// should be special-cased. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8850 To: mwolff, amantia Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8850: WIP: support drag and drop between shared folder view containments

mwolff created this revision. mwolff added a reviewer: amantia. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is still super buggy. From what I've understood so far, the problem seems to be the positioner acting u

D8006: Add edit button to desktop theme

davidedmundson marked 2 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8006 To: davidedmundson, #plasma Cc: apol, abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D8849: [Folder View Filter Config] Use TableView for mime types

broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Implements proper keyboard navigation (up/down) as well as space to goggle check box - Makes l

D8641: FormLayout

mart added inline comments. INLINE COMMENTS > broulik wrote in FormLayout.qml:45 > Use `Qt.callLater` (new in Qt 5.8) if you pass it an actual function (ie. not > an inline one) it will compress subsequent calls to one: > https://doc.qt.io/qt-5/qml-qtqml-qt.html#callLater-method > > There's pr

D8692: QML mouse cursor KCM and components

mart added a comment. In https://phabricator.kde.org/D8692#168581, @ngraham wrote: > A scrollbar to show hidden buttons is a pretty bad UX. We should aim for something better in the new version. Perhaps the buttons should lose their text and become icons-only when the window is too narro

D8641: FormLayout

mart updated this revision to Diff 22468. mart marked 10 inline comments as done. mart added a comment. - adress comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8641?vs=22462&id=22468 BRANCH mart/formlayout REVISION DETAIL https://phabricator

D8006: Add edit button to desktop theme

davidedmundson updated this revision to Diff 22467. davidedmundson added a comment. Use QProcess REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8006?vs=19973&id=22467 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8006 AFFECTED FIL

D8692: QML mouse cursor KCM and components

ngraham added a comment. A scrollbar to show hidden buttons is a pretty bad UX. We should aim for something better in the new version. Perhaps the buttons should lose their text and become icons-only when the window is too narrow to show them all with icons and text. REPOSITORY R119 Plasm

D8809: Reduce spurious signal emissions

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvgitem.cpp:295 > If we always have 4 and can initialised them to 0 qreal[4] with a c style > array would be better. Would it? it's harder to compare then as you can't do a simple `!=` REPOSITORY R242 Plasma Framework

D8809: Reduce spurious signal emissions

This revision was automatically updated to reflect the committed changes. Closed by commit R242:11c9206bf68f: Reduce spurious signal emissions (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8809?vs=22304&id=22465 REVISIO

D8692: QML mouse cursor KCM and components

aspotashev added a comment. >> Does it add a horizontal scrollbar when the width is not enough for all the pushbuttons, like in the QWidget-based KCM (screenshot below)? > > this screenshot if from the old module, you have to actually unistall it or will keep loading that one I know

D8522: keyboard navigation in and out QML kcms

This revision was automatically updated to reflect the committed changes. Closed by commit R295:9ebf898572ca: keyboard navigation in and out QML kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=22463&id=22464 REVISION DETAIL

D8522: keyboard navigation in and out QML kcms

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #framewo

D8692: QML mouse cursor KCM and components

mart added a comment. In https://phabricator.kde.org/D8692#168408, @aspotashev wrote: > Does it add a horizontal scrollbar when the width is not enough for all the pushbuttons, like in the QWidget-based KCM (screenshot below)? F5494095: Screenshot_20171116_143922.png

D8522: keyboard navigation in and out QML kcms

mart updated this revision to Diff 22463. mart added a comment. - guard null REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21440&id=22463 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTED FILES src/kcmoduleqml.

D8522: keyboard navigation in and out QML kcms

mart marked 2 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8809: Reduce spurious signal emissions

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > framesvgitem.cpp:295 > + > +const QVector m_oldMargins; > +FrameSvgItemMargins *const m_margins; If we always have 4 and can initialised them to

D8526: add a background in ScrollView

mart added a comment. In https://phabricator.kde.org/D8526#168377, @davidedmundson wrote: > > so, may be worth to have in kirigami a component called like ItemScrollView intended for this? > > I think so. > The component can be just one line of ScrollView{}, and the styles can do

D8641: FormLayout

mart updated this revision to Diff 22462. mart added a comment. - if there is a rendercontrol, watch the target window REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8641?vs=22410&id=22462 BRANCH mart/formlayout REVISION DETAIL https://phabricator.kd

D8845: Create tooltipManager on demand

broulik created this revision. broulik added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It takes a couple of milliseconds to be created and isn't vital for System Settings startup. TEST PLAN Tool

D8598: FolderView: position files at drop event target position

mwolff updated this revision to Diff 22458. mwolff edited the summary of this revision. mwolff added a comment. update message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8598?vs=22457&id=22458 REVISION DETAIL https://phabricator.kde.org/D8598

D8598: FolderView: position files at drop event target position

mwolff updated this revision to Diff 22457. mwolff added a comment. use filename in mapping to support desktop:/ REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8598?vs=21775&id=22457 REVISION DETAIL https://phabricator.kde.org/D8598 AFFECTED FILE

D8834: Make it possible to have videos on the background of breeze

apol abandoned this revision. apol added a comment. Here's the fork as requested `kde:scratch/apol/breeze-video-sddm`. TBH it feels a shame to fork 1200 lines of code for rejecting a patch that basically added 1. ¯\_(ツ)_/¯ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://pha

D8807: Fix warning regarding blur setting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddaf6f5696bd: Fix warning regarding blur setting (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8807?vs=22302&id=22456 REVISION DETAIL

D8493: Make Folder View screen aware

mwolff added a comment. [14:24] andris: milian umm, how do I actually move files between screens? [14:26] the fact that you can actually resize it with Alt+right-click is a bug [14:27] kbroulik: dnd, which is WIP [14:28] milian: okay because right now the screen-aware FV doe

D8493: Make Folder View screen aware

davidedmundson added a comment. Fine with me. Would be good if Eike could comment REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham,

D8807: Fix warning regarding blur setting

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8807 To: apol, #plasma, guoyunhe, ngraham, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je

D8807: Fix warning regarding blur setting

apol added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8807 To: apol, #plasma, guoyunhe, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8493: Make Folder View screen aware

mwolff accepted this revision. mwolff added a comment. lgtm from my side. Anyone from the plasma team care to chime in? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwo

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > mwolff wrote in screenmapper.cpp:85 > this should imo be a for loop to make it clear that it is iterating over all > items (more ideomatic). Also, couldn't you use range-based for here even? range based loop: I need access to both key and value

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22444. amantia added a comment. Some code reogranization per Milian's request REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22438&id=22444 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D8493: Make Folder View screen aware

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. some more nits, sorry for that ;-) INLINE COMMENTS > screenmapper.cpp:69 > +auto adjustFirstScreen = [this, &screenId](const QString &path) { > +int firstScreen = m_fi

D8840: XRandR: Clear EDID data when monitor is disconnected from an output

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8840 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je

D8833: Make it possible to pass different kind of backgrounds as such

apol added a comment. > No for the same reason. How will one create a theme that supports video if they then can't put videos in it? INLINE COMMENTS > davidedmundson wrote in themeconfig.cpp:90 > So if it's blank (like the current Plasma theme with the blue image) a user > can never se

D8840: XRandR: Clear EDID data when monitor is disconnected from an output

dvratil created this revision. dvratil added a reviewer: sebas. Restricted Application added a project: Plasma. REVISION SUMMARY This fixes KScreen behavior in situation when a monitor is unplugged from an output and another monitor is plugged into the same output afterwards. By keeping the

D8692: QML mouse cursor KCM and components

aspotashev added a comment. Does it add a horizontal scrollbar when the width is not enough for all the pushbuttons, like in the QWidget-based KCM (screenshot below)? F5494095: Screenshot_20171116_143922.png REPOSITORY R119 Plasma Desktop REVISION DE

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22438. amantia added a comment. Handle screen removal correctly: - adjust the first screen per path in a more efficient way - adjust the number of screens per path properly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabri

D8522: keyboard navigation in and out QML kcms

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleqml.cpp:154 > can this be null? Quick glance at `QQuickItemPrivate::nextPrevItemInTabFocusChain` shows it cannot. In doubt it returns `this`. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.o

D8522: keyboard navigation in and out QML kcms

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmoduleqml.cpp:143 > +{ > +//FIXME: those are all workarounds around the QQuickWidget brokeness > +if (watched == d->quickWidget && ev

D8526: add a background in ScrollView

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > so, may be worth to have in kirigami a component called like ItemScrollView intended for this? I think so. The component can be just one line of ScrollView

D8493: Make Folder View screen aware

mwolff added inline comments. INLINE COMMENTS > screenmapper.cpp:82 > +// the screen got completely removed, not only its path changed > +pathIt = m_screensPerPath.begin(); > +while (pathIt != m_screensPerPath.end()) { personally I'd make this code explicit. i.e. this her

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22434. amantia added a comment. Remove unused var REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22428&id=22434 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 AFFECTED FILES cont

D8641: FormLayout

broulik added inline comments. INLINE COMMENTS > FormLayoutGallery.qml:79 > +text: item ? "Remove Field" : "Add Field" > +property var item > +onClicked: { `property Item`? That's in a couple of places > FormLayout.qml:45 > + > +Timer { > +

D8522: keyboard navigation in and out QML kcms

mart added a comment. ping REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8692: QML mouse cursor KCM and components

mart added a comment. ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8692 To: mart, #plasma Cc: januz, ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8526: add a background in ScrollView

mart added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: mart, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > mwolff wrote in screenmapper.cpp:108 > `m_itemsOnDisabledScreensMap` stores "names" from the `m_screenItemMap`, so I > think this line here is wrong and should also use the proposed > `screenUrlForPath` above, or `QUrl::fromUserInput`, no? Otherw

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22428. amantia marked 2 inline comments as done. amantia added a comment. Add a code comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22387&id=22428 BRANCH master REVISION DETAIL https://phabr