D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22868. amantia added a comment. Guard screenmapper usage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22797=22868 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8850: Support drag and drop between shared folder view containments

amantia marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

IRC have mode +r set now

Hello, So due to spammer we have enabled +r mode in #plasma channel as temporary measures. This would mean you can not join #plasma channel with unregistered nick. Thanks

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure updated this revision to Diff 22860. dfaure added a comment. Use a signal instead of invokeMethod REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8421?vs=22855=22860 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8421

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure added a comment. In https://phabricator.kde.org/D8421#171420, @davidedmundson wrote: > > What should happen when I do? Surely a webview won't fit there... > > We should show an icon (like a dictionary or something) > which will show the popup with the relevant plasmoid. >

D8421: Port the dict applet to KF5 and QtQuick 2

anthonyfieroni added inline comments. INLINE COMMENTS > dict_object.cpp:42 > +// different thread -> use invokeMethod > +QMetaObject::invokeMethod(m_dict, "lookup", Q_ARG(QString, word)); > + } Why you prefer invoke rather than a signal ? REPOSITORY R114 Plasma Addons

D8421: Port the dict applet to KF5 and QtQuick 2

davidedmundson added a comment. > What should happen when I do? Surely a webview won't fit there... We should show an icon (like a dictionary or something) which will show the popup with the relevant plasmoid. In theory this should all happen automatically if the minimum size hints

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure updated this revision to Diff 22855. dfaure added a comment. Remove old code, not used anymore. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8421?vs=22852=22855 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8421 AFFECTED

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure updated this revision to Diff 22852. dfaure edited the test plan for this revision. dfaure added a comment. clean up TODO REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8421?vs=21473=22852 BRANCH master REVISION DETAIL

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure edited the test plan for this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D8421 To: dfaure, #plasma Cc: broulik, davidedmundson, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Visually, it looks great to me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22820. mart added a comment. - remove spurious changes to resync with master - use qqc1 buttons for the icon - adapt to new scrollview behavior - base components: SimpleKCM GridViewKCM REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8725: [PageRow] Navigate between levels with mouse back/forward buttons

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8725 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D8726: [ScrollView] Scroll one page with Shift+wheel

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. could you take a look at qqc2-desktop-style as well, as it has another scrollview implementation? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8726 To: broulik,

D8850: Support drag and drop between shared folder view containments

mwolff requested changes to this revision. mwolff added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > foldermodel.cpp:1071 > +m_dropTargetPositions.insert(url.fileName(), dropPos); > +m_screenMapper->addMapping(mappableUrl(url),

D8850: Support drag and drop between shared folder view containments

amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1131 > unguarded same here REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8850: Support drag and drop between shared folder view containments

amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1123 > unguarded It is guarded (line 1117) REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8963: [Containment Interface] Set WA_TranslucentBackground before accessing winId()

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8963 To: broulik, #plasma, fvogt Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8965: [PlasmaComponents Menu] Set WA_TranslucentBackground on the underlying QMenu

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8965 To: broulik, #plasma, fvogt, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D8963: [Containment Interface] Set WA_TranslucentBackground before accessing winId()

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8963 To: broulik, #plasma, fvogt Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8965: [PlasmaComponents Menu] Set WA_TranslucentBackground on the underlying QMenu

broulik created this revision. broulik added reviewers: Plasma, fvogt. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This ensures the menu can have nice round corners with Breeze and Oxygen. The

D8963: [Containment Interface] Set WA_TranslucentBackground before accessing winId()

broulik created this revision. broulik added reviewers: Plasma, fvogt. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This would create the surface after which this flag has no effect causing menus

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22829. mart added a comment. - correctly manage apply REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22820=22829 BRANCH kcm-redesign/cursorTheme REVISION DETAIL https://phabricator.kde.org/D8692

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22828. hein added a comment. - Implement latest VDG mockup. This simplifies the UI from two seperate timeout settings to one, but in the config files we still have two. We write both, but the code needs to make a decision which one to read and show

D8692: QML mouse cursor KCM and components

hein requested changes to this revision. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmcursortheme.cpp:150 > +emit selectedThemeRowChanged(); > +setNeedsSave(true); > +updateSizeComboBox(); Incorrect Apply button management >

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Updated screenshot: F5506081: Screenshot_20171123_231847.png Branch is re-pushed as well. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac,

D8963: [Containment Interface] Set WA_TranslucentBackground before accessing winId()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8963 To: broulik, #plasma, fvogt, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D8866: [Applet Configuration] Switch page on press instead of click

This revision was automatically updated to reflect the committed changes. Closed by commit R119:29ebb3130264: [Applet Configuration] Switch page on press instead of click (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8961: [Folder View] Accept mouse events if we handled them

broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8961 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8961: [Folder View] Accept mouse events if we handled them

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This keeps the event from propagating to e.g. the containment resulting in two context menus (both

D8864: RFC: [MouseEventListener] Allow accepting mouse event

This revision was automatically updated to reflect the committed changes. Closed by commit R296:e2795e947233: [MouseEventListener] Allow accepting mouse event (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8864?vs=22518=22803#toc REPOSITORY R296 KDeclarative

D8910: Add Plasma Mobile session

This revision was automatically updated to reflect the committed changes. Closed by commit R20:3a73eae701cf: Add Plasma Mobile session (authored by bshah). REPOSITORY R20 Plasma Phone Components CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8910?vs=22623=22802 REVISION DETAIL