date:20171130

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2017-11-30 Thread Christoph Feck

https://bugs.kde.org/show_bug.cgi?id=374311

Christoph Feck  changed:

   What|Removed |Added

 CC||bugs5.kde@sjau.ch

--- Comment #4 from Christoph Feck  ---
*** Bug 387459 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread René J . V . Bertin

rjvbb added a comment.


  > On the other hand, calling setBold(true) on a font called 
"HandwriteCursive" _should_ select "HandwriteBoldCursive", even if the 
styleName was intended to enforce a specific face. If Qt cannot fix this issue, 
then we have to clear the styleName() at least for those fonts, where a perfect 
match is possible using the attributes alone (by comparing with the database 
again).
  
  Indeed - and I think there are limits to what any automated system can do 
here. There's a point where you have to accept that fonts may have a design 
issue in how they're named and what additional information is available in the 
font file (fortunately the font name isn't the only metadata). And at that 
point you indeed have to fall back to using databases (maybe FontConfig could 
help here)?
  
  > The patch also addresses the bug only for default fonts, but not 
per-application fonts that write their settings to the appnamerc file.
  
  True. Yet I only got bold syntax highlighting again after I applied this 
patch in addition to removing the stylename extension from kateschemarc. I 
don't yet have an explanation for that ...
  
  > All of those will also have a StyleName, so this here doesn't apply either.
  
  Hah, that depends with what Qt version they were generated, and on whether or 
not the user removed the parameter. I didn't invent that move myself, reading 
comments from others who did that to restore issues is what got me to write 
this patch in the end.
  
  > Nothing gets overridden here. It's just that the user didn't specify it.
  
  Which probably means he didn't want it, in this case... What if that short 
name is one of the fonts from Christoph's example (and thus includes an 
explicit weight specification), are you going to do heuristics on it?
  
  This kind of changing the default is fine for users who never use the 
configuration utilities and thus may not even have a kdeglobals file.
  It can get a bit tricky if s/he has a spec in the file that corresponds to an 
old default, but when in doubt I always assume the user is right in this sort 
of thing.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck
Cc: cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8856: Add support for new IdleInhibition protocol

2017-11-30 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ff2e8834694a: Add support for new IdleInhibition protocol 
(authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8856?vs=22488&id=23193

REVISION DETAIL
  https://phabricator.kde.org/D8856

AFFECTED FILES
  CMakeLists.txt
  autotests/integration/CMakeLists.txt
  autotests/integration/idle_inhibition_test.cpp
  autotests/integration/kwin_wayland_test.h
  autotests/integration/test_helpers.cpp
  idle_inhibition.cpp
  idle_inhibition.h
  wayland_server.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread Christoph Feck

cfeck added a comment.


  The patch also addresses the bug only for default fonts, but not 
per-application fonts that write their settings to the appnamerc file.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck
Cc: cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread Fabian Vogt

fvogt added a comment.

  In https://phabricator.kde.org/D9070#173835, @rjvbb wrote:

  > >   IMO that's a feature though and is the expected behaviour. For 
instance, if we change the default window title to be bold, users with 
"windowTitle=Comic Sans" will also have a bold title.
  >
  > So how would you "change the default window title to be bold"

  By editing the files in plasma-integration and the fonts kcm  in 
plasma-desktop, chaning the default stylename and weight.

  > and more importantly, how many people are going to have only a font family 
name in their configuration files? The vast majority will use the available GUI 
methods for selecting fonts and will end up with a complete specification.

  All of those will also have a StyleName, so this here doesn't apply either.

  > I'd go one step further: why would changes to defaults override choices 
already made by users? That's bad practice any way you look at it.

  Nothing gets overridden here. It's just that the user didn't specify it.

  >>   So just specifying exactly 10 parameters as part of the config key 
should have the exact same effect.
  > 
  > I don't know what Qfont method that comes from, but experience shows that 
just removing the stylename extension from the config key (a freshly generated 
one) doesn't do the trick. IOW, the stylename isn't cleared.

  I just checked, the behaviour I described is part of Qt 5.8.0-rc1 and onwards.

  In the end, this is just a matter of preference: Should the default stylename 
for a font family be the same as the stylename we chose as default or just 
empty?
  The options available in the GUI force a selection of the stylename, so it 
only applies to migrated and hand-edited configuration anyway.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck
Cc: cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread Christoph Feck

cfeck added a reviewer: cfeck.
cfeck added a comment.


  The config would work with removed styleName() for the cases where the 
weight() and style() attributes are sufficient. The intention from Qt's side 
was to uniquely identify fonts that cannot be selected by those two attributes. 
Imagine a font that has these faces:
  
  - HandwriteRegular
  - HandwriteBold
  - HandwriteItalic
  - HandwriteBoldItalic
  - HandwriteCursive
  - HandwriteBoldCursive
  
  Now the user picks "HandwriteCursive", and unless we do not save the 
styleName(), the font matching would probably select "HandwriteItalic" based on 
the weight() and style() attributes. On the other hand, calling setBold(true) 
on a font called "HandwriteCursive" _should_ select "HandwriteBoldCursive", 
even if the styleName was intended to enforce a specific face. If Qt cannot fix 
this issue, then we have to clear the styleName() at least for those fonts, 
where a perfect match is possible using the attributes alone (by comparing with 
the database again).

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck
Cc: cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8673: Sanitize signal handling in ksmserver

2017-11-30 Thread Martin Flöser

graesslin added inline comments.

INLINE COMMENTS

> server.cpp:615
> +QSocketNotifier* n = new QSocketNotifier(sockets[1], 
> QSocketNotifier::Read, this);
> +qApp->connect(n, SIGNAL(activated(int)), SLOT(quit()));
> +

why the old connect syntax?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8673

To: jpalecek, #plasma
Cc: graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread René J . V . Bertin

rjvbb added a comment.


  >   IMO that's a feature though and is the expected behaviour. For instance, 
if we change the default window title to be bold, users with "windowTitle=Comic 
Sans" will also have a bold title.
  
  So how would you "change the default window title to be bold" and more 
importantly, how many people are going to have only a font family name in their 
configuration files? The vast majority will use the available GUI methods for 
selecting fonts and will end up with a complete specification.
  
  I'd go one step further: why would changes to defaults override choices 
already made by users? That's bad practice any way you look at it.
  
  >   So just specifying exactly 10 parameters as part of the config key should 
have the exact same effect.
  
  I don't know what Qfont method that comes from, but experience shows that 
just removing the stylename extension from the config key (a freshly generated 
one) doesn't do the trick. IOW, the stylename isn't cleared.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread Anthony Fieroni

anthonyfieroni added reviewers: Frameworks, davidedmundson, graesslin.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread Fabian Vogt

fvogt added a comment.


  Oh, now I understand: It fixes the issue that the styleName was prefilled 
with the stylename of the default font and fromString might not reset it.
  IMO that's a feature though and is the expected behaviour. For instance, if 
we change the default window title to be bold, users with "windowTitle=Comic 
Sans" will also have a bold title.
  
  qtbase's src/gui/text/qfont.cpp says:
  
setFamily(l[0].toString());
if (count > 1 && l[1].toDouble() > 0.0)
setPointSizeF(l[1].toDouble());
if (count == 9) {
setStyleHint((StyleHint) l[2].toInt());
setWeight(qMax(qMin(99, l[3].toInt()), 0));
setItalic(l[4].toInt());
setUnderline(l[5].toInt());
setStrikeOut(l[6].toInt());
setFixedPitch(l[7].toInt());
} else if (count >= 10) {
if (l[2].toInt() > 0)
setPixelSize(l[2].toInt());
setStyleHint((StyleHint) l[3].toInt());
setWeight(qMax(qMin(99, l[4].toInt()), 0));
setStyle((QFont::Style)l[5].toInt());
setUnderline(l[6].toInt());
setStrikeOut(l[7].toInt());
setFixedPitch(l[8].toInt());
if (count == 11)
d->request.styleName = l[10].toString();
else
d->request.styleName.clear();
}
  
  So just specifying exactly 10 parameters as part of the config key should 
have the exact same effect.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread René J . V . Bertin

rjvbb added a comment.


  It depends a little bit what kind of call you make. But yes, certain 
"conflicting" attributes can no longer be set. A particular example reported by 
many is setting bold. If you do `setStyleName("Regular")` on a Qfont, 
`setBold(true)` will no longer have the intended effect, or possibly not the 
same effect (apparently you can also end up with an emboldened version of the 
font, rather than with the actual bold version).
  
  Have you ever worked with professional typesetting, drawing of page-layout 
applications like InDesign or Illustrator? There you don't set a font to bold, 
you select another typeface from among the ones you have installed. This is of 
course how fonts are designed and implemented but most of expect that 
"old-fashioned inconvenience" to be hidden. IOW, flip a font to bold by hitting 
Ctrl-B and you get "Foo Bold" rather than "Foo Regular-or-Whatever-you-had 
turned into something looking bold". Calling `setStyleName()` brings back a bit 
of that old-fashioned "pedantic" nature.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9073: Don't try to generate metadata.json if there's no metadata.desktop

2017-11-30 Thread Aleix Pol Gonzalez

apol created this revision.
apol added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In fact, if metadata.json is provided directly, that's all we need.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9073

AFFECTED FILES
  KF5PackageMacros.cmake
  src/kpackagetool/kpackagetool.cpp

To: apol, #plasma, #frameworks
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread Fabian Vogt

fvogt added a comment.


  So after calling setStyleName on a QFont, it's "tainted" and subsequent calls 
won't have the same effect?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9072: make ksshaskpass work with git-lfs

2017-11-30 Thread Friedrich W . H . Kossebau

kossebau resigned from this revision.
kossebau added a comment.


  no clue about these ksshaskpass internals, sorry

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9072

To: mkoller, cfeck, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8816: Show root items in kicker menu

2017-11-30 Thread Nathaniel Graham

ngraham edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8816

To: lopatin, #plasma
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9072: make ksshaskpass work with git-lfs

2017-11-30 Thread Martin Koller

mkoller created this revision.
mkoller added reviewers: kossebau, cfeck, jriddell.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  On our git-lfs setup, I could not authenticate to the server due to 2 
problems with ksshaskpass:
  
  1. the git-lfs uses yet another syntax for the prompt, which was not covered 
by a regular expression
  2. KWallet writes an error to stderr when a 0-winId is given to openWallet() 
which is received by git-lfs and aborts the operation.
  
  The attached patch solves both issues.
  
  1. a new regexp is added
  2. I pass the desktop winId to openWallet

TEST PLAN
  using git with lfs

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9072

AFFECTED FILES
  src/main.cpp

To: mkoller, kossebau, cfeck, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9045: Better UI for the "Create a new vault" button

2017-11-30 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  OK, if it's just me, then +1. I'll have to look into what's up with my Neon 
dev VM.

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9045

To: ivan, #plasma, cryptodude, ngraham
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9066: [AppletInterface] Emit change signals for configurationRequired and -Reason

2017-11-30 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fa3a3899258b: [AppletInterface] Emit change signals for 
configurationRequired and -Reason (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9066?vs=23168&id=23177

REVISION DETAIL
  https://phabricator.kde.org/D9066

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9045: Better UI for the "Create a new vault" button

2017-11-30 Thread Marco Martin

mart added a comment.


  code change looks fine, and no, shouldn't do that layouting bug, (nor i can 
reproduce with long text inside plasma buttons)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D9045

To: ivan, #plasma, cryptodude, ngraham
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9066: [AppletInterface] Emit change signals for configurationRequired and -Reason

2017-11-30 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9066

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2017-11-30 Thread René J . V . Bertin

rjvbb created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Applying the default, hardwired QFont::styleName to one of the standard fonts 
which then gets changed to a user-selected font can break expectations because 
of the way Qt handles such canonical stylenames, letting them override the 
effects of other QFont methods invoked subsequently. It can for instance become 
impossible to make the font bold afterwards: see 
https://bugs.kde.org/show_bug.cgi?id=378523, 
https://bugreports.qt.io/browse/QTBUG-63792 or 
https://bugs.kde.org/show_bug.cgi?id=387467 .
  
  This may be a Qt "feature" that's here to stay, sadly.
  
  The change proposed here makes it possible (again) for users to prevent font 
weight rendering regressions by removing the stylename extension from 
configuration files manually as documented in several locations. This approach 
is useless when the KDE platform theme plugin then applies the default 
stylename, an issue that can be avoided by calling QFont::setStyleName() only 
when no user-specified font is available.
  
  Evidently the manual intervention could be replaced with a change in the way 
font settings are stored; this would also require the current change.

TEST PLAN
  Works as intended on Linux. An equivalent modification in my osx-integration 
fork of the platform theme plugin for Mac has the same effect (without it 
"Segoe UI Semi-bold" is no longer made bold where it should in dialogs).
  
  I don't think there are possible side-effects:
  
  - a stylename still gets set either if there is no user-selected font or if 
that selection includes a stylename extension
  - font specifications should still contain all the required information they 
always had; not applying a guessed stylename only means that no conflict can 
arise with the combined set of numeric style and weight attributes.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

AFFECTED FILES
  src/platformtheme/kfontsettingsdata.cpp

To: rjvbb
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8816: Show root items in kicker menu

2017-11-30 Thread Sergei Lopatin

lopatin added a comment.


  Before: F5519898: Выделение_073.png 
  After: F5519897: Выделение_072.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8816

To: lopatin, #plasma
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9068: Use setSize() instead of setProperty width and height

2017-11-30 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b6b81c67b310: Use setSize() instead of setProperty width 
and height (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9068?vs=23173&id=23174

REVISION DETAIL
  https://phabricator.kde.org/D9068

AFFECTED FILES
  src/plasmaquick/containmentview.cpp
  src/plasmaquick/view.cpp

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9068: Use setSize() instead of setProperty width and height

2017-11-30 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I'm sure we'd done this already...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9068

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9068: Use setSize() instead of setProperty width and height

2017-11-30 Thread Kai Uwe Broulik

broulik updated this revision to Diff 23173.
broulik added a comment.


  - Restore accidentally removed comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9068?vs=23171&id=23173

REVISION DETAIL
  https://phabricator.kde.org/D9068

AFFECTED FILES
  src/plasmaquick/containmentview.cpp
  src/plasmaquick/view.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9068: Use setSize() instead of setProperty width and height

2017-11-30 Thread Kai Uwe Broulik

broulik added a comment.


  > I'm sure we'd done this already...
  
  I replaced all method calls to `setWidth()` and `setHeight()` but not 
instances where we went through `setProperty`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9068

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9068: Use setSize() instead of setProperty width and height

2017-11-30 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  We know we have a `QQuickItem` so we can just use its methods directly and 
then also use`setSize` which does both at once, saving intermediate signal 
emission and potential re-layouting

TEST PLAN
  Containment still looks normal

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9068

AFFECTED FILES
  src/plasmaquick/containmentview.cpp
  src/plasmaquick/view.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9066: [AppletInterface] Emit change signals for configurationRequired and -Reason

2017-11-30 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

TEST PLAN
  I now can react on that from the containment and show/hide a configure button

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9066

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8924: Move the KDE Polkit-Agent into ksmserver

2017-11-30 Thread David Edmundson

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Somehow this went from "lets add a thing to ksmserver" to "lets split 
ksmserver"
  
  Abandoning for now. Will return with something more extreme. (maybe for 5.13 
at this point)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8924

To: davidedmundson, #plasma
Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D9065: [Task Manager] Support places categories

2017-11-30 Thread Kai Uwe Broulik

broulik edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9065

To: broulik, #plasma, hein, #vdg, renatoo
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9065: [Task Manager] Support places categories

2017-11-30 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, hein, VDG, renatoo.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds submenus for subsequent categories in places model. Now that baloo 
search and others are in there the menu would grow enormous otherwise.

TEST PLAN
  F5519702: Screenshot_20171130_104431.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9065

AFFECTED FILES
  applets/taskmanager/plugin/backend.cpp

To: broulik, #plasma, hein, #vdg, renatoo
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8444: Define default Action when we plug unknown monitor

2017-11-30 Thread David Edmundson

davidedmundson added a comment.


  I left a comment a month ago. It has not been addressed.
  
  > there's one part that's going to appear very confusing.
  
  
  
  > I have my (small) laptop. Lets say I want any new (big) screen to appear on 
the left. So I save "Extend to left".
  > So I'd expect to see: monitor, laptop.
  
  
  
  > What will happen, is it will extend my biggest screen to the left, leaving 
me with:
  > laptop, monitor
  
  
  
  > rendering the option seemingly broken.
  
  It's artbitrary depending on what size monitor you happen to plug in.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D8444: Define default Action when we plug unknown monitor

2017-11-30 Thread Laurent Montel

mlaurent added a comment.


  Ping ?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

kdesrc-build setup for building qt5 before plasma

2017-11-30 Thread Stéphane Ancelot


Hi,

using kdesrc-build , I dont manage to compile qt before kde5

I setted up qtdir in global conf

and repository kde:qt in module qt5, but it does not help

Regards

S.Ancelot

D8917: Reduce the amount of spurious property changes on ColorScope

2017-11-30 Thread David Edmundson

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Concept is good.

INLINE COMMENTS

> colorscope.cpp:127
>  }
> +m_lastGroup = m_group;
>  return m_group;

It's weird to be caching in a public getter.

It opens us up for problems

If some client code (for whatever reason) did 
connect(scope, inheritChanged, []() {scope->colorGroup());

then our signals in checkColorGroupChanged won't get emitted.

Can we move this member var into checkColorGroupChanged? Means we can get rid 
of the mutable too

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8917

To: apol, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8673: Sanitize signal handling in ksmserver

2017-11-30 Thread David Edmundson

davidedmundson added a comment.


  > It would certainly be cleaner to close them in the destructor.
  
  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8673

To: jpalecek, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8856: Add support for new IdleInhibition protocol

2017-11-30 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

INLINE COMMENTS

> idle_inhibition.cpp:42
> +
> +void IdleInhibition::registerShellClient(ShellClient *client)
> +{

We could do with a line in wayland-protocol docs to say it has to be a toplevel 
surface.
Right now we're making an assumption. Albeit a fairly safe one.

REPOSITORY
  R108 KWin

BRANCH
  idle-inhibit

REVISION DETAIL
  https://phabricator.kde.org/D8856

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

37 matches

Mail list logo