D10084: Make the messages translatable

[Burkhard Lück]

lueck accepted this revision.
lueck added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10084

To: yurchor, #plasma, graesslin, #localization, lueck
Cc: lueck, aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10111: [Klipper] Force plain text on the edit dialog

[Safa Alfulaij]

safaalfulaij added a comment.


  This is how it looks currently:
  
  F5675251: Screenshot_٢٠١٨٠١٢٦_٠٧٤٨٢٣.png 

  
  With the patch we'll get `Test` instead in the textedit.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10111

To: safaalfulaij, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10111: [Klipper] Force plain text on the edit dialog

[Safa Alfulaij]

safaalfulaij created this revision.
safaalfulaij added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
safaalfulaij requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10111

AFFECTED FILES
  klipper/klipper.cpp

To: safaalfulaij, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10110: Port konsolesessions runner to Plasma5/Qt5

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: broulik, jriddell, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Ported following changes in katesessions runner and konsole.

TEST PLAN
  Konsole profiles are shown as matches when entering "konsole"
  and "konsole "

REPOSITORY
  R114 Plasma Addons

BRANCH
  portkonsolesessions

REVISION DETAIL
  https://phabricator.kde.org/D10110

AFFECTED FILES
  runners/CMakeLists.txt
  runners/konsolesessions/CMakeLists.txt
  runners/konsolesessions/konsolesessions.cpp
  runners/konsolesessions/konsolesessions.h

To: kossebau, broulik, jriddell, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10096: Softer shadow on the screenshots

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:b6f1d90bd49e: Softer shadow on the screenshots (authored 
by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10096?vs=25970=25971

REVISION DETAIL
  https://phabricator.kde.org/D10096

AFFECTED FILES
  discover/qml/ApplicationScreenshots.qml

To: apol, ngraham
Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10096: Softer shadow on the screenshots

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks fantastic. Ship it! I love the fade-in/fade-out effect.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10096

To: apol, ngraham
Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10096: Softer shadow on the screenshots

[Aleix Pol Gonzalez]

apol updated this revision to Diff 25970.
apol added a comment.


  Small improvement

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10096?vs=25940=25970

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10096

AFFECTED FILES
  discover/qml/ApplicationScreenshots.qml

To: apol, ngraham
Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10104: Port charrunner to Plasma5/Qt5

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:58e9e839f0a2: Port charrunner to Plasma5/Qt5 (authored by 
kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10104?vs=25959=25969

REVISION DETAIL
  https://phabricator.kde.org/D10104

AFFECTED FILES
  runners/CMakeLists.txt
  runners/characters/CMakeLists.txt
  runners/characters/charrunner.cpp
  runners/characters/charrunner.h
  runners/characters/charrunner_config.cpp
  runners/characters/charrunner_config.h
  runners/characters/charrunner_config.ui

To: kossebau, broulik, jriddell, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  @graesslin: do elevated windows have order? (e.g. docks are above fullscreen 
windows, etc)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#196143, @graesslin wrote:
  
  > The region in this method is later on used for clipping. Given that you 
need that paintclipper fragment.
  
  
  I think `PaintClipper pc(QRegion(effects->virtualScreenGeometry()));` should 
be enough.(given that the slide effect only translates windows)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#196145, @graesslin wrote:
  
  > > Docks are drawn above all windows by the following code:
  > > 
  > >   for (EffectWindow* w : windows) {
  > >   if (! w->isDock()) {
  > >   continue;
  > >   }
  > >   WindowPaintData dockData(w);
  > >   int dockMask = mask
  > >   | (w->hasAlpha() ? PAINT_WINDOW_TRANSLUCENT
  > >: PAINT_WINDOW_OPAQUE);
  > >   effects->drawWindow(w, dockMask, infiniteRegion(), dockData);
  > >   }
  > >
  > > 
  > > (`WindowForceBackgroundContrastRole` and `WindowForceBlurRole` are set at 
the beginning of the slide animation)
  > > 
  > > Am I missing something?
  >
  > I have an idea: the problem might be how you create the WindowPaintData. 
The ctor you use creates the WindowPaintData with an identity 
screenProjectionMatrix. This might be wrong in this case. The blur effect seems 
to use it.
  
  
  Maybe just elevate docks? E.g. at the beginning for each dock call 
`effects->setElevatedWindow(w, true)` and paint docks with the last visible 
virtual desktop?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D10104: Port charrunner to Plasma5/Qt5

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  good stuff!
  Master only pleae.

REPOSITORY
  R114 Plasma Addons

BRANCH
  portcharrunner

REVISION DETAIL
  https://phabricator.kde.org/D10104

To: kossebau, broulik, jriddell, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  > Docks are drawn above all windows by the following code:
  > 
  >   for (EffectWindow* w : windows) {
  >   if (! w->isDock()) {
  >   continue;
  >   }
  >   WindowPaintData dockData(w);
  >   int dockMask = mask
  >   | (w->hasAlpha() ? PAINT_WINDOW_TRANSLUCENT
  >: PAINT_WINDOW_OPAQUE);
  >   effects->drawWindow(w, dockMask, infiniteRegion(), dockData);
  >   }
  >
  > 
  > (`WindowForceBackgroundContrastRole` and `WindowForceBlurRole` are set at 
the beginning of the slide animation)
  > 
  > Am I missing something?
  
  I have an idea: the problem might be how you create the WindowPaintData. The 
ctor you use creates the WindowPaintData with an identity 
screenProjectionMatrix. This might be wrong in this case. The blur effect seems 
to use it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#196026, @zzag wrote:
  
  > In https://phabricator.kde.org/D9638#195979, @graesslin wrote:
  >
  > > What you could try is using the PaintClipper to perform clipping. But I 
don't know whether it's still fully functional on OpenGL.
  >
  >
  > So, adding
  >
  >   PaintClipper pc(QRegion(
  > QPoint(0, 0),
  > effects->virtualScreenSize()
  >   ));
  >
  >
  > in `SlideEffect::paintScreen` would be enough? Doesn't KWin do something 
like that somewhere else? I've just realized, maybe, this effect doesn't need 
to clip...
  
  
  I just looked into the source (relevant method Scene::paintScreen). For 
PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS the region is set to infinite region.
  
if (*mask & (PAINT_SCREEN_TRANSFORMED | 
PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS)) {
// Region painting is not possible with transformations,
// because screen damage doesn't match transformed positions.
*mask &= ~PAINT_SCREEN_REGION;
region = infiniteRegion();
  
  The region in this method is later on used for clipping. Given that you need 
that paintclipper fragment.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D10102: base scrolling on the smallest item

[Kai Uwe Broulik]

broulik added a comment.


  On my desktop it seems to improve it slightly but on my laptop I don't see 
any improvement, it's still way too fast. The slightest finger movement scrolls 
an entire page and more.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10102

To: mart, #dolphin, broulik
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10104: Port charrunner to Plasma5/Qt5

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: broulik, jriddell.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  As it has been part of Plasma4, is mentioned in documentation still
  and also all the time covered by translation system, someone out there
  might perhaps still be happy to use it once in a while also with Plasma5.
  Port has been straightforward, so no regressions expected.

TEST PLAN
  Entering "#hexdigits" works as advertized.
  Changing trigger word in config UI and using new instead works as well.

REPOSITORY
  R114 Plasma Addons

BRANCH
  portcharrunner

REVISION DETAIL
  https://phabricator.kde.org/D10104

AFFECTED FILES
  runners/CMakeLists.txt
  runners/characters/CMakeLists.txt
  runners/characters/charrunner.cpp
  runners/characters/charrunner.h
  runners/characters/charrunner_config.cpp
  runners/characters/charrunner_config.h
  runners/characters/charrunner_config.ui

To: kossebau, broulik, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10102: base scrolling on the smallest item

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10102

To: mart, #dolphin, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10102: base scrolling on the smallest item

[Marco Martin]

mart edited reviewers, added: broulik; removed: Plasma.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10102

To: mart, #dolphin, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10102: base scrolling on the smallest item

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, Dolphin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  after recent highdpi patches on scrolling that delegated it
  completely to the scrollbar, based upon the scrollbar singleStep
  setted to the tallest of the items in the view.
  tough this makes scrolling way too fast, and on folders where just
  few filenames are longer than most we can get a single scrolling
  step almost double the number of lines configured in the
  mouse kcm.
  Using the shortest item instead of the tallest mitigates this problem
  making it a bit more usable

TEST PLAN
  tested on different folders in different view modes both with
  mouse and touchpad

REPOSITORY
  R318 Dolphin

BRANCH
  phab/dolphinScroll

REVISION DETAIL
  https://phabricator.kde.org/D10102

AFFECTED FILES
  src/kitemviews/kitemlistcontainer.cpp
  src/kitemviews/kitemlistview.cpp
  src/kitemviews/private/kitemlistsizehintresolver.cpp
  src/kitemviews/private/kitemlistsizehintresolver.h

To: mart, #plasma, #dolphin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9848#196036, @zzag wrote:
  
  > File mode bits are slightly off.
  
  
  Fixed in https://phabricator.kde.org/D10100

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10101: Fix autohide panels on wayland

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  To test if the panel is under the cursor we used:
  if (geometry().contains(QCursor::pos(screenToFollow( {
  
  Unsurprisingly in wayland we don't know the cursor position once it's
  left our window. Behaviour seems to be undefined.
  
  We were already using enter and leave events to start the autohide
  timer, so we may as well rely on that for tracking state too.
  
  BUG: 377838

TEST PLAN
  Tested mouse in, mouse out
  
  Tested mouse in and waiting and panel stayed open
  
  Tested opening wifi applet and closing it 
  That will trigger the restoreAutoHide method as an applet status changed 
  The panel stayed open because the mouse was on it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10101

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  File mode bits are slightly off.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:0179f741bbd4: Updated the blur method to use the more 
efficient dual kawase blur algorithm. (authored by anemeth, committed by hein).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9848?vs=25948=25949

REVISION DETAIL
  https://phabricator.kde.org/D9848

AFFECTED FILES
  effects/blur/CMakeLists.txt
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/blur/blur.kcfg
  effects/blur/blur_config.cpp
  effects/blur/blur_config.desktop
  effects/blur/blur_config.h
  effects/blur/blur_config.ui
  effects/blur/blurconfig.kcfgc
  effects/blur/blurshader.cpp
  effects/blur/blurshader.h
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth updated this revision to Diff 25948.
anemeth added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Rebased to master.
  There was a conflict with https://phabricator.kde.org/D9879
  This change reverts those changes since it is superseded by this change 
because caching blur option has been 
  removed.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9848?vs=25782=25948

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

AFFECTED FILES
  effects/blur/CMakeLists.txt
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/blur/blur.kcfg
  effects/blur/blur_config.cpp
  effects/blur/blur_config.desktop
  effects/blur/blur_config.h
  effects/blur/blur_config.ui
  effects/blur/blurconfig.kcfgc
  effects/blur/blurshader.cpp
  effects/blur/blurshader.h
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#195979, @graesslin wrote:
  
  > What you could try is using the PaintClipper to perform clipping. But I 
don't know whether it's still fully functional on OpenGL.
  
  
  So, adding
  
PaintClipper pc(QRegion(
  QPoint(0, 0),
  effects->virtualScreenSize()
));
  
  in `SlideEffect::paintScreen` would be enough? Doesn't KWin do something like 
that somewhere else? I've just realized, maybe, this effect doesn't need to 
clip...
  
  ---
  
  Also, I've noticed that there is no blur behind docks when docks are painted 
above all windows(`Slide docks` checkbox is unchecked).
  
  F5674581: 2018-01-25 17-55-02.mp4 
  
  Effect chain positions:
  
  - slide effect: 50
  - blur: 75
  - background contrast: 76
  
  Docks are drawn above all windows by the following code:
  
for (EffectWindow* w : windows) {
if (! w->isDock()) {
continue;
}
WindowPaintData dockData(w);
int dockMask = mask
| (w->hasAlpha() ? PAINT_WINDOW_TRANSLUCENT
 : PAINT_WINDOW_OPAQUE);
effects->drawWindow(w, dockMask, infiniteRegion(), dockData);
}
  
  (`WindowForceBackgroundContrastRole` and `WindowForceBlurRole` are set at the 
beginning of the slide animation)
  
  Am I missing something?
  
  ---
  
  Quick side note: when the `Slide docks` checkbox is unchecked, docks are 
drawn above other windows so they can properly animate themselves if an user 
enters or leaves a virtual desktop with a window in full screen mode.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9993: Improve quality of images in notifications (Bug 385097)

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9993

To: rkron, #plasma_workspaces, #plasma, broulik
Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, 
gassaf, progwolff, franciscofernandes, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10098: Fix drag cursor

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:3c70f04ebe8a: Fix drag cursor (authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10098?vs=25943=25945

REVISION DETAIL
  https://phabricator.kde.org/D10098

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10098: Fix drag cursor

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10098

To: broulik, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10098: Fix drag cursor

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10098

To: broulik, #plasma, drosca, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10098: Fix drag cursor

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The `MouseArea` for allowing middle click to mute overrules the `cursorShape` 
of the draggable area.
  By moving the middle click area to the right of the icon, we avoid this and 
can change the cursor to an open hand when hovering the icon to indicate 
something draggable. The drag area can still be middle clicked to mute.

TEST PLAN
  - Verified hand cursor does not show up when it cannot be dragged (device 
list or only one device in application list)
  - Verified that left pressing mouse changes cursor to closed hand on drag area
  - Verified middle pressing mouse does not change cursor on drag area
  - Verified drag and drop to send applications to other audio devices still 
works
  - Verified that middle click on the list item still mutes/unmutes
  - Verified that middle click on the icon still mutes/unmutes
  - Verified that layout is correct with layout mirroring
  
  There's now a little gap above and below the icon where you can no longer 
middle click to mute/unmute but that's negligible imho as there's nothing 
visually there.
  
  Note the little dead area
  F5674568: Screenshot_20180125_172806.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10098

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, drosca, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10096: Softer shadow on the screenshots

[Andres Betts]

abetts added a comment.


  I like it, it is definitively softer. The horizontal length could be shrunk a 
bit. Maybe 150, or 100?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10096

To: apol, ngraham
Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  What you could try is using the PaintClipper to perform clipping. But I don't 
know whether it's still fully functional on OpenGL.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#195793, @zzag wrote:
  
  > I think this effect is ready for testing.
  >
  > Yet, I would like to have some clipping but it seems like there is no way 
to do this with current implementation of `Scene::paintGenericScreen`.
  
  
  That's quite likely

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D10096: Softer shadow on the screenshots

[Nathaniel Graham]

ngraham added a comment.


  In general not bad! Maybe the spread is a bit high, though?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10096

To: apol, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10096: Softer shadow on the screenshots

[Aleix Pol Gonzalez]

apol updated this revision to Diff 25940.
apol added a comment.


  unrelated change

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10096?vs=25939=25940

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10096

AFFECTED FILES
  discover/qml/ApplicationScreenshots.qml

To: apol, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10096: Softer shadow on the screenshots

[Aleix Pol Gonzalez]

apol added a comment.


  F5674545: vokoscreen-2018-01-25_16-50-00.mkv 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10096

To: apol, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10096: Softer shadow on the screenshots

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10096

AFFECTED FILES
  discover/qml/ApplicationScreenshots.qml

To: apol, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Eike Hein]

hein added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  @anemeth The patch doesn't apply cleanly to current master. Would you mind 
rebasing it please? I don't want to introduce errors at this stage by editing 
code I didn't review.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Eike Hein]

hein added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  I'll push this for you (I'm interpreting Martin's resignation as withdrawing 
objections, knock on wood).

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol

D10091: Combine source and version into a single piece of metadata

[Nathaniel Graham]

ngraham added a comment.


  IMHO the version number itself is valuable information, and I'm always a bit 
disconcerted when it's not available. Or did you mean something like this:
  
  Version: 2.8.1 from flathub
  or
  Version: 2.8.1 from neon-xenial-main
  or 
  Version: 2.8.1 from kdeapps
  or
  Version: 2.8.1 from snappy

INLINE COMMENTS

> apol wrote in AbstractResource.cpp:227
> This change we can't integrate in 5.12 at the moment, because i18n()

Right, this would be for master, not Plasma/5.12.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10091

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10091: Combine source and version into a single piece of metadata

[Aleix Pol Gonzalez]

apol added a comment.


  Would it maybe make sense to just show the version by the displayOrigin in 
the different places?

INLINE COMMENTS

> AbstractResource.cpp:227
> +const QString version = state() >= Installed ? installedVersion() : 
> availableVersion();
> +return i18nc("version from source (backend)", "%1 from %2 (%3)", 
> version, origin(), backend()->displayName());
>  }

This change we can't integrate in 5.12 at the moment, because i18n()

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10091

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9944: Expose if the tablet mode switch is available

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:87b688daae7a: Expose if the tablet mode switch is 
available (authored by mart).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9944?vs=25865=25934

REVISION DETAIL
  https://phabricator.kde.org/D9944

AFFECTED FILES
  input.cpp
  input.h
  libinput/connection.cpp
  libinput/connection.h
  tabletmodemanager.cpp
  tabletmodemanager.h

To: mart, #kwin, #plasma, graesslin
Cc: graesslin, ngraham, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10084: Make the messages translatable

[Yuri Chornoivan]

yurchor marked an inline comment as done.
yurchor added a comment.


  I have removed the duplicate. Thanks.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10084

To: yurchor, #plasma, graesslin, #localization
Cc: aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9325: Use QUrl in the ScreenMapper API

[Andras Mantia]

amantia updated this revision to Diff 25933.
amantia added a comment.


  Make the code more clear,  by renaming a local variable.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9325?vs=25799=25933

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9325

AFFECTED FILES
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/autotests/screenmappertest.cpp
  containments/desktop/plugins/folder/autotests/screenmappertest.h
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/screenmapper.cpp
  containments/desktop/plugins/folder/screenmapper.h

To: amantia, #plasma, mwolff, broulik, hein
Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10080: ensure the rounded rectangle of scrollbard stays round

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:a9a509d444bf: ensure the rounded rectangle of scrollbard 
stays round (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10080?vs=25894=25932#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10080?vs=25894=25932

REVISION DETAIL
  https://phabricator.kde.org/D10080

AFFECTED FILES
  kstyle/breezehelper.cpp

To: mart, #plasma, #vdg, hpereiradacosta, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10092: [Examples] Fix build

[René J . V . Bertin]

rjvbb accepted this revision.
rjvbb added a comment.
This revision is now accepted and ready to land.


  LGTM.
  
  The examples seem to have a circular runtime dependency on (at least) 
plasma-desktop. Is that just an opportunistic dependency (= they'd work fine 
you'd only just installed plasma-framework)?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10092

To: broulik, #plasma, rjvbb
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10056: [Look and feel KCM] Sync color group after copying over color file values

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cf49d415e7bb: [Look and feel KCM] Sync color group after 
copying over color file values (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10056?vs=25834=25931

REVISION DETAIL
  https://phabricator.kde.org/D10056

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10016: [KFileTreeView] Manually expand tree when model tells us to

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:af9284852c49: [KFileTreeView] Manually expand tree when 
model tells us to (authored by broulik).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10016?vs=25745=25930

REVISION DETAIL
  https://phabricator.kde.org/D10016

AFFECTED FILES
  src/platformtheme/kfiletreeview.cpp

To: broulik, #plasma, dfaure, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9325: Use QUrl in the ScreenMapper API

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  two questions, otherwise lgtm

INLINE COMMENTS

> foldermodel.cpp:291
>  
> -const auto oldUrl = m_url;
> +const auto oldUrl = this->resolvedUrl();
>  

could you call this at the top? then the `this->` call shouldn't be required, I 
think.

> foldermodel.cpp:327
>  m_screenMapper->removeScreen(m_screen, oldUrl);
> -m_screenMapper->addScreen(m_screen, url);
> +m_screenMapper->addScreen(m_screen, this->resolvedUrl());
>  }

is this different from the local `resolvedUrl` variable? If so, why? confusing 
;-) Add a comment then

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9325

To: amantia, #plasma, mwolff, broulik, hein
Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10093: Fix moving streams by drag and drop

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:12c5c46a9121: Fix moving streams by drag and drop 
(authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10093?vs=25928=25929

REVISION DETAIL
  https://phabricator.kde.org/D10093

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: broulik, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10093: Fix moving streams by drag and drop

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10093

To: broulik, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10093: Fix moving streams by drag and drop

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This broke when I moved the contents into `compactRepresentation` as the main 
could no longer access those items by ID.
  
  BUG: 389402
  FIXED-IN: 5.12.0

TEST PLAN
  Successfully dragged an app from one stream to another

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10093

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: broulik, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10083: [Look and Feel] Reverse the button order

[Safa Alfulaij]

safaalfulaij updated this revision to Diff 25924.
safaalfulaij added a comment.


  Align the warning text to the right

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10083?vs=25902=25924

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10083

AFFECTED FILES
  kcms/lookandfeel/package/contents/ui/main.qml

To: safaalfulaij, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart