KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 103 - Still unstable!

2018-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/103/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 29 Jan 2018 06:17:46 + Build duration: 12 min and counting JUnit Tests

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 21 - Failure!

2018-01-28 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/21/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 29 Jan 2018 05:51:31 + Build duration: 12 min and counting

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 102 - Failure!

2018-01-28 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/102/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 29 Jan 2018 04:07:06 + Build duration: 28 min and counting CONSOLE OUTPUT

D10102: base scrolling on the smallest item

2018-01-28 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I understand now. This patch does indeed make it //better// in the case where you have icons with really long/tall filenames, but it doesn't do anything to help the general case of

D10102: base scrolling on the smallest item

2018-01-28 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: mart, #dolphin, broulik Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6673: [Notifications] Manually remove remote images

2018-01-28 Thread David Edmundson
davidedmundson commandeered this revision. davidedmundson added a reviewer: broulik. davidedmundson added a comment. FYI, started making changes (as I know Kai is away). Will be done by tomorrow eve with autotest suite. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

2018-01-28 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10039 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

2018-01-28 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic! Works much better now. In testing, it looks like this does fix all the concerns in 371023. REPOSITORY R114 Plasma Addons REVISION DETAIL

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-28 Thread René J . V . Bertin
rjvbb added a comment. > In the code shown by this patch ;) Line 80. Right. Doh. The line that causes other side-effects when you comment it out :) > But the test you suggested that I do above is further proof anyhow. > > But even without setStyleName call (i.e.

D10170: Added optional transparency/blur to menu frames

2018-01-28 Thread Alex Nemeth
anemeth added a project: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

2018-01-28 Thread Alex Nemeth
anemeth retitled this revision from "Added transparency/blur to menu frames" to "Added optional transparency/blur to menu frames". REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff,

D10170: Added transparency/blur to menu frames

2018-01-28 Thread Alex Nemeth
anemeth edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added transparency/blur to menu frames

2018-01-28 Thread Alex Nemeth
anemeth edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added transparency/blur to menu frames

2018-01-28 Thread Alex Nemeth
anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: hpereiradacosta, Plasma, VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot,

D10170: Added transparency/blur to menu frames

2018-01-28 Thread Alex Nemeth
anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED FILES

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-28 Thread David Faure
dfaure added a comment. In https://phabricator.kde.org/D9070#197332, @rjvbb wrote: > What happens when you remove the `,Regular` That fixes the problem indeed. >> Workaround: enabling the line that calls QApplication::setDesktopSettingsAware(false). >> Proof that this

D9995: Allow longer app names in titlebar without eliding

2018-01-28 Thread Nathaniel Graham
ngraham added a comment. Yup, I've been running with this for a week; no issues seen. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9995 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9995: Allow longer app names in titlebar without eliding

2018-01-28 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:53dfa26a11fb: Allow longer app names in titlebar without eliding (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D10146: Further improve quality of images in notifications (Bug 385097)

2018-01-28 Thread Nathaniel Graham
ngraham added a comment. I would have approved too, had you not beat me too it! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10146 To: rkron, #plasma_workspaces, #plasma, broulik, ngraham Cc: davidedmundson, #plasma, #plasma_workspaces, plasma-devel,

D10146: Further improve quality of images in notifications (Bug 385097)

2018-01-28 Thread David Edmundson
davidedmundson added a comment. >> This revision was not accepted when it landed; it landed in state For benefit of paperwork, it is implicitly accepted by me, I just didn't click the button before merging. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10146: Further improve quality of images in notifications (Bug 385097)

2018-01-28 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:54c13f4c8ae9: Further improve quality of images in notifications (authored by rkron, committed by davidedmundson).

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

2018-01-28 Thread Friedrich W . H . Kossebau
kossebau added a comment. I just saw that 5.12 beta tarballs have all the po files for all the dead applets, runners etc, because of the translation system just executing Messages.sh etc, ignoring any skipped subdirs in the actual buildsystem. 5.12 being an LTS, perhaps it might make

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

2018-01-28 Thread David Edmundson
davidedmundson added a comment. +1 FWIW, the original rationale behind leaving them was because I didn't want translators to delete a load of work only to have to redo it. I've since found that's not how KDE translation works, they get moved to comments in the end of the .pot file -

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

2018-01-28 Thread Friedrich W . H . Kossebau
kossebau edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10163 To: kossebau, jriddell, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

2018-01-28 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added reviewers: jriddell, mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With no-one having invested into

D9638: [effects] replace old slide effect with a new one

2018-01-28 Thread Vlad Zagorodniy
zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. @graesslin: could you please review code? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel,

D9638: [effects] replace old slide effect with a new one

2018-01-28 Thread Vlad Zagorodniy
zzag updated this revision to Diff 26137. zzag edited projects, added Plasma; removed KWin. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. - rebase on master - finish work on `shouldForceBlur()` and `shouldForceBackgroundContrast()` REPOSITORY

D9638: [effects] replace old slide effect with a new one

2018-01-28 Thread Vlad Zagorodniy
zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. I've got full(or some part) KDE Plasma wayland session working. Here's what I did: - source `~/.config/kde-env-master.sh` (you should have `install-environment-driver true` in your

D9995: Allow longer app names in titlebar without eliding

2018-01-28 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Please test properly in all cases before pushing. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D9995 To: ngraham, apol,

D10146: Further improve quality of images in notifications (Bug 385097)

2018-01-28 Thread Randy Kron
rkron added a reviewer: ngraham. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10146 To: rkron, #plasma_workspaces, #plasma, broulik, ngraham Cc: #plasma, #plasma_workspaces, plasma-devel, broulik, ngraham, ZrenBot, progwolff, franciscofernandes, lesliezhai,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-28 Thread René J . V . Bertin
rjvbb added a comment. > Unfortunately, this patch doesn't fix it. The text still isn't bold. No, this patch is written to be as transparent as possible. It won't impose a stylename, but will not remove it either. What happens when you remove the `,Regular`, i.e. [General]

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-28 Thread David Faure
dfaure added a comment. I've been hitting a very similar bug where a Qt app was trying to use a bold font, and this had no effect when running in a plasma workspace, because of this code in kfontsettingsdata.cpp. Testcase (couldn't be simpler...)

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-28 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Indeed. Fixed in shared-mime-info 1.10 (commit 009f22a, https://bugs.freedesktop.org/show_bug.cgi?id=101667) Fix proposed for Qt: https://codereview.qt-project.org/218155

D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

2018-01-28 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, jgrulich. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed

D9980: Do not reset the size of window once we move it to an edge

2018-01-28 Thread Martin Flöser
graesslin added a comment. Another attempt to fix it based on the ideas of this change in https://phabricator.kde.org/D10156 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9980 To: jgrulich, graesslin Cc: ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot,

D10101: Fix autohide panels on wayland

2018-01-28 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1cb0d180bdda: Fix autohide panels on wayland (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10101?vs=25951=26102#toc REPOSITORY R120 Plasma Workspace CHANGES

D10060: Enable blending if a subsurface has an alpha channel

2018-01-28 Thread Martin Flöser
graesslin updated this revision to Diff 26097. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Always call setBlendEnabled before rendering a subsurface. @romangg: I hope this addresses all your comments. REPOSITORY R108 KWin CHANGES