[Plasma] Qt patch for desktop icon papercut

'lo dear packagers, the Plasma team recommends applying the following patch to both Qt 5.9 and Qt 5.10 at your convenience: https://codereview.qt-project.org/#/c/215939/ This fixes a bug causing the wrong desktop icon to look hovered after dragging an icon on the desktop (the top-left icon

Re: Plasma 5.12.0 tagging

Im back in europe but not back home with computer until this european late afternoon. I can make tars then or someone else can start it earlier. Jonathan On Thursday, 1 February 2018, David Edmundson wrote: > Plasma 5.12.0 is being tagged Thursday > a.ka. (depending

D10217: Choose source with a combobox, but only on the desktop view

davidc added a comment. Are there problems with implementation? I don't understand why this concept would not be considered an improvement to the way source selection is handled. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10217 To: ngraham,

D10217: Choose source with a combobox, but only on the desktop view

ngraham abandoned this revision. ngraham added a comment. Discussed it internally, not popular. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10217 To: ngraham, apol, #discover_software_store, #vdg Cc: rkflx, plasma-devel, ZrenBot, progwolff,

D10170: Added optional transparency/blur to menu frames

januz added a comment. +1 I wouldn't have this as a default for Breeze, but it looks really cool. I'm sure it'd be a popular option, specially among those trying to mimic macOS. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta,

D10219: Load translations from KPackage files if bundled

This revision was automatically updated to reflect the committed changes. Closed by commit R118:37792755e48a: [plasmoidviewer] Load translations from KPackage files if bundled (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D10219: Load translations from KPackage files if bundled

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. thanks REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D10219 To: Zren, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot,

D10219: Load translations from KPackage files if bundled

Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Based on https://phabricator.kde.org/D5209, which adds this feature to

D10217: Choose source with a combobox, but only on the desktop view

rkflx added a comment. FWIW, I nearly commented on one of your early blog posts. I wanted to suggest a combobox to: - indicate the possibility to make a selection (which a link clearly fails at) - solve the issue of having to move the mouse to a completely different location

D10181: Removed the "fastblur" path

ngraham added a reviewer: VDG. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma, #vdg Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff,

D10181: Removed the "fastblur" path

ngraham accepted this revision as: VDG. ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. No VDG objections! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma, #vdg Cc: fredrik,

D10181: Removed the "fastblur" path

fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. Code wise this LGTM. Consider it accepted if the VDG has no objections. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma Cc:

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/32/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 22:56:29 + Build duration: 8 min 6 sec and counting

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 22:56:29 + Build duration: 4 min 33 sec and counting JUnit

Plasma 5.12.0 tagging

Plasma 5.12.0 is being tagged Thursday a.ka. (depending on your timezone and when you read this) today. If there is anything super critical that has not yet been merged please do so and/or ping me as soon as possible. Public release is next Tuesday. David

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/23/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 22:21:55 + Build duration: 7 min 51 sec and counting

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. OK, I have to admit that those examples look really, really good. 30% more than 40%. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel,

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. Just to show you how it looks compared to something that is generally considered good design: Deepin I choose the same wallpaper and menu locations. I tested it with 30% and 40% transparency and 10/15 blur strength (that is likely going to be the new default).

D10217: Choose source with a combobox, but only on the desktop view

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10217 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D10217: Choose source with a combobox, but only on the desktop view

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Here I am again, hawking my

D7155: Implement sorting of the device tree items

isaact updated this revision to Diff 26293. isaact added a comment. Hi @broulik, I've rebased the diff based on the latest source revision (https://phabricator.kde.org/R102:d3d3ee543a17a3859bf2204c15dc7c36804eed15). Unfortunately I don't have commit access. REPOSITORY R102 KInfoCenter

D10181: Removed the "fastblur" path

anemeth updated this revision to Diff 26279. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Undone unrelated change REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10181?vs=26181=26279 BRANCH master REVISION

D10181: Removed the "fastblur" path

anemeth marked an inline comment as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff,

D10170: Added optional transparency/blur to menu frames

zzag added a comment. In https://phabricator.kde.org/D10170#198659, @anemeth wrote: > I got enableBackgroundContrast to work. It is very very poorly documented. > I played around with the values but the endresult does not look better. > In my opinion it looks worse

D10170: Added optional transparency/blur to menu frames

zzag added a comment. In https://phabricator.kde.org/D10170#198656, @ngraham wrote: > Sort of/mostly: https://community.kde.org/KDE_Visual_Design_Group/HIG It would nice to have a fully-fledged design language which would specify grid stuff, animations, etc. Something like Fluent

D10181: Removed the "fastblur" path

fredrik added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > blur.kcfg:9 > > -5 > - > - > -false > +10 > This looks like an unrelated change. REPOSITORY R108 KWin

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26278. anemeth added a comment. . REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26160=26278 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED FILES kstyle/breeze.kcfg

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. In https://phabricator.kde.org/D10170#198655, @zzag wrote: > @ngraham: blur is OK but it should be used wisely. Blurring the hell out from UI is not really cool. > > IMO, changes like this, require some changes in the "design language". > PS. does Plasma

D10170: Added optional transparency/blur to menu frames

zzag added a comment. @ngraham: blur is OK but it should be used wisely. Blurring the hell out from UI is not really cool. IMO, changes like this, require some changes in the "design language". PS. does Plasma have a design language? (like Fluent or Material design) REPOSITORY R31

D10170: Added optional transparency/blur to menu frames

abetts added a comment. In https://phabricator.kde.org/D10170#198634, @ngraham wrote: > Eh, maybe I'm wrong. Still... [shakes old man stick] I don't like it! These whippersnappers and their transparency! Back in my day things were opaque and we liked it that way! > > I won't die on

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. Eh, maybe I'm wrong. Still... [shakes old man stick] I don't like it! These whippersnappers and their transparency! Back in my day things were opaque and we liked it that way! I won't die on this hill though, since it's being proposed as an optional feature and

D10170: Added optional transparency/blur to menu frames

zzag added a comment. In https://phabricator.kde.org/D10170#198591, @ngraham wrote: > Since then, both of those companies have mostly moved away from blur transparency in their operating systems, or made it optional. Did they? Microsoft is doing some work on Fluent design

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. FWIW, I don't think I'd ever want this enabled by default, and I'm leery of adding the option to Breeze. I'm not sure how much it really fits the visual style. Only very very subtle blur transparency would ever work here without becoming garish and distracting--and

D10170: Added optional transparency/blur to menu frames

zzag added a comment. Also, please, take into account contrast issues. That's nice to have blur, but, please, use it wisely. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma Cc: abetts, colomar, andreask, zzag, ngraham,

D10170: Added optional transparency/blur to menu frames

abetts removed a reviewer: VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

abetts added subscribers: andreask, colomar, abetts. abetts added a comment. In https://phabricator.kde.org/D10170#198471, @hpereiradacosta wrote: > Hello, > Hi, > thanks for the patch ! > > Few comments: > 1/ the code does not compile under kde4 (cmake -DUSE_KDE4). You

D10170: Added optional transparency/blur to menu frames

abetts removed a reviewer: abetts. This revision now requires review to proceed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added a comment. Dear Andy, With all due respect, please stop "accepting" revisions. Revisions should be accepted by the code maintainer, who then endorse the responsibility that the code then remains in a workable state forever after. You are not the breeze maintainer.

D10170: Added optional transparency/blur to menu frames

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg, abetts Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added a comment. Hello, Hi, thanks for the patch ! Few comments: 1/ the code does not compile under kde4 (cmake -DUSE_KDE4). You would need to use the proper #ifdef to prevent this 2/ I think the "blur" option should go. Blur should be controlled centrally

D10193: use proper padding for list contents

This revision was automatically updated to reflect the committed changes. Closed by commit R134:2644e5773030: use proper padding for list contents (authored by mart). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10193?vs=26216=26259

D10188: Sanitise notification HTML

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bc696b5abcd: Sanitise notification HTML (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10188?vs=26251=26252#toc REPOSITORY R120 Plasma Workspace CHANGES

D10188: Sanitise notification HTML

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10188 To: davidedmundson, #plasma, fvogt Cc: aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10188: Sanitise notification HTML

davidedmundson updated this revision to Diff 26251. davidedmundson added a comment. One extra test REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10188?vs=26248=26251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10188 AFFECTED

D9835: Bump min cmake version to 3.0

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fc53e3420188: Bump min cmake version to 3.0 (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9835?vs=25197=26250#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/31/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 14:03:28 + Build duration: 9 min 30 sec and counting

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 30 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 14:03:28 + Build duration: 8 min 41 sec and counting CONSOLE

D10173: windowthumbnail: Fix the GLXFBConfig selection code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:46121d58484c: windowthumbnail: Fix the GLXFBConfig selection code (authored by fredrik). REPOSITORY R242 Plasma

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 111 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/111/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 12:42:27 + Build duration: 10 min and counting JUnit Tests

D9835: Bump min cmake version to 3.0

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please verify our CI has 3.0 first. REPOSITORY R120 Plasma Workspace BRANCH bumpcmakeversiondep REVISION DETAIL https://phabricator.kde.org/D9835 To: kossebau,

D10200: base listitemdelegate color on selected, not checked

mart added inline comments. INLINE COMMENTS > DefaultListItemBackground.qml:25 > id: background > -color: listItem.checked || (listItem.supportsMouseEvents && > listItem.pressed && !listItem.checked && !listItem.sectionDelegate) ? > (internal.indicateActiveFocus ?

D10188: Sanitise notification HTML

davidedmundson updated this revision to Diff 26248. davidedmundson added a comment. Added const Added two new unit test rows REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10188?vs=26213=26248 BRANCH Plasma/5.8 REVISION DETAIL

D10197: Fix krunner's alt+f2 on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fc5a45403025: Fix krunners alt+f2 on wayland (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10197?vs=26233=26247 REVISION DETAIL

D9984: WIP: Add bookmarks runner

sebas added a comment. That's what the "old" bookmarks runner was doing, it loaded the bookmarks from the file the browsers write out. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D9984 To: broulik, #plasma, #vdg, davidedmundson Cc: sebas,

D10200: base listitemdelegate color on selected, not checked

sebas created this revision. sebas added reviewers: hein, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY I can't say that I'm grasping the logic here completely,

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 110 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/110/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 08:11:27 + Build duration: 4 min 39 sec and counting CONSOLE

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

This revision was automatically updated to reflect the committed changes. Closed by commit R119:586797610e08: [Panel Config] Scrolling over size button increments size by 2 and shows… (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE