BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/410/
Project:
Plasma kwin kf5-qt5 SUSEQt5.9
Date of build:
Sat, 10 Feb 2018 04:03:04 +
Build duration:
27 min and counting
JUnit Tests
Name: (root) Failed: 0
ngraham added a comment.
Is this expected to fully fix https://bugs.kde.org/show_bug.cgi?id=385942?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10383
To: hein, #plasma, broulik, ivan
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/73/
Project:
Plasma discover stable-kf5-qt5 SUSEQt5.9
Date of build:
Sat, 10 Feb 2018 01:53:14 +
Build duration:
1 hr 32 min and counting
JUnit Tests
ngraham added a comment.
Getting there!
- Change the text "Show reviews" to "Show more reviews"
- Maybe change the "Reviews" header to "Top Reviews". Judgment call, not
necessarily required
- The increased padding between the reviews is good, but now the divider line
is misplaced.
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/136/
Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 10 Feb 2018 01:46:14 +
Build duration:
3 min 29 sec and counting
CONSOLE
apol updated this revision to Diff 26856.
apol added a comment.
Addressed Nate's comments
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10237?vs=26338=26856
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10237
AFFECTED
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/39/
Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 10 Feb 2018 01:10:22 +
Build duration:
9 min 50 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/135/
Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 10 Feb 2018 00:45:57 +
Build duration:
8 min 50 sec and counting
JUnit
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/38/
Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 10 Feb 2018 00:42:02 +
Build duration:
3 min 59 sec and counting
apol abandoned this revision.
apol added a comment.
https://phabricator.kde.org/D10420 this one works better.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10416
To: apol, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel,
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
On wayland (at least) it's initialized when the
davidedmundson added a comment.
Looks sensible. Do you have commit access?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10407
To: amantia, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
> Fixes rendering of svg in many places, for example now icons don't look
By editing FrameSVG? That seems unlikely.
I think you've got some results mixed
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/419/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Fri, 09 Feb 2018 23:34:41 +
Build duration:
10 min and counting
JUnit Tests
ngraham added a comment.
It doesn't merge cleanly on master. Can you re-base it?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot,
progwolff, lesliezhai,
ijanssen added a comment.
In https://phabricator.kde.org/D10114#202694, @ngraham wrote:
> Is this committable?
I think yes
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel,
apol added a comment.
This breaks the rendering of buttons (exclusively, as long as I've seen), any
idea why?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10416
To: apol, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham,
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/409/
Project:
Plasma kwin kf5-qt5 SUSEQt5.9
Date of build:
Fri, 09 Feb 2018 20:03:39 +
Build duration:
38 min and counting
CONSOLE OUTPUT
[...truncated 874.92
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Plasma::Svg uses this information to know the pixel
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:68a2ceb60e80: Only multiply the icon size if Qt
isnt doing it already (authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10413?vs=26835=26837
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10413
To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
This multiplication is redundant with Qt and will introduce awkward
icota added a comment.
@mart It's quite reproducible. Start kirigami gallery (I did it on Android)
-- go into 'list view' -- bunch of SwipeListItems there -- tap somewhere to the
left of the 'swipe icon' (the one you're supposed to drag left) --- you will
trigger either action 1 or 2 as
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/72/
Project:
Plasma discover stable-kf5-qt5 SUSEQt5.9
Date of build:
Fri, 09 Feb 2018 17:33:33 +
Build duration:
4 min 53 sec and counting
CONSOLE OUTPUT
amantia added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION DETAIL
https://phabricator.kde.org/D10408
To: amantia, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/418/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Fri, 09 Feb 2018 16:43:46 +
Build duration:
5 min 23 sec and counting
CONSOLE
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/417/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Fri, 09 Feb 2018 16:41:22 +
Build duration:
2 min 22 sec and counting
CONSOLE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c6dc4b566c7e: [krunner] No need to duplicate work of
KAboutData::setApplicationData (authored by kossebau).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e04947534c77: Use KDEInstallDir variables instead of
custom calculated install paths (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D10400?vs=26804=26825#toc
REPOSITORY
amantia added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10407
To: amantia, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
amantia created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
amantia requested review of this revision.
REVISION SUMMARY
We need to use the overriden sortMode, not the model's sort mode.
The == -> === changes are just
ivan added a comment.
I can not say with certainty - never tested html encoding, but I would expect
it to work in general.
The potential problem might be that sqlite part might consider "hello world"
and "hello%20world" to be different.
REPOSITORY
R120 Plasma Workspace
REVISION
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
lesshardcodedinstallpaths
REVISION DETAIL
https://phabricator.kde.org/D10400
To: kossebau, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mart added a comment.
the issue is valid, i'm not sure a check of the item x is a good enough
assumption.
in what conditions this click trough happens? i can't seem to be able to
reproduce
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10392
To: icota,
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
removeduplicatedkrunnermetadatasetup
REVISION DETAIL
https://phabricator.kde.org/D10398
To: kossebau, broulik, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
apol added a comment.
Can you explain a bit better the issue?
Why aren't they exposed? what do you mean by exposing them?
Why is x false?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10392
To: icota, #kirigami
Cc: apol, plasma-devel, davidedmundson, mart,
jgrulich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R623 Plasma PackageKit Updater
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10404
To: fvogt, lukas, jgrulich
Cc: plasma-devel
fvogt created this revision.
fvogt added reviewers: lukas, jgrulich.
fvogt requested review of this revision.
REVISION SUMMARY
The plasmoid searches for the next batch of updates which might be misleading.
Related: https://bugs.kde.org/show_bug.cgi?id=390143
TEST PLAN
Installed updates,
hein added a comment.
Thanks for your analysis! I actually did try roughly the same thing, but I
thought keeping the behavior of having larger preview thumbs is nicer overall.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10223
To: hein, #plasma, broulik,
anemeth updated this revision to Diff 26814.
anemeth added a comment.
Fixed a visual glitch when using a scaled display
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10170?vs=26658=26814
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10170
Hello there,
>however, please consider to use bugzilla at bugs.kde.orgproduct: plasmashell
Done.
https://bugs.kde.org/show_bug.cgi?id=390087
Regards
David Binderman
On giovedì 8 febbraio 2018 10:07:23 CET David Binderman wrote:
> Hello there,
>
>
>
>
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/85/
Project:
Plasma kwayland kf5-qt5 SUSEQt5.9
Date of build:
Wed, 07 Feb 2018 18:42:41 +
Build duration:
1 day 14 hr and counting
CONSOLE OUTPUT
42 matches
Mail list logo
