[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=346972
Bug 346972 depends on bug 339863, which changed state.

Bug 339863 Summary: Full and empty stars are indistinguishable when using an 
icon theme (including Oxygen) that lacks the "rating-unrated" icon
https://bugs.kde.org/show_bug.cgi?id=339863

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10481: Add FormLayout.qml to kirigami.qrc

[Igor Cota]

icota added a commit: R169:bed2722949b6: Add FormLayout.qml to kirigami.qrc.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10481

To: icota, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

[Igor Cota]

icota closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami, mart
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10482: Add an isNull() check before setting wheter QIcon is a mask

[Igor Cota]

icota closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10482

To: icota, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10597: Fix media frame config layout

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Removed pointless parent wrapper
  Added spacer on bottom

TEST PLAN
  Looked at it.
  Changed some settings

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10597

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos updated this revision to Diff 27382.
mvourlakos added a comment.


  - improve semantics

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10592?vs=27373&id=27382

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D10592

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10596: Remove uninstalled themerc files for no longer existing Qt themes

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4149b474d301: Remove uninstalled themerc files for no 
longer existing Qt themes (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10596?vs=27380&id=27381

REVISION DETAIL
  https://phabricator.kde.org/D10596

AFFECTED FILES
  themes/b3.themerc
  themes/beos.themerc
  themes/default.themerc
  themes/highcolor.themerc
  themes/keramik.themerc
  themes/light-v2.themerc
  themes/light-v3.themerc
  themes/mega.themerc
  themes/qtmotifplus.themerc
  themes/qtplatinum.themerc
  themes/qtsgi.themerc

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10596: Remove uninstalled themerc files for no longer existing Qt themes

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  deleteunusedthemercfiles

REVISION DETAIL
  https://phabricator.kde.org/D10596

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10596: Remove uninstalled themerc files for no longer existing Qt themes

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  deleteunusedthemercfiles

REVISION DETAIL
  https://phabricator.kde.org/D10596

AFFECTED FILES
  themes/b3.themerc
  themes/beos.themerc
  themes/default.themerc
  themes/highcolor.themerc
  themes/keramik.themerc
  themes/light-v2.themerc
  themes/light-v3.themerc
  themes/mega.themerc
  themes/qtmotifplus.themerc
  themes/qtplatinum.themerc
  themes/qtsgi.themerc

To: kossebau, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added inline comments.

INLINE COMMENTS

> ComboBox.qml:113
>  highlightMoveDuration: 0
> -LayoutMirroring.enabled: true
> +// HACK: When the ComboBox is not inside the base Item, it does 
> not inherit
> +// the LayoutMirroring options. This is a workaround to fix this 
> by enforcing

When the ComboBox is not inside a top-level Window, it's Popup does not inherit

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D3588: Remove inexistent file references from kirigami.qrc

[Ilya Bizyaev]

IlyaBizyaev abandoned this revision.
IlyaBizyaev added a comment.


  Outdated, was superceded by D3591 .

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3588

To: IlyaBizyaev, #kirigami, mart
Cc: bearsh, plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

[Ilya Bizyaev]

IlyaBizyaev closed this revision.
IlyaBizyaev added a comment.


  Merged by 389f4c29acc3 
.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

To: IlyaBizyaev, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

To: IlyaBizyaev, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10594: Disable window rule configuration for Wayland

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  The window rule detection is too bound to X11 for it to work for
  Wayland windows. In fact it results in the config module just crashing.
  Thus it's better to just disable the items in the menu. As it's only for
  X11 windows we can also enforce platform xcb for the rules dialog.

TEST PLAN
  Menu disabled on Wayland window, menu enabled on Xwayland window

REPOSITORY
  R108 KWin

BRANCH
  disable-rules-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10594

AFFECTED FILES
  kcmkwin/kwinrules/main.cpp
  useractions.cpp
  useractions.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10593: Fix qmake warning for Kirigami

[Ilya Bizyaev]

IlyaBizyaev added a reviewer: mart.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

To: IlyaBizyaev, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

[Ilya Bizyaev]

IlyaBizyaev retitled this revision from "Fix qmake warning for " to "Fix qmake 
warning for Kirigami".
IlyaBizyaev edited the summary of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

To: IlyaBizyaev
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for

[Ilya Bizyaev]

IlyaBizyaev created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
IlyaBizyaev requested review of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10593

AFFECTED FILES
  kirigami.qrc

To: IlyaBizyaev
Cc: plasma-devel, apol, davidedmundson, mart, hein

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @safaalfulaij I created the following for this: 
https://phabricator.kde.org/D10592

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  - when the combobox isnt inside the main Item
  
  but rather a sub-Item it doesnt inherit the
  LayoutMirroring properties. This is a workaround
  to handle that behavior.
  QTBUG: https://bugreports.qt.io/browse/QTBUG-66446

TEST PLAN
  checkout that LayoutMirroring works properly in
  such case

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D10592

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[David Edmundson]

davidedmundson added a comment.


  What would this code do if the device notifier is expanded but on the desktop?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10589: Make it possible to tweak the sorting of a resources list

[Nathaniel Graham]

ngraham requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10589

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  if an applet is requiresattention, always give the popup focus
  
  rationale is for the devicenotifier which opten opens and is not possible to
  dismiss it by clicking anywhere: unfortunately the only way we have is to
  give it focus, so it can close.
  
  there is probably a more elegant way to do this (and not steal focus)
  maybe a dbus protocol from kwin?

TEST PLAN
  device notifier always gets focus even if input from the current focus
  window is recent

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/activatepopups

REVISION DETAIL
  https://phabricator.kde.org/D10591

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Vlad Zagorodniy]

zzag added a comment.


  Why?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: zzag, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10589: Make it possible to tweak the sorting of a resources list

[Nathaniel Graham]

ngraham added a comment.


  Huzzah! Users are going to be really happy about this. Sorting by name and 
size seem to work as expected. I found some issues, though:
  
  - We should use a dropdown menu control for this UI. Perhaps we should revive 
our Kirigami patch to keep the title visible when we have other actions on the 
header
  - RatingPointsRole appears to result in apps being sorted in reverse 
alphabetical order, rather than by rating:F5714483: oops.png 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10589

To: apol
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:e5c0824adf8a: Added optional transparency/blur to menu 
frames (authored by anemeth, committed by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10170?vs=27358&id=27368#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=27358&id=27368

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[Anthony Fieroni]

anthonyfieroni accepted this revision.
anthonyfieroni added a comment.
This revision is now accepted and ready to land.


  It looks good to me.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma, anthonyfieroni
Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10584: fix double spacing bug

[Vlad Zagorodniy]

zzag added a comment.


  @hpereiradacosta: yes, you're right

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10584

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10584: fix double spacing bug

[Vlad Zagorodniy]

zzag updated this revision to Diff 27367.
zzag added a comment.


  add icon width to the contents size only if there is an icon

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10584?vs=27345&id=27367

BRANCH
  double-space-bug

REVISION DETAIL
  https://phabricator.kde.org/D10584

AFFECTED FILES
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma breeze kf5-qt5 FreeBSDQt5.9 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20FreeBSDQt5.9/26/
 Project:
Plasma breeze kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 16 Feb 2018 17:14:46 +
 Build duration:
3 min 35 sec and counting

KDE CI: Plasma breeze kf5-qt5 SUSEQt5.9 - Build # 89 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20SUSEQt5.9/89/
 Project:
Plasma breeze kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 16 Feb 2018 17:14:46 +
 Build duration:
2 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/98)0%
(0/98)0%
(0/7998)0%
(0/6768)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskdecoration0%
(0/8)0%
(0/8)0%
(0/816)0%
(0/606)kdecoration.config0%
(0/13)0%
(0/13)0%
(0/572)0%
(0/327)kstyle0%
(0/21)0%
(0/21)0%
(0/5136)0%
(0/4675)kstyle.animations0%
(0/48)0%
(0/48)0%
(0/1216)0%
(0/1069)kstyle.config0%
(0/5)0%
(0/5)0%
(0/115)0%
(0/38)kstyle.debug0%
(0/2)0%
(0/2)0%
(0/68)0%
(0/25)misc.kde4breeze.src0%
(0/1)0%
(0/1)0%
(0/75)0%
(0/28)

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[David Edmundson]

davidedmundson updated this revision to Diff 27364.
davidedmundson added a comment.


  Track window changes

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10019?vs=25753&id=27364

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10019

AFFECTED FILES
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/plugin/minimizeall.cpp
  applets/minimizeall/plugin/minimizeall.h
  applets/minimizeall/plugin/minimizeallplugin.cpp
  applets/minimizeall/plugin/minimizeallplugin.h
  applets/minimizeall/plugin/qmldir

To: davidedmundson, #plasma
Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag added a comment.


  I've reverted that commit.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10589: Make it possible to tweak the sorting of a resources list

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Now that we have context actions shown, we can consider doing it, will need
  work for the header.
  
  BUG: 383518

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10589

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag added a comment.


  This breaks build. Missed breezeblurhelper.cpp and breezeblurhelper.h?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:cd25c7078ab2: [konsolesession runner] Rename to 
konsoleprofiles, no sessions here (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10505?vs=27144&id=27361

REVISION DETAIL
  https://phabricator.kde.org/D10505

AFFECTED FILES
  runners/CMakeLists.txt
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/Messages.sh
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h
  runners/konsoleprofiles/plasma-runner-konsoleprofiles.desktop
  runners/konsolesessions/CMakeLists.txt
  runners/konsolesessions/Messages.sh
  runners/konsolesessions/konsolesessions.cpp
  runners/konsolesessions/konsolesessions.desktop
  runners/konsolesessions/konsolesessions.h

To: kossebau, broulik, mart
Cc: ltoscano, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma breeze kf5-qt5 SUSEQt5.9 - Build # 88 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20SUSEQt5.9/88/
 Project:
Plasma breeze kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 16 Feb 2018 16:45:21 +
 Build duration:
9 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 111.21 KB...]-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.43.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.43.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.43.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  CoreAddons GuiAddons ConfigWidgets WindowSystem I18n -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") -- Found XCB_XCB: /usr/lib64/libxcb.so (found version "1.12") -- Found XCB: /usr/lib64/libxcb.so (found version "1.12") found components:  XCB -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  I18n Config GuiAddons ConfigWidgets WindowSystem -- Could not set up the appstream test. appstreamcli is missing.-- Found KF5: success (found version "5.43.0") found components:  CoreAddons Config CMake Warning (dev) at /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageMacros.cmake:26 (message):  Deprecated: use kpackage_install_bundled_packageCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning at /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageMacros.cmake:66 (message):  warnings during generation of metainfo for org.kde.breezedark.desktop:  Package type "Plasma/LookAndFeel" not foundCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)-- The following OPTIONAL packages have been found: * KF5Auth (required version >= 5.43.0) * KF5FrameworkIntegration, KF5 Framework Integration,Required to use KStyle convenience functionalities in style * PkgConfig * XCB, X protocol C-language Binding,Required to pass style properties to native Windows on X11 Platform   Required to pass style properties to native Windows on X11 Platform * KF5Wayland * KF5KCMUtils, KF5 KCM utils Framework,Required for breeze-settings5 application to build * Qt5Core-- The following REQUIRED packages have been found: * KDecoration2 * Qt5DBus * Qt5Network (required version >= 5.9.4) * Qt5Qml (required version >= 5.9.4) * Qt5Quick * Gettext * PythonInterp * KF5I18n * KF5GuiAddons * KF5ConfigWidgets * KF5WindowSystem * Qt5X11Extras * Qt5Widgets * Qt5 * KF5Config * KF5 * KF5CoreAddons (required version >= 5.43.0) * ECM (required version >= 1.6.0) * KF5Package-- Configuring doneCMake Error at kstyle/CMakeLists.txt:162 (add_library):  Cannot find source file:breezeblurhelper.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: breezeCMake Error: Cannot determine link language for target "breeze".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma breeze kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma breeze kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma breeze kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Plasma breeze kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 16 Feb 2018 16:45:21 +
 Build duration:
2 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 84.65 KB...]-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.43.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.43.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.43.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.2") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  CoreAddons GuiAddons ConfigWidgets WindowSystem I18n -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.4.0") -- Found XCB_XCB: /usr/local/lib/libxcb.so (found version "1.12") -- Found XCB: /usr/local/lib/libxcb.so (found version "1.12") found components:  XCB -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  I18n Config GuiAddons ConfigWidgets WindowSystem -- Could not set up the appstream test. appstreamcli is missing.-- Found KF5: success (found version "5.43.0") found components:  CoreAddons Config CMake Warning (dev) at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:26 (message):  Deprecated: use kpackage_install_bundled_packageCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:66 (message):  warnings during generation of metainfo for org.kde.breezedark.desktop:  Package type "Plasma/LookAndFeel" not foundCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)-- The following OPTIONAL packages have been found: * KF5Auth (required version >= 5.43.0) * KF5FrameworkIntegration, KF5 Framework Integration,Required to use KStyle convenience functionalities in style * PkgConfig * XCB, X protocol C-language Binding,Required to pass style properties to native Windows on X11 Platform   Required to pass style properties to native Windows on X11 Platform * KF5Wayland * KF5KCMUtils, KF5 KCM utils Framework,Required for breeze-settings5 application to build * Qt5Core-- The following REQUIRED packages have been found: * KDecoration2 * Qt5DBus * Qt5Network (required version >= 5.9.3) * Qt5Qml (required version >= 5.9.3) * Qt5Quick * Gettext * PythonInterp * KF5I18n * KF5GuiAddons * KF5ConfigWidgets * KF5WindowSystem * Qt5X11Extras * Qt5Widgets * Qt5 * KF5Config * KF5 * KF5CoreAddons (required version >= 5.43.0) * ECM (required version >= 1.6.0) * KF5Package-- Configuring doneCMake Error at kstyle/CMakeLists.txt:162 (add_library):  Cannot find source file:breezeblurhelper.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: breezeCMake Error: Cannot determine link language for target "breeze".-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma breeze kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma breeze kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D10480: align checkable widgets in menu items

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:f697b07340f3: align checkable widgets in menu items 
(authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10480?vs=27344&id=27359

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma breeze kf5-qt5 FreeBSDQt5.9 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20FreeBSDQt5.9/24/
 Project:
Plasma breeze kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 16 Feb 2018 16:28:56 +
 Build duration:
2 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 84.87 KB...]-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.43.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.43.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.43.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.2") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  CoreAddons GuiAddons ConfigWidgets WindowSystem I18n -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.4.0") -- Found XCB_XCB: /usr/local/lib/libxcb.so (found version "1.12") -- Found XCB: /usr/local/lib/libxcb.so (found version "1.12") found components:  XCB -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  I18n Config GuiAddons ConfigWidgets WindowSystem -- Could not set up the appstream test. appstreamcli is missing.-- Found KF5: success (found version "5.43.0") found components:  CoreAddons Config CMake Warning (dev) at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:26 (message):  Deprecated: use kpackage_install_bundled_packageCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:66 (message):  warnings during generation of metainfo for org.kde.breezedark.desktop:  Package type "Plasma/LookAndFeel" not foundCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)-- The following OPTIONAL packages have been found: * KF5Auth (required version >= 5.43.0) * KF5FrameworkIntegration, KF5 Framework Integration,Required to use KStyle convenience functionalities in style * PkgConfig * XCB, X protocol C-language Binding,Required to pass style properties to native Windows on X11 Platform   Required to pass style properties to native Windows on X11 Platform * KF5Wayland * KF5KCMUtils, KF5 KCM utils Framework,Required for breeze-settings5 application to build * Qt5Core-- The following REQUIRED packages have been found: * KDecoration2 * Qt5DBus * Qt5Network (required version >= 5.9.3) * Qt5Qml (required version >= 5.9.3) * Qt5Quick * Gettext * PythonInterp * KF5I18n * KF5GuiAddons * KF5ConfigWidgets * KF5WindowSystem * Qt5X11Extras * Qt5Widgets * Qt5 * KF5Config * KF5 * KF5CoreAddons (required version >= 5.43.0) * ECM (required version >= 1.6.0) * KF5Package-- Configuring doneCMake Error at kstyle/CMakeLists.txt:162 (add_library):  Cannot find source file:breezeblurhelper.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: breezeCMake Error: Cannot determine link language for target "breeze".-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma breeze kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma breeze kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma breeze kf5-qt5 SUSEQt5.9 - Build # 87 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20SUSEQt5.9/87/
 Project:
Plasma breeze kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 16 Feb 2018 16:28:56 +
 Build duration:
1 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 111.17 KB...]-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.43.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.43.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.43.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  CoreAddons GuiAddons ConfigWidgets WindowSystem I18n -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") -- Found XCB_XCB: /usr/lib64/libxcb.so (found version "1.12") -- Found XCB: /usr/lib64/libxcb.so (found version "1.12") found components:  XCB -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found version "5.43.0") found components:  I18n Config GuiAddons ConfigWidgets WindowSystem -- Could not set up the appstream test. appstreamcli is missing.-- Found KF5: success (found version "5.43.0") found components:  CoreAddons Config CMake Warning (dev) at /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageMacros.cmake:26 (message):  Deprecated: use kpackage_install_bundled_packageCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Warning at /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageMacros.cmake:66 (message):  warnings during generation of metainfo for org.kde.breezedark.desktop:  Package type "Plasma/LookAndFeel" not foundCall Stack (most recent call first):  CMakeLists.txt:42 (kpackage_install_package)-- The following OPTIONAL packages have been found: * KF5Auth (required version >= 5.43.0) * KF5FrameworkIntegration, KF5 Framework Integration,Required to use KStyle convenience functionalities in style * PkgConfig * XCB, X protocol C-language Binding,Required to pass style properties to native Windows on X11 Platform   Required to pass style properties to native Windows on X11 Platform * KF5Wayland * KF5KCMUtils, KF5 KCM utils Framework,Required for breeze-settings5 application to build * Qt5Core-- The following REQUIRED packages have been found: * KDecoration2 * Qt5DBus * Qt5Network (required version >= 5.9.4) * Qt5Qml (required version >= 5.9.4) * Qt5Quick * Gettext * PythonInterp * KF5I18n * KF5GuiAddons * KF5ConfigWidgets * KF5WindowSystem * Qt5X11Extras * Qt5Widgets * Qt5 * KF5Config * KF5 * KF5CoreAddons (required version >= 5.43.0) * ECM (required version >= 1.6.0) * KF5Package-- Configuring doneCMake Error at kstyle/CMakeLists.txt:162 (add_library):  Cannot find source file:breezeblurhelper.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: breezeCMake Error: Cannot determine link language for target "breeze".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma breeze kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma breeze kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Jonathan Riddell]

jriddell retitled this revision from "Summary: No icons on the desktop by 
default.  Dont add Home.desktop to links folder and dont add trash link
https://phabricator.kde.org/T7948"; to "Summary: No icons on the desktop by 
default.  Dont add Home.desktop to links folder and dont add trash 
linkhttps://phabricator.kde.org/T7948";.
jriddell added a reviewer: Plasma.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Jonathan Riddell]

jriddell created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
jriddell requested review of this revision.

TEST PLAN
  Start plasma as new user

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10588

AFFECTED FILES
  kioslave/desktop/CMakeLists.txt
  kioslave/desktop/Home.desktop
  kioslave/desktop/kio_desktop.cpp

To: jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:336cf7b63a6a: Added option to set transparency and blur 
behind menu frames such as right… (authored by hpereiradacosta).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10170?vs=27010&id=27358#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=27010&id=27358

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10480: align checkable widgets in menu items

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Ship it ! 
  Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10584: fix double spacing bug

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Thanks for the patch.
  I "think" one must also do a similar fix in "Style::menuItemSizeFromContents".
  It seems to me that there also the line 2728 
  leftColumnWidth += Metrics::MenuItem_ItemSpacing;
  should also be conditionned with "if iconWidth > 0"
   Can you double check ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10584

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10586: [Task Manager] Limit badge label to a sane size

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When moving a horizontal panel around so it becomes vertical, the height of 
the badge would grow enormous briefly during re-layouting causing a crash in 
the font engine.

TEST PLAN
  Had KMail sitting in my task bar with a badge, moved the panel from 
horizontal to vertical. Previously it would reproducibly crash, now it doesn't 
crash anymore.
  
  Backtrace
  
(gdb) bt
#0  0x7fffe389d2a6 in QTransformToFTMatrix (matrix=...) at 
freetype/qfontengine_ft.cpp:1533
  
#1  QFontEngineFT::loadGlyphSet (this=0x7ffe50114c90, matrix=...) at 
freetype/qfontengine_ft.cpp:1547

#2  0x7fffe389d7e4 in QFontEngineFT::loadGlyphFor 
(this=this@entry=0x7ffe50114c90, g=g@entry=28, subPixelPosition=..., 
subPixelPosition@entry=...,   
format=format@entry=QFontEngine::Format_A8, t=..., 
fetchBoundingBox=fetchBoundingBox@entry=false, disableOutlineDrawing=true)  
  
at freetype/qfontengine_ft.cpp:2058 

 
#3  0x7fffe389fa26 in QFontEngineFT::alphaMapForGlyph 
(this=this@entry=0x7ffe50114c90, g=g@entry=28, subPixelPosition=..., 
subPixelPosition@entry=...,   
t=...) at freetype/qfontengine_ft.cpp:2089  

 
#4  0x7fffe389750e in QFontEngineFT::alphaMapForGlyph 
(this=0x7ffe50114c90, g=28, subPixelPosition=...) at 
freetype/qfontengine_ft.cpp:2082  
#5  0x726d851f in QFontEngine::alphaMapForGlyph 
(this=this@entry=0x7ffe50114c90, glyph=glyph@entry=28, subPixelPosition=...,
 
subPixelPosition@entry=..., t=...) at text/qfontengine.cpp:879  

 
#6  0x7fffe389fba0 in QFontEngineFT::alphaMapForGlyph 
(this=this@entry=0x7ffe50114c90, g=g@entry=28, subPixelPosition=..., 
subPixelPosition@entry=...,   
t=...) at freetype/qfontengine_ft.cpp:2100  

 
#7  0x7fffe389750e in QFontEngineFT::alphaMapForGlyph 
(this=0x7ffe50114c90, g=28, subPixelPosition=...) at 
freetype/qfontengine_ft.cpp:2082  
#8  0x726d851f in QFontEngine::alphaMapForGlyph 
(this=this@entry=0x7ffe50114c90, glyph=glyph@entry=28, subPixelPosition=...,
 
subPixelPosition@entry=..., t=...) at text/qfontengine.cpp:879  

 
#9  0x7fffe389fba0 in QFontEngineFT::alphaMapForGlyph 
(this=this@entry=0x7ffe50114c90, g=g@entry=28, subPixelPosition=..., 
subPixelPosition@entry=...,   
t=...) at freetype/qfontengine_ft.cpp:2100  

 
#10 0x7fffe389750e in QFontEngineFT::alphaMapForGlyph 
(this=0x7ffe50114c90, g=28, subPixelPosition=...) at 
freetype/qfontengine_ft.cpp:2082  
#11 0x726d851f in QFontEngine::alphaMapForGlyph 
(this=this@entry=0x7ffe50114c90, glyph=glyph@entry=28, subPixelPosition=...,
 
subPixelPosition@entry=..., t=...) at text/qfontengine.cpp:879  

 
#12 0x7fffe389fba0 in QFontEngineFT::alphaMapForGlyph 
(this=this@entry=0x7ffe50114c90, g=g@entry=28, subPixelPosition=..., 
subPixelPosition@entry=...,   
t=...) at freetype/qfontengine_ft.cpp:2100 
  
  and so on

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10586

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Badge.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d69abdbe4dce: Make the review pop-up a bit more 
user-friendly (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10500?vs=27203&id=27354

REVISION DETAIL
  https://phabricator.kde.org/D10500

AFFECTED FILES
  discover/qml/Rating.qml
  discover/qml/ReviewDialog.qml

To: ngraham, #discover_software_store, apol, abetts
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

T7071: Fragment shader in UserDelegate.qml is not GLSL/ES compatible, missing precision specifier

[Jonathan Riddell]

jriddell closed this task as "Resolved".

TASK DETAIL
  https://phabricator.kde.org/T7071

To: plasma-devel, jriddell
Cc: bruns, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Release calendar

[Luigi Toscano]

On Friday, 16 February 2018 16:27:10 CET Jonathan Riddell wrote:
> I've added the release dates for Plasma 5.12, .13 and .14 as well as
> Frameworks releases to the end of the year onto the calendar on Phab.

> 
> https://phabricator.kde.org/calendar/

Thanks!


> 
> Which makes more sense than the Google calendar I had on my personal
> account.  You should be able to export the .ics and import it into
> whatever calendar you like to use.

I created an export for all events with type "Events: Release" and it's 
available here:

https://phabricator.kde.org/calendar/export/ics/en57n5ovb3k6vg4mtqbx/
events_release.ics 

I also added the release date for KDE Applications 18.04; I should go back and 
add 17.12 and before. Any other project who wants to add their release date to 
the calendar can contact one of the Calendar manager (like Jonathan or me), or 
open a ticket with sysadmins.


Ciao
-- 
Luigi

D10500: Make the review pop-up a bit more user-friendly

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  review-popup-button-text

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store, apol, abetts
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10579: Search runtime dependencies on QML modules

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:cf64323795b9: Search runtime dependencies on QML modules 
(authored by heikobecker).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10579?vs=27351&id=27352

REVISION DETAIL
  https://phabricator.kde.org/D10579

AFFECTED FILES
  CMakeLists.txt
  README.md

To: heikobecker, mvourlakos, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10579: Search runtime dependencies on QML modules

[Michail Vourlakos]

mvourlakos added a comment.


  nice

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10579

To: heikobecker, mvourlakos, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Nathaniel Graham]

ngraham added a comment.


  That's a good idea, but I'm having a bit of trouble with the implementation. 
If this is otherwise okay, can we land it in its current state, and commit to 
doing that in a subsequent patch?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store, apol, abetts
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10579: Search runtime dependencies on QML modules

[Heiko Becker]

heikobecker updated this revision to Diff 27351.
heikobecker added a comment.


  Also updated README

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10579?vs=27338&id=27351

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10579

AFFECTED FILES
  CMakeLists.txt
  README.md

To: heikobecker, mvourlakos, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10580: Add .arcconfig

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:15dc67016117: Add .arcconfig (authored by heikobecker).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10580?vs=27339&id=27350

REVISION DETAIL
  https://phabricator.kde.org/D10580

AFFECTED FILES
  .arcconfig
  .gitignore

To: heikobecker, mvourlakos, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Release calendar

[Jonathan Riddell]

I've added the release dates for Plasma 5.12, .13 and .14 as well as
Frameworks releases to the end of the year onto the calendar on Phab.

https://phabricator.kde.org/calendar/

Which makes more sense than the Google calendar I had on my personal
account.  You should be able to export the .ics and import it into
whatever calendar you like to use.

Jonathan
Not the boss, not the chief and not secretly controlling the whole KDE
release process

D10579: Search runtime dependencies on QML modules

[Michail Vourlakos]

mvourlakos added a comment.


  Can you please update also the README file?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10579

To: heikobecker, mvourlakos, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10584: fix double spacing bug

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10584

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10584: fix double spacing bug

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: Breeze, VDG, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  When a menu doesn't have any icons, space between check boxes and
  text is twice as big as it should be.

TEST PLAN
  - open menu which has at least one checkbox and doesn't have any icons

REPOSITORY
  R31 Breeze

BRANCH
  double-space-bug

REVISION DETAIL
  https://phabricator.kde.org/D10584

AFFECTED FILES
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10480: align checkable widgets in menu items

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10480: align checkable widgets in menu items

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10480: align checkable widgets in menu items

[Vlad Zagorodniy]

zzag updated this revision to Diff 27344.
zzag added a comment.


  delete double space bug fix

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10480?vs=27116&id=27344

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10580: Add .arcconfig

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10580

To: heikobecker, mvourlakos, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10579: Search runtime dependencies on QML modules

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10579

To: heikobecker, mvourlakos, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: Does Breeze provide QtQuick2 theming?

[Ongun Kanat]

Hi, thanks for the answer

Application is a QtQuickControls 2 application
(https://github.com/agateau/sfxr-qt/blob/master/ui/main.qml#L4).

There's a pull request implements system palette so I think it will be
solved (https://github.com/agateau/sfxr-qt/pull/5).

Looking at theme definitions in /usr/lib/qt/qml/QtQuick/Controls.2/ :
I realized that all Qt5 standard QQC2 themes has
libqtquickcontrols2THEMENAMEstyleplugin.so files under their
respective directories while there's no such file in
/usr/lib/qt/qml/QtQuick/Controls.2/org.kde.desktop/ . Is it normal?

Regards
-Ongun

On 16 February 2018 at 13:03, Marco Martin  wrote:
> On venerdì 16 febbraio 2018 03:10:53 CET Ongun Kanat wrote:
>> Hello,
>>
>> I was testing a QtQuick2 application
>> (https://github.com/agateau/sfxr-qt). One thing I noticed, using dark
>> color schemes (i.e Breeze Dark) result in unreadable white-ish text on
>> white window backgrounds in QtQuick2 applications like [1]. Example
>> code in Qt docs also show similar behavior.
>>
>> I wonder if Breeze provide QtQuick2 theming support. It looks like
>> some level of support is existing since buttons follow selected color
>> scheme.
>>
>> Regards
>> -Ongun
>>
>> [1]
>> https://user-images.githubusercontent.com/3601965/36073061-64b79a6a-0f3b-11
>> e8-9943-8fdb04b25aa0.png
>
> depends on QtQuickControls version.
> if uses version 1, it will naturally use the breeze theme, if uses version 2,
> it needs an extra style installed which is in the qqc2-desktop-style
> framework.
>
> from the screenshot i see that the controls are themed correctly (probably
> qtqquickcontrols 1 i think) but the background isn't
> that would be an application bug, which should take as its background color
> the system palette background color, see 
> http://doc.qt.io/qt-5/qml-qtquick-systempalette.html
>
>
> --
> Marco Martin

Releases Status

[Jonathan Riddell]

As discussed at Kickoff meeting I've documented our ongoing releases
and their dependencies and status.  Please check for clarity and
correctness.

https://community.kde.org/Schedules/Plasma_5

5.8 LTS. Qt 5.6, KDE Frameworks 5.26. Releases made as required in
cases of important bugfixes or security issues
5.12 LTS. Qt 5.9, KDE Frameworks 5.42. Bugfix releases as scheduled
until subsequent LTS
5.13. Qt 5.9 (may yet change to 5.10), KDE Frameworks 5.46. Open for
development then releases as scheduled until 5.14

I also changed the long-standing title of release dude to release
mangler which doesn't include any implied gender.

Jonathan

D10580: Add .arcconfig

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: mvourlakos.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10580

AFFECTED FILES
  .arcconfig
  .gitignore

To: heikobecker, mvourlakos
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10579: Search runtime dependencies on QML modules

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: mvourlakos.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  Raises the required version of extra-cmake-modules to 5.38.0 which
  nowadays follows the same versioning as the rest of KDE frameworks,
  so no need to keep two different versions.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10579

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, mvourlakos
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10552: Keep item highlighted when context menu opens

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4d229146fa4c: Keep item highlighted when context menu 
opens (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10552?vs=27283&id=27337

REVISION DETAIL
  https://phabricator.kde.org/D10552

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Mind to update package pages

[Jonathan Riddell]

Distros are reminded to update the pages listing when they make Plasma
software available though packages, docker images and live/installable
images

https://community.kde.org/Plasma/Live_Images
https://community.kde.org/Plasma/Docker_Images
https://community.kde.org/Plasma/Packages


Jonathan

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  Latte config window is a Plasma::ConfigView, so it inherates a QQuickView

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10480: align checkable widgets in menu items

[Vlad Zagorodniy]

zzag reclaimed this revision.
zzag added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:4740
> If I understand right, this is the double spacing bug fix. 
> Correct ? Very nice. 
> In principle, it would be better to have it in a separate Review, and a 
> separate commit. 
> This way, if in the future someone wants to revert the margin change, she/he 
> does not revert the bug fix at the same time. Can you do that ? 
> Note that thinking about it, I also like the other fix (the margin width 
> increase), so this will go too.

> This way, if in the future someone wants to revert the margin change, she/he 
> does not revert the bug fix at the same time. Can you do that ?

Yes.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  Reported: https://bugreports.qt.io/browse/QTBUG-66446
  Although this is really unlikly to happen, a widget having a combobox, but 
this is the case of Latte where the whole config overlay is just a `MouseArea`.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  In D9275#207623 , @mvourlakos wrote:
  
  > Can you build Latte from master version? All comboboxes in its settings 
window are PlasmaComponents3
  
  
  :)
  Ok, I can assume that Latte doens't have a `Window`/`ApplicationWindow`, and 
that is why this is needed.
  I've tried this and it didn't work as with `ApplicationWindow` instead of the 
base `Item`:
  
import QtQuick 2.7
import QtQuick.Layouts 1.3

import "plasma" as Plasma

Item {
LayoutMirroring.enabled: true
LayoutMirroring.childrenInherit: true

width: 350
height: 150

RowLayout {
anchors.fill: parent
Plasma.ComboBox {
id: combo
model: ["أولا_", "Second_", "Third"]
}
}
}
  
  We should include this for now, with the HACK comment, till we can get it 
somehow solved in Qt.
  Sorry for all the misunderstandings!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

[Harald Sitter]

sitter added a comment.


  Yeah, it costs us nothing to use a 5 suffix though and it is more consistent 
with the other bins. If someone says bin/kdesu as a name is more useful to them 
I am not opposed to dropping the suffix though.
  
  (also I just checked and we even had kdesu in libexec of kde-runtime at least 
towards its later versions, so any conflict potential is probably 
distribution-specific to begin with)

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D10541

To: sitter
Cc: rdieter, asturmlechner, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  Can you build Latte from master version? All comboboxes in its settings 
window are PlasmaComponents3

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  I've done some more testing and read some Qt docs. `Popup` item get 
reparented to the window once displayed, so LayoutMirroring is applied to it 
only at that point (applying it to the contentItem).
  So my comments above about `Popup` not inheerting `Item` are wrong, sorry.
  I'm still not sure if this is needed really.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10560: [Clipboard plasmoid] Support Aztec barcode

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a42ccf51c3c5: [Clipboard plasmoid] Support Aztec barcode 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10560?vs=27301&id=27332#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10560?vs=27301&id=27332

REVISION DETAIL
  https://phabricator.kde.org/D10560

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  klipper/clipboardjob.cpp

To: broulik, #plasma, graesslin, vkrause, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10560: [Clipboard plasmoid] Support Aztec barcode

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10560

To: broulik, #plasma, graesslin, vkrause, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Does Breeze provide QtQuick2 theming?

[Marco Martin]

On venerdì 16 febbraio 2018 03:10:53 CET Ongun Kanat wrote:
> Hello,
> 
> I was testing a QtQuick2 application
> (https://github.com/agateau/sfxr-qt). One thing I noticed, using dark
> color schemes (i.e Breeze Dark) result in unreadable white-ish text on
> white window backgrounds in QtQuick2 applications like [1]. Example
> code in Qt docs also show similar behavior.
> 
> I wonder if Breeze provide QtQuick2 theming support. It looks like
> some level of support is existing since buttons follow selected color
> scheme.
> 
> Regards
> -Ongun
> 
> [1]
> https://user-images.githubusercontent.com/3601965/36073061-64b79a6a-0f3b-11
> e8-9943-8fdb04b25aa0.png

depends on QtQuickControls version.
if uses version 1, it will naturally use the breeze theme, if uses version 2, 
it needs an extra style installed which is in the qqc2-desktop-style 
framework.

from the screenshot i see that the controls are themed correctly (probably 
qtqquickcontrols 1 i think) but the background isn't
that would be an application bug, which should take as its background color 
the system palette background color, see 
http://doc.qt.io/qt-5/qml-qtquick-systempalette.html


-- 
Marco Martin

D10480: align checkable widgets in menu items

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10480#207511 , @zzag wrote:
  
  > > Here: if you look at the last checkbox (folders first). The distance to 
the left edge is larger to that of the bottom edge, while before they were 
identical.
  >
  > Oh, I haven't noticed that before. To me, that's still fine.
  >
  > > So this really depends on what we want to align with what ...
  >
  > I'd propose to align check boxes between the left edge and icon/text.
  
  
  ok. I agree.
  
  See comments below: if you can split this patch in two (first bug fix, then 
margin width increase, then both can go.
  
  Thanks for the good work !

INLINE COMMENTS

> breezestyle.cpp:4740
> +QRect iconRect;
> +if( showIcon && iconWidth > 0 )
> +{

If I understand right, this is the double spacing bug fix. 
Correct ? Very nice. 
In principle, it would be better to have it in a separate Review, and a 
separate commit. 
This way, if in the future someone wants to revert the margin change, she/he 
does not revert the bug fix at the same time. Can you do that ? 
Note that thinking about it, I also like the other fix (the margin width 
increase), so this will go too.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10388: allow to have more than one default activity

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:6e60c6a3e46b: allow to have more than one default 
activity (authored by mart).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10388?vs=27224&id=27327

REVISION DETAIL
  https://phabricator.kde.org/D10388

AFFECTED FILES
  src/service/Activities.cpp

To: mart, #plasma, ivan, bshah
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10392: Don't trigger SwipeListItem's actions unless they are exposed

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami, mart
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10388: allow to have more than one default activity

[Ivan Čukić]

ivan accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  phab/defaultMultipleActivities

REVISION DETAIL
  https://phabricator.kde.org/D10388

To: mart, #plasma, ivan, bshah
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10560: [Clipboard plasmoid] Support Aztec barcode

[Volker Krause]

vkrause added a comment.


  looks good to me

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10560

To: broulik, #plasma, graesslin, vkrause
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10571: [AppletAppearance] Remove d QtObject

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's not like this is public API or anything.

TEST PLAN
  Saves one QObject per applet.
  Moving applets still works and is saved correctly, no warnings on console.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10560: [Clipboard plasmoid] Support Aztec barcode

[Kai Uwe Broulik]

broulik added a comment.


  > There surely needs to be some CMake change somewhere with the version?
  
  I thought the same but in CMakeLists.txt ist says
  
find_package(KF5Prison ${KF5_MIN_VERSION})
  
  and min is 5.42 already

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10560

To: broulik, #plasma, graesslin, vkrause
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart