D10835: [kicker] Never execute recent documents

aleksejshilin added a comment. In D10835#214865 , @hein wrote: > Do you have a contributor account to commit this or should we do it on your behalf? I have a contributor account, thanks. I'll update the revision to address code

D10835: [kicker] Never execute recent documents

hein added a comment. It looks good to me as well. I was waiting for Kai's concerns to get sorted out ;) @aleksejshilin Do you have a contributor account to commit this or should we do it on your behalf? (Your authorship will be preserved, of course.) REPOSITORY R119 Plasma Desktop

D10835: [kicker] Never execute recent documents

broulik added a subscriber: hein. broulik added a comment. Stupid me, you're absolutely right. Looks good to me but please let @hein have the final word on this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10835 To: aleksejshilin, #plasma Cc: hein,

D10835: [kicker] Never execute recent documents

aleksejshilin added a comment. In D10835#214197 , @broulik wrote: > So why not do the same here instead of offering "Open With"? Currently recent documents in application launchers (i.e. Kicker, Kickoff etc.) are opened in their default

D10753: Provide the source selection as a contextual action

ngraham added a comment. Got it working. I think it's better than what we have now, at least. However, the use of checkboxes in the menu is inappropriate: since the entries are mutually exclusive, we should use radio buttons instead (Same with the sort menu; see

D10878: Changed default context menu entries on the desktop

rizzitello added a comment. Just wanted to point out that as proposed in a Desktop view the contect menu would contain only three items Lock screen , Leave and Configure Desktop. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10878 To: anemeth, #plasma,

D10878: Changed default context menu entries on the desktop

zzag added a comment. -1, sorry. I totally agree with @hein (except the part about regular usage). > Why not just create a new submenu called "Manage" No one will see what's inside. I don't discover what's inside of each submenu and I think so others. REPOSITORY R120 Plasma

D10878: Changed default context menu entries on the desktop

jnoack added a comment. I agree, the context menu looks really convoluted. But what happens when the cashew is disabled and the desktop is empty? There would be no way to add widgets. Why not just create a new submenu called "Manage" or something instead for: - Add Widgets - Add

D10878: Changed default context menu entries on the desktop

hein added a comment. I'm quite heavily -1 on this. This is removing various entries that I personally use regularly and that I think users rely on: - Add Widgets - Add Panel - The lock toggle These are only "unnecessary" if you assume people actually understand and use

D10878: Changed default context menu entries on the desktop

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Plasma, VDG. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10878 To: anemeth, #plasma, #vdg Cc: plasma-devel, ZrenBot, lesliezhai,

D10878: Changed default context menu entries on the desktop

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10878 AFFECTED

D10855: Emit clicked when double click expires

graesslin added a comment. > Press and hold isn't particularly intuitive. When enabling this behavior (which is default off) a message is shown with the following content: "Close by double clicking:\n To open the menu, keep the button pressed until it appears." Given that I'm not

D10837: bad textarea width for rename file if filename too short

anemeth added a comment. works great REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

garg added a comment. LGTM REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D10541 To: sitter Cc: garg, rdieter, asturmlechner, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10830: Disable SplitterProxy by default since it's broken

aacid added a comment. I'm running with the splitter proxy disabled in the configuration dialog and i don't have any problem moving splitters. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10830 To: aacid, hpereiradacosta Cc: plasma-devel, ZrenBot, lesliezhai,

D10830: Disable SplitterProxy by default since it's broken

hpereiradacosta added a comment. yeah so ... Qt Broke it. Was not broken in past version (not with the version I have) (5.9.4) Note that what is broken is the rendering (basically Qt having issues with transparent widgets), not the actual functionality. (the ability to resize splitter in

D10774: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2a935337c111: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10774?vs=27862=28122#toc REPOSITORY

D10773: Port to QmlObjectSharedEngine in all remaining places

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b284265924bd: Port to QmlObjectSharedEngine in all remaining places (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10773: Port to QmlObjectSharedEngine in all remaining places

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10773 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10774: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10774 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10830: Disable SplitterProxy by default since it's broken

broulik added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10830 To: aacid, hpereiradacosta Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10855: Emit clicked when double click expires

ngraham added a comment. Does this result in a behavior change such that a slow user with a mouse who clicks and then leaves the mouse in the same place for a moment will get a context menu? If so, I'm not sure that's a good idea. Lots of users aren't so great with non-touch input devices

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 77 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/77/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Feb 2018 13:47:04 + Build duration: 7 min 50 sec and counting

D10858: [Solid Device Engine] Connect device signals initially

broulik added a comment. Works fine in plasmawindowed but doesn't help in plasmashell :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10858 To: broulik, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10858: [Solid Device Engine] Connect device signals initially

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Signals like mount started/finished were only connected for newly

Re: Minutes Monday Plasma Hangout

On Mon, Feb 26, 2018 at 12:30 PM, Sebastian Kügler wrote: > Monday meeting time! > -- > sebas > > http://www.kde.org | http://vizZzion.org Hi, I couldn't attend, so here are my notes * Most of the week, work on preloading plasmodis for "first impression" ** finished and pushed

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

https://bugs.kde.org/show_bug.cgi?id=350684 Edmund Kasprzak changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO

[Breeze] [Bug 343580] All look and feel, icons, theme are not configurable and all icons are gone

https://bugs.kde.org/show_bug.cgi?id=343580 Edmund Kasprzak changed: What|Removed |Added Resolution|WAITINGFORINFO |FIXED --- Comment #7 from

Minutes Monday Plasma Hangout

Monday meeting time! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 26-02-2018 Present: Sho, notmart, psifidotos, kbroulik, bshah, romangg Sho: * Fixed window delegates not being properly clamped to the desktop rect in the pager * Working on a KMessageWidget equivalent

D10549: Don't crash if the cursor theme fails to create

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH dont-crash-cursor-theme-failure REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin, #plasma, davidedmundson, romangg Cc: romangg, plasma-devel, kwin, iodelay,

D10855: Emit clicked when double click expires

broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Press and hold isn't particularly intuitive. Instead,

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. The fix needs to be a bit more complex. We can not really rely on the user to fix the database. The current plan is to have kamd backup the important parts of the database from time to time, and to recreate the database when needed. I'll see whether I can roll

D10235: [server] Add support for the frame semantics of Pointer version 5

bcooksley edited projects, added Plasma; removed Plasma on Wayland. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH server-pointer-frame-semantics REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin, #kwin,

D10835: [kicker] Never execute recent documents

broulik added a comment. So why not do the same here instead of offering "Open With"? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10835 To: aleksejshilin, #plasma Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10835: [kicker] Never execute recent documents

anthonyfieroni added inline comments. INLINE COMMENTS > recentusagemodel.cpp:286 > if (!resource.startsWith(QLatin1String("applications:"))) { > -new KRun(docData(resource, Kicker::UrlRole).toUrl(), 0); > +QUrl resourceUrl = docData(resource,