D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#226836 , @ngraham wrote: > @graesslin, those are good comments for @mart's ideas for the other approach. Do you have any remaining concerns with this one that I can work on? As long as the lnf theme

D11197: Allow OverlaySheet clients to omit the built-in close button

ngraham added a comment. Ping REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11197 To: ngraham, mart, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

Re: no OSK in Plasma Mobile

Hello Heather, On Thu, Mar 15, 2018 at 06:57:27PM -0600, Heather Ellsworth wrote: > I've been running Plasma Mobile on my iMX6 dev board (precursor to the > dev kit for the Librem 5) and I've notices there's no onscreen keyboard. > Is it there and I'm just not initializing it? Or what is the

D11375: Don't block evaluating DBus scripts if widgets are locked.

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Original decision didn't really have a

Re: no OSK in Plasma Mobile

Hi, I'm not the maintainer or even an accountable person but these may help: Blog about: https://blog.martin-graesslin.com/blog/2016/05/virtual-keyboard-support-in-kwinwayland-5-7/ > As you can see in the video the virtual keyboard is only enabled by default > if no hardware keyboard is

D11372: Put the refresh action on the left

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, just what the doctor ordered! A much cleaner approach than making one contextual and the other one main. Works great. REPOSITORY R134 Discover Software Store BRANCH master

D11372: Put the refresh action on the left

apol created this revision. apol added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Rather than on the contextual actions that incidentally go on the right

no OSK in Plasma Mobile

Hi Guys, I've been running Plasma Mobile on my iMX6 dev board (precursor to the dev kit for the Librem 5) and I've notices there's no onscreen keyboard. Is it there and I'm just not initializing it? Or what is the story with the OSK in Plasma Mobile? Thanks, Heather signature.asc Description:

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. @graesslin, those are good comments for @mart's ideas for the other approach. Do you have any remaining concerns with this one that I can work on? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg,

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#226803 , @ngraham wrote: > Thanks @mart. I think using an animated slideshow by default will be really popular, especially if we do some work to add more nice images by default and polish up the slideshow

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. Thanks @mart. I think using an animated slideshow by default will be really popular, especially if we do some work to add more nice images by default and polish up the slideshow plugin's UI a bit. I'm glad to hear that the memory issue is or should be resolved soon.

D11352: [RFC] Auto ordered systray

mart added a comment. I like where this is going! (will still have to test it running tough) one general thing i wonder, is if would be better to implementthe whole reorderItem() logic on the c++ side as is potentially heavy and complicated.. (and the actual reordering needs to be done

D11308: Use the default Plasma wallpaper on the lock screen

mart added a subscriber: davidedmundson. mart added a comment. In D11308#226767 , @ngraham wrote: > @mart You're essentially describing transforming the lock screen into a screensaver, with the default effect being an animated slideshow. I

D11358: Give file and folder names a bit more room in Folder View

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8208d9b3b3b9: Give file and folder names a bit more room in Folder View (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 366 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/366/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Thu, 15 Mar 2018 19:40:35 + Build duration: 3 min 0 sec and counting JUnit Tests Name:

D11358: Give file and folder names a bit more room in Folder View

ngraham added a comment. Well, either way, we can continue the discussion elsewhere, and I'll land this minimal patch. Thanks, Eike. REPOSITORY R119 Plasma Desktop BRANCH more-generous-folder-view-title-display (branched from master) REVISION DETAIL https://phabricator.kde.org/D11358

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 365 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/365/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Thu, 15 Mar 2018 19:04:18 + Build duration: 36 min and counting CONSOLE OUTPUT [...truncated

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. @mart You're essentially describing transforming the lock screen into a screensaver, with the default effect being an animated slideshow. I would favor this. Users like screensavers simply for the visual flair, and I've heard a lot of user feedback that they'd like

D11308: Use the default Plasma wallpaper on the lock screen

mart added a comment. That's a way i would like it: https://www.youtube.com/watch?v=BOsclMNpK3M (quick and dirty so the interaction and effects are very buggy) have the lockscreen by default to be a slideshow of the default installed wallpapers and show only the clock (in this mode the

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 195 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/195/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 19:19:53 + Build duration: 4 min 17 sec and counting JUnit Tests

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 194 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/194/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 19:13:28 + Build duration: 1 min 56 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 193 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/193/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 19:04:18 + Build duration: 3 min 27 sec and counting CONSOLE OUTPUT

D11364: Remove redundant app name from header

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11364 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11358: Give file and folder names a bit more room in Folder View

ngraham added a comment. In D11358#226649 , @hein wrote: > Folder View always reserves enough vertical space to fit the configured number of lines to keep an evenly-spaced grid. The default number of lines should therefore strike a happy medium

D11362: Fix double top padding on scrollable pages with headers

ngraham added a comment. OK, I see that you just added the same fix to the cards branch, so I'll abandon this. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11362 To: ngraham, mart, apol, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D11316: Components for Cards

mart updated this revision to Diff 29626. mart added a comment. - better top padding REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29585=29626 BRANCH mart/Card REVISION DETAIL https://phabricator.kde.org/D11316 AFFECTED FILES

D11362: Fix double top padding on scrollable pages with headers

mart added a comment. that should be done also in the cards branch (tough this version is more correct) if it's ok with you i would put this in the branch iinstead, otherwise there may be a conflict when merging REPOSITORY R169 Kirigami REVISION DETAIL

D11364: Remove redundant app name from header

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now that we're using the header for

D11362: Fix double top padding on scrollable pages with headers

ngraham created this revision. ngraham added reviewers: mart, apol, Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Kirigami was erroneously allocating extra top

D11358: Give file and folder names a bit more room in Folder View

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Folder View always reserves enough vertical space to fit the configured number of lines to keep an evenly-spaced grid. The default number of lines should therefore strike a happy medium

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 192 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/192/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 16:58:38 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT

D11358: Give file and folder names a bit more room in Folder View

ngraham added a comment. This patch does that too, so I've removed the other changes. However, if we have users clamoring for diametrically-opposed things, maybe it's time to consider making the grid spacing configurable? macOS had the exact same problem for more than a decade and Apple

D11358: Give file and folder names a bit more room in Folder View

ngraham updated this revision to Diff 29614. ngraham added a comment. Revert unacceptable changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11358?vs=29609=29614 BRANCH more-generous-folder-view-title-display (branched from master) REVISION

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 364 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/364/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Thu, 15 Mar 2018 16:57:33 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 191 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/191/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 16:54:03 + Build duration: 3 min 26 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 363 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/363/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Thu, 15 Mar 2018 16:54:03 + Build duration: 1 min 40 sec and counting CONSOLE OUTPUT

D10753: Provide the source selection as a contextual action

This revision was automatically updated to reflect the committed changes. Closed by commit R134:af5058de7f9a: Provide the source selection as a contextual action (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D11358: Give file and folder names a bit more room in Folder View

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. The grid spacing has been reduced multiple times on user requests. I'm not going to accept a patch that makes it wider, or changes the default number of lines. But I think a patch

D11358: Give file and folder names a bit more room in Folder View

ngraham created this revision. ngraham added reviewers: hein, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Give Folder View cells a small amount more horizontal space

D11356: [Media Controller] Show track length if available even if seeking isn't possible

kossebau added a comment. Thanks for the quick patch, works nicely with my CanSeek=false gwenview position WIP patch :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11356 To: broulik, #plasma, #vdg, kossebau, Fuchs, romangg Cc: plasma-devel, ZrenBot,

D11356: [Media Controller] Show track length if available even if seeking isn't possible

This revision was automatically updated to reflect the committed changes. Closed by commit R120:513d3a69af50: [Media Controller] Show track length if available even if seeking isnt possible (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11356: [Media Controller] Show track length if available even if seeking isn't possible

Fuchs accepted this revision. Fuchs added a comment. This revision is now accepted and ready to land. +1, looks great to me. Bit of duplicate control, but given there can be one at most, that seems fine to me. Also progress bar makes sense, since a playing track is progress, so it

D11356: [Media Controller] Show track length if available even if seeking isn't possible

broulik created this revision. broulik added reviewers: Plasma, VDG, kossebau, Fuchs. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When seeking isn't possible but the track

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 190 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/190/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 13:48:23 + Build duration: 2 min 34 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 362 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/362/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Thu, 15 Mar 2018 13:48:23 + Build duration: 2 min 36 sec and counting CONSOLE OUTPUT

D11333: introduce the function containmentGraphicsItemPreview

mart updated this revision to Diff 29595. mart added a comment. approach with a model a possible approach is this: a model with all the activities that map to items, but i don't like this, because it's pretty much duplicating the activity model present in kactivities with a worse

D11333: introduce the function containmentGraphicsItemPreview

mart added a comment. a possible approach is this: a model with all the activities that map to items, but i don't like this, because it's pretty much duplicating the activity model present in kactivities with a worse version. another approach i'll try shortly, is to just have a list

D11198: [libbreezecommon] add box shadow helper

zzag added inline comments. INLINE COMMENTS > broulik wrote in config-breezecommon.h.cmake:1 > This file is generated and should not be checked in What do you mean? We need to pass an input file to the `configure_file`. REPOSITORY R31 Breeze REVISION DETAIL

D11292: [RFC] Ordered system tray v2

Pitel added a comment. To compare with auto ordering (as @mart would like) see D11352 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni,

D11352: [RFC] Auto ordered systray

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY @mart dislikes idea of manually ordering the systray (D11233 ,

D11133: Fix minimise all applet on wayland with an active window

This revision was automatically updated to reflect the committed changes. Closed by commit R114:3697f4511337: Fix minimise all applet on wayland with an active window (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D11327: [Workspace Options KCM] sync() after writing settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:06c837e274ed: [Workspace Options KCM] sync() after writing settings (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10338: Don't show tooltips for inactive windows

broulik added a comment. Ping REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10338 To: broulik, #plasma, graesslin, McPain Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11309: Use the default Plasma wallpaper on the login screen

davidedmundson added a comment. > if vdg agrees ok... i'm still not sure about this Will wait for the relevant screenlocker thread REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11309 To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham Cc:

D11335: [System Tray] Fix hiding applets with HiddenStatus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:de715e8c5d95: [System Tray] Fix hiding applets with HiddenStatus (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in CardsLayout.qml:35 > I can see you want it in a layout because you're setting the relevant > attached properties, but why explicitly Column? It's not mandatory but the one i think it makes more sense, so i want to put it as

D11316: Components for Cards

mart updated this revision to Diff 29585. mart marked 3 inline comments as done. mart added a comment. - fix elide for bannerimage REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29514=29585 BRANCH mart/Card REVISION DETAIL

D11350: [AppMenuModel] Don't store actions ourselves

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Always redirect to the ones in `m_menu` in case

D11333: introduce the function containmentGraphicsItemPreview

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in desktopview.cpp:201 > In the main code path shellcorona is responsible for assigning containments > to desktopviews. > > In this code path DesktopView is extracting the relevant containments for > itself. > > That's super

D10837: bad textarea width for rename file if filename too short

hein closed this revision. hein added a comment. Committed as d6818eac6fbe495facf558b41cd570604bb7cbcb. REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai,

D11333: introduce the function containmentGraphicsItemPreview

mart added a comment. In D11333#225797 , @davidedmundson wrote: > ShellCorona only creates the containment in currentActivityChanged, so this swiping stuff isn't going to work until you've first switched containment an existing way, then

D11292: [RFC] Ordered system tray v2

mart added a comment. i'm still against this, but in favor of just forcing sort by type and alphabetic REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham,

D11309: Use the default Plasma wallpaper on the login screen

mart added a comment. if vdg agrees ok... i'm still not sure about this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11309 To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham Cc: mart, davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai,

D11198: [libbreezecommon] add box shadow helper

broulik added inline comments. INLINE COMMENTS > config-breezecommon.h.cmake:1 > +/* config-breezecommon.h. Generated by cmake from > config-breezecommon.h.cmake */ > + This file is generated and should not be checked in REPOSITORY R31 Breeze REVISION DETAIL