KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.9 - Build # 136 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.9/136/ Project: Plasma systemsettings kf5-qt5 SUSEQt5.9 Date of build: Wed, 21 Mar 2018 05:51:07 + Build duration: 3 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Plasma systemsettings kf5-qt5 FreeBSDQt5.9 - Build # 33 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20FreeBSDQt5.9/33/ Project: Plasma systemsettings kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Mar 2018 05:51:07 + Build duration: 1 min 18 sec and counting CONSOLE

D11447: No longer export QT_QPA_PLATFORM env variable to the session

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c4a0d6925ec6: No longer export QT_QPA_PLATFORM env variable to the session (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Mar 2018 05:50:19 + Build duration: 1 min 13 sec and counting CONSOLE

D11446: Use platform detection from KWorkspace in Powerdevil

This revision was automatically updated to reflect the committed changes. Closed by commit R122:8ba04f890e15: Use platform detection from KWorkspace in Powerdevil (authored by graesslin). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11446?vs=29811=30085

D11445: Use platform detection in SystemSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R124:2d8296904bb4: Use platform detection in SystemSettings (authored by graesslin). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11445?vs=29810=30084

KDE CI: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20FreeBSDQt5.9/15/ Project: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Mar 2018 05:50:19 + Build duration: 45 sec and counting

D11352: [RFC] Auto ordered systray

ngraham added a comment. I rather like this auto-order-by-category approach, myself. +1 conceptually. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel, #vdg, #plasma Cc: ngraham, wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11522: [RFC] KCM Launch Feedback not saving cursor settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8af970fd49f3: KCM Launch Feedback not saving cursor settings (authored by sharvey, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey added a comment. In D11522#230474 , @hein wrote: > Nah, it's to prevent an infinite loop between the different radio buttons and the backend object, since onCheckedChange will fire for both false and true. Makes sense, in a QML

D11522: [RFC] KCM Launch Feedback not saving cursor settings

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nah, it's to prevent an infinite loop between the different radio buttons and the backend object, since onCheckedChange will fire for both false and true. Thanks! Should I commit this for

D11198: [libbreezecommon] add box shadow helper

zzag added a comment. In D11198#229897 , @hpereiradacosta wrote: > I deliberately accepted the revision, despite having still some comments about what should be implemented, because I trusted you that you would implement this and only this.

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 83 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/83/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 23:55:52 + Build duration: 1 min 16 sec and counting

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 247 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/247/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Tue, 20 Mar 2018 23:55:52 + Build duration: 1 min 18 sec and counting CONSOLE

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 110 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/110/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Tue, 20 Mar 2018 23:55:52 + Build duration: 1 min 12 sec and counting

Re: no OSK in Plasma Mobile

On 03/20/2018 10:47 AM, Martin Flöser wrote: > Am 2018-03-19 21:25, schrieb Heather Ellsworth: >> On 03/17/2018 02:41 PM, Martin Flöser wrote: >>> >>> >>> Am 17. März 2018 02:01:24 MEZ schrieb Heather Ellsworth >>> : On 03/15/2018 09:10 PM, Bhushan Shah wrote: >

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 115 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/115/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 23:23:27 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated

D11106: Fix app initialization order

This revision was automatically updated to reflect the committed changes. Closed by commit R121:576d10209bd9: Fix app initialization order (authored by kossebau). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11106?vs=28880=30070

D11126: [touchpad kded] Work around kded fail on X-KDE-OnlyShowOnQtPlatforms lists

This revision was automatically updated to reflect the committed changes. Closed by commit R119:830ff8deb477: [touchpad kded] Work around kded fail on X-KDE-OnlyShowOnQtPlatforms lists (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11209: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

This revision was automatically updated to reflect the committed changes. Closed by commit R129:05b3b8b6d335: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN (authored by kossebau). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

D11533: [kstyle] create shadow tiles more explicitly

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY With this changes it's more clear where shadow tiles are

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

This revision was automatically updated to reflect the committed changes. Closed by commit R120:27854ca9f48a: NotifcationPopup: workaround crash in Qt when appending empty actions array (authored by dvratil). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks so much for looking into that! I don't think in general we should do workarounds for unreleased software, given the final version won't have the bug but

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey updated this revision to Diff 30042. sharvey added a comment. - Revise code to use `Qt.callLater()` instead of invalid `Qt.later()` Per @hein, revised with correct function call REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

dvratil updated this revision to Diff 30041. dvratil added a comment. Update explanation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11519?vs=30030=30041 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11519 AFFECTED FILES

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey added a comment. In D11522#230217 , @hein wrote: > The actuall bug here is pretty stupid - the function is called callLater(), not later(). Could you modify the patch to use callLater? Sure, easy enough. As long as you (or

D11516: use plasma_install_bundled_package

mart added a comment. In D11516#230172 , @kossebau wrote: > How new is the plasma_install_bundled_package macro? Needs a bump of min kf5 version as well, so people know which plasma-framework version they need at least? good point, the

D11522: [RFC] KCM Launch Feedback not saving cursor settings

hein added a comment. The actuall bug here is pretty stupid - the function is called callLater(), not later(). Could you modify the patch to use callLater? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11522 To: sharvey, #plasma, hein, davidedmundson,

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey marked an inline comment as done. sharvey added a comment. Braces and semicolons removed. Taking these away was one of the ways I'd get a segfault. This time, however, all's well in the world. I need to keep debugging my environment. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

apol added a comment. In D11519#230170 , @dvratil wrote: > Add comment with explanation sorry it was my fault not commenting enough :P I'd put the url to the bug or to the patch so that when future us want to check if this if still

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey updated this revision to Diff 30031. sharvey edited the summary of this revision. sharvey added a comment. - Removed erroneous braces and semicolons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11522?vs=30028=30031 BRANCH

D11516: use plasma_install_bundled_package

kossebau added a comment. How new is the plasma_install_bundled_package macro? Needs a bump of min kf5 version as well, so people know which plasma-framework version they need at least? Otherwise patch fine with me, not aware of details, so assume you have your reason for going rcc :)

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

dvratil updated this revision to Diff 30030. dvratil added a comment. Add comment with explanation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11519?vs=30020=30030 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11519 AFFECTED

D11522: [RFC] KCM Launch Feedback not saving cursor settings

ngraham added a comment. Thanks for the patch! Formatting-wise, please capitalize Bug (should be BUG). INLINE COMMENTS > main.qml:63 > > -onCheckedChanged: Qt.later(function() { > kcm.busyCursorCurrentIndex = 0; }) > +onCheckedChanged: {

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

apol added inline comments. INLINE COMMENTS > NotificationPopup.qml:61 > +notificationItem.actions.clear(); > +if (notificationProperties.actions.length > 0) { > +notificationItem.actions.append(notificationProperties.actions); Add a comment indicating what's

D11522: [RFC] KCM Launch Feedback not saving cursor settings

sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY [Bug 392050] Launch Feedback KCM was not saving the cursor notifications properly - `Apply`

D11514: use plasma_install_bundled_package

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e37156b404bf: use plasma_install_bundled_package (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11514?vs=30009=30024 REVISION DETAIL

D11518: Use model reset rather than beginRemoveRows() to clear font groups

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d97d360ba408: Use model reset rather than beginRemoveRows() to clear font groups (authored by dvratil). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11515: use plasma_install_bundled_package

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fe3db8eec014: use plasma_install_bundled_package (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11515?vs=30010=30025 REVISION DETAIL

D11447: No longer export QT_QPA_PLATFORM env variable to the session

fvogt added a comment. > We won't need it anymore anyway after we can expect Qt 5.11 and then can remove the "hack" again. I'm not sure about that - Qt 5.11 allows a fallback, but one reason for this patch was to use xcb + Xwayland instead of native qtwayland as it has certain

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

dvratil created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Appending an empty array of actions to QQmlListModel triggers an assert in Qt when built in debug

D11518: Use model reset rather than beginRemoveRows() to clear font groups

dvratil created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Calling beginRemoveRows() when the model is empty hits an assert in QAbstractItemModel which

D11352: [RFC] Auto ordered systray

Pitel added a comment. I am using Czech translation and I am satisfied with item order (but I keep only a few items in my systray). I like the current rule because it is simple and have some internal logic (even though it might not be obvious what the `text` of an applet is) and it is not

D11447: No longer export QT_QPA_PLATFORM env variable to the session

romangg added a comment. I think it is fine as it is now. We won't need it anymore anyway after we can expect Qt 5.11 and then can remove the "hack" again. REPOSITORY R120 Plasma Workspace BRANCH unset-qt-qpa-platform REVISION DETAIL https://phabricator.kde.org/D11447 To: graesslin,

D11482: Export Translations to right filename

leszeklesner added a comment. In D11482#229987 , @davidedmundson wrote: > ... > Leszek which were the strings that renderered incorrectly? > Have you tried renaming your local .po file to see if it does fix things? The issue

Re: no OSK in Plasma Mobile

Am 2018-03-19 21:25, schrieb Heather Ellsworth: On 03/17/2018 02:41 PM, Martin Flöser wrote: Am 17. März 2018 02:01:24 MEZ schrieb Heather Ellsworth : On 03/15/2018 09:10 PM, Bhushan Shah wrote: Hello Heather, On Thu, Mar 15, 2018 at 06:57:27PM -0600, Heather

D10838: [joystick kcm] Fix translation catalog name to follow patterns

ltoscano added a comment. (you can add the #Localization group too) I would suggest kcm5_joystick in order to be future-proof. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10838 To: kossebau, #plasma,

D11516: use plasma_install_bundled_package

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use the new install macro to install bundled packages in the form of an

D11447: No longer export QT_QPA_PLATFORM env variable to the session

graesslin added a comment. In D11447#229522 , @graesslin wrote: > There's another solution which might be cleaner and which KWin uses for that problem: modifying the process environment. I'll give a try whether this could work here.

D11515: use plasma_install_bundled_package

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use the new install macro to install bundled packages in the form of an

D10838: [joystick kcm] Fix translation catalog name to follow patterns

davidedmundson added a comment. Change is correct, but if it doesn't explicitly fix anything, I personally wouldn't bother. See what kde-i18n-doc say REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10838 To: kossebau, #plasma, kde-i18n-doc Cc:

D10850: Rename wallpaper translation catalogs to follow pattern

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. If you do rename any catalogs please inform kde-i18n-doc so they can move any existing translations REPOSITORY R120 Plasma Workspace BRANCH fixwallpapercatalognames

D11514: use plasma_install_bundled_package

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use the new install macro which compresses packages in a bundled rcc TEST

D11057: Add a custom default avatar to the sddm-breeze theme.

davidedmundson added a comment. Urgh, I'm really sorry, I committed it without correctly changing the author to give you the correct credit. Thanks for the patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11057 To: pstefan, #plasma, #vdg,

D11375: Don't block evaluating DBus scripts if widgets are locked.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddf452b6774f: Dont block evaluating DBus scripts if widgets are locked. (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11375?vs=30006=30008#toc REPOSITORY R120

D11057: Add a custom default avatar to the sddm-breeze theme.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:57385777cdff: Add a custom default avatar to the sddm-breeze theme. (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11375: Don't block evaluating DBus scripts if widgets are locked.

davidedmundson updated this revision to Diff 30006. davidedmundson added a comment. How embarassing :/ REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11375?vs=29991=30006 REVISION DETAIL https://phabricator.kde.org/D11375 AFFECTED FILES

D11375: Don't block evaluating DBus scripts if widgets are locked.

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Now you block everything but when system immutable REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11375 To: davidedmundson, #plasma, broulik

D11482: Export Translations to right filename

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > I doubt changing the name of the translation catalog is correct, because You're right. Change could still make sense if done with changing those other

D11512: Set proper application name once browser identifies to us

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. + do the thing fvogt said REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D11512 To: broulik, davidedmundson, fvogt Cc:

D11512: Set proper application name once browser identifies to us

fvogt added a comment. Wouldn't you need to set the `organisationName` as well? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D11512 To: broulik, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11512: Set proper application name once browser identifies to us

davidedmundson added a comment. We're loading all the stuff QGuiApp loads, purely for setApplicationDisplayName? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D11512 To: broulik, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, lesliezhai,

D11512: Set proper application name once browser identifies to us

broulik created this revision. broulik added reviewers: davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This information is mainly used for download

D11498: Install firefox's native messaging host to LIBDIR

This revision was automatically updated to reflect the committed changes. Closed by commit R856:5846f3bfed56: Install firefoxs native messaging host to LIBDIR (authored by heikobecker). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D11350: [AppMenuModel] Don't store actions ourselves

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c9ba8e0cf7e5: [AppMenuModel] Dont store actions ourselves (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11350?vs=29582=29995

D9400: use kpackage_install_bundled_package

apol added a comment. In D9400#229861 , @mart wrote: > using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids"

D9400: use kpackage_install_bundled_package

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:7af18926322e: use kpackage_install_bundled_package (authored by mart). REPOSITORY R242 Plasma Framework (Library)

D9400: use kpackage_install_bundled_package

mart updated this revision to Diff 29993. mart added a comment. 2 macros REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9400?vs=24078=29993 BRANCH phab/bundled REVISION DETAIL https://phabricator.kde.org/D9400 AFFECTED FILES

D11198: [libbreezecommon] add box shadow helper

hpereiradacosta added a comment. > I have updated the diff so the "Accepted" should have gone away because I could introduce a bug, etc. Most likely it's a bug, I don't know ... Or Phabricator has AI so it could recognize what changes you wanted and what changes the new diff

D1230: GBM remote access support for KWin

romangg added inline comments. INLINE COMMENTS > drm_output.h:135 > +const KWayland::Server::OutputInterface* getWaylandInterface() const { > +return m_waylandOutput.data(); > +} This gives me an compile error: invalid static_cast from type 'QObject*' to type

D11482: Export Translations to right filename

lueck added a comment. I doubt changing the name of the translation catalog is correct, because 1. CMakeLists.txt has add_definitions (-DTRANSLATION_DOMAIN=\"plasmavault-kde\") therefore the vault library uses the translation domain "plasmavault-kde", not

D11498: Install firefox's native messaging host to LIBDIR

bshah added a comment. See : https://wiki.mozilla.org/WebExtensions/Native_Messaging#Host_Manifests REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D11498 To: heikobecker, #plasma, bshah, broulik, davidedmundson Cc: plasma-devel,

D11498: Install firefox's native messaging host to LIBDIR

bshah added a comment. That's interesting... because umm, firefox specs says DATADIR should work™ REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D11498 To: heikobecker, #plasma, bshah, broulik, davidedmundson Cc: plasma-devel,

D11021: [Media controller] Add simple volume control

Pitel added inline comments. INLINE COMMENTS > broulik wrote in multiplexedservice.h:38 > Shouldn't this be a job? So you use the `startOperationCall` stuff used > elsewhere (for e.g. Play and so on) I guess it would look more consistent if it was a job but somehow I fail to see why any of

D9400: use kpackage_install_bundled_package

mart added a comment. In D9400#229866 , @davidedmundson wrote: > My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes. what about doing a second plasma macro

D11375: Don't block evaluating DBus scripts if widgets are locked.

davidedmundson updated this revision to Diff 29991. davidedmundson added a comment. system immutable check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11375?vs=29650=29991 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11375

D11198: [libbreezecommon] add box shadow helper

zzag added a comment. In D11198#229871 , @hpereiradacosta wrote: > In D11198#229870 , @zzag wrote: > > > @hpereiradacosta could you please accept this diff again? (I updated the diff) > > >

D11069: [kdecoration] refine shadows

zzag added a comment. Hey, everyone! Even though the patches are accepted I won't land them because KWin patches haven't landed yet(I'm waiting for the code to be reviewed). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg,

D11198: [libbreezecommon] add box shadow helper

hpereiradacosta added a comment. In D11198#229870 , @zzag wrote: > @hpereiradacosta could you please accept this diff again? (I updated the diff) Must I ? Here the revision is marked accepted and ready to be shipped. Or is it a problem

D11198: [libbreezecommon] add box shadow helper

zzag added a comment. @hpereiradacosta could you please accept this diff again? (I updated the diff) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11198: [libbreezecommon] add box shadow helper

zzag updated this revision to Diff 29989. zzag added a comment. prepend `std::` to `erf` REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11198?vs=29858=29989 REVISION DETAIL https://phabricator.kde.org/D11198 AFFECTED FILES CMakeLists.txt

D9400: use kpackage_install_bundled_package

davidedmundson added a comment. My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9400 To: mart, #plasma Cc: davidedmundson,

D9400: use kpackage_install_bundled_package

mart added a comment. using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids" ${PLASMA_RELATIVE_DATA_INSTALL_DIR}) I would still go with this form. REPOSITORY R242 Plasma

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. The new access button is really great, but Kill a window still looks a bit unfinished to me: - The text should use title case: "Kill a Window" - The shortcut does not get localized. (In the global shortcuts KCM, it is localized correctly for me.) - The

D11504: [DeviceNotifications Engine] Never show safely remove message when mounting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f449adc19936: [DeviceNotifications Engine] Never show safely remove message when mounting (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. Unfortunately, comparing by `item.text` with a non-US language enabled makes the result worse than on previous screenshot (especially the order of items within the `Hardware` group is very odd). To get it consistent regardless of system's language setting it might

D11021: [Media controller] Add simple volume control

broulik added a comment. Mostly good! INLINE COMMENTS > multiplexedservice.h:38 > > +Q_INVOKABLE void changeVolume(double delta, bool showOSD) { > +if (m_control) m_control->changeVolume(delta, showOSD); Shouldn't this be a job? So you use the `startOperationCall` stuff used

D11021: [Media controller] Add simple volume control

Pitel added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma, broulik Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11175: [kstyle] refine shadows

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. ship it. Thanks ! REPOSITORY R31 Breeze BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts,

D11069: [kdecoration] refine shadows

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it. Thanks ! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts, fabianr,

D11198: [libbreezecommon] add box shadow helper

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Fix it (std::erf), then ship it ! I have had no time to work on an alternative QGradient blur, and wont in the near future. In the meanwhile lets use this code (that

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 29977. Pitel added a comment. ty, updated REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11352?vs=29973=29977 BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 AFFECTED FILES

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. They are `org.kde.plasma.keyboardindicator` and `org.kde.discovernotifier`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 29973. Pitel added a comment. - put UnknownCategory first - treat applets with category not in the list as UnknownCategory - split reorderItem function into two - add temporary hack whcih allows overriding applet's category (applets with wrong

D11504: [DeviceNotifications Engine] Never show safely remove message when mounting

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It doesn't make any sense. BUG: 391180 FIXED-IN: 5.12.4