D11567: Fix use of assert/crash when removing global shortcut

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Or just remove the assert. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D11567 To: davidedmundson, #plasma, graesslin Cc:

Re: KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 248 - Still Failing!

​Failure is just because the p-f on Plasma doesn't have latest kpackage. the p-f on the frameworks build does build correctly. It's a non-issue which will get synced up soon. The failing unit tests are another matter.

D11567: Fix use of assert/crash when removing global shortcut

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY I'm not the author, but it's pretty clear

D11558: Don't show cache memory in systemloadviewer bars

rkflx added a comment. In D11558#231153 , @davidedmundson wrote: > > Quickly seeing the difference between "free" and "cached" can be quite useful. > > Useful for what? For a start, there's a problem with a system (and thus

D11558: Don't show cache memory in systemloadviewer bars

davidedmundson added a comment. > Quickly seeing the difference between "free" and "cached" can be quite useful. Useful for what? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11558 To: davidedmundson, #plasma Cc: rkflx, plasma-devel, ZrenBot,

D11558: Don't show cache memory in systemloadviewer bars

rkflx added a comment. > It's a completely useless value to know vs how much memory is free. FWIW, I find it's a useful information to assess the state of a system: It grows with time after a reboot, and it shows nicely how memory intensive processes eventually take a toll on the cache

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

kossebau added a comment. Based on request on irc # plasma yesterday: [14:34] frinring: Feel free to remove it again - in all branches please If okayed, would do the same in the Plasma/5.12 branch to all other plasma repos I touched before in master only for this. REPOSITORY R120

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

kossebau updated this revision to Diff 30164. kossebau added a comment. remove unrelated fields.txt file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11563?vs=30163=30164 BRANCH removeencoding REVISION DETAIL

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

kossebau created this revision. kossebau added reviewers: Plasma, fvogt, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The "Encoding" entry had been deprecated in

D10297: Add new "Tools" button above System Monitor's process list

rkflx added inline comments. INLINE COMMENTS > rkflx wrote in ksysguardprocesslist.cpp:412 > Could you do an exact match on the filename, i.e. only the last part of the > full path? There might be situations where "System Monitor" is developed or > installed in a directory containing this

D11559: Fix default colour used by Swap monitor

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. An obvious typo. Thanks for this fix! PS: A Screenshot would have been nice, though :-) REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL

D11561: fix typos in UI strings

schwarzer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. schwarzer requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL https://phabricator.kde.org/D11561 AFFECTED

D10670: Reduce plasmashell frozen time

bcooksley added a comment. Phabricator considers reviews approved only when all individual and group reviewers have approved it. In this instance, nobody approved on behalf of #frameworks and @mwolff has changes requested still. REPOSITORY

D11559: Fix default colour used by Swap monitor

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It has a typo, meaning it gives an error (in

D11558: Don't show cache memory in systemloadviewer bars

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's a completely useless value to know vs

D10670: Reduce plasmashell frozen time

hein added a comment. I think it's because mwolff did "Requesting changes" and he didn't accept. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10670 To: jtamate, #frameworks, #plasma, mwolff, davidedmundson Cc: hein, mwolff, plasma-devel,

D10670: Reduce plasmashell frozen time

jtamate added a comment. In D10670#230938 , @hein wrote: > > This revision was not accepted when it landed; it landed in state Needs Review. > > Weird, David accepted it though? Yes. Shouldn't this be reported as a bug to

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 84 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/84/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Mar 2018 18:27:07 + Build duration: 8 min 34 sec and counting

D10670: Reduce plasmashell frozen time

hein added a comment. > This revision was not accepted when it landed; it landed in state Needs Review. Weird, David accepted it though? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10670 To: jtamate, #frameworks, #plasma, mwolff,

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 111 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/111/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 21 Mar 2018 18:27:07 + Build duration: 1 min 47 sec and counting

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 248 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/248/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Wed, 21 Mar 2018 18:27:07 + Build duration: 1 min 28 sec and counting CONSOLE

D10670: Reduce plasmashell frozen time

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:33ddaaa23f6b: Reduce plasmashell frozen time (authored by jtamate). REPOSITORY R242 Plasma Framework (Library)

Re: PulseAudio switch-on-connect and device-manager modules

On Wed, 21 Mar 2018 10:27:50 -0700 David Edmundson wrote > In the current state when in "automatic mode", the device preference is > still visible but you now only see one entry in the audio playback device > preference column. So at least there's

Re: PulseAudio switch-on-connect and device-manager modules

>If option 1 is chosen, doesn't that disable functionality in the Phonon KCM? Yes. In the current state when in "automatic mode", the device preference is still visible but you now only see one entry in the audio playback device preference column. So at least there's some indication. That part

Re: PulseAudio switch-on-connect and device-manager modules

On Wed, 21 Mar 2018 10:13:11 -0700 David Edmundson wrote > I'll try explaining again. > > Default outputs can be either: > > 1) Automatic > 2) Chosen by the user > > There is one PA module for automatic behaviour, there is one PA module for >

Re: PulseAudio switch-on-connect and device-manager modules

On Wed, Mar 21, 2018 at 5:01 PM, Nate Graham wrote: > On Wed, 21 Mar 2018 09:47:25 -0700 David Rosca > wrote > > As already said by David Edmundson, it works correctly. > > When I suggested in 392103 that we enable switch-on-connect by default,

Re: PulseAudio switch-on-connect and device-manager modules

On Wed, 21 Mar 2018 09:47:25 -0700 David Rosca wrote > As already said by David Edmundson, it works correctly. When I suggested in 392103 that we enable switch-on-connect by default, you said we couldn't do that because it would break the Phonon KCM (your exact

Re: PulseAudio switch-on-connect and device-manager modules

On Wed, Mar 21, 2018 at 4:51 PM, Nate Graham wrote: > Howdy folks, > > It seems that we have KCMs that conflict with one another: > - The Phonon Audio/Video KCM uses the module-device-manager PulseAudio Module. > - plasma-pa's KCM has an "Automatically switch all running streams

Re: PulseAudio switch-on-connect and device-manager modules

I'm trying to centralize the conversation here rather than in a bunch of disjointed bug reports, because I feel like that's made it difficult to discuss the issue. If enabling source switching in plasma-pa disables the device-manager module to prevent module conflicts and in the process breaks

Re: PulseAudio switch-on-connect and device-manager modules

You're not going to get a different answer here to the comments David and I have already left on bugzilla. I don't understand what you think the problem is. >...But both modules can't be loaded at once. Not technically true, but they would interfere with each other. But in any case plasma-pa

PulseAudio switch-on-connect and device-manager modules

Howdy folks, It seems that we have KCMs that conflict with one another: - The Phonon Audio/Video KCM uses the module-device-manager PulseAudio Module. - plasma-pa's KCM has an "Automatically switch all running streams when a new output becomes available" checkbox that loads the

D11308: Use the default Plasma wallpaper on the lock screen

fvogt added a comment. I'll write my viewpoint as downstream maintainer here: We removed the blue background as default as soon as it landed as it is was complained about in various places. Also, our sddm theme also uses the wallpaper as background so it looks similiar now. (if a

D11551: use the new install_package form

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R115:28c54b9851f6: use the new install_package form (authored by mart). REPOSITORY R115 Plasma Audio Volume Applet

D11292: [RFC] Ordered system tray v2

Pitel abandoned this revision. Pitel added a comment. Replaced by D11352 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham,

D11550: use the bundled variant of installpackage

This revision was automatically updated to reflect the committed changes. Closed by commit R116:2583b4232e87: use the bundled variant of installpackage (authored by mart). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D11551: use the new install_package form

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY plasmoids can now be used also from binary resource files rcc which

D11550: use the bundled variant of installpackage

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY plasmoids can now be used also from binary resource files rcc which

D1230: GBM remote access support for KWin

Kanedias added a comment. This makes sense. Thanks, will try with KDecoration master once I'm home REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid,

D1230: GBM remote access support for KWin

kossebau added a comment. In D1230#230642 , @romangg wrote: > In D1230#230613 , @Kanedias wrote: > > > They don't override anything and compile fails for me if they are present. GCC 7.3.1. > > >

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 30111. Pitel added a comment. Great, but I found one more bug (and it affected order of items). This fixes it. - Add tie breaking (for the unlikely case of the same category & text) - Add debug print - Fix sorting algorithm (the order was wrong if

D11352: [RFC] Auto ordered systray

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. got trough some testing of the last version, for me is now good to go REPOSITORY R120 Plasma Workspace BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 To:

D1230: GBM remote access support for KWin

Kanedias added a comment. I don't have KDecoration checked out. The problem is much more simple. These functions don't override anything but there's override keyword present where it shouldn't be. The fix is still required for them, regardless of KDecoration status. Any other issues

D1230: GBM remote access support for KWin

romangg added a comment. In D1230#230613 , @Kanedias wrote: > They don't override anything and compile fails for me if they are present. GCC 7.3.1. I believe this is an unrelated regression you just ran into because of D11209

D1230: GBM remote access support for KWin

Kanedias marked an inline comment as done. Kanedias added a comment. They don't override anything and compile fails for me if they are present. GCC 7.3.1. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc:

D1230: GBM remote access support for KWin

romangg added a comment. Why did you remove the override specifier? It compiles for me also with them. And they are certainly in no connection to this patch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin

D11512: Set proper application name once browser identifies to us

This revision was automatically updated to reflect the committed changes. Closed by commit R856:3d8e61b3901f: Set proper application name once browser identifies to us (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D11512: Set proper application name once browser identifies to us

broulik updated this revision to Diff 30099. broulik added a comment. - Set organization domain and name also REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11512?vs=30003=30099 REVISION DETAIL https://phabricator.kde.org/D11512

D1230: GBM remote access support for KWin

Kanedias requested review of this revision. Kanedias marked an inline comment as done. Kanedias added inline comments. INLINE COMMENTS > romangg wrote in drm_output.h:135 > This gives me an compile error: invalid static_cast from type 'QObject*' to > type 'KWayland::Server::OutputInterface*' >

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 30092. Kanedias added a comment. - Fix clang compilation - Fix QPointer REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=29434=30092 BRANCH fix-clang REVISION DETAIL https://phabricator.kde.org/D1230