KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Failing!

2018-05-21 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/5/
 Project:
Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 22 May 2018 05:48:01 +
 Build duration:
47 sec and counting
   CONSOLE OUTPUT
  [...truncated 62.67 KB...]JOB_BASE_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'BUILD_DISPLAY_NAME= '#5'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'USER  = 'jenkins'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/5/display/redirect'JENKINS_URL   = 'https://build.kde.org/'QT_SELECT = 'qt5'JOB_NAME  = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'_ = '/usr/local/bin/java'OLDPWD= '/usr/home/jenkins'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.10'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'HUDSON_URL= 'https://build.kde.org/'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/5/display/redirect?page=changes'BUILD_ID  = '5'LANG  = 'en_US.UTF-8'EXECUTOR_NUMBER   = '0'MAIL  = '/var/mail/jenkins'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'SHELL = '/usr/local/bin/bash'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'XDG_CURRENT_DESKTOP   = 'KDE'BLOCKSIZE = 'K'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/5/'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'LOGNAME   = 'jenkins'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'TERM  = 'su'HOME  = '/home/jenkins'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/'MM_CHARSET= 'UTF-8'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/display/redirect'BUILD_NUMBER  = '5'STAGE_NAME= 'Configuring Build'JAVA_HOME = '/usr/local/openjdk8-jre'NODE_NAME = 'FreeBSD Builder 1'SHLVL = '1'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.47.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.47.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.47.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n:

D12973: Workspace KCM Redesign Using Kirigami

2018-05-21 Thread Nathaniel Graham 
ngraham added a comment.


  Looks gorgeous!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12973

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Failing!

2018-05-21 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/8/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 22 May 2018 03:38:36 +
 Build duration:
6 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 64.24 KB...]BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.10-8'NODE_LABELS   = 'FreeBSD Builder 3 FreeBSDQt5.10'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'HOST  = 'freebsd-node3'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'STAGE_NAME= 'Configuring Build'BUILD_DISPLAY_NAME= '#8'XDG_CURRENT_DESKTOP   = 'KDE'SHELL = '/bin/tcsh'SHLVL = '1'MAIL  = '/var/mail/jenkins'HOME  = '/usr/home/jenkins/'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/8/display/redirect'EXECUTOR_NUMBER   = '0'JAVA_HOME = '/usr/local/openjdk8-jre'HUDSON_HOME   = '/home/production/data'BUILD_NUMBER  = '8'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'LANG  = 'en_US.UTF-8'PAGER = 'more'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'JOB_BASE_NAME = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'BLOCKSIZE = 'K'NODE_NAME = 'FreeBSD Builder 3'JENKINS_URL   = 'https://build.kde.org/'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'MACHTYPE  = 'x86_64'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'HUDSON_URL= 'https://build.kde.org/'LOGNAME   = 'jenkins'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins//bin'GROUP = 'jenkins'TERM  = 'su'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/8/display/redirect?page=changes'VENDOR= 'amd'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.47.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.47.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.47.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.47.0") -- Found KF5KIO:

D12974: Workspace KCM Code Improvement

2018-05-21 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> workspaceoptions.cpp:97
> +
> +config->sync();
>  }

We want to batch our syncs to plasmarc, which the old code did better.

I wouldn't bother trying to be clever with checking if it's the original state 
or not here, as KConfig will do all of that for us anyway at a more correct 
lower level.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign Using Kirigami

2018-05-21 Thread Furkan Tokac 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:78cd8bb31ea3: Workspace KCM Redesign Using Kirigami 
(authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12973?vs=34500=34616

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13013: Small fixes for execute_kwallet

2018-05-21 Thread Albert Astals Cid 
aacid updated this revision to Diff 34615.
aacid added a comment.


  free fullSocket

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13013?vs=34570=34615

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

AFFECTED FILES
  pam_kwallet.c

To: aacid, fvogt
Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13013: Small fixes for execute_kwallet

2018-05-21 Thread Albert Astals Cid 
aacid added a comment.


  In D13013#265868 , @fvogt wrote:
  
  > fullSocket was malloc'd by the parent process. free()-ing it is pointless.
  
  
  it's not pointless, it's "unneeded" since the child process will exit on the 
"cleanup" goto and then all its resources should be freed anyway by the OS, 
*but* it is the correct thing to do, the fact that the memory was allocated by 
the parent process doesn't mean the memory still needs freeing in the child 
process too, i.e. fork basically "mallocs" the memory again (simplified version 
of what is happening). Example: at https://paste.kde.org/psqeol0uc

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

To: aacid, fvogt
Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12976: Check cmake _FOUND variables for existance

2018-05-21 Thread Heiko Becker 
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:659ae5f5981c: Check cmake foo_FOUND variables for 
existance (authored by heikobecker).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12976?vs=34464=34611

REVISION DETAIL
  https://phabricator.kde.org/D12976

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #plasma, jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13001: Handle children of added nodes as well

2018-05-21 Thread Fabian Vogt 
fvogt added a comment.


  In D13001#265923 , @lbeltrame 
wrote:
  
  > What's the easiest way to test this? I might just patch the package and see 
what happens.
  
  
  git clone the repo and load an unpacked extension at the /extension 
(deactivate/uninstall the other version first).
  
  You can't really patch a .crx.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13001

To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13001: Handle children of added nodes as well

2018-05-21 Thread Fabian Vogt 
fvogt updated this revision to Diff 34606.
fvogt added a comment.


  We've officially arrived in callback hell.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13001?vs=34531=34606

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13001

AFFECTED FILES
  extension/content-script.js

To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11175: [kstyle] refine shadows

2018-05-21 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 34595.
zzag added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=31810=34595

BRANCH
  refine-shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

2018-05-21 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 34594.
zzag added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=31809=34594

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11198: [libbreezecommon] add box shadow helper

2018-05-21 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 34593.
zzag added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11198?vs=32789=34593

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13022: add workspaceoptions docbook

2018-05-21 Thread Burkhard Lück 
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added projects: Plasma, Documentation.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  in systemsettings it is not possible to find the module 
  containing the single / double click settings using the search field
  but that works in khelpcenter and on docs.kde.org
  -> therefor add a workspaceoptions docbook

TEST PLAN
  checkXML5 doc/kcontrol/workspaceoptions/index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13022

AFFECTED FILES
  doc/kcontrol/CMakeLists.txt
  doc/kcontrol/workspaceoptions/CMakeLists.txt
  doc/kcontrol/workspaceoptions/index.docbook
  kcms/workspaceoptions/kcm_workspace.desktop

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12990: update mouse kcm docbook to 5.13

2018-05-21 Thread Burkhard Lück 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5c1b125ce192: update mouse kcm docbook to 5.13 (authored 
by lueck).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12990?vs=34564=34591

REVISION DETAIL
  https://phabricator.kde.org/D12990

AFFECTED FILES
  doc/kcontrol/mouse/index.docbook

To: lueck, #plasma, #documentation, mart
Cc: ltoscano, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12760: Improve single-instance application behavior

2018-05-21 Thread Alexander Volkov 
volkov closed this revision.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12760

To: volkov, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12960: Drag handle to reorder items in a ListView

2018-05-21 Thread Marco Martin 
mart added a comment.


  In D12960#265012 , @alex-l wrote:
  
  > I tried with arrows too, but I think the fifth one looks better... my 
second choice is the third one.
  >
  > F5858203: immagine.png 
  
  
  i like the 5th more as well, tough the 2nd may be better if there will be the 
just horizontal or just vertical one, so all would have the same style

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

2018-05-21 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13001: Handle children of added nodes as well

2018-05-21 Thread Luca Beltrame 
lbeltrame added a comment.


  What's the easiest way to test this? I might just patch the package and see 
what happens.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13001

To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

2018-05-21 Thread Marco Martin 
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  now became 5.14 for sure, but i think it's safe to go

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-add-to-panel-as-widget-when-theres-a-task-manager (branched from 
Plasma/5.13)

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13001: Handle children of added nodes as well

2018-05-21 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> content-script.js:355
>  mutation.addedNodes.forEach(function (node) {
> -if (node.tagName === "VIDEO" || node.tagName === "AUDIO") {
> -registerPlayer(node);
> -}
> +if (!node.querySelectorAll) return; // Ignore text
> +var players = node.querySelectorAll("video,audio");

`if (typeof node.querySelectorAll !== "function")`
also coding style, add braces

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13001

To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12996: Register players when tab becomes audible

2018-05-21 Thread Kai Uwe Broulik 
broulik abandoned this revision.
broulik added a comment.


  I like Fabian's approach better

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12996

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13001: Handle children of added nodes as well

2018-05-21 Thread Kai Uwe Broulik 
broulik added a subscriber: lbeltrame.
broulik added a comment.


  Sweet!
  
  I think it used to have this but it caused trouble due to DOM traversal with 
complex sites. The old code walked the entire DOM every time whereas you just 
query the node that changed, so shouldn't have that big of an impact as the old 
one did.
  
  @lbeltrame Can you check whether this causes trouble with the massive table 
you had issues with?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13001

To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13015: use explicit_bzero() if it is present

2018-05-21 Thread Rolf Eike Beer 
dakon created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dakon requested review of this revision.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D13015

AFFECTED FILES
  CMakeLists.txt
  pam_kwallet.c

To: dakon
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13013: Small fixes for execute_kwallet

2018-05-21 Thread Fabian Vogt 
fvogt added a comment.


  fullSocket was malloc'd by the parent process. free()-ing it is pointless.

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

To: aacid, fvogt
Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13013: Small fixes for execute_kwallet

2018-05-21 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> pam_kwallet.c:392
>  if (drop_privileges(userInfo) < 0) {
>  syslog(LOG_ERR, "%s: could not set gid/uid/euid/egit for kwalletd", 
> logPrefix);
>  goto cleanup;

fullSocket is not free'd.

> pam_kwallet.c:398
>  if ((envSocket = socket(AF_UNIX, SOCK_STREAM, 0)) == -1) {
> -pam_syslog(pamh, LOG_ERR, "%s: couldn't create socket", logPrefix);
> -return;
> +syslog(LOG_ERR, "%s: couldn't create socket", logPrefix);
> +goto cleanup;

Here also.

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

To: aacid, fvogt
Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Minutes meeting week 21

2018-05-21 Thread Bhushan Shah 
Hello,

Super small meeting due to some people being off for holiday.

Present: notmart, d_ed, romangg, bshah

notmart:

 * some bug triaging
 * more work on list items drag and drop D12960 (just needs icons now)
 * fix kirigami build on macos
 * more work on multi page KCMs
 * early experiments on porting plasma desktop scripting to QJSEngine will be a 
looong lasting side project, involving mostly porting huge chunks of 
boilerplate before it even builds

d_ed:

 - In addition to usual bugs / tiny fixes I've tidied up my date and time KCM 
backend code ready for QtQuick port
 - design discussion here: https://phabricator.kde.org/T7248   it's gone a few 
iterations locally
 - and I've been working on a KConfig patch that should land on frameworks this 
evening that will make it easier to notify other clients of config changes 
(intended for dropping the kdelibs4support kdeglobals signalling) in a much 
tidier and better way


romangg:

 * GSoC mentoring of Furkan on landing the Workspace KCM rewrite to QML in 5.13.
 * moving the single/double click option to it.
 * investigating https://bugs.kde.org/show_bug.cgi?id=386304, which seems to be 
a hell of a bug. I'm currently setting up a Qt build because the bug might 
actually be in Qt.
 * maybe I ask bshah again to help me with it. :)

bshah:

 - Started triaging the plasma mobile phabricator task board
 - Adding details in most of the task so that they are not just title
 - Working with dimkard[m] to make it easier for people to contribute to PlaMo
 - Some part-time KDE sysadmin work this weekend to make our static website 
generation easier
 - Affects plasma-mobile.org
 - Other then mostly non-plasma work

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
15:41  notmart: d_ed: meeting! :)
15:41  notmart: your turn first
15:41  ok
15:41  * some bug triaging
15:41  * more work on list items drag and drop D12820 (just needs 
icons now)
15:41  Diff 12820 "Add KWayland virtual desktop protocol" [Needs 
Review] https://phabricator.kde.org/D12820
15:41  * fix kirigami build on macos
15:41  * more work on multi page KCMs
15:41  * early experiments on porting plasma desktop scripting to 
QJSEngine will be a looong lasting side project, involving mostly porting huge 
chunks of boilerplate before it even builds
15:41  crap, wrong phab
15:42  i mean D12960 the list items drag and drop
15:42  Diff 12960 "Drag handle to reorder items in a ListView" [Needs 
Review] https://phabricator.kde.org/D12960
15:42  that's basically it
15:42  what does multi page KCMs mean?
15:43  d_ed: some of the kcm redesigns in the mockups, have a kind of 
breadcrumb..
15:43  let me find references
15:44  ok, so some sort of stack view within the KCM itself
15:44  https://www.youtube.com/watch?v=sgPa0d-0f1I the preliminary 
implementation
15:44  yep
15:44  cool
15:44  the mockups use that iirc in icons, maybe colors and fonts
15:44  also the network one rewrite by jgrulich is going to rely on 
that
15:45  ok, so I'll go next
15:45  okay, so any questions? if not d_ed turn
15:46  The question is how this integrates with the KCM structure 
itself. Will it be Syse->Category->KCM -//-> Stackview 1 -> Stackview2 ?
15:46  all in one line?
15:46  In addition to usual bugs / tiny fixes I've tidied up my date and 
time KCM backend code ready for QtQuick port
15:46  design discussion here: https://phabricator.kde.org/T7248   it's 
gone a few iterations locally
15:46  Task 7248 "Date/time" [Open,High] {Plasma: KCM Redesign} 
https://phabricator.kde.org/T7248
15:47  looking
15:47  romangg: for old systemsettings would have to be 2 stacks one 
for categories one for the main thing.. in the long term i would like a single 
line yeah
15:48  and I've been working on a KConfig patch that should land on 
frameworks this evening that will make it easier to notify other clients of 
config changes (intended for dropping the kdelibs4support kdeglobals 
signalling) in a much tidier and better way
15:48  phab link?
15:48  sorry, I meant, I should have it ready to submit to review this 
evening
15:49  okay
15:49  :)
15:49  and I'm done
15:49  cool cool
15:49  romangg: your turn!
15:49  d_ed: oooh, <3 for kconfig change signaling :)
15:51  * GSoC mentoring of Furkan on landing the Workspace KCM rewrite 
to QML in 5.13.
15:51  hmm, i never know on phab if comments on screenshots actually 
worked or not.. and they're almost invisible anyways
15:51  * moving the single/double click option to it.
15:52  * investigating https://bugs.kde.org/show_bug.cgi?id=386304, 
which seems to be a hell of a bug. I'm currently setting up a Qt build because 
the bug might actually be in Qt.
15:52  * maybe I ask bshah again to help me with it. :)
15:53  later today I mean
15:53  any questions?
15:53  with "it".. here it being?
15:54  getting my Qt build to work. It didn't really work for me when 
I tried this weekend.
15:54  ah qt build...

D13013: Small fixes for execute_kwallet

2018-05-21 Thread Albert Astals Cid 
aacid created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Don't return on error conditions, exit instead. It's a child process we
  need to finish it
  Don't use pam_syslog, there's a comment at the beginning saying it
  doesn't work, it seems to kind of work for me but some investigation by
  Matthias Gerstner seems to show it's doing funny things with the fds
  so don't use it.

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

AFFECTED FILES
  pam_kwallet.c

To: aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13012: Activity switcher auto-hide when using Meta-Tab

2018-05-21 Thread Thomas Surrel 
thsurrel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Commit 174aa217180434ab93b899d9c7cf967bd2daff7e 
 
created a new
  issue where the activity switcher would not hide anymore when
  switching activities with the Meta-Tab global shortcut and
  releasing the keys under one second.
  
  This patch fixes this by unconditionnal toggling the activity
  switcher visibility if it should be hidden, but keeping the
  timestamp condition before showing it, so that both Meta-q and
  Meta-Tab behaves correctly.
  
  BUG: 393912

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13012

AFFECTED FILES
  desktoppackage/contents/views/Desktop.qml

To: thsurrel
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2018-05-21 Thread David Edmundson 
davidedmundson added a comment.


  Please also fill in the testing done field.

INLINE COMMENTS

> tooltip.cpp:162
> +dlg->SetAutoShowHide(m_autoShowHide);
> +connect(dlg, :.containtsMouseChanged, this, 
> ::toolTipWindowContainsMouseChangedSlot);
>  dlg->setVisible(true);

doing a connect inside show() probably isn't what you want, you'll connect 
multiple times.

Also that signal name has a typo

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10305

To: lshoravi, #plasma, #plasma_accessibility, mart, aacid
Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, 
ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12991: Ensure the salt file is indeed a regular file

2018-05-21 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12991

To: aacid, fvogt, mgerstner
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2018-05-21 Thread Albert Astals Cid 
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  The code doesn't merge, and after fixing that manually that the code doesn't 
build because you're doing
  
  dlg->SetAutoShowHide(m_autoShowHide);
  
  and the S is wrong

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10305

To: lshoravi, #plasma, #plasma_accessibility, mart, aacid
Cc: kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, ragreen, Pitel, 
michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart, #frameworks

D12990: update mouse kcm docbook to 5.13

2018-05-21 Thread Burkhard Lück 
lueck updated this revision to Diff 34564.
lueck added a comment.


  add note where to find the setting for click behavior in 5.13

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12990?vs=34506=34564

REVISION DETAIL
  https://phabricator.kde.org/D12990

AFFECTED FILES
  doc/kcontrol/mouse/index.docbook

To: lueck, #plasma, #documentation
Cc: ltoscano, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12991: Ensure the salt file is indeed a regular file

2018-05-21 Thread Albert Astals Cid 
aacid updated this revision to Diff 34563.
aacid added a comment.


  free path

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12991?vs=34508=34563

BRANCH
  arcpatch-D12991

REVISION DETAIL
  https://phabricator.kde.org/D12991

AFFECTED FILES
  pam_kwallet.c

To: aacid, fvogt, mgerstner
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart