D13013: Small fixes for execute_kwallet

[Anthony Fieroni]

anthonyfieroni added a comment.


  It's ok to me.

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

To: aacid, fvogt
Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13051: Fix Font KCM force font DPI checkbox

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Fixes numerous issues:
  
  1. the default behaviour had changed. It should disable force font DPI,
  
  not set it to 96
  
  2. disabling didn't work, we'd set the value to 0, which would update
  
  the spinbox, which has a minimum which sets the value to 96 (we were
  warned of this with a binding loop error)
  
  3. toggling the checkbox didn't enable the apply button
  
  New code fixes that and is more declarative too.
  
  BUG: 394180

TEST PLAN
  Toggled, reset to defaults, restarted

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13051

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13050: Allow typing in font DPI spinbox

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise keyboard use is hard, this fixes a regression that we could no
  longer select DPIs that weren't intervals of 24

TEST PLAN
  Ran, typed

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13050

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13049: It turns out the flickable in a scrollview is the contentItem

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  Discover, the gallery still work

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13049

AFFECTED FILES
  org.kde.desktop/ScrollView.qml

To: apol, #kirigami
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12982: Make the new KCMs with QtQuick translatable

[Albert Astals Cid]

aacid added a comment.


  Plasma people any hint of what are your preferences on fixing this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano
Cc: aacid, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13013: Small fixes for execute_kwallet

[Albert Astals Cid]

aacid added a comment.


  @fvogt @anthonyfieroni happy with this new revision?

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

To: aacid, fvogt
Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

[Nathaniel Graham]

ngraham added a comment.


  @lshoravi are you willing and able to address the above-mentioned issues, or 
should someone else comandeer the revision and do it themselves?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10305

To: lshoravi, #plasma, #plasma_accessibility, mart, aacid
Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, 
ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13012: Activity switcher auto-hide when using Meta-Tab

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13012

To: thsurrel, mart, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick updated this revision to Diff 34671.
croick marked an inline comment as done.
croick added a comment.


  - check size of socket path

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=34670=34671

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/queryptrace.cpp
  src/queryptrace.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks
Cc: maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13012: Activity switcher auto-hide when using Meta-Tab

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Nice fix. Works for me too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13012

To: thsurrel, mart, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick marked 6 inline comments as done.
croick added a comment.


  Thank you for your comments, totally forgot about licensing.

INLINE COMMENTS

> maximilianocuria wrote in queryptrace.cpp:26
> Please honour TMPDIR or, even better, use QTemporaryDir (this will also make 
> the generated path unpredictable), and create the socket inside.

QTemporaryDir will not work, since the location is set in KCrash.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick updated this revision to Diff 34670.
croick added a comment.


  - add license text
  - use `QDir::tempPath()`
  - ifdefs to definition

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=30979=34670

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/queryptrace.cpp
  src/queryptrace.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks
Cc: maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13015: use explicit_bzero() if it is present

[Albert Astals Cid]

aacid accepted this revision.
aacid added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> pam_kwallet.c:181
>  
> -size_t len;
> +size_t len = strlen (str);
> +#if HAVE_EXPLICIT_BZERO

make it const?

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D13015

To: dakon, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Oleg Chernovskiy]

Kanedias added a comment.


  @jgrulich @alexeymin  please review new framebuffer approach
  
  This is the first draft of the implementation. I intend to add more features 
and fix review comments in the process.
  
  Missing features:
  
  - Only knows about first screen for now
  - Doesn't fail if D-Bus is unavailable
  - Read-only

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin
Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D13030: Always display brightness OSD even when at maximum

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great for me! @broulik?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13030

To: thsurrel, ngraham
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 34665.
Kanedias edited the summary of this revision.
Kanedias added a comment.


  Rewrite everything from scratch with Pipewire connectivity in mind

REPOSITORY
  R437 Desktop Sharing

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6096?vs=15147=34665

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6096

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindPipeWire.cmake
  cmake/modules/FindSPA.cmake
  framebuffers/CMakeLists.txt
  framebuffers/pipewire/CMakeLists.txt
  framebuffers/pipewire/krfb_framebuffer_pw.json
  framebuffers/pipewire/pw_framebuffer.cpp
  framebuffers/pipewire/pw_framebuffer.h
  framebuffers/pipewire/pw_framebufferplugin.cpp
  framebuffers/pipewire/pw_framebufferplugin.h
  framebuffers/pipewire/xdp_dbus_interface.xml

To: Kanedias, davidedmundson, graesslin
Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362830

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D13031: [ProcessModel] Center more column headings

[Nathaniel Graham]

ngraham added a comment.


  +1 from me.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D13031

To: broulik, #plasma
Cc: ngraham, alex-l, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

[Furkan Tokac]

furkantokac updated this revision to Diff 34656.
furkantokac added a comment.


  .qrc file is cancelled.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12974?vs=34652=34656

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: mart, davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Eike Hein]

hein added a comment.


  > The purpose of this patch was to simply hide the standalone launcher 
functionality a little
  
  Isn't it more than "a little" though? What other way to add apps to the panel 
now remains other than DND, which many people never attempt?
  
  > Hmm, I don't see them in git master or in any other version of Plasma that 
I've ever used.
  
  A bug maybe?
  
[eike@ehl1 ~/devel/src/kde/workspace/plasma-workspace/applets/icon 
(arcpatch-D12069) 5]$ grep -inR jump *
iconapplet.cpp:304:m_jumpListActions.clear();
iconapplet.cpp:323:m_jumpListActions << action;
iconapplet.cpp:375:actions << m_jumpListActions;
iconapplet.h:71:void jumpListActionsChanged(const QVariantList 
);
iconapplet.h:92:QList m_jumpListActions;

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Nathaniel Graham]

ngraham added a comment.


  In D12969#266528 , @hein wrote:
  
  > Widget-based launchers do have jump lists, fwiw
  
  
  Hmm, I don't see them in git master or in any other version of Plasma that 
I've ever used.
  
  F5864058: No jump list.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Eike Hein]

hein added a comment.


  Widget-based launchers do have jump lists, fwiw

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13042: Do not show activity switcher during fast switches

[Thomas Surrel]

thsurrel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  When using the keyboard global shortcut to switch quickly between
  two activities, it does not make sense to start showing the activity
  switcher, as it does not have time to show completely and just
  flickers on the left side.
  
  This patch modifies the timing when the activity switcher is shown
  and when the activity is actually switched. It makes switching
  quickly between two activities snappier. If the user has to search
  between more activities, the bottleneck will likely not be the
  small delay before showing the activity switcher.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13042

AFFECTED FILES
  imports/activitymanager/switcherbackend.cpp

To: thsurrel
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Nathaniel Graham]

ngraham added a comment.


  The idea was that nobody who uses a task manager would actually want to 
create launchers instead of pinning their apps to it. Perhaps that was not 
totally true, but with Christian's patch, I think it can become even more true, 
because the patch addresses the case where someone wants the app's icon to 
never move or disappear once launched.
  
  If we deleted pinned Task Manager app items in favor of launcher widgets we 
would lose some of the current functionality provided by pinned TM apps:
  
  - Jump lists in context menu
  - Ability to remove the icon when an instance is open in the Task Manager
  - Ability to re-order or remove even when widgets are locked
  
  With an Icons-Only Task Manager, there's even less of a reason to remove the 
pinned apps concept because they are arbitrarily re-orderable.
  
  But that said, I don't think we can remove standalone launchers entirely. 
It's totally fine functionality, so long as you don't get it mixed up with what 
the Task Manager does. The purpose of this patch was to simply hide the 
standalone launcher functionality a little bit so that people who want it have 
to go out of their way to get it, instead of getting confused when they pin 
some apps, and create launchers for others, and have no idea why the two don't 
behave the same.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Christian]

Fuchs added a comment.


  In D12969#266503 , @hein wrote:
  
  >
  
  
  
  
  > In that case I would honestly argument for dropping Task Manager pinning 
entirely: I've never entirely liked that it complicates the Task Manager toward 
doing multiple things, and that makes it have to contend with having 
different-sized items, and that means launchers aren't just straight-forward 
panel items that can be moved anywhere (this gets a lot of user bug reports too 
btw).
  
  Oof. As a user of icon-only task manager I heavily rely on pinned tasks, as 
they work great for muscle memory and otherwise the task manager is just an 
empty waste of space. 
  And I don't think it's only a lack of feature parity, if you have launchers 
and a task manager you end up with two entries if the application is running, 
and for icon-only task manager both of them will look almost the same  (except 
the little bar showing it is a window).
  
  Personally I'd rather get rid of the launcher widget thing, since this is 
also what Windows does and, as far as I am aware, what Mac OS does (I don't use 
a Mac, but I think the dock there is mostly this)
  
  I assume this is one of the areas where lot of people have different 
workflows  (i.e. I would never use the "icon only" thing I wrote myself, but 
multiple people asked for it and it seems to greatly improve their efficiency) 
and thus we have loads of options. 
  Personally I am in favour of keeping most of them if possible, just with sane 
defaults and also (more) sane ways of accessing them.
  
  So I would prefer some discussion and mind-mapping before throwing more 
patches at it, as this will spread the discussion over various places.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12974: Workspace KCM Code Improvement

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> resources.qrc:1
> +
> +

I don't want this kcm done differently from all the others, i want  all modules 
using the same structure, on disk

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: mart, davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Eike Hein]

hein added a comment.


  > And personally I consider pinning to be activity dependant way more 
complicated than having both options to pin and have a launcher
  
  I'm also very unhappy with this hyper-complicated context menu. It made it in 
because everyone was getting impatient on this feature being merged after it 
took many cycles, but I said at the time I would like the context menu to be 
treated as placeholder and overhauled/simplified later. Particularly the UX of 
unpinning is so difficult with all these checkboxes.
  
  > Christian's patch allows pinned Task Manager icons to be always visible, 
yeah.
  
  But it also has a behavior change for running apps (which I am personally not 
a huge fan of because it complicates the system, but the argument that it could 
finally get apps out of the tray is somewhat compelling).
  
  > That's just a recipe for confusion, and it feels very expert-friendly, but 
not very average-user-friendly.
  
  In that case I would honestly argument for dropping Task Manager pinning 
entirely: I've never entirely liked that it complicates the Task Manager toward 
doing multiple things, and that makes it have to contend with having 
different-sized items, and that means launchers aren't just straight-forward 
panel items that can be moved anywhere (this gets a lot of user bug reports too 
btw).
  
  Except people want dock-like behavior for the launcher-to-window lifecycle.
  
  That's how we arrived at this duality.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12974: Workspace KCM Code Improvement

[Furkan Tokac]

furkantokac updated this revision to Diff 34652.
furkantokac added a comment.


  Changes are done according to feedbacks. For detailed information,
  please check the commit message.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12974?vs=34499=34652

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/resources.qrc
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, ngraham, romangg, #plasma
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Scott Harvey]

sharvey added a comment.


  As a side note, usage of the terms "kicker" and/or "kickoff" aren't 
user-friendly at all. They're basically internal names and aren't mentioned in 
any user-facing text. I'm not trying to hijack the issue; this is just one of 
those barriers to entry we should try to knock down for newcomers.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Nathaniel Graham]

ngraham added a comment.


  Christian's patch allows pinned Task Manager icons to be always visible, 
yeah. However, if we merge that but reject this, IMHO the situation becomes 
even more confusing for the average user. I think we really need to focus on 
the "Simple by default" side of the equation a bit more here. Presenting two 
subtly different ways to accomplish essentially the same thing--and putting 
them adjacent to each other in the UI--is just not a "Simple by default" UI, I 
think. That's just a recipe for confusion, and it feels very expert-friendly, 
but not very average-user-friendly.
  
  If this patch isn't the way to go, I can accept that, but then I think we'd 
need to try to focus on reducing the confusion regarding launcher widgets vs 
pinned apps in another way.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12974: Workspace KCM Code Improvement

[Furkan Tokac]

furkantokac marked 8 inline comments as done.
furkantokac added inline comments.

INLINE COMMENTS

> davidedmundson wrote in workspaceoptions.cpp:97
> We want to batch our syncs to plasmarc, which the old code did better.
> 
> I wouldn't bother trying to be clever with checking if it's the original 
> state or not here, as KConfig will do all of that for us anyway at a more 
> correct lower level.

Nice point. I tested the situation for the old code. When I just change 
single/double click option, other option files (plasmarc) are not opened. That 
means KConfig handles the situation. Thank you. Correction will be done now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Christian]

Fuchs added a comment.


  Maybe we need to discuss things, especially also with 
https://phabricator.kde.org/D12463 where I have an interest in, on a broader 
scale.
  
  I agree that both need to exist and have different use cases, personally I 
think I'd only show the task manager pin in the context menu though, since the 
widgets are likely to be used by power users and placed manually where wanted.
  
  Note that I am only somewhat happy with the task manager pinning as well, 
since in task manager you are forced to choose which activities it shall be 
pinned on, whilst in the context menu of kicker you only have the possibility 
to pin it to all of them. 
  (And personally I consider pinning to be activity dependant way more 
complicated than having both options to pin and have a launcher)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Eike Hein]

hein added a comment.


  > That's disappointing to hear and a bit frustrating considering that it 
never came up in the Bugzilla ticket I filed months 3 ago
  
  I've never seen that ticket because it was filed against the wrong component 
and I wasn't CC'd on it. Making sure the relevant maintainer is in the loop is 
a good way to get feedback early and avoid frustration.
  
  > the patch was approved by one Plasma developer
  
  This should be a lesson that a random "code looks good" accept doesn't always 
get patches in. If you don't have that expectation it also helps with 
frustration.
  
  > In my bug triaging and online user support, I encounter many people being 
confused by the distinction between panel launchers and pinned Task Manager 
icons.
  
  Good, we should fix that. Not by taking features away people many like and 
rely on, though. And I know they do, because I too have interacted with users 
over the many years I've worked on the related features. Many users don't like 
launchers that disappear when launched because it conflates two things they 
regard as unrelated. This is e.g. why the Quick Launch applet is popular, too, 
because a lot of people don't realize there's "Add to Panel" and think Quick 
Launch is the only way to get this behavior.
  
  A possible way forward would be a combo of this patch and a new "Always show" 
checkbox for TM launchers, but without some more work this means one additional 
setup step for people who want persistent launchers. TM launchers also have 
more constrains placed on them on where on the panel you can move them, which 
is also a problem this wouldn't fix. I'm therefore not really happy with this 
proposal. I guess it needs more discussion and thought.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Nathaniel Graham]

ngraham added a comment.


  That's disappointing to hear and a bit frustrating considering that it never 
came up in the Bugzilla ticket I filed months 3 ago, and the patch was approved 
by one Plasma developer and not objected to by another. Can I try to explain my 
reasoning before we revert it?
  
  In my bug triaging and online user support, I encounter //many// people being 
confused by the distinction between panel launchers and pinned Task Manager 
icons. With the default settings (task manager on panele and unlocked widgets), 
Kicker/Kickoff's context menus show options for creating both. And they are 
similar, but not exactly identical:
  
  - Both live in the same part of the panel by default
  - Pinned apps become Task Manager buttons when launched; launcher widgets 
don't
  - Pinned apps display jump lists; launcher widgets don't
  - Pinned apps can be removed when widgets are locked; launcher widgets can't
  - Icon sizes and scaling policy differs between pinned apps and launcher 
widgets
  
  To someone like you or me, these differences may be useful, because we 
understand them. To an average user, it just seems like a UI papercut. "Why are 
there two ways to do the same thing?" they initially wonder. Later on, as 
stumble across the differences (often by adding a launcher and then wondering 
why it doesn't have a jump list or turn into a Task Manager button when 
launched), they wonder "Why are these things so similar to one another? Why 
bother to have both?" I've seen a lot of people complain that launcher widgets 
seem like crippled versions of pinned launchers.
  
  Again, //you// understand why both exist and what each one is good for. But 
to an average user, only one is needed, depending on the context. Otherwise we 
just confuse people. As such, I think keeping this patch not only fixes a 
usability issue, but also fixes a source of Bugzilla tickets, user support 
requests, and feelings of confusion about Plasma being "Too complex". Before 
this patch, it was not "Simple by default". With this patch, we reduce the 
confusion and regain "Simple by default", but retain "complex when needed" 
because technically adept users like us can still add launcher widgets whose 
properties and traits we understand via the other methods.
  
  Does that make sense? I'm happy to clarify anything!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12928: Make Apply/Discard settings prompt consistent with rest of settings

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R101:ac133254b761: Make Apply/Discard settings prompt 
consistent with rest of settings (authored by broulik).

REPOSITORY
  R101 KHotKeys

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12928?vs=34292=34638

REVISION DETAIL
  https://phabricator.kde.org/D12928

AFFECTED FILES
  kcm_hotkeys/kcm_hotkeys.cpp

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Eike Hein]

hein added a comment.


  I veto this patch, sorry. These are different features and they're both 
intended to be there. Task Manager pinning is not a replacement for permanent 
launchers.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma, mart
Cc: hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12957: Show focus rect when CheckBox or RadioButton are focused

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=33681939bde3dbe46ceb225e615ba92d8420db9a

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D12957

To: broulik, #plasma, #vdg, mart, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Maximiliano Curia]

maximilianocuria added inline comments.

INLINE COMMENTS

> queryptrace.cpp:26
> +server.sun_family = AF_UNIX;
> +sprintf(server.sun_path, "/tmp/kcrash_%lld", 
> QCoreApplication::applicationPid());
> +if (::connect(sfd, (struct sockaddr *), sl) == 0) {

Please honour TMPDIR or, even better, use QTemporaryDir (this will also make 
the generated path unpredictable), and create the socket inside.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Adriaan de Groot]

adridg added a comment.


  Comments directed at licensing and non-Linux cases.

INLINE COMMENTS

> queryptrace.cpp:1
> +#include 
> +

Missing file header / license bits

> queryptrace.cpp:49
> +
> +#endif

For non-Linuxen, include a null implementation here.

> queryptrace.h:1
> +#ifndef QUERYPTRACE_H
> +#define QUERYPTRACE_H

Missing a file header / license bits

> queryptrace.h:5
> +#ifdef Q_OS_LINUX
> +void queryPtrace(long long pid);
> +#else

You used qint64 elsewhere

> queryptrace.h:7
> +#else
> +#define queryPtrace(x)
> +#endif

In general, and for type safety, I'd avoid using #ifdefs to define an API. 
There should probably be **only** the one declaration of queryPtrace.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: adridg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in workspaceoptions.cpp:97
> We want to batch our syncs to plasmarc, which the old code did better.
> 
> I wouldn't bother trying to be clever with checking if it's the original 
> state or not here, as KConfig will do all of that for us anyway at a more 
> correct lower level.

For the sync yes.

For checking state: the old code wrote always all values to the config file, 
with or without the user changing them at all. It might make sense to only 
write config values which have been explicitly changed by the user, because 
this would mean that we can later on change the default of values of this user 
which have never been explicitly changed by the user before with an update of 
just the KCM code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13031: [ProcessModel] Center more column headings

[Alessandro Longo]

alex-l added a comment.


  Please provide screenshots when tagging VDG

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D13031

To: broulik, #plasma, #vdg
Cc: alex-l, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

[Thomas Surrel]

https://bugs.kde.org/show_bug.cgi?id=362830

Thomas Surrel  changed:

   What|Removed |Added

 CC||thomas.sur...@protonmail.co
   ||m

--- Comment #6 from Thomas Surrel  ---
I'm going to try to implement that. My idea is that the steps when pressing the
brightness buttons should not be linear. It should be tiny steps when getting
close to 0 and larger steps when getting higher because when you need a bright
screen in sunlight, having fine grain brightness adjustment does not make much
sense whereas when you are in the dark, even small increases of brightness make
a difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D13031: [ProcessModel] Center more column headings

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Also horizontally center TTY, Relative Start Time, and CPU Time.
  Those are typically narrow columns and so should be horizontally centered 
like the others.
  
  BUG: 394467
  FIXED-IN: 5.12.6

TEST PLAN
  The column headings are centered now.
  Only Name (which is all the way to the left by default) and Command and 
Window Title (which are typically at the right and wide) are left-aligned now

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D13031

AFFECTED FILES
  processui/ProcessModel.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13001: Handle children of added nodes as well

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:0db2416dc351: Handle children of added nodes as well 
(authored by fvogt).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13001?vs=34606=34625

REVISION DETAIL
  https://phabricator.kde.org/D13001

AFFECTED FILES
  extension/content-script.js

To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13030: Always display brightness OSD even when at maximum

[Thomas Surrel]

thsurrel marked an inline comment as done.
thsurrel added inline comments.

INLINE COMMENTS

> broulik wrote in powerdevilupowerbackend.cpp:406
> Can we be sure that the `currentBrightness` is always up-to-date? We must 
> still be able to force a new brightness if the hardware forgot to tell us or 
> changed it outside our realm of influence

I removed the condition since it does not bring much value anyway.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13030

To: thsurrel
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13030: Always display brightness OSD even when at maximum

[Thomas Surrel]

thsurrel updated this revision to Diff 34624.

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13030?vs=34622=34624

REVISION DETAIL
  https://phabricator.kde.org/D13030

AFFECTED FILES
  daemon/powerdevilbrightnesslogic.cpp

To: thsurrel
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13030: Always display brightness OSD even when at maximum

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> powerdevilupowerbackend.cpp:406
>  
> -setBrightness(newBrightness, controlType);
> +if (newBrightness != currentBrightness) {
> +setBrightness(newBrightness, controlType);

Can we be sure that the `currentBrightness` is always up-to-date? We must still 
be able to force a new brightness if the hardware forgot to tell us or changed 
it outside our realm of influence

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13030

To: thsurrel
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13030: Always display brightness OSD even when at maximum

[Thomas Surrel]

thsurrel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  When the brightness is already at the maximum value, hitting
  the keyboard shortcut to increase it does not bring up the OSD,
  there is no visual feedback. This is not consistent either with
  the audio volume which handles this correctly.
  
  BUG: 387284

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13030

AFFECTED FILES
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/powerdevilbrightnesslogic.cpp

To: thsurrel
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart