D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey added a comment. F5865966: Screenshot_20180523_223641.png Two quick injections of `units.smallSpacing` for margins and we have a nice sleek display with no overlap. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34767. sharvey added a comment. - Add `units.smallSpacing` as margins around search bar row REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34761=34767 BRANCH new-search-row (branched from master)

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. Got the chance to test this out. Functionally, it works great, and resolves the issue! Visually, I can understand you guys's hesitation about bringing the arrows back, because they do seem to lack that //je-ne-sais-quoi//, somehow. I wonder if the arrow might

[kio-extras] [Bug 369520] FISH: directories are mistaken for files and vice-versa

https://bugs.kde.org/show_bug.cgi?id=369520 --- Comment #2 from Emmett Culley --- After doing some more testing I found that this issue happens only on certain servers. Connecting to any of the server on my LAN seems to work OK. Also one remote server I've been using

[kio-extras] [Bug 369520] FISH: directories are mistaken for files and vice-versa

https://bugs.kde.org/show_bug.cgi?id=369520 Emmett Culley changed: What|Removed |Added CC|

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey added a comment. Should ‘someAmazingValue’ be an explicit number (like (x) pixels), or something like ‘units.smallValue’ (or whatever the correct syntax is)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson,

D12855: Move Widget search field to its own row so it doesn't get compressed

davidedmundson added a comment. Much nicer > what's the most-correct and most-effective QML method to add a bit of padding around these elements? if you're using anchors, which I think is the case here TextField { anchors.top: topBar.bottom anchors.topMargin:

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added a comment. F5865709: Screenshot_20180523_180214.png @davidedmundson (and/or others) - what's the most-correct and most-effective QML method to add a bit of padding around these elements? I

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > davidedmundson wrote in WidgetExplorer.qml:275 > This is all a bit weird. > > This searchBarContainer is 0 px tall as it's not set to be the size of the > children. which is why you need to do that

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34761. sharvey marked an inline comment as done. sharvey added a comment. - Merge branch 'master' into new-search-row - Revise QML using relative sizing & spacing instead of fixed values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12974: Workspace KCM Code Improvement

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:de742972bf31: Workspace KCM Code Improvement (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES

D13079: use a consistent style to handle fork()

aacid added inline comments. INLINE COMMENTS > pam_kwallet.c:441 > +switch (pid) { > +case 0: > +break; This construct makes the code harder to read imho, previously it was clear that the parent (i.e. pid != 0) was being exited and the child (outside the if) left to live, now

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. I don't object to your proposal per se, but I don't think it goes far enough to address the need here. Let me give you a specific example I'm familiar with: I recently submitted a patch (https://phabricator.kde.org/D13026) to fix a functional problem with Kate's

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. In D10297#266823 , @gregormi wrote: > @rkflx: Hi Henrik, I resolved all your code remarks. Could you look it over and give a go to have this landed. Thanks, I noticed your update, but I've been busy (sorry). I hope

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

abetts added a comment. In D13064#267368 , @ngraham wrote: > In D13064#267358 , @hpereiradacosta wrote: > > > Should we also add a symbol on icons to say that they are non-dangerous ? (even if not

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. In D13064#267358 , @hpereiradacosta wrote: > Should we also add a symbol on icons to say that they are non-dangerous ? (even if not a menu ?) In fact, we already do signal danger by using red icons for

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. In D13064#267357 , @abetts wrote: > In D13064#267356 , @ngraham wrote: > > > 'Fraid I gotta disagree with you on this one, @abetts. I think it's important to signal

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. I really don't understand the fear factor and unknown action argument. There are tooltips, possibly text alongside (or below icon), and the icon itself. Also, if you have to fear what an application might do to the point that you will only click on menus and

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

abetts added a comment. In D13064#267356 , @ngraham wrote: > 'Fraid I gotta disagree with you on this one, @abetts. I think it's important to signal that these buttons will bring up a menu because without that, there is no way to distinguish it

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

ngraham added a comment. 'Fraid I gotta disagree with you on this one, @abetts. I think it's important to signal that these buttons will bring up a menu because without that, there is no way to distinguish it from an ordinary action button. It's the same reason why comboboxes have arrows

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

abetts added a comment. In D13064#267117 , @hpereiradacosta wrote: > I am not particularly excited by the change, because on how it breaks the spacing between buttons in a toolbar. > I am also not completely convinced that it is important to

D13015: use explicit_bzero() if it is present

This revision was automatically updated to reflect the committed changes. Closed by commit R107:1f8707c4e114: use explicit_bzero() if it is present (authored by dakon). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13015?vs=34752=34753

D13079: use a consistent style to handle fork()

dakon created this revision. dakon added a reviewer: aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dakon requested review of this revision. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL

D13015: use explicit_bzero() if it is present

dakon updated this revision to Diff 34752. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13015?vs=34573=34752 REVISION DETAIL https://phabricator.kde.org/D13015 AFFECTED FILES CMakeLists.txt pam_kwallet.c To: dakon, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13030: Display brightness OSD even when min and max is reached

thsurrel updated this revision to Diff 34751. thsurrel retitled this revision from "Always display brightness OSD even when at maximum" to "Display brightness OSD even when min and max is reached". thsurrel edited the summary of this revision. thsurrel added a comment. This revision is now

D13013: Small fixes for execute_kwallet

This revision was automatically updated to reflect the committed changes. Closed by commit R107:84dbc30f99de: Small fixes for execute_kwallet (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13013?vs=34615=34748#toc REPOSITORY R107 KWallet PAM Integration CHANGES

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34742. hein marked 3 inline comments as done. hein added a comment. - Consistently use isEmpty(). - Make intro to comment less ambiguous. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13073?vs=34741=34742

D13073: Weigh matching services by relating data used in query to their menuids

hein marked 3 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in tasktools.cpp:374 > `isEmpty` (unless consistent with the rest but it seems to be mixed already) Will change. > broulik wrote in tasktools.cpp:228 > This comment makes it sound like this

D13073: Weigh matching services by relating data used in query to their menuids

broulik added a comment. Fine in principle, surely adds less complexity than my weird rewriting stuff that also just attempted to fix Chrome :D INLINE COMMENTS > tasktools.cpp:374 > // The appId looks like a path. > -if (appId.startsWith(QStringLiteral("/"))) { > +

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34741. hein added a comment. Remove forgotten QDebug include. Thanks to @cfeck, who I now know is just as anal about include collation as I am. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D13073: Weigh matching services by relating data used in query to their menuids

cfeck added inline comments. INLINE COMMENTS > tasktools.cpp:45 > #include > +#include > #include Can be removed? If not, sort correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13073 To: hein, broulik, davidedmundson Cc: cfeck, plasma-devel,

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34740. hein added a comment. Optimize common case. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13073?vs=34739=34740 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13073 AFFECTED FILES

D13073: Weigh matching services by relating data used in query to their menuids

hein added a comment. I'll add that KServiceTypeTrader doesn't offer any facilities for weighing. KService has a `KService::initialPreference()` but that seems only useful when sorting services for a MIME type by prioirty (and I'd guess it's maybe also used for KCM sorting?) and isn't

D13073: Weigh matching services by relating data used in query to their menuids

hein created this revision. hein added reviewers: broulik, davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The overall mission of TaskTools::windowUrlFromMetadata is to use various pieces of metadata to run

D13062: Don't manipulate foreign windows

graesslin accepted this revision. graesslin added a comment. Please as bugfix to 5.12 branch. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D13062 To: broulik, #plasma, davidedmundson, graesslin Cc: graesslin, plasma-devel,

D13071: [Klipper] Port aways from KLineEdit

cfeck created this revision. cfeck added reviewers: Plasma, graesslin. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY Klipper does not use completion features, so port to QLineEdit. REPOSITORY

Re: Plasma Vaults by Default

On domenica 20 maggio 2018 17:28:08 CEST Ivan Čukić wrote: > Hi Jonathan, > > One possibility is to hide the icon if the user does not use Vaults (if the > user has no vaults configured) similar to how the pager applet behaves. how one would add one then? should it be visible but in the systray

D13070: [libtaskmanager] Add missing QUrlQuery includes

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13070 To: cfeck, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13070: [libtaskmanager] Add missing QUrlQuery includes

cfeck created this revision. cfeck added reviewers: Plasma, hein. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY Found by removing KDELibs4Support from CMakeLists.txt REPOSITORY R120 Plasma

D7087: Add "Copy Info" button to the About System KCM

ngraham added inline comments. INLINE COMMENTS > Module.cpp:250 > +if (!ui->nameVersionLabel->isHidden()) { > +text += i18n("%1 %2", QStringLiteral("Distro:"), > ui->nameVersionLabel->text()) + QStringLiteral("\n"); > +} Is "Distro" not a translated string? REPOSITORY R102

D13069: [Task Manager] Fix URL comparison

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f7516196cfa4: [Task Manager] Fix URL comparison (authored by broulik, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13060: Add mappings for VirtualBox

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b2206d16c155: Add mappings for VirtualBox (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13060?vs=34709=34730 REVISION DETAIL

D13058: Remove legacy Wine hack-around from rules rc.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:30654e2158c4: Remove legacy Wine hack-around from rules rc. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13058?vs=34702=34729

D13069: [Task Manager] Fix URL comparison

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY You cannot compare to `null` but to empty string. This was

D13058: Remove legacy Wine hack-around from rules rc.

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. kcmshell5 still shows proper icon and some Wine apps I tested also work fine, however wine notepad is just as broken as before REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12

D12536: [timer applet] Change how time is tracked

broulik added a comment. I think a C++ part should be added using `QElapsedTimer` and then a display update timer REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12536 To: mmazur, #plasma, davidedmundson Cc: broulik, ngraham, davidedmundson, plasma-devel,

D13068: Filter out incognito tabs and media controls on Firefox

broulik created this revision. broulik added reviewers: Plasma, fvogt, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Chrome doesn't run extensions in incognito

D12536: [timer applet] Change how time is tracked

ngraham added a comment. Fixed in D13065 ; this can be Abandoned. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12536 To: mmazur, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D13065: [Timer applet] Fix double speed countdown & commands run multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit R114:6ce58880151d: [Timer applet] Fix double speed countdown commands run multiple times (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

[Solved]: Switchuser Issue

Hi, just for completeness, fvogt helped on #plasma to resolve the issue: this seems to cause the issue https://bugs.gentoo.org/644718#c0 This fixes the problem https://github.com/sddm/sddm/pull/1010/files Rainer Am Dienstag, 15. Mai 2018, 17:26:03 CEST schrieb Rainer Dorsch: > Hi, > > small

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. I am not particularly excited by the change, because on how it breaks the spacing between buttons in a toolbar. I am also not completely convinced that it is important to convey the information that a menu will open when you press on the button (because you

D12855: Move Widget search field to its own row so it doesn't get compressed

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > WidgetExplorer.qml:275 > +// full width borrowed from panel definition > +width:

D13065: [Timer applet] Fix double speed countdown & commands run multiple times

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R114 Plasma Addons BRANCH fixtimerdoublecount REVISION DETAIL https://phabricator.kde.org/D13065 To: kossebau, #plasma, davidedmundson Cc:

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta added a comment. How it looks for the sorting button in Open dialog: F5865249: Screenshot_20180523_172606.png Gwenview "share" button: F5865251: Screenshot_20180523_172825.png

D13065: [Timer applet] Fix double speed countdown & commands run multiple times

kossebau added a comment. Patch is against 5.12 branch. Sadly does not apply cleanly against 5.13 & master, blame me for code brush up since then... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13065 To: kossebau, #plasma Cc: plasma-devel, ragreen, Pitel,

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta updated this revision to Diff 34723. hpereiradacosta added a comment. Removed unrelated change REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13064?vs=34720=34723 BRANCH master-toolbuttons REVISION DETAIL

D13065: [Timer applet] Fix double speed countdown & commands run multiple times

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Both the compact and the fullpresentation variants of the

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

hpereiradacosta created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hpereiradacosta requested review of this revision. REVISION SUMMARY As discussed in bug 344746 this helps identifying which toolbuttons will trigger

D13030: Always display brightness OSD even when at maximum

thsurrel planned changes to this revision. thsurrel marked an inline comment as done. thsurrel added a comment. I think we should do the same thing for the other side of the spectrum: when hitting the minimum value, we should still show the OSD as well. On my laptop, the screen turns

D13063: distro release upgrade checker for ubuntu distros

jriddell added a comment. Note this still has a bunch of qDebugs to be removed before merge and the QTimer is changed to 5 seconds from 5 minutes which needs also to be reverted before merge REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13063 To:

D13063: distro release upgrade checker for ubuntu distros

jriddell created this revision. jriddell added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jriddell requested review of this revision. REVISION SUMMARY Kubuntu and KDE neon have not got their act together for

D12974: Workspace KCM Code Improvement

romangg accepted this revision. romangg added a comment. Looks good to me. Only commit to master branch please. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12974 To: furkantokac, ngraham, romangg, #plasma, mart Cc: mart, davidedmundson, zzag,

D13062: Don't manipulate foreign windows

broulik updated this revision to Diff 34712. broulik added a comment. - Remove accidental coding style change REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13062?vs=34711=34712 REVISION DETAIL

D13062: Don't manipulate foreign windows

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN I noticed that Chrome's window had the property

D12982: Make the new KCMs with QtQuick translatable

ltoscano added a comment. In D12982#267013 , @davidedmundson wrote: > > Please also note that, if supporting a different name for the translation catalog would mean changing something in Frameworks,... > > Relevant parts are: > > .pot

D12982: Make the new KCMs with QtQuick translatable

davidedmundson added a comment. > Please also note that, if supporting a different name for the translation catalog would mean changing something in Frameworks,... Relevant parts are: .pot needs to match TRANSLATION_DOMAIN for C++ code .pot needs to match

D13042: Do not show activity switcher during fast switches

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13060: Add mappings for VirtualBox

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Patch works perfectly for me. Thanks so much for the quick fix, Eike! REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13060 To:

D13060: Add mappings for VirtualBox

hein added a comment. It's still the same in the VirtualBox packaged in Fedora 28. The alleged fix is six months old though and I don't know their release cycle. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13060 To: hein, broulik, davidedmundson Cc:

D13060: Add mappings for VirtualBox

hein added a comment. https://www.virtualbox.org/ticket/12534 claims this got fixed upstream, but apparently we still have users stuck on affected VirtualBox versions. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13060 To: hein, broulik, davidedmundson

D13060: Add mappings for VirtualBox

hein created this revision. hein added reviewers: broulik, davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:394610 REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12 REVISION DETAIL

D12982: Make the new KCMs with QtQuick translatable

ltoscano added a comment. Please also note that, if supporting a different name for the translation catalog would mean changing something in Frameworks, I think that this patch would be the correct way to fix 5.13. Nevertheless this use case should be fixed afterwards so that 5.14 could

D12982: Make the new KCMs with QtQuick translatable

ltoscano added a comment. Libs connected to KCMs or other libraries part of Plasma? About the latter, I don't recall relevant case of renamings/reshuffling, so probably no need. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12982 To: yurchor, #plasma,

D12982: Make the new KCMs with QtQuick translatable

mart added a comment. In D12982#266967 , @ltoscano wrote: > We already had changes in the structure of kcm, and I prefer the names to be future-proof. > > > Besides, we already have some versioned names, so this use case should be

D12982: Make the new KCMs with QtQuick translatable

ltoscano added a comment. We already had changes in the structure of kcm, and I prefer the names to be future-proof. Besides, we already have some versioned names, so this use case should be supported. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13054: SwipeItem: Fix using QRC resources and custom image providers.

broulik added inline comments. INLINE COMMENTS > desktopicon.cpp:440 > +// QRC paths are not correctly handled by .path() > +if (iconId.size() >=2 && iconId.left(2) == QLatin1String("/:")) > +iconId = iconId.remove(0, 1); `startWith()` avoids creating a temporary

D13059: Only enable on XCB

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Wayland version has a new KCM BUG: 394548

D12982: Make the new KCMs with QtQuick translatable

hein added a comment. What's the point of "kcm5"? kcm_translations.pot matches the package and .so names, which is nice and neat. Why does the pot need to be more versioned, is there a namespace conflict with KDE4? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13058: Remove legacy Wine hack-around from rules rc.

hein added a comment. I was a bit worried my latest change could break the case of kcmshell setting KCM .desktop files (which are NoDisplay), but on X11, this is done via a window hint we evaluate directly in XWindowsTasksModel (bypassing TaskTools) and in any case it's set to a path, which

D13049: It turns out the flickable in a scrollview is the contentItem

This revision was automatically updated to reflect the committed changes. Closed by commit R858:681b8fba260d: It turns out the flickable in a scrollview is the contentItem (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D13058: Remove legacy Wine hack-around from rules rc.

hein updated this revision to Diff 34702. hein added a comment. It turns out Wine installs its Windows Program Loader as a wine.desktop file, which is useful to "Open With" .exe files, but means if Wine doesn't set a WM_CLASS that we can find a .desktop file by StartupWMClass for, we map

D13049: It turns out the flickable in a scrollview is the contentItem

apol updated this revision to Diff 34701. apol added a comment. Include a test for item views REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13049?vs=34677=34701 BRANCH master REVISION DETAIL

D13058: Remove legacy Wine hack-around from rules rc.

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. [12:26] Sho_: what happens with this patch and an old wine? [12:28] d_ed: the result should be the same. because ManualOnly is a vestige from old libtm, but the new

D13058: Remove legacy Wine hack-around from rules rc.

hein created this revision. hein added reviewers: broulik, davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY After we improved our StartupWMClass handling we worked with Wine in

D13054: SwipeItem: Fix using QRC resources and custom image providers.

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > desktopicon.cpp:440 > +// QRC paths are not correctly handled by .path() > +if (iconId.size() >=2 && iconId.left(2) == QLatin1String("/:")) > +

D13042: Do not show activity switcher during fast switches

thsurrel planned changes to this revision. thsurrel added a comment. Good point. I had a look, the timeout is set at 90ms by default. But it is configurable (DelayTime), should I try to read the kwin configuration value or can we just go with 90ms ? REPOSITORY R119 Plasma Desktop

D13051: Fix Font KCM force font DPI checkbox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b2694cfc64de: Fix Font KCM force font DPI checkbox (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13051?vs=34679=34697#toc REPOSITORY R119 Plasma Desktop

D13050: Allow typing in font DPI spinbox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2ba367d576aa: Allow typing in font DPI spinbox (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13050?vs=34678=34696 REVISION

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

On Sat, May 19, 2018 at 4:15 PM, Ben Cooksley wrote: > Hi all, > > If someone could please check if this is correct, and whether Plasma Vault > is intended to be built outside of Linux systems? > *Ping* > > Regards, > Ben > > > On Sat, May 19, 2018 at 9:30 AM, CI System

D13051: Fix Font KCM force font DPI checkbox

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in main.qml:222 > `when: dpiSpinbox.enabled`? I want to set it explicitly to 0 when we're not enabled. Two Bindings with two when statements would work, but that seems more complex. REPOSITORY R119 Plasma Desktop

D13051: Fix Font KCM force font DPI checkbox

broulik added inline comments. INLINE COMMENTS > main.qml:222 > +property: "fontAASettings.dpi" > +value: dpiSpinBox.enabled ? dpiSpinBox.value : 0 > +} `when: dpiSpinbox.enabled`? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13042: Do not show activity switcher during fast switches

broulik added a comment. +1 This is the same as KWin does with Alt+Tab, can you check what timeout it uses so we can be consistent here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: broulik, plasma-devel,

D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture

bshah added a comment. Is there any reason this was submitted without being accepted? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D13056 To: jgrulich, broulik, fvogt Cc: bshah, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture

fvogt added a comment. This would work for openSUSE as well (currently we do a manual mv in our .spec file), but I think it might break Debian and Debian-based. IIRC it doesn't use /usr/lib// there, but /usr/lib/ directly. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:d115fea3cb23: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64… (authored by jgrulich).

D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY According to documentation, this location is expected to be either /usr/lib or /usr/lib64. It

D13054: SwipeItem: Fix using QRC resources and custom image providers.

lepagevalleeemmanuel created this revision. lepagevalleeemmanuel added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. lepagevalleeemmanuel requested review of this revision. REVISION SUMMARY This patch does 2 things.

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. @rkflx: Hi Henrik, I resolved all your code remarks. Could you look it over and give a go to have this landed. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein

D7087: Add "Copy Info" button to the About System KCM

gregormi added a comment. @ngraham , @rkflx, @dhaumann: Do you have any more suggestions to this? I think it is now ready to land. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, dhaumann Cc: rkflx, dhaumann, ltoscano, sebas,