D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. As for wanting to making this non-scrollable: in general, we should aspire for the main views of our KCMs to never require scrolling (subviews like tables are okay, of course). It's very awkward to able to scroll a UI that's packed full of UI controls. It can even

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. "Speed profile" sounds weird (in English, at least). For now, let's go with: Pointer speed: -I-- Acceleration profile: (o) Flat ( ) Adaptive REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:94 > +enabled: touchpadCount > 1 > +//Layouts.Layout.fillWidth: true > +implicitWidth: units.gridUnit * 10 This will go if nobody tells me it is necessary. I couldn't find any use case that this

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. @romangg There are some "TODO"s in the code. Please tell me if they still need to be applied so I'll do them, if they are not, I'll remove them. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#268853 , @ngraham wrote: > Is the user-facing control for the click method (areas or clickfinger) going to come in a separate patch? It might make sense to add

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. In general much nicer! Is the user-facing control for the click method (areas or clickfinger) going to come in a separate patch? It might make sense to add that feature first and then we can do all the UI review in a single patch. Why is "acceleration

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 34950. furkantokac added a comment. Comment correction. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=34949=34950 BRANCH kcmtouchpad-kirigamidesign REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:466 > +} // END Kirigami.FormLayout > +} // END KCM.SimpleKCM This comment will be changed as "END Kirigami.ScrollablePage" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REVISION SUMMARY Touchpad KCM is redesigned in Kirigami. Tested in Wayland+Libinput and Xorg+Libinput.

D13111: Activate next task in group on shortcut

mvourlakos closed this revision. mvourlakos added a comment. applied with: https://cgit.kde.org/latte-dock.git/commit/?id=79df6cbe2cca6d612a2102ae60bbf30965295423 REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D13111 To: lholecek, mvourlakos Cc: plasma-devel,

D12982: Make the new KCMs with QtQuick translatable

yurchor updated this revision to Diff 34932. yurchor added a comment. Normalized to Luigi's scheme. May not work. Please test at least for English (default). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12982?vs=34475=34932 REVISION DETAIL

D13042: Do not show activity switcher during fast switches

This revision was automatically updated to reflect the committed changes. Closed by commit R119:13ae9edb85ca: Do not show activity switcher during fast switches (authored by thsurrel, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Closing old Plasma 4 bugs

Hello, Just to remind you that companies using KDE/Plasma on RHEL7 are still using plasma 4. I don't know if it has an impact but in case I wanted to point it out. Cheers, Olivier Le samedi 26 mai 2018, 05:09:06 CEST Nate Graham a écrit : > Kubuntu 18.04 has now now been out for a month, so

Re: Closing old Plasma 4 bugs

Yes, in fact I work for a company some of whose employees and customers use RHEL 7 (and 6, and 5, believe it or not...). In the end, I don't think it's relevant to us. KDE Plasma 4 wasn't the default shell in any of these distros anyway, so we are talking about an inherently old, niche use

D12982: Make the new KCMs with QtQuick translatable

ltoscano added a comment. Should I create a bug/task somewhere to track the work needed to fix this properly, where we can discuss about the proper solution? (fix in kdeclarative?) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12982 To: yurchor, #plasma,

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

> In regards to NetworkManagerQt, that is unavailable as > NetworkManager itself isn't available on FreeBSD. Ok, didn't know that. NM will be an optional dep once I get to it (probably not in the next release). I guess after that PV will be buildable again on BSD. Cheers, Ivan -- KDE,

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

On Sat, May 26, 2018 at 8:29 PM, Ivan Čukić wrote: > Hi all, Hi Ivan, > > I was on a trip. > > P-V is meant to be linux-only. If someone to make it work on BSD, I'm open > to that. > > Though, it seems like a missing dep only - Could NOT find KF5 (missing: >

D12982: Make the new KCMs with QtQuick translatable

davidedmundson accepted this revision. davidedmundson added a comment. > I think that this patch would be the correct way to fix 5.13. From Luigi is good enough for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12982 To: yurchor, #plasma,

D7087: Add "Copy Info" button to the About System KCM

rkflx added a comment. @dhaumann Your status is still set to "Requesting changes" and thus blocks the patch from landing, but as far as I can see the general concern has been resolved. See inline comment for a question concerning the implementation. @gregormi After re-reading all

D12982: Make the new KCMs with QtQuick translatable

yurchor added a comment. I have no idea what to do with all the suggestions and cannot test the required changes. For sure, I can formally change *.cpp, CMakeLists.txt and Messages.sh, but it can break the KCMs to the state that they will not be able to function even in English. May it

Re: Plasma Vaults by Default

Yes, that is what I meant. Cheers, Ivan On Wed, May 23, 2018 at 7:14 PM Marco Martin wrote: > On domenica 20 maggio 2018 17:28:08 CEST Ivan Čukić wrote: > > Hi Jonathan, > > > > One possibility is to hide the icon if the user does not use Vaults (if the > > user has no

D13042: Do not show activity switcher during fast switches

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Looks ok to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot,

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

Hi all, I was on a trip. P-V is meant to be linux-only. If someone to make it work on BSD, I'm open to that. Though, it seems like a missing dep only - Could NOT find KF5 (missing: NetworkManagerQt) I'll skip commenting other parts of this discussion. Cheers, Ivan

D13123: Make .deb and .rpm mime type handling optional at build time

arojas updated this revision to Diff 34908. arojas added a comment. Check for the presence of the dpkg and rpm binaries to decide whether to install the mime type handlers REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13123?vs=34887=34908

D13119: Abort transaction on PK dependency resolution error

This revision was automatically updated to reflect the committed changes. Closed by commit R134:ee8e49422118: Abort transaction on PackageKit errors (authored by arojas). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13119?vs=34886=34907