D13202: Circular user avatar for Kickoff

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Looks great now! Quite pleasing to the eye. I've got a few blockers though: - When I change the icon in the user-manager KCM and re-open Kickoff, the new icon isn't

D13183: Use Control.palette

apol updated this revision to Diff 35154. apol added a comment. Make sure that the right palette is defined at all times REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13183?vs=35117=35154 BRANCH master REVISION DETAIL

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35151. sharvey added a comment. - Whitespace once more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35150=35151 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL

D13202: Circular user avatar for Kickoff

sharvey marked 2 inline comments as done. sharvey added a comment. F5876367: Screenshot_20180529_180924.png Best yet, I think. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, #plasma

D13202: Circular user avatar for Kickoff

sharvey marked 4 inline comments as done. sharvey added inline comments. INLINE COMMENTS > davidedmundson wrote in Header.qml:76 > needed? Not anymore. I thought your ShaderEffect just drew circles. I didn't catch on that it rounded off an image and then added a border. This probably helped

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35150. sharvey added a comment. - Remove redundant `OpacityMask`; tweaked antialiasing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35139=35150 BRANCH round-kickoff-avatar (branched from master)

D13186: Use HiddenStatus when keyboard indicator is inactive

arojas added a comment. Right, I guess if someone disables everything on the config there's no way to reenable them in systray-embedded mode (well, removing and readding the applet will reset the config, but that's not obvoius) REPOSITORY R114 Plasma Addons REVISION DETAIL

D13202: Circular user avatar for Kickoff

davidedmundson added inline comments. INLINE COMMENTS > Header.qml:76 > + > + OpacityMask { > + anchors.fill: squareFace needed? > Header.qml:102 > +hideSource: true > +live: false > +} because this is false, we need to force

D13202: Circular user avatar for Kickoff

abetts added a comment. In D13202#270530 , @sharvey wrote: > In D13202#270529 , @abetts wrote: > > > It doesn't look any different to me. They are both the same. Maybe the screenshot is too small? I

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#270529 , @abetts wrote: > It doesn't look any different to me. They are both the same. Maybe the screenshot is too small? I can see the pixels from far on both images. Yeah, the same to me as well. The

D13202: Circular user avatar for Kickoff

abetts added a comment. In D13202#270528 , @sharvey wrote: > AA option not set > F5875999: Screenshot_20180529_131810.png > > AA option set > F5876003: Screenshot_20180529_155151.png

D13202: Circular user avatar for Kickoff

sharvey added a comment. AA option not set F5875999: Screenshot_20180529_131810.png AA option set F5876003: Screenshot_20180529_155151.png Does the second option look dramatically better or different?

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Thanks Nate. If your screen does not turn on while passing from 0 to 2, than this patch is in trouble ... Could you tell me at what value your screen does turn on for the first time, starting from 0 (by writing values directly in /sys/class/backlight//brightness)

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

romangg added inline comments. INLINE COMMENTS > broulik wrote in LockScreenUi.qml:72 > How about > > cursorShape: uiVisible ? Qt.ArrowCursor : Qt.BlankCursor The problem was that I first had to move the mouse to enter the MouseArea. I.e. when the Screenlocker is activated by timer the

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#270496 , @ngraham wrote: > Cool! But in your latest screenshot, the circle is aliased pretty badly I noticed. Dave's code specifically says it'll be drawn antialiased. There's also an antialiasing

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

abetts added a comment. In D13192#270517 , @ngraham wrote: > While that's true, it would represent a significant change to the interaction pattern. I'm not totally against it, but I think we should try out the triangle filter here first and see

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

ngraham added a comment. While that's true, it would represent a significant change to the interaction pattern. I'm not totally against it, but I think we should try out the triangle filter here first and see if that's good enough. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13202: Circular user avatar for Kickoff

ngraham added a comment. Cool! But in your latest screenshot, the circle is aliased pretty badly REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, #plasma Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot,

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

abetts added a comment. In D13192#270492 , @ngraham wrote: > If we removed the hover interactivity, I would want to see the buttons' appearance become distinctly more button-like or tab-like so that people can figure out that they're clickable.

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

broulik added inline comments. INLINE COMMENTS > LockScreenUi.qml:72 > > MouseArea { > id: lockScreenRoot How about cursorShape: uiVisible ? Qt.ArrowCursor : Qt.BlankCursor REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13207 To: romangg,

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

ngraham added a comment. If we removed the hover interactivity, I would want to see the buttons' appearance become distinctly more button-like or tab-like so that people can figure out that they're clickable. But honestly I don't mind the hover effect right now. Is there any particular

D13207: [lookandfeel/lockscreen] Hide cursor on fade out

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY With the new lockscreen fade out effect the mouse cursor was

D13206: Add context property to hide cursor

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Allows QML part to hide cursor and let it reappear. TEST PLAN

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

abetts added a comment. Could a different approach work here? No change on hover, but just on click? The user controls the entire action. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13192 To: hein, ngraham, davidedmundson, rkflx, cfeck Cc: abetts, zzag,

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35139. sharvey added a comment. - Whitespace (again...) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35138=35139 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL

D13202: Circular user avatar for Kickoff

sharvey added a comment. I stuck with @davidedmundson 's use of `PlasmaCore.ColorScope.textColor` for the highlight ring. I tested it with a few different color themes and the whole thing comes out looking like a natural match. This shot is back to my personal choice of an openSUSE scheme.

D13202: Circular user avatar for Kickoff

sharvey added a comment. > If you copy and paste the ShaderEffect from UserDelegate.qml colorBorder is a property you can change {icon thumbs-up} Very nice bit of code. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey,

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35138. sharvey added a comment. - Add theme-colored ring around avatar REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35132=35138 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL

D12990: update mouse kcm docbook to 5.13

lueck added a comment. backported to 5.13 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12990 To: lueck, #plasma, #documentation, mart Cc: lbeltrame, bshah, ltoscano, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai,

D13022: add workspaceoptions docbook

lueck added a comment. backported to 5.13 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13022 To: lueck, #plasma, #documentation, yurchor Cc: bshah, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg,

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. @abetts This ticket was closed and replaced with a newer patch. Please read up on a discussion before commenting! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, abetts, hein Cc: rkflx, hein, cfeck,

D13202: Circular user avatar for Kickoff

davidedmundson added a comment. > The bordered avatars are done in a different manner than this (mine involves less math!). I'll see if there's a way I can sort it out. If you copy and paste the ShaderEffect from UserDelegate.qml colorBorder is a property you can change REPOSITORY

D13202: Circular user avatar for Kickoff

abetts added a comment. In D13202#270398 , @sharvey wrote: > > The one visual improvement I could think of is adding a thin light gray outline around the circle to help separate it from the background. This is done on the login and lock

D13202: Circular user avatar for Kickoff

ngraham added a comment. Yes, always a theme-specific color please! "Light gray" was just for illustration purposes. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, #plasma Cc: plasma-devel, abetts, ragreen, Pitel,

D13202: Circular user avatar for Kickoff

sharvey added a comment. > The one visual improvement I could think of is adding a thin light gray outline around the circle to help separate it from the background. This is done on the login and lock screens; might be able to mine those implementations for ideas, if it's not too hard. But

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes updated this revision to Diff 35133. murillobernardes added a comment. Update based on your comments. The MacOS elif is the same as the else, so I removed. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13148?vs=35049=35133 REVISION

D13202: Circular user avatar for Kickoff

abetts added a comment. In D13202#270391 , @ngraham wrote: > Nice work! Will test it out later today. > > There's no reason to have the appearance user-selectable, IMHO. Part of the goal here is a consistent visual appearance. I vote for

D13202: Circular user avatar for Kickoff

ngraham added a comment. Nice work! Will test it out later today. There's no reason to have the appearance user-selectable, IMHO. Part of the goal here is a consistent visual appearance. I vote for always showing the round avatar and marking this as fixing Bug 386656. The one

D13202: Circular user avatar for Kickoff

sharvey added a comment. I intentionally didn't tag Bug 386656 , as it has some debate allowing the user to select between a round or square avatar. @ngraham voted for the circle, which is what I implemented. If we want it switchable, I'll add a

D13202: Circular user avatar for Kickoff

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, plasma-devel Cc: abetts, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13202: Circular user avatar for Kickoff

sharvey added a comment. F5875550: Screenshot_20180529_113110.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: sharvey, ngraham, hein, plasma-devel Cc: ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35132. sharvey added a comment. - Remove whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35131=35132 BRANCH round-kickoff-avatar (branched from master) REVISION DETAIL

D13202: Circular user avatar for Kickoff

sharvey created this revision. sharvey added reviewers: ngraham, hein, plasma-devel. Restricted Application added a project: Plasma. sharvey requested review of this revision. REVISION SUMMARY Apply circular `OpacictyMask` to crop square user avatar into a circle TEST PLAN - Download & apply

D13185: Make the string 'No touchpad found' translatable

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9c5d8bfd66a4: Make the string No touchpad found translatable (authored by yurchor). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13185?vs=35073=35127

D13199: Move updateDevice to private class

nicolasfella created this revision. nicolasfella added a reviewer: drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN KDE Connect volume control still works REPOSITORY R994

D12937: Drop privileges when reading the salt file

dakon added a comment. Nice. Now only the fread() return code needs to be handled and it is perfect. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D12937 To: aacid, dakon Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot,

D11848: [Kickoff] Reduce hover delay before switching tabs

abetts added a comment. Could a different approach work here? No change on hover, but just on click? The user controls the entire action. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, abetts, hein Cc: rkflx, hein, cfeck,

D13183: Use Control.palette

mart added a comment. In D13183#270171 , @apol wrote: > In D13183#270156 , @mart wrote: > > > to not break all custom kirigami color set, i think by default all controls in the desktop style should

D13183: Use Control.palette

apol updated this revision to Diff 35117. apol added a comment. Only get the palette if there's such a property REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13183?vs=35071=35117 BRANCH master REVISION DETAIL

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

zzag added inline comments. INLINE COMMENTS > FullRepresentation.qml:439 > +// pointer motion vector. > +if ((Math.abs(dx) + Math.abs(dy)) > > Qt.styleHints.startDragDistance) { > +if (tabBar.currentTab != button) { I believe it's possible to reduce

D13194: Use the new drag handle in the Language KCM

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY WIP. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D13183: Use Control.palette

mart added inline comments. INLINE COMMENTS > apol wrote in kquickstyleitem.cpp:716 > In which case will it be a wrong palette? We are reading a Control property, > it's not really optional. m_control comes from any qquickitem, so it's not a given that will be a qqc2 control instance

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35109. hein added a comment. Moar correctness. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35105=35109 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13192 AFFECTED FILES

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in FullRepresentation.qml:438 > that's normal length. > > Manhattan would be dx+dy > > As in the distance to walk to another place in the city using only roads in a > block shaped city such as Manhattan. abs(dx) +

D12960: Drag handle to reorder items in a ListView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:c6f88c7d504d: Drag handle to reorder items in a ListView (authored by mart). REPOSITORY R169 Kirigami CHANGES

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 35107. mart added a comment. - proper version - use handle icon REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34430=35107 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35105. hein added a comment. Fix typo. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35104=35105 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13192 AFFECTED FILES

D13187: Move "click" and "double click" keywords from Mouse to Workspace KCM

lueck added a comment. +1 from german translation team REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13187 To: broulik, #plasma, #localization Cc: lueck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35104. hein added a comment. Fix a comment, being in a rush due to store closing times is bad :-). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35102=35104 BRANCH master REVISION DETAIL

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35102. hein added a comment. Fix Manhattan distance calc and add a comment. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35100=35102 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13192

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

davidedmundson added inline comments. INLINE COMMENTS > FullRepresentation.qml:438 > +var dy = (mouse.y - oldPos.y); > +var manhattanLength = Math.sqrt(dx * dx + dy * dy); > + that's normal length. Manhattan would be dx+dy As in the distance to walk to another place

D13193: Rename kcm_input to kcm_mouse

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY This KCM provides settings for mouse only. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.13

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35100. hein added a comment. Don't forget updating oldPos in one case. Sorry for the noise, should be good to review now. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35099=35100 BRANCH master

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35099. hein added a comment. Remove unused variable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35097=35099 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13192 AFFECTED FILES

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35097. hein edited the summary of this revision. hein added a comment. Add bug number to message. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35096=35097 BRANCH master REVISION DETAIL

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. Now superseded by D13192 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, abetts, hein Cc: rkflx, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein created this revision. hein added reviewers: ngraham, davidedmundson, rkflx, cfeck. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY D11848 started out with the aim to remove the delay on Kickoff

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269989 , @ngraham wrote: > Here's another idea for the multi-tapping radio button to reduce the string length: > > Two-finger tap: (o) Right-click (three-finger tap to middle-click) >

D13183: Use Control.palette

apol added a comment. In D13183#270156 , @mart wrote: > to not break all custom kirigami color set, i think by default all controls in the desktop style should be binded to Kirigami.Theme.palette > or the colorset, complementary areas gets

D13183: Use Control.palette

apol added inline comments. INLINE COMMENTS > mart wrote in kquickstyleitem.cpp:716 > it should check if that proeprty is valid and if managed to get an > intelligible qpalette out of it In which case will it be a wrong palette? We are reading a Control property, it's not really optional.

D13183: Use Control.palette

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. to not break all custom kirigami color set, i think by default all controls in the desktop style should be binded to Kirigami.Theme.palette or the colorset, complementary areas gets

D13186: Use HiddenStatus when keyboard indicator is inactive

apol added a comment. How would one configure it if it's hidden? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13186 To: arojas, apol Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13183: Use Control.palette

mart added inline comments. INLINE COMMENTS > kquickstyleitem.cpp:716 > +if (m_control) { > +m_styleoption->palette = > m_control->property("palette").value(); > +} else { it should check if that proeprty is valid and if managed to get an intelligible qpalette out of it

D13182: Use Mnemonics on the toolbar buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4e6bafa39eb8: Use Mnemonics on the toolbar buttons (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13182?vs=35067=35093 REVISION DETAIL

D13107: Add Settings class to API documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R169:23453233fddd: Add Settings class to API documentation (authored by davidedmundson). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13107?vs=34854=35094 REVISION

D13148: Allow Kirigami build without KWin tablet mode dependency

davidedmundson added a comment. If we have an defined(KIRIGAMI_USE_DBUS) we don't need to put if (!APPLE && ..) in the code which would be much much cleaner. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc:

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. almost there :) since there is also a qmake mode to build for embedded, where dbus should be disabled as well, I would prefer to flip the logic. so, have a KIRIGAMI_ENABLE_DBUS which is undefined by default (so nothing to do in the .pri file) but having it defined

D13188: Respect libdir for Firefox native messaging host manifest

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R856 Plasma Browser Integration BRANCH Plasma/5.13

D13187: Move "click" and "double click" s keywords

broulik updated this revision to Diff 35077. broulik retitled this revision from "[Workspace KCM] Add "click" and "double click" as keywords" to "Move "click" and "double click" s keywords". broulik added a comment. - Remove from mouse kcm REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D13186: Use HiddenStatus when keyboard indicator is inactive

broulik added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13186 To: arojas, apol Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13187: [Workspace KCM] Add "click" and "double click" as keywords

broulik created this revision. broulik added reviewers: Plasma, Localization. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This way a user searching for "click" will find the

D13186: Use HiddenStatus when keyboard indicator is inactive

arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY This way it doesn't take space in the systray popup or in the panel

D13185: Make the string 'No touchpad found' translatable

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Making previously //erroneously// untranslated strings translatable is always allowed, they're not "new strings" as far as this rule is concerned REPOSITORY R119 Plasma Desktop