D13148: Allow Kirigami build without KWin tablet mode dependency

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:f5cd75acadf4: Allow Kirigami build without KWin tablet mode dependency (authored by murillobernardes, committed by

D13148: Allow Kirigami build without KWin tablet mode dependency

apol added a comment. In D13148#271691 , @murillobernardes wrote: > Sorry, first time contributing to kde-related project. > > I’m not sure what I need to do next? Send a pull request somewhere? No, you just would land the patch. I'm

D13237: Show action.main more prominently on the ToolBarApplicationHeader

apol updated this revision to Diff 35296. apol added a comment. Remove property, only assign the palette if there's a palette property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13237?vs=35255=35296 BRANCH master REVISION DETAIL

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a comment. In D7038#265444 , @graesslin wrote: > any update on this? Currently I'm working on other stuff and don't want to increase the mental load. I really only need this when looking again into sub-surfaces to handle

D13255: Make dependency on KF5NetworkManagerQt optional

asturmlechner added a comment. (this is me forwarding a Gentoo user contribution) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13255: Make dependency on KF5NetworkManagerQt optional

asturmlechner created this revision. asturmlechner added reviewers: Plasma, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH Plasma/5.13

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes added a comment. Sorry, first time contributing to kde-related project. I’m not sure what I need to do next? Send a pull request somewhere? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc:

D13240: Fix wrong full form of acronym SMB in kinfocenter docbook

This revision was automatically updated to reflect the committed changes. Closed by commit R102:f40ba4b48f34: Fix wrong full form of acronym SMB in kinfocenter docbook (authored by lueck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY Adds a checkbox and changes the filter of the ListView models. REPOSITORY R115 Plasma

D13237: Show action.main more prominently on the ToolBarApplicationHeader

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PrivateActionToolButton.qml:62 > > -flat: true > +palette.button: control.kirigamiAction ? > control.kirigamiAction.icon.color : undefined > +

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc: davidedmundson, plasma-devel, apol, mart, hein

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

davidedmundson accepted this revision. davidedmundson added a comment. Would be good if we can make this a more generic component in future, but we should land this as-is first. REPOSITORY R119 Plasma Desktop BRANCH kickoff_triangle_filter REVISION DETAIL

D13194: Use the new drag handle in the Language KCM

hein updated this revision to Diff 35260. hein added a comment. Drop height and anchors as per Marco's advise. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13194?vs=35249=35260 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13194

D13240: Fix wrong full form of acronym SMB in kinfocenter docbook

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added projects: Plasma, Documentation. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY

D13237: Show action.main more prominently on the ToolBarApplicationHeader

mart added inline comments. INLINE COMMENTS > ToolBarApplicationHeader.qml:105 > showText: !parent.toobig > +mainButton: true > } can just assign flat: false instead of adding a new property in actiontoolbutton? REPOSITORY R169 Kirigami

D13237: Show action.main more prominently on the ToolBarApplicationHeader

apol updated this revision to Diff 35255. apol added a comment. Address some typos and added nate's margin REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13237?vs=35254=35255 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13237 AFFECTED

D13237: Show action.main more prominently on the ToolBarApplicationHeader

apol added a comment. In D13237#271434 , @ngraham wrote: > Love it! Two issues that I can see: > > - In this example, the text really needs to be white; it doesn't show up well against the dark green background. If the color is

D13237: Show action.main more prominently on the ToolBarApplicationHeader

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Love it! Two issues that I can see: - In this example, the text really needs to be white; it doesn't show up well against the dark green background. If the color is

D13237: Show action.main more prominently on the ToolBarApplicationHeader

apol added a comment. F5880995: greenbutton.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13237 To: apol, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Show it as a full button instead of a tool button. Use the icon

D13194: Use the new drag handle in the Language KCM

hein updated this revision to Diff 35249. hein added a comment. Reference correct variable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13194?vs=35247=35249 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13194 AFFECTED FILES

D13194: Use the new drag handle in the Language KCM

hein updated this revision to Diff 35247. hein added a comment. Uncheck sheet list items when the sheet is closed. This now has to be done explicitly as the delegates no longer get destroyed with the use of a DelegateRecycler. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13233: Support for the Custom color set

davidedmundson added inline comments. INLINE COMMENTS > plasmadesktoptheme.cpp:177 > + > +QPalette pal; > +for (auto state : { QPalette::Active, QPalette::Inactive, > QPalette::Disabled }) { I don't understand this part of the patch in relation to custom color set support.

D13233: Support for the Custom color set

mart added a comment. F5880598: image.png REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D13233 To: mart, #kirigami, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13233: Support for the Custom color set

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY In some scenarios, some applications need certain areas with completely

D13232: introduce Custom color set

mart added a comment. F5880591: image.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13232 To: mart, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D13232: introduce Custom color set

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY In some scenarios, some applications need certain areas with