D13194: Use the new drag handle in the Language KCM

hein added a comment. The other two are currently still needed: - Without the parenting, the sheet doesn't show up at all. - Without setting the width on the DelegateRecycler (which you told me was necessary, and it seems to be true!) the delegates in the sheet aren't full width so

D13194: Use the new drag handle in the Language KCM

hein updated this revision to Diff 35814. hein added a comment. Remove width from RowLayout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13194?vs=35260=35814 BRANCH arcpatch-D13194 REVISION DETAIL https://phabricator.kde.org/D13194

D13194: Use the new drag handle in the Language KCM

hein added inline comments. INLINE COMMENTS > mart wrote in main.qml:77 > this explicit reparenting shouldn't be necessary (and breaks in my branch for > multi level kcms) I've told you a few times now that it's been necessary for me so far, since the sheet doesn't appear or in bizarre

D13372: Mouse KCM Redesign Using Kirigami

furkantokac marked an inline comment as done. furkantokac added a comment. Please test the code and if everyone is happy, I'll push the code. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: mart, plasma-devel,

D13372: Mouse KCM Redesign Using Kirigami

furkantokac marked an inline comment as done. furkantokac added inline comments. INLINE COMMENTS > mart wrote in main.qml:31 > KCM.SimpleKCM This is not based on KConfigModule yet so it is not okay to convert it to SimpleKCM since it'll look for "kcm" reference from the backend but will not be

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35809. furkantokac added a comment. Update V0.2 Page is converted to ScrollablePage. ExclGroupBox converted to RadioButton since the titling is issue with ExclGroupBox + ScrollablePage. Middle-click title is updated. REPOSITORY R119 Plasma

D13390: Fonts KCM: Fix text readability regression

rkflx updated this revision to Diff 35808. rkflx edited the summary of this revision. rkflx edited the test plan for this revision. rkflx added a comment. Okay, great. Thanks for investigating! I now changed to what you proposed, so we have something for 5.13.1. REPOSITORY R119 Plasma

D13357: Use logging categories in a few dataengines

rikmills added a comment. Build errors with this: https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/44/console https://build.neon.kde.org/job/bionic_unstable_kde_plasma-workspace/102/ https://kci.pangea.pub/job/cosmic_unstable_plasma-workspace/

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added a comment. In D13415#275567 , @ngraham wrote: > I encounter the very same issue as in D13202 : Changing the Avatar in System Settings results in a blank circle in Kickoff. Here's a clue though:

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey added inline comments. INLINE COMMENTS > ngraham wrote in Header.qml:96 > I think I might prefer a lighter color than this. Perhaps the window > alternate background color? As soon as I get it working reliably and not showing blank circles...! REPOSITORY R119 Plasma Desktop

D13367: Improve the clarity and presentation of the update details text field

ngraham added a comment. Before landing this, I'd still prefer a quick test from anyone not using an Ubuntu-based distro to make sure that the strings still make sense. Thanks! REPOSITORY R134 Discover Software Store BRANCH clearer-update-text (branched from master) REVISION DETAIL

D13367: Improve the clarity and presentation of the update details text field

ngraham updated this revision to Diff 35804. ngraham marked an inline comment as done. ngraham added a comment. Use an even simpler total lack of `i18n`, since we don't actually change the string at ally REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D13367: Improve the clarity and presentation of the update details text field

ngraham added a comment. Oops, thanks! REPOSITORY R134 Discover Software Store BRANCH clearer-update-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D13367 To: ngraham, apol, #discover_software_store Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot,

D13367: Improve the clarity and presentation of the update details text field

ngraham updated this revision to Diff 35803. ngraham added a comment. Use the simpler `i18n` function call REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13367?vs=35639=35803 BRANCH clearer-update-text (branched from master) REVISION

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

ngraham added a comment. This doesn't apply for me (conflict in `Applet.qml`); could you rebase on master? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12857 To: miklosm, #plasma, mart Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot,

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham added a comment. I encounter the very same issue as in D13202 : Changing the Avatar in System Settings results in a blank circle in Kickoff. Here's a clue though: it only happens on the first change for each image. For example, if I change the

D13418: Add build dependencies to INSTALL file

majohnson created this revision. majohnson added a project: Documentation. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. majohnson requested review of this revision. REVISION SUMMARY While trying to build the applet I followed the

D13202: Circular user avatar for Kickoff

sharvey added a comment. I rewrote this patch using an `OpacityMask` and a second rounded `Rectangle` to draw the ring. It's a separate diff - D13415: Reshape Kickoff avatar to a circle with Opacity Mask . Please help me test and offer any

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Attempt to avoid non-refreshing avatar by using `OpacityMask` instead of `ShaderEffect` TEST

D13202: Circular user avatar for Kickoff

sharvey added a comment. **#$%$@$!!!** I thought I had the blank circle problem fixed, but it appears I was wrong - must've done something incomplete in my testing. Will someone Plasma-related please have a look at this and see if you can offer any suggestions? I'm at a loss. All

D13374: Check the visible property of the action as well

This revision was automatically updated to reflect the committed changes. Closed by commit R169:7da3a5c05533: Check the visible property of the action as well (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13374?vs=35659=35779 REVISION

Plasma 5.13.0 tars available

Hello, Tars are up for Plasma 5.13.0 on racnoss for packagers to package. release is signed by my key, fingerprint is in signature. https://www.kde.org/info/plasma-5.13.0.php Plasma devs: any last minute bug fixes ask me for a re-roll of tars. Errata

D13112: Port Plasma Desktop Scripting to QJSEngine

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. + Thanks for tackling a very boring and difficult task. There are two things I'd like to see also tested: - the DBus wallpaper changing script that I know a

D12827: Added process details in the process list context menu

broulik added a comment. That crash should be fixed by [1] which I just saw forgot to merge to master [1] https://cgit.kde.org/breeze.git/commit/?h=Plasma/5.13=6d886e9f75d04eb34cd34cac668606d027384f96 REPOSITORY R111 KSysguard Library REVISION DETAIL

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#275279 , @davidedmundson wrote: > Worth noting that some values were tweaked here because of the smaller circle size. For the record, the values that I tweaked were: highp float blend = 0.03;

D12827: Added process details in the process list context menu

chrisx added a comment. In D12827#275187 , @broulik wrote: > > The existing "Show detailed memory information" and "Process details". I think they can be merged. > > The show detailed memory information is a QtWebKit-powered "plugin" (I

D13202: Circular user avatar for Kickoff

sharvey added a comment. @ngraham - This now appears to function properly with no blank circles. Will you please confirm? If Nate is happy, will someone from #plasma please approve so I can land it and get it filed under "finished"?

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 - Build # 44 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/44/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 Date of build: Thu, 07 Jun 2018 13:36:50 + Build duration: 9 min 50 sec and counting CONSOLE

D13202: Circular user avatar for Kickoff

sharvey updated this revision to Diff 35770. sharvey added a comment. - Remove explicit `visible: true`, as default == `true` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13202?vs=35648=35770 BRANCH round-kickoff-avatar (branched from master)

D13357: Use logging categories in a few dataengines

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a8573d1be5a4: Use logging categories in a few dataengines (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12263: [kstyle] Don't suppress deprecation warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R31:d2c04c657198: [kstyle] Dont suppress deprecation warnings (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12263?vs=32331=35768 REVISION DETAIL

D12259: [kstyle] Drop QStyleOptionViewItemV4 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3c40e3869796: [kstyle] Drop QStyleOptionViewItemV4 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12259?vs=32327=35767

D12258: [kstyle] Drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:aa4d7d6247f7: [kstyle] Drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12258?vs=32326=35766

D12257: [kstyle] Drop QStyleOptionTabV3 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:342c05c21813: [kstyle] Drop QStyleOptionTabV3 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12257?vs=32325=35765 REVISION

D12256: [kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:ad50781ec718: [kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12256?vs=32324=35764

D12260: [kstyle] Drop QStyleOptionFrameV2 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:6c79210f31a9: [kstyle] Drop QStyleOptionFrameV2 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12260?vs=32328=35762 REVISION

D12261: [kstyle] Drop QStyleOptionFrameV3 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:abc4464fecb3: [kstyle] Drop QStyleOptionFrameV3 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12261?vs=32329=35763 REVISION

D12262: [kstyle] Drop QStyleOptionDockWidgetV2 in Qt 5 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:34011b10b5c6: [kstyle] Drop QStyleOptionDockWidgetV2 in Qt 5 style plugin (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12262?vs=32330=35761

D13390: Fonts KCM: Fix text readability regression

mart added a comment. edit: Kirigami.Theme.colorGroup: was wrong,should have been Kirigami.Theme.colorSet: Kirigami.Theme.Window tough i prefer the latter form of the patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13390 To: rkflx Cc: mart,

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/9/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 07 Jun 2018 12:26:49 + Build duration: 11 min and counting CONSOLE OUTPUT

D13202: Circular user avatar for Kickoff

davidedmundson added a comment. As for this patch, IMHO it's good to go. If things do become libraries we can always migrate it. Worth noting that some values were tweaked here because of the smaller circle size. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13202: Circular user avatar for Kickoff

davidedmundson added a comment. > btw... i was thinking about copypasting such thing to have an avatar component in kirigami... would there be interest on this? Not sure, I think an Avatar component would be far too use-case specific for Kirigami. Having a round effect (like

D13390: Fonts KCM: Fix text readability regression

mart added a comment. on which it looks like that: F5895805: Spectacle.S22260.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13390 To: rkflx Cc: mart, broulik, Zren, plasma-devel, ragreen, Pitel, ZrenBot,

D13390: Fonts KCM: Fix text readability regression

mart added a comment. In D13390#275223 , @rkflx wrote: > In D13390#275153 , @mart wrote: > > > what you should do is: > > TextField { > > > > readOnly: true > > Kirigami.Theme.inherit:

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/3/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 07 Jun 2018 12:19:09 + Build duration: 2 min 51 sec and counting

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/5/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 07 Jun 2018 12:19:09 + Build duration: 1 min 4 sec and counting

D13390: Fonts KCM: Fix text readability regression

rkflx added a comment. In D13390#275153 , @mart wrote: > what you should do is: > TextField { > > readOnly: true > Kirigami.Theme.inherit: false //always to be set when you are writing anything to the Theme attached proeprty >

D13331: Don't overflow around popups

This revision was automatically updated to reflect the committed changes. Closed by commit R858:f16eda2ffbff: Dont overflow around popups (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13331?vs=35525=35744

D13178: Compress calls to configuration slots upon new connections

broulik added inline comments. INLINE COMMENTS > keyboard_daemon.cpp:163 > } > - connect(xEventNotifier, ::newPointerDevice, this, > ::configureMouse); > - connect(xEventNotifier, ::newKeyboardDevice, this, > ::configureKeyboard); > + connect(xEventNotifier,

D13178: Compress calls to configuration slots upon new connections

mart added a comment. In D13178#271165 , @jacopods wrote: > In D13178#270671 , @mart wrote: > > > are configureKeyboard configureMouse etc doing an immediate write to disk? (like KConfig::sync() >

D13194: Use the new drag handle in the Language KCM

mart added inline comments. INLINE COMMENTS > main.qml:77 > > parent: root.parent > this explicit reparenting shouldn't be necessary (and breaks in my branch for multi level kcms) > main.qml:98 > +delegate: Kirigami.DelegateRecycler { > +width:

D13225: Move methods to private class

nicolasfella added a comment. In D13225#275197 , @mart wrote: > does this library have any kind of binary compatibility promise? It is not yet released. REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL

D13202: Circular user avatar for Kickoff

mart added a comment. In D13202#270416 , @davidedmundson wrote: > > The bordered avatars are done in a different manner than this (mine involves less math!). I'll see if there's a way I can sort it out. > > If you copy and paste the

D13202: Circular user avatar for Kickoff

mart added a comment. In D13202#270391 , @ngraham wrote: > Nice work! Will test it out later today. > > There's no reason to have the appearance user-selectable, IMHO. Part of the goal here is a consistent visual appearance. I vote for

D13225: Move methods to private class

mart added a comment. does this library have any kind of binary compatibility promise? REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D13225 To: nicolasfella, drosca, apol Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13372: Mouse KCM Redesign Using Kirigami

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:31 > > -Item { > +Kirigami.Page { > id: root KCM.SimpleKCM REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12827: Added process details in the process list context menu

broulik added a comment. > The existing "Show detailed memory information" and "Process details". I think they can be merged. The show detailed memory information is a QtWebKit-powered "plugin" (I would love to get rid of tbh) REPOSITORY R111 KSysguard Library REVISION DETAIL

D12827: Added process details in the process list context menu

davidedmundson added a comment. As for this patch. I'm not particulalry convinced context switches is a very useful thing, ksysguard isn't catering to be a perf replacement. But if it's hidden away in a dialog, meh, no real objections. I don't think we need to have two

D12827: Added process details in the process list context menu

davidedmundson added a comment. Relevant screenshot F5895510: image.png REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D12827 To: chrisx Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13390: Fonts KCM: Fix text readability regression

mart added a comment. In D13390#275117 , @rkflx wrote: > In D13390#275116 , @broulik wrote: > > > > It will lead users to click into the field, expecting to be able to edit the name directly > >

D13390: Fonts KCM: Fix text readability regression

broulik added a subscriber: mart. broulik added a comment. > Is this working for you? For me this resolves to the disabled palette (as it should). Interesting. I just looked at `TextField`'s code and saw that it explicit used a different color for `!enabled` so I thought removing that

D12851: Change preview text background color to match with default combobox background color

rkflx added a comment. In D12851#275112 , @progwolff wrote: > Sorry for the delay... No problem ;) > If you want to have this on the 5.13 branch, please feel free to land it. I guess that's something for #Plasma

D13390: Fonts KCM: Fix text readability regression

rkflx added a comment. In D13390#275116 , @broulik wrote: > > It will lead users to click into the field, expecting to be able to edit the name directly > > Oh, you mean because the background turns white when enabled? I see. Yup,

D13390: Fonts KCM: Fix text readability regression

broulik added a comment. > It will lead users to click into the field, expecting to be able to edit the name directly Oh, you mean because the background turns white when enabled? I see. Please use color: Kirigami.Theme.textColor then this is good to go imho REPOSITORY

D13390: Fonts KCM: Fix text readability regression

rkflx added a comment. In D13390#275109 , @broulik wrote: > > Unfortunately that's not what I think is needed here. > > Why not? You make the text field look as though it is enabled, which is what readOnly does. Still being able to select

D12851: Change preview text background color to match with default combobox background color

progwolff added a comment. Sorry for the delay... I planned to land this together with D12849 and D12925 . It will take me two weeks or so until I can continue working on this. I need to finish my master thesis

D13390: Fonts KCM: Fix text readability regression

broulik added a comment. > Unfortunately that's not what I think is needed here. Why not? You make the text field look as though it is enabled, which is what readOnly does. Still being able to select text isn't too bad, is it? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13390: Fonts KCM: Fix text readability regression

rkflx added a comment. In D13390#275034 , @Zren wrote: > Would the `TextField.readOnly` property be useful here? > > http://doc.qt.io/qt-5/qml-qtquick-controls-textfield.html#readOnly-prop > > F5894577: 2018-06-06___19-47-34.png