[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-08-03 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck changed: What|Removed |Added CC||piotr...@gmail.com --- Comment #17 from

D7087: Add "Copy Info" button to the About System KCM

2018-08-03 Thread Henrik Fehlauer
rkflx added a comment. Happy birthday D7087 , you are now 1 year old. @dhaumann Could you either accept, resign or tell us what still needs changing? `arc land` will currently block because your reviewer status is still set to "requesting changes".

D14035: Unbreak SSH agent support for SSH VPN tunnels.

2018-08-03 Thread whitequark
catherinez updated this revision to Diff 39036. catherinez added a comment. Complete request when SSH_AUTH_SOCK is not present. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14035?vs=38850=39036 REVISION DETAIL https://phabricator.kde.org/D14035 AFFECTED FILES

D14035: Unbreak SSH agent support for SSH VPN tunnels.

2018-08-03 Thread whitequark
catherinez marked an inline comment as done. catherinez added a comment. Done. REVISION DETAIL https://phabricator.kde.org/D14035 To: catherinez, #plasma, jgrulich Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

2018-08-03 Thread Kai Uwe Broulik
broulik added a comment. I didn't write that code, I noticed a crash that was trivially fixed and did just that REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14576 To: broulik, #plasma Cc: davidedmundson, anthonyfieroni, plasma-devel, ragreen, Pitel,

Re: KWin tests on FreeBSD all timing out

2018-08-03 Thread Martin Flöser
Am 2018-08-03 12:04, schrieb Ben Cooksley: Hi all, Sometime recently there was a change in the KWin / FreeBSD world which means all KWin tests now fail on FreeBSD, and instead of exiting nicely simply fail with a timeout on the CI system. As a consequence this means KWin builds now tie up

D14581: e a breadcrumb for multilevel kcms

2018-08-03 Thread Marco Martin
mart added a comment. F6173800: vokoscreen-2018-08-03_17-03-18.mkv REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D14581 To: mart, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14581: e a breadcrumb for multilevel kcms

2018-08-03 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Make the title a toolbutton, and when there are multiple levels, make a

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

2018-08-03 Thread David Edmundson
davidedmundson added a comment. KConfigGroup is internally shared. Why have it on the heap in the first place? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14576 To: broulik, #plasma Cc: davidedmundson, anthonyfieroni, plasma-devel, ragreen, Pitel,

Re: Reminder regarding policy for new or updated dependencies

2018-08-03 Thread Jonathan Riddell
We plan to update the Qt dep to 5.11 for Plasma 5.14. Is anyone able to say more about when and where that update will happen? Jonathan On 3 August 2018 at 12:28, Aleix Pol wrote: > On Fri, Aug 3, 2018 at 11:46 AM Ben Cooksley wrote: >> >> Hi all, >> >> The following is a friendly reminder

Re: Akademy BOF Topics

2018-08-03 Thread David Edmundson
Sure. I'll select an hour for generic Plasma + wayland topics, then we'll do this and whatever Marco has ad-hoc within that.

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 87 - Still unstable!

2018-08-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/87/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 Aug 2018 11:19:02 + Build duration: 1 hr 31 min and counting JUnit Tests Name:

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-03 Thread Eike Hein
hein updated this revision to Diff 39009. hein added a comment. Relicense to GPL. So it fits the code temporarily copied from dbusinterface.(h|cpp). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=39008=39009 BRANCH mart/plasmavirtualdesktop

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-03 Thread Eike Hein
hein updated this revision to Diff 39008. hein added a comment. - Use GetAll to initialize m_desktops and m_rows at the same time. - Reuse QStrings for DBus connection stuff. - Fix the DesktopRow role. - Add list-add icon to button. - Fix license. REPOSITORY R108 KWin CHANGES SINCE

Re: Reminder regarding policy for new or updated dependencies

2018-08-03 Thread Aleix Pol
On Fri, Aug 3, 2018 at 11:46 AM Ben Cooksley wrote: > > Hi all, > > The following is a friendly reminder that the introduction of new > mandatory dependencies, or bumping of versions of mandatory > dependencies, requires explicit notification to Sysadmin in advance of > the change being made. > >

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.10 - Build # 94 - Still unstable!

2018-08-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.10/94/ Project: Plasma discover kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 03 Aug 2018 11:19:02 + Build duration: 3 min 26 sec and counting JUnit Tests

Re: Akademy BOF Topics

2018-08-03 Thread Jan Grulich
On středa 1. srpna 2018 17:01:28 CEST David Edmundson wrote: > We currently have a bunch of slots booked as general "Plasma". > We should split them up into relevant topics people actually want to > discuss so people know when to turn up to what. > > Either post here or update the wiki directly.

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-03 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > broulik wrote in desktopsmodel.cpp:92 > Architectural question: why don't you go the standard > `org.freedesktop.DBus.Properties.PropertiesChanged` way? No deeper reason. Marco added an additional rowsChanged I guess. REPOSITORY R108 KWin

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

2018-08-03 Thread Kai Uwe Broulik
broulik updated this revision to Diff 39004. broulik added a comment. - Check in destructor as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14576?vs=39003=39004 REVISION DETAIL https://phabricator.kde.org/D14576 AFFECTED FILES

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

2018-08-03 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > configgroup.cpp:67 > d->synchTimer->stop(); > d->configGroup->sync(); > } Here as well should be sync(), if it destroys object before timer is elapsed e.g. before 1.5 sec it will crash. REPOSITORY R120 Plasma

KWin tests on FreeBSD all timing out

2018-08-03 Thread Ben Cooksley
Hi all, Sometime recently there was a change in the KWin / FreeBSD world which means all KWin tests now fail on FreeBSD, and instead of exiting nicely simply fail with a timeout on the CI system. As a consequence this means KWin builds now tie up builders for around 11 hours per run. Could

D13988: Use subseq matching for service runner

2018-08-03 Thread Kai Uwe Broulik
broulik added a comment. Apparently you have to tell sysadmin two weeks in advance. [1] [1] https://mail.kde.org/pipermail/plasma-devel/2018-August/087983.html REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To:

Reminder regarding policy for new or updated dependencies

2018-08-03 Thread Ben Cooksley
Hi all, The following is a friendly reminder that the introduction of new mandatory dependencies, or bumping of versions of mandatory dependencies, requires explicit notification to Sysadmin in advance of the change being made. Per Community Policy these notifications must be made 2 weeks in

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

2018-08-03 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They were missing in a couple of places leading to crashes. TEST

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2018-08-03 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=375840 Chris changed: What|Removed |Added CC||scrutini...@pm.me --- Comment #8 from Chris --- Same

D14546: [Service Runner] Look up relative entryPaths

2018-08-03 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > anthonyfieroni wrote in servicerunner.cpp:474 > Does it better to check that file exists? `QStandardPaths::locate` already does that: > The full path to the first file […] found is returned. If no such file […] > can be found, an empty string

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

2018-08-03 Thread Julian Wolff
progwolff planned changes to this revision. progwolff added a comment. In D12925#302675 , @ngraham wrote: > With this latest version, the issue I mentioned earlier persists for me. I did briefly get sub-pixel rendering again to work by switching