[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=345618

Christoph Feck  changed:

   What|Removed |Added

 CC||piotr...@gmail.com

--- Comment #17 from Christoph Feck  ---
*** Bug 397139 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7087: Add "Copy Info" button to the About System KCM

[Henrik Fehlauer]

rkflx added a comment.


  Happy birthday D7087 , you are now 1 year 
old.
  
  @dhaumann Could you either accept, resign or tell us what still needs 
changing? `arc land` will currently block because your reviewer status is still 
set to "requesting changes".
  
  @gregormi Could you rebase your patch on master?
  
  Thanks!

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D14035: Unbreak SSH agent support for SSH VPN tunnels.

[whitequark]

catherinez updated this revision to Diff 39036.
catherinez added a comment.


  Complete request when SSH_AUTH_SOCK is not present.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14035?vs=38850=39036

REVISION DETAIL
  https://phabricator.kde.org/D14035

AFFECTED FILES
  kded/secretagent.cpp

To: catherinez, #plasma, jgrulich
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14035: Unbreak SSH agent support for SSH VPN tunnels.

[whitequark]

catherinez marked an inline comment as done.
catherinez added a comment.


  Done.

REVISION DETAIL
  https://phabricator.kde.org/D14035

To: catherinez, #plasma, jgrulich
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

[Kai Uwe Broulik]

broulik added a comment.


  I didn't write that code, I noticed a crash that was trivially fixed and did 
just that

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14576

To: broulik, #plasma
Cc: davidedmundson, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: KWin tests on FreeBSD all timing out

[Martin Flöser]

Am 2018-08-03 12:04, schrieb Ben Cooksley:

Hi all,

Sometime recently there was a change in the KWin / FreeBSD world which
means all KWin tests now fail on FreeBSD, and instead of exiting
nicely simply fail with a timeout on the CI system.

As a consequence this means KWin builds now tie up builders for around
11 hours per run.

Could someone please take a look into this?


This is something the FreeBSD devs need to look into.

Cheers
Martin

D14581: e a breadcrumb for multilevel kcms

[Marco Martin]

mart added a comment.


  F6173800: vokoscreen-2018-08-03_17-03-18.mkv 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D14581

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14581: e a breadcrumb for multilevel kcms

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Make the title a toolbutton, and when there are multiple levels, make
  a breadcrumb out of buttons.
  clicking on buttons will navigate the levels(keyboard shortcuts work too)
  
  a similar modification will be needed to be done to KCMShell
  depends from D14579  and D14580 


TEST PLAN
  Added a level to a kcm, works as intended

REPOSITORY
  R124 System Settings

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14581

AFFECTED FILES
  core/ModuleView.cpp

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

[David Edmundson]

davidedmundson added a comment.


  KConfigGroup is internally shared.
  
  Why have it on the heap in the first place?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14576

To: broulik, #plasma
Cc: davidedmundson, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Reminder regarding policy for new or updated dependencies

[Jonathan Riddell]

We plan to update the Qt dep to 5.11 for Plasma 5.14.  Is anyone able
to say more about when and where that update will happen?

Jonathan


On 3 August 2018 at 12:28, Aleix Pol  wrote:
> On Fri, Aug 3, 2018 at 11:46 AM Ben Cooksley  wrote:
>>
>> Hi all,
>>
>> The following is a friendly reminder that the introduction of new
>> mandatory dependencies, or bumping of versions of mandatory
>> dependencies, requires explicit notification to Sysadmin in advance of
>> the change being made.
>>
>> Per Community Policy these notifications must be made 2 weeks in
>> advance of the change being introduced.
>>
>> Regards,
>> Ben Cooksley
>> KDE Sysadmin
>
> If you say that because fwupd, it's not a mandatory dependency, just
> nice to have.
> The fact that it failed was legitimate CI finding broken code.
>
> Aleix

Re: Akademy BOF Topics

[David Edmundson]

Sure. I'll select an hour for generic Plasma + wayland topics, then we'll
do this and whatever Marco has ad-hoc within that.

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 87 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/87/
 Project:
Plasma discover kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 03 Aug 2018 11:19:02 +
 Build duration:
1 hr 31 min and counting
   JUnit Tests
  Name: (root) Failed: 12 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.dummytestFailed: TestSuite.installFailed: TestSuite.knsbackendtestFailed: TestSuite.missingResourceFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstallFailed: TestSuite.updatedummytestFailed: TestSuite.wrongInput
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report47%
(8/17)26%
(25/96)26%
(25/96)19%
(896/4609)13%
(402/3080)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover73%
(8/11)73%
(8/11)49%
(320/647)31%
(119/386)discover.autotests100%
(1/1)100%
(1/1)100%
(92/92)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/65)0%
(0/40)libdiscover29%
(2/7)29%
(2/7)17%
(41/247)17%
(28/167)libdiscover.Category80%
(4/5)80%
(4/5)49%
(109/224)38%
(80/210)libdiscover.ReviewsBackend0%
(0/7)0%
(0/7)0%
(0/215)0%
(0/72)libdiscover.Transaction13%
(1/8)13%
(1/8)6%
(17/281)6%
(8/138)libdiscover.UpdateModel0%
(0/4)0%
(0/4)0%
(0/200)0%
(0/108)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/217)0%
(0/98)libdiscover.backends.DummyBackend0%
(0/11)0%
(0/11)0%
(0/289)0%
(0/154)libdiscover.backends.DummyBackend.tests100%
(2/2)100%
(2/2)9%
(24/255)4%
(10/260)libdiscover.backends.KNSBackend0%
(0/5)0%
(0/5)0%
(0/384)0%
(0/199)libdiscover.backends.KNSBackend.tests0%
(0/1)0%
(0/1)0%
(0/86)0%
(0/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/4)0%
(0/2)libdiscover.resources28%
(5/18)28%
(5/18)7%
(70/1013)2%
(16/748)libdiscover.tests100%
(2/2)100%
(2/2)83%
(223/269)46%
(106/232)notifier0%
   

D14542: WIP: Basic KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 39009.
hein added a comment.


  Relicense to GPL.
  
  So it fits the code temporarily copied from dbusinterface.(h|cpp).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=39008=39009

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/CMakeLists.txt
  kcmkwin/kwindesktopng/CMakeLists.txt
  kcmkwin/kwindesktopng/Messages.sh
  kcmkwin/kwindesktopng/desktopsmodel.cpp
  kcmkwin/kwindesktopng/desktopsmodel.h
  kcmkwin/kwindesktopng/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktopng/org.kde.kwin.virtualdesktopmanager.xml
  kcmkwin/kwindesktopng/package/contents/ui/main.qml
  kcmkwin/kwindesktopng/package/metadata.desktop
  kcmkwin/kwindesktopng/virtualdesktops.cpp
  kcmkwin/kwindesktopng/virtualdesktops.h

To: hein, mart
Cc: broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, 
iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas, apol, mart

D14542: WIP: Basic KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 39008.
hein added a comment.


  - Use GetAll to initialize m_desktops and m_rows at the same time.
  - Reuse QStrings for DBus connection stuff.
  - Fix the DesktopRow role.
  - Add list-add icon to button.
  - Fix license.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=38914=39008

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/CMakeLists.txt
  kcmkwin/kwindesktopng/CMakeLists.txt
  kcmkwin/kwindesktopng/Messages.sh
  kcmkwin/kwindesktopng/desktopsmodel.cpp
  kcmkwin/kwindesktopng/desktopsmodel.h
  kcmkwin/kwindesktopng/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktopng/org.kde.kwin.virtualdesktopmanager.xml
  kcmkwin/kwindesktopng/package/contents/ui/main.qml
  kcmkwin/kwindesktopng/package/metadata.desktop
  kcmkwin/kwindesktopng/virtualdesktops.cpp
  kcmkwin/kwindesktopng/virtualdesktops.h

To: hein, mart
Cc: broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, 
iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas, apol, mart

Re: Reminder regarding policy for new or updated dependencies

[Aleix Pol]

On Fri, Aug 3, 2018 at 11:46 AM Ben Cooksley  wrote:
>
> Hi all,
>
> The following is a friendly reminder that the introduction of new
> mandatory dependencies, or bumping of versions of mandatory
> dependencies, requires explicit notification to Sysadmin in advance of
> the change being made.
>
> Per Community Policy these notifications must be made 2 weeks in
> advance of the change being introduced.
>
> Regards,
> Ben Cooksley
> KDE Sysadmin

If you say that because fwupd, it's not a mandatory dependency, just
nice to have.
The fact that it failed was legitimate CI finding broken code.

Aleix

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.10 - Build # 94 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.10/94/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 03 Aug 2018 11:19:02 +
 Build duration:
3 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.installFailed: TestSuite.updateandinstall

Re: Akademy BOF Topics

[Jan Grulich]

On středa 1. srpna 2018 17:01:28 CEST David Edmundson wrote:
> We currently have a bunch of slots booked as general "Plasma".
> We should split them up into relevant topics people actually want to
> discuss so people know when to turn up to what.
> 
> Either post here or update the wiki directly.

I also plan to attend the BoF to discuss screen sharing and remote desktop on 
Wayland if you are okay with that :).

Jan

D14542: WIP: Basic KCM using new virtual desktops DBus interface

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> broulik wrote in desktopsmodel.cpp:92
> Architectural question: why don't you go the standard 
> `org.freedesktop.DBus.Properties.PropertiesChanged` way?

No deeper reason. Marco added an additional rowsChanged I guess.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart
Cc: broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, 
iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas, apol, mart

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

[Kai Uwe Broulik]

broulik updated this revision to Diff 39004.
broulik added a comment.


  - Check in destructor as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14576?vs=39003=39004

REVISION DETAIL
  https://phabricator.kde.org/D14576

AFFECTED FILES
  shell/scripting/configgroup.cpp

To: broulik, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> configgroup.cpp:67
>  d->synchTimer->stop();
>  d->configGroup->sync();
>  }

Here as well should be sync(), if it destroys object before timer is elapsed 
e.g. before 1.5 sec it will crash.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14576

To: broulik, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KWin tests on FreeBSD all timing out

[Ben Cooksley]

Hi all,

Sometime recently there was a change in the KWin / FreeBSD world which
means all KWin tests now fail on FreeBSD, and instead of exiting
nicely simply fail with a timeout on the CI system.

As a consequence this means KWin builds now tie up builders for around
11 hours per run.

Could someone please take a look into this?

Thanks,
Ben

D13988: Use subseq matching for service runner

[Kai Uwe Broulik]

broulik added a comment.


  Apparently you have to tell sysadmin two weeks in advance. [1]
  
  [1] https://mail.kde.org/pipermail/plasma-devel/2018-August/087983.html

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reminder regarding policy for new or updated dependencies

[Ben Cooksley]

Hi all,

The following is a friendly reminder that the introduction of new
mandatory dependencies, or bumping of versions of mandatory
dependencies, requires explicit notification to Sysadmin in advance of
the change being made.

Per Community Policy these notifications must be made 2 weeks in
advance of the change being introduced.

Regards,
Ben Cooksley
KDE Sysadmin

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  They were missing in a couple of places leading to crashes.

TEST PLAN
  Ran the following script
  
print(new ConfigFile().groupList);
  
  Used to crash, now it no longer does

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14576

AFFECTED FILES
  shell/scripting/configgroup.cpp

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

[Chris]

https://bugs.kde.org/show_bug.cgi?id=375840

Chris  changed:

   What|Removed |Added

 CC||scrutini...@pm.me

--- Comment #8 from Chris  ---
Same here on Debian Stretch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D14546: [Service Runner] Look up relative entryPaths

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in servicerunner.cpp:474
> Does it better to check that file exists?

`QStandardPaths::locate` already does that:

> The full path to the first file […] found is returned. If no such file […] 
> can be found, an empty string is returned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14546

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

[Julian Wolff]

progwolff planned changes to this revision.
progwolff added a comment.


  In D12925#302675 , @ngraham wrote:
  
  > With this latest version, the issue I mentioned earlier persists for me. I 
did briefly get sub-pixel rendering again to work by switching the hinting 
style to Full, but then after switching back to something else and then back to 
Full again, it no longer worked and I was back to no sub-pixel rendering again. 
Feels kinda buggy.
  
  
  Very strange...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12925

To: progwolff, ngraham, #plasma
Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol