D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes added a comment.


  In D16425#349588 , @ngraham wrote:
  
  > We'll need a spinbox to display time options for the amount of delay before 
hibernating if this is the UI we go with. But I kinda like Martin's idea and 
present this in the form of an additional control sort of like this:
  >
  >   While suspended, hibernate after: [combobox with some carefully selected 
intervals, plus "Never", which is the default choice]
  >
  >
  > Also, how does this handle hardware or distro configurations that don't 
support hibernation? I might suggest that it would be best to hide the option 
entirely in such a case. On this subject, the HIG says:
  >
  > > If some of the program’s settings are only applicable in certain 
contexts, do not hide the inapplicable ones. Instead, disable them and hint to 
the user why they’re disabled. **Exception:** it is acceptable to hide settings 
for non-existent hardware. For example, it’s okay to hide the touchpad 
configuration when no touchpad is present.
  >
  > It's not //exctly// the same thing, but I think the principle applies 
here.
  
  
  If the hardware you are running doesn't support hibernation, logind 
canSupportThenHibernate method should return no, I tested this code in a 
machine without hibernation and it currently hides the new option. I added some 
checks before saving so we don't accidentally enable this suspend option by 
error.
  
  On the amount of time to hibernate, afaik this can only be configured by 
modifying /etc/systemd/sleep.conf and adding HibernateDelaySec= with the amount 
of seconds that you want to wait to hibernate, by default the wait time is 3 
hours. I have no knowledge of an API to configure this time.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik
Cc: graesslin, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4034: Show descriptive text when changing containment plugins

[Nathaniel Graham]

ngraham added a comment.


  In D4034#349125 , @rooty wrote:
  
  > hey guys don't get mad at me for the necropost (and the nitpicking) but... 
it really should be "while", not "whilst" for users that use en_US, for the 
sake of consistency
  
  
  You are correct. Fixed with 64d0815faed992ddf71b788d196878d14d045744 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4034

To: davidedmundson, #plasma, mart
Cc: ngraham, rooty, broulik, mart, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16425: Added new Suspend then Hibernate option

[Nathaniel Graham]

ngraham added a comment.


  We'll need a spinbox to display time options for the amount of delay before 
hibernating if this is the UI we go with. But I kinda like Martin's idea and 
present this in the form of an additional control sort of like this:
  
While suspended, hibernate after: [combobox with some carefully selected 
intervals, plus "Never", which is the default choice]
  
  Also, how does this handle hardware or distro configurations that don't 
support hibernation? I might suggest that it would be best to hide the option 
entirely in such a case. On this subject, the HIG says:
  
  > If some of the program’s settings are only applicable in certain contexts, 
do not hide the inapplicable ones. Instead, disable them and hint to the user 
why they’re disabled. **Exception:** it is acceptable to hide settings for 
non-existent hardware. For example, it’s okay to hide the touchpad 
configuration when no touchpad is present.
  
  It's not //exctly// the same thing, but I think the principle applies 
here.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik
Cc: graesslin, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13100: do not use buffered file IO

[Rolf Eike Beer]

dakon added inline comments.

INLINE COMMENTS

> aacid wrote in pam_kwallet.c:696
> const

While this is "just an int", my personal taste is very much against using const 
on a file descriptor as this is not how this really works. I don't know.

> aacid wrote in pam_kwallet.c:704
> const

ACK

REVISION DETAIL
  https://phabricator.kde.org/D13100

To: dakon, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[frameworks-kio] [Bug 368008] Using a DAV filesystem, Dolphin fails to delete a file containing a µ

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=368008

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org,
   ||kdelibs-b...@kde.org
Product|kio-extras  |frameworks-kio
  Component|default |WebDAV

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15514: [libbreezecommon] Use box blur instead of FFT blur

[Vlad Zagorodniy]

zzag closed this revision.
zzag added a comment.


  It's fixed now.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma, #breeze, #vdg, ngraham
Cc: fvogt, cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16459: Fix build of libbreezecommon with USE_KDE4

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:663ef0c694b3: Fix build of libbreezecommon with USE_KDE4 
(authored by fvogt).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16459?vs=44305=44306

REVISION DETAIL
  https://phabricator.kde.org/D16459

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp
  libbreezecommon/breezeboxshadowrenderer.h

To: fvogt, #breeze, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16459: Fix build of libbreezecommon with USE_KDE4

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16459

To: fvogt, #breeze, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16459: Fix build of libbreezecommon with USE_KDE4

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Breeze, zzag.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  includes were incompatible.

TEST PLAN
  Built it.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16459

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp
  libbreezecommon/breezeboxshadowrenderer.h

To: fvogt, #breeze, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT blur

[Fabian Vogt]

fvogt reopened this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Fails to build the KDE4 version here:
  
[   76s] 
/home/abuild/rpmbuild/BUILD/breeze-5.14.80git.20181027T152517~f1e4f103/libbreezecommon/breezeboxshadowrenderer.cpp:29:10:
 fatal error: QtMath: No such file or directory
[   76s]  #include 

REPOSITORY
  R31 Breeze

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma, #breeze, #vdg, ngraham
Cc: fvogt, cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT blur

[Vlad Zagorodniy]

zzag closed this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma, #breeze, #vdg, ngraham
Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT blur

[Vlad Zagorodniy]

zzag added a comment.


  Landing it...

REPOSITORY
  R31 Breeze

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma, #breeze, #vdg, ngraham
Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D14949: Add option for whether to show the volume change OSD

[Alassane Maiga]

amaiga added a comment.


  Yes! Please.
  I also struggle to understand what is the rationale for having something this 
big in the middle of the screen. Its not only distracting when watching movies 
playing games etc, but also while writing a report or just while basically 
doing anything that involves watching/reading the screen while listening to 
whatever in the background.
  
  The real question is: why does the icon need to be this big? Why was the 
middle of the screen chosen as the only sensible and non configurable position 
to place the OSD?

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: amaiga, davidedmundson, filipf, rooty, graesslin, svenmauch, ngraham, 
romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes updated this revision to Diff 44294.
avaldes added a comment.


  I have added a new checkbox inside the suspend session delay and in button 
event handling.
  
  I wasn't able to make it work with the button event handling, but the 
checkbox does work with the logic when Suspend Session is enabled.
  
  Let me know if you know of a better way to do this.
  
  Here's how it looks now: F6364813: sth-checkbox.png 


REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16425?vs=44208=44294

REVISION DETAIL
  https://phabricator.kde.org/D16425

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h
  daemon/actions/bundled/handlebuttoneventsconfig.cpp
  daemon/actions/bundled/handlebuttoneventsconfig.h
  daemon/actions/bundled/suspendsession.cpp
  daemon/actions/bundled/suspendsession.h
  daemon/actions/bundled/suspendsessionconfig.cpp
  daemon/actions/bundled/suspendsessionconfig.h
  daemon/org.freedesktop.PowerManagement.xml
  daemon/powerdevilfdoconnector.cpp
  kcmodule/activities/activitywidget.cpp

To: avaldes, broulik
Cc: graesslin, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4034: Show descriptive text when changing containment plugins

[Root]

rooty added a comment.


  hey guys don't get mad at me for the necropost (and the nitpicking) but... it 
really should be "while", not "whilst" for users that use en_US, for the sake 
of consistency

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4034

To: davidedmundson, #plasma, mart
Cc: rooty, broulik, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:c255ac792a0d: Fix connecting to PulseAudio with Qt 5.12 
beta 3 (authored by arojas).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16443?vs=44268=44284

REVISION DETAIL
  https://phabricator.kde.org/D16443

AFFECTED FILES
  src/context.cpp

To: arojas, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart