D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-11-09 Thread Root
rooty added a comment. thanks! and good luck! sorry about the little ones hope they get well soon REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello, davidedmundson Cc: romangg, davidedmundson, rizzitello, abetts,

D16622: [Plasmoid] Clean up layout

2018-11-09 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R112:f1637beef1b9: [Plasmoid] Clean up layout (authored by ngraham). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16622?vs=44750=45211 REVISION DETAIL

D16622: [Plasmoid] Clean up layout

2018-11-09 Thread Nathaniel Graham
ngraham added a comment. Thanks David! REPOSITORY R112 Milou BRANCH better-layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D16622 To: ngraham, #plasma, broulik, #vdg, davidedmundson Cc: davidedmundson, Codezela, plasma-devel, ragreen, Pitel, ZrenBot,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-11-09 Thread Nathaniel Graham
ngraham added a comment. I'm separating out all the potentially controversial changes into a separate patch (and will probably revert the font size changes; you guys are right about that). I might not have time until later tonight or sometime tomorrow evening since I'm single-parenting for

D16082: Notify headphone being plugged in on some hardware

2018-11-09 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:179 > +} else if (port.name == "analog-output-speaker") { > +icon = Icon.formFactorIcon("speaker"); > +} What I don't like about this is that it no longer reflects the actual device volume, e.g.

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-11-09 Thread Root
rooty added a comment. hey nate would you consider changing all the #232629 outlines to #4d4d4d? they come out a little strong when set to #232629 imo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello,

D16768: mage global menu screen aware

2018-11-09 Thread Michail Vourlakos
mvourlakos updated this revision to Diff 45193. mvourlakos added a comment. - remove confusing emit call REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16768?vs=45143=45193 BRANCH appMenuScreen REVISION DETAIL

D16768: mage global menu screen aware

2018-11-09 Thread Michail Vourlakos
mvourlakos added inline comments. INLINE COMMENTS > davidedmundson wrote in appmenumodel.cpp:229 > why move this? this patch depends on https://phabricator.kde.org/D16715 that has moved it... the reason is that m_currentWindowId in current implementation is not a current window id. it is used

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-11-09 Thread Filip Fila
filipf added a comment. In D16031#356881 , @rooty wrote: > hey i just set up these revisions and i'm liking the new theme > one problem though, it seems as though Suspend, Restart, Shutdown are showing up as 12pt instead of 11pt or 10pt? it

D16622: [Plasmoid] Clean up layout

2018-11-09 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. code is fine. I don't have an opinion either way on the visuals. REPOSITORY R112 Milou BRANCH better-layout (branched from master) REVISION DETAIL

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-11-09 Thread Root
rooty added a comment. hey i just set up these revisions and i'm liking the new theme one problem though, it seems as though Suspend, Restart, Shutdown are showing up as 12pt instead of 11pt or 10pt? it just looks a little too big compared to (when i force) 11pt REPOSITORY R120 Plasma

D16768: mage global menu screen aware

2018-11-09 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > appmenumodel.cpp:85-86 > +connect(this, ::screenGeometryChanged, this, [this] { > +emit onWindowChanged(m_currentWindowId); > +

D16776: Better error handling in KNewStuff backend

2018-11-09 Thread Aleix Pol Gonzalez
apol added a comment. Where will the `All categories are missing` error fall right now? INLINE COMMENTS > KNSBackend.cpp:247 > +QString error = message; > +bool invalidFile = false; > +switch(errorCode) { Maybe at least qDebug() it? > KNSBackend.cpp:275 > +case

D16776: Better error handling in KNewStuff backend

2018-11-09 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added reviewers: Discover Software Store, apol. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Previously error handling was

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 12 - Still unstable!

2018-11-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/12/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Fri, 09 Nov 2018 07:57:50 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.11 - Build # 13 - Fixed!

2018-11-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.11/13/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Fri, 09 Nov 2018 07:57:48 + Build duration: 1 min 58 sec and counting JUnit Tests

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.11 - Build # 13 - Fixed!

2018-11-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.11/13/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 09 Nov 2018 07:57:49 + Build duration: 1 min 48 sec and counting

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.11 - Build # 9 - Fixed!

2018-11-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.11/9/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Fri, 09 Nov 2018 07:57:49 + Build duration: 2 min 12 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.11 - Build # 10 - Fixed!

2018-11-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.11/10/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 09 Nov 2018 07:57:51 + Build duration: 2 min 6 sec and counting