D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. sorry to be a bore, but how do you guys feel about removing the outline and tinkering with DropShadow instead? i set it to: radius: 12 samples: 32 spread: 0.35 color: Qt.rgba(0, 0, 0, 1) and this is what happens on top of a very messy bright

D16812: Avoid potential race condtion with QFutureWatcher in FWUPD backend

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY One should connect to the finish slot before starting the threaded job.

D16811: Load KDE QtQuickSettings in Discover

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY As per other QtQuick parts of Plasma CCBUG: 400908 TEST PLAN

D16807: Fix colors in sound settings

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. That shouldn't be needed. It seems like there's a problem in the label being used, which needs fixing at the root cause. It's QQC1 label, which on

D16768: mage global menu screen aware

mvourlakos updated this revision to Diff 45243. mvourlakos added a comment. - improve check for window in current screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16768?vs=45193=45243 BRANCH appMenuScreen REVISION DETAIL

D16768: mage global menu screen aware

davidedmundson added inline comments. INLINE COMMENTS > mvourlakos wrote in appmenumodel.cpp:263 > you mean? > > setMenuHidden(info.isMinimized() || m_screenGeometry.isNull() || > !m_screenGeometry.contains(info.geometry().center())); I mean const bool contained = m_screenGeometry.isNull()

D16807: Fix colors in sound settings

dkardarakos created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY In Plasma Mobile, when Breeze Dark is selected, color text is hardly visible. Labels' color has been set to fix the issue.

D16805: improve variable name for global menu model

mvourlakos added a comment. I have sent some patches for Global Menu applet because I want to be clear for the changes that they introduce they should be read in the following order: 1. D16805 - rename a variable 2. D16715

D16805: improve variable name for global menu model

mvourlakos created this revision. mvourlakos added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --the currentWindowId variable is currently used only for