KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.11 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.11/12/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 21 Nov 2018 04:59:09 + Build duration: 2.6 sec and counting CONSOLE OUTPUT Starte

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 207 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/207/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 21 Nov 2018 04:48:08 + Build duration: 10 min and counting CONSOLE OUTPUT Started by an SCM chan

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.11 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.11/11/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 21 Nov 2018 04:56:13 + Build duration: 2 min 54 sec and counting CONSOLE OUTPUT S

D17038: Fix uncentered crosshairs

This revision was automatically updated to reflect the committed changes. Closed by commit R31:a7d07492bf65: Fix uncentered crosshairs (authored by ndavis, committed by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17038?vs=45866&id=45926 REVISION DE

D17064: datetime runner: Match timezones less restrictively

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of just showing the first match, show all of the matches. So if Europe was the query, it will list

D17038: Fix uncentered crosshairs

ndavis added a comment. In D17038#363375 , @ngraham wrote: > Whoops! Nice find, and nice fix. Since the other crosshair patch went into the `Plasma/5.12` stable branch, let's do the same thing here. You wanna have another go at https://communit

D17038: Fix uncentered crosshairs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! Nice find, and nice fix. Since the other crosshair patch went into the `Plasma/5.12` stable branch, let's do the same thing here. You wanna have another go at https://community.k

D17034: [Kickoff] Fix bad kerning in tab labels

ngraham added a comment. FWIW, we already conditionally switch to using QtRendering when using a fractional scale factor throughout the PlasmaComponents library. So there is already a precedent for sometimes using a different renderer to work around visual bugs, and so far it has been much a

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17022 To: rooty, ngraham, romangg Cc: abetts, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17050: Allow clicking of links in app descriptions

abetts added a comment. +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17050 To: leinir, #discover_software_store, apol Cc: abetts, plasma-devel, masilva, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16220: Add feature to save sensor displays as images

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. seems an ok feature. INLINE COMMENTS > SensorDisplay.cpp:401 > + QFileDialog chooser; > + chooser.setWindowTitle("Save As Image"); > + chooser.setAcceptMode(QFi

D17050: Allow clicking of links in app descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit R134:8bea95730eab: Allow clicking of links in app descriptions (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17050?vs=45887&id=458

D17050: Allow clicking of links in app descriptions

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me, maybe it would make sense to restrict it to http:? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17050 To: leinir, #discover_softwa

D17050: Allow clicking of links in app descriptions

leinir created this revision. leinir added reviewers: Discover Software Store, apol. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch, links fou

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362807 , @rooty wrote: > Also it's hardly random, it's specifically targeted at a label or a //single// portion of the UI that's affected by this gravely and consistently. Yes, I just logged in and out 10

D17041: Sync text for empty trash

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Copying src/widgets/jobuidelegate.cpp it's "empty trash" BUG: 401119 TE

D17023: [Kickoff] Change search label and username font size

rooty updated this revision to Diff 45869. rooty added a comment. - Remove (duplicated) code shared with D17020 and D17022 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1702

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty updated this revision to Diff 45868. rooty added a comment. - Remove duplicated code common to D17020 , D17022 and D17023 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D17039: ASAN: Fix leak in KAStatsFavoritesModel

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kfunk requested review of this revision. REVISION SUMMARY Trace: Direct leak of 336 byte(s) in 6 object(s) allocated from: #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel

D17038: Fix uncentered crosshairs

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY For some reason, the centers of the generated PNGs are not the centers of the crosshairs

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty added a comment. In D17022#362813 , @davidedmundson wrote: > I appreciate the effort to split up a big commit, but this isn't quite right. > > There's duplicated code changes both here and in https://phabricator.kde.org/D17020

D17025: Perf: Do expensive regexp construction earlier

This revision was automatically updated to reflect the committed changes. kfunk marked an inline comment as done. Closed by commit R120:a46179d9497a: Perf: Do expensive regexp construction earlier (authored by kfunk). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabric

D17025: Perf: Do expensive regexp construction earlier

kfunk marked an inline comment as done. kfunk added inline comments. INLINE COMMENTS > apol wrote in systemtray.cpp:88 > Shouldn't we prefer QRegularExpression? Thought the same, but the new QRegularExpression doesn't allow wildcard matching. REPOSITORY R120 Plasma Workspace BRANCH master

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

davidedmundson added a comment. I appreciate the effort to split up a big commit, but this isn't quite right. There's duplicated code changes both here and in https://phabricator.kde.org/D17020 INLINE COMMENTS > Header.qml:285 > +] // states > +Keys.onPressed: { > +if (e

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362808 , @broulik wrote: > > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. > > It does because it's using a `TextEdit` directly to make

D17034: [Kickoff] Fix bad kerning in tab labels

broulik added a comment. > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. It does because it's using a `TextEdit` directly to make text selectable rather than a full `TextArea` which would set this automatically int

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362786 , @hein wrote: > This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. The rasterization should be consistent throughout the system and consistent