D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47317. mbehrendt added a comment. more simplifications REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47256&id=47317 REVISION DETAIL https://phabricator.kde.org/D17467 AFFECTED FILES applets/di

D17493: Implementation of an Easy Mode in KCM fonts module

ngraham added a comment. 1. This needs screenshots. :) 2. Don't you think it's premature to submit code before we've settled on what it is we actually want? I don't see any consensus in T7927 . Personally I am not at all sold on the idea of presenting use

D17493: Implementation of an Easy Mode in KCM fonts module

harmathy created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. harmathy requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17493 AFFECTED FILES CMakeLists.txt kcms/fonts/CMakeLists.txt

D17487: Check if the form has changed, and only reconnect if it has

enriquem created this revision. enriquem added a reviewer: jgrulich. enriquem added a project: Plasma (Plasma 5.14). Herald edited projects, added Plasma; removed Plasma (Plasma 5.14). Herald added a subscriber: plasma-devel. enriquem requested review of this revision. REVISION SUMMARY BUG: 3951

D17484: Fix menu item width when the delegate is overriden

apol closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D17484 To: apol, #kirigami, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17268: Fix warning

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17268 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17346: Support Bluetooth batteries

abetts added a comment. Maybe not applicable to this patch, but would we consider making the battery color in the progress bar to be green? Green seems to be very standard to mean charge. We are using blue. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17

D17484: Fix menu item width when the delegate is overriden

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Have MenuItem get the width of the parent instead of needing to specify it every time. This fixe

D17458: Add help button to KCMs where it was missing

abetts added a comment. Thanks Dave! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17458 To: davidedmundson, #plasma, ngraham Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb created this revision. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ognarb requested review of this revision. REVISION SUMMARY New screenshots that reflect current version of system settings. I also uncommented a section in the sp

D17480: Fix warnings

apol closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D17480 To: apol, #frameworks, mart, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17480: Fix warnings

apol created this revision. apol added reviewers: Frameworks, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Now it doesn't complain about being undefined anymore REPOSITORY R858 Qt Quick Controls 2: Desk

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. The lock and login screens are already subtly inconsistent with one another, so changing that isn't currently on the table. Please keep the comments relevant to //this// patch. If you want to discuss conceptual issues, please do it in the Phab task (T9658

D17458: Add help button to KCMs where it was missing

davidedmundson added a comment. In D17458#374552 , @broulik wrote: > > Then why was launch wrong? > > It does `setButtons(Apply | Default);` in the C++ part Then my patch was kinda crappy :/ I'll tidy it up. REPOSITORY R119 Plasma

D17458: Add help button to KCMs where it was missing

broulik added a comment. > Then why was launch wrong? It does `setButtons(Apply | Default);` in the C++ part REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17458 To: davidedmundson, #plasma, ngraham Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, les

D17458: Add help button to KCMs where it was missing

davidedmundson added a comment. > I think one can just remove the buttons meddling, the default is Help | Defaults | Apply as far as I can tell. Then why was launch wrong? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17458 To: davidedmundson, #plasma,

D17346: Support Bluetooth batteries

broulik added a comment. > Does it have to be in the Plasma theme? Yes, to be consistent with the other Bluetooth icons we have in there REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17346 To: broulik, #plasma, bruns, #vdg Cc: ndavis, plasma-devel, ra

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. In D16031#373947 , @filipf wrote: > In D16031#373904 , @raddison wrote: > > > > but I don't see why the lock and login screens should necessarily be identical in design >

D17346: Support Bluetooth batteries

ndavis added a comment. Does it have to be in the Plasma theme? I want to move all icons into breeze-icons eventually. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17346 To: broulik, #plasma, bruns, #vdg Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot,

D17458: Add help button to KCMs where it was missing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc8545f9d2d5: Add help button to KCMs where it was missing (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17458?vs=47203&id=472

D17467: digital-clock: Show events on expanding applet

mbehrendt added a reviewer: Plasma. mbehrendt added a comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17467 To: mbehrendt, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47256. mbehrendt marked an inline comment as done. mbehrendt added a comment. fix typos REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47255&id=47256 REVISION DETAIL https://phabricator.kde.org/D1

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47255. mbehrendt added a comment. only once set hasExpanded = true REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47252&id=47255 REVISION DETAIL https://phabricator.kde.org/D17467 AFFECTED FILES

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

zzag added a comment. > - if any virtual desktop is removed, then System Settings window will be sent to the last virtual desktop. This seems to be a bug in KWin core. --- "Navigation wraps around" and the other check boxes initially don't represent the actual state, e.g. RollO

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47252. mbehrendt added a comment. This should even be lighter REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47248&id=47252 REVISION DETAIL https://phabricator.kde.org/D17467 AFFECTED FILES app

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47248. mbehrendt added a comment. Besides checking for isExpanded this prevents from updating the holidaysList twice by checking if the date needs to be reset. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D17464: [Timer applet] Minor fixes for the applet

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in TimerView.qml:65 > I dislike the clock code, but if you leave a comment of why it's that way, > then ok. Clock is 0.71 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17464 To: gepa

D16918: [dimdisplay] Do not change screen brightness on invalid values

anthonyfieroni added a comment. Isn't there. https://phabricator.kde.org/source/powerdevil/browse/master/daemon/backends/upower/xrandrbrightness.cpp$160 You can investigate on what backend it's used for you and it may set value only one output not to all. REPOSITORY R122 Powerdevil REVIS

D17458: Add help button to KCMs where it was missing

broulik added a comment. You beat me to it :( I think one can just remove the buttons meddling, the default is `Help | Defaults | Apply` as far as I can tell. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17458 To: davidedmundson, #plasma,

D17467: digital-clock: Show events on expanding applet

broulik added inline comments. INLINE COMMENTS > CalendarView.qml:55 > monthView.resetToToday(); > +holidaysList.update(); > } I think this should check for `isExpanded` so it does not update the events (potentially heavy operation) when *closing* REPOSITORY R120 Plasma

D16918: [dimdisplay] Do not change screen brightness on invalid values

thsurrel added a comment. Neither helped... The problem may not be in plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16918 To: anthonyfieroni, #plasma, broulik, mart Cc: thsurrel, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, j