D17552: Fix 2 typos

2018-12-12 Thread Emmanuel Lepage Vallee 
lepagevalleeemmanuel created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
lepagevalleeemmanuel requested review of this revision.

REVISION SUMMARY
  There is 2 instances of instabnce

TEST PLAN
  none, this will totally regress ;)
  
  But maybe teaching Krazy2 to read QML comments would help

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17552

AFFECTED FILES
  src/controls/Page.qml
  src/controls/ScrollablePage.qml

To: lepagevalleeemmanuel
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17551: Take the scrollbar into account for the ScrollablePage margin

2018-12-12 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  BUG: 401972

TEST PLAN
  Now I never get that overlapping, it could have other ramifications though.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17551

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17225: Update translation kcm docbook to plasma 5.14

2018-12-12 Thread Burkhard Lück 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c1b9e8003feb: Update translation kcm docbook to plasma 
5.14 (authored by lueck).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17225?vs=46428=47472

REVISION DETAIL
  https://phabricator.kde.org/D17225

AFFECTED FILES
  doc/kcontrol/translations/index.docbook

To: lueck, #plasma, #documentation, yurchor
Cc: plasma-devel, kde-doc-english, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17531: Don't exec() hint about deactivating URL grabber

2018-12-12 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fb918b6440ce: Dont exec() hint about deactivating 
URL grabber (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17531?vs=47431=47459

REVISION DETAIL
  https://phabricator.kde.org/D17531

AFFECTED FILES
  klipper/klipper.cpp

To: broulik, #plasma, davidedmundson, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purprose more clear

2018-12-12 Thread Andras Mantia 
amantia updated this revision to Diff 47441.
amantia added a comment.


  Reworked, by reshuffling the dialog text, instead of renaming the buttons

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17533?vs=47434=47441

BRANCH
  accesbility_dialog_improvement

REVISION DETAIL
  https://phabricator.kde.org/D17533

AFFECTED FILES
  kaccess/kaccess.cpp
  kaccess/kaccess.h

To: amantia, #plasma_accessibility, davidedmundson, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purprose more clear

2018-12-12 Thread Andras Mantia 
amantia planned changes to this revision.
amantia added a comment.


  Will have to rework, I missed some cases(the dialog might as to activate. 
deactivate or "activate some, deactivate others"), it is not as simple as I 
thought.

INLINE COMMENTS

> davidedmundson wrote in kaccess.cpp:713
> can we choose another role here?

Oops.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purprose more clear

2018-12-12 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> kaccess.cpp:713
> +buttons->addButton(i18n("Activate"), QDialogButtonBox::AcceptRole);
> +buttons->addButton(i18n("Do Not Activate"), 
> QDialogButtonBox::AcceptRole);
>  

can we choose another role here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17536: Make accessibility warning dialog usable again and fix event handling

2018-12-12 Thread Andras Mantia 
amantia added a comment.


  Accessibility bugfixes cherry picked from master

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17536

To: amantia, #plasma_accessibility, #plasma, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17536: Make accessibility warning dialog usable again and fix event handling

2018-12-12 Thread Andras Mantia 
amantia created this revision.
amantia added reviewers: Plasma Accessibility, Plasma, aacid.
amantia added a project: Plasma.
amantia requested review of this revision.

REVISION SUMMARY
  Layout was completely broken, resulting in an empty dialog.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17536

AFFECTED FILES
  kaccess/kaccess.cpp

To: amantia, #plasma_accessibility, #plasma, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17532: Show tooltip for pinning system tray and calendar

2018-12-12 Thread Shubham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:977d2aadd522: Show tooltip for pinning system tray and 
calendar (authored by shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17532?vs=47433=47437

REVISION DETAIL
  https://phabricator.kde.org/D17532

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17532: Show tooltip for pinning system tray and calendar

2018-12-12 Thread Shubham 
shubham updated this revision to Diff 47433.
shubham edited the summary of this revision.
shubham added a comment.


  "Keep Open"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17532?vs=47432=47433

REVISION DETAIL
  https://phabricator.kde.org/D17532

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purprose more clear

2018-12-12 Thread Andras Mantia 
amantia created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
amantia requested review of this revision.

REVISION SUMMARY
  BUG: 190369

REPOSITORY
  R119 Plasma Desktop

BRANCH
  accesbility_dialog_improvement

REVISION DETAIL
  https://phabricator.kde.org/D17533

AFFECTED FILES
  kaccess/kaccess.cpp

To: amantia
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17532: Show tooltip for pinning system tray and calendar

2018-12-12 Thread Kai Uwe Broulik 
broulik added a comment.


  Keep instead of Leave?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17532

To: shubham, mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17532: Show tooltip for pinning system tray and calendar

2018-12-12 Thread Shubham 
shubham created this revision.
shubham added reviewers: mart, Plasma.
shubham added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  F6472870: 1.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17532

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17531: Don't exec() hint about deactivating URL grabber

2018-12-12 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, graesslin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Nested event loops in conjunction with QML are dangerous.
  Port to `QMessageBox` which can be used without `exec()`
  
  BUG: 363771

TEST PLAN
  5.12? 5.14? master?
  
  - Pressed Ctrl+Alt+X to enable the URL grabber, selected a URL in the browser:
  - Plasma stay interactive
  - Doesn't crash anymore
  - Text still translated (ie. didn't break the translation)
  - Doesn't make a "ding" sound anymore but I didn't find a way to use 
`KMessageBox` without `exec()`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17531

AFFECTED FILES
  klipper/klipper.cpp

To: broulik, #plasma, davidedmundson, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17527: [Chrome Bookmark Runner] Use QJsonObject directly

2018-12-12 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of converting to `QVariantMap` first.
  Also, port code touched as part of this to range for

TEST PLAN
  Saves some cycles on a query, 0.1ms here,
  bookmarks are still found

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17527

AFFECTED FILES
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart