D18559: Use correct sidebar back button press color

2019-01-26 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The system settings currently use a wrong sidebar back button press color, which can look very bad on

D15304: [KCM] Port to QQC2

2019-01-26 Thread Aleix Pol Gonzalez
apol added a comment. (Catching up with e-mail) did this fall through? REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D15304 REVISION DETAIL https://phabricator.kde.org/D15304 To: ngraham, #plasma, drosca Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel,

D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

2019-01-26 Thread Aleix Pol Gonzalez
apol added a comment. (Catching up with e-mail) did this fall through? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18322 To: broulik, #plasma Cc: apol, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Ben Cooksley
On Sun, Jan 27, 2019 at 6:41 AM Albert Astals Cid wrote: > > El dissabte, 26 de gener de 2019, a les 13:05:23 CET, Bhushan Shah va > escriure: > > > > > > Can we try to get this documented? 1.7GB isn't a lot for lots of people > > > with fast internet (if the server serves fast enough). > > > >

D18508: Somewhat guard failing to load backend

2019-01-26 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R110:08d494c401cb: Guard failing to load backend (authored by davidedmundson). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18508?vs=50211=50342 REVISION

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Albert Astals Cid
El dissabte, 26 de gener de 2019, a les 13:05:23 CET, Bhushan Shah va escriure: > > > > Can we try to get this documented? 1.7GB isn't a lot for lots of people > > with fast internet (if the server serves fast enough). > > https://invent.kde.org/sysadmin/ci-tooling/wikis/CI-On-Local-Machine >

D15304: [KCM] Port to QQC2

2019-01-26 Thread Nathaniel Graham
ngraham added a comment. I understand and agree. We definitely need to fix https://bugs.kde.org/show_bug.cgi?id=394295 and https://bugs.kde.org/show_bug.cgi?id=394296 to make the QQC2 TabBar actually usable without all these client workarounds. I'm okay with committing this now and

D15304: [KCM] Port to QQC2

2019-01-26 Thread David Rosca
drosca accepted this revision. drosca added a comment. I don't really like that this port became full of workarounds to be honest, but if it works and there's no other way then fine. REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D15304 REVISION DETAIL

D15304: [KCM] Port to QQC2

2019-01-26 Thread Nathaniel Graham
ngraham updated this revision to Diff 50328. ngraham edited the summary of this revision. ngraham added a comment. Update workaround comments to reflect the actual bugs REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=50088=50328

Re: Help for finding a File

2019-01-26 Thread Nate Graham
On 1/26/19 2:49 AM, Raghavendra Vijaya wrote: Hello Plasma Devs,             I was searching for the slide-show wallpaper code in the plasma codebase, can anyone help me out to find the code and share the where actually the file is.

D18546: [Desktop Toolbox] Use "tools" icon

2019-01-26 Thread Nathaniel Graham
ngraham added a comment. I've started a Phab task to discuss the issue from a higher level: T10402: The Desktop Toolbox . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18546 To: ngraham, #vdg, #plasma Cc: Codezela, GB_2,

D18546: [Desktop Toolbox] Use "tools" icon

2019-01-26 Thread Noah Davis
ndavis added a comment. If we are going to change the name, I would suggest changing it to something that has a similar meaning to "edit the desktop" and change the icon to something that means "edit". That's the primary use for this widget anyway. REPOSITORY R119 Plasma Desktop REVISION

D18546: [Desktop Toolbox] Use "tools" icon

2019-01-26 Thread Noah Davis
ndavis added a comment. In D18546#400325 , @Codezela wrote: > In D18546#400256 , @GB_2 wrote: > > > In D18546#400253 , @hein wrote: > > > > > How about

D18546: [Desktop Toolbox] Use "tools" icon

2019-01-26 Thread Hazem Salem
Codezela added a comment. In D18546#400256 , @GB_2 wrote: > In D18546#400253 , @hein wrote: > > > How about we actually rename it "Desktop Menu". > > > +1, good idea! or we can remove

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Bhushan Shah
> > Can we try to get this documented? 1.7GB isn't a lot for lots of people with > fast internet (if the server serves fast enough). https://invent.kde.org/sysadmin/ci-tooling/wikis/CI-On-Local-Machine I have added some initial documentation here, which I will improve later. -- Bhushan Shah

D16658: Respect the display property of buttons

2019-01-26 Thread Alexander Stippich
astippich added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Albert Astals Cid
El dissabte, 26 de gener de 2019, a les 9:13:45 CET, Ben Cooksley va escriure: > On Sat, Jan 26, 2019 at 10:35 AM Albert Astals Cid wrote: > > > > El dilluns, 21 de gener de 2019, a les 6:46:32 CET, Ben Cooksley va > > escriure: > > > Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben

Help for finding a File

2019-01-26 Thread Raghavendra Vijaya
Hello Plasma Devs, I was searching for the slide-show wallpaper code in the plasma codebase, can anyone help me out to find the code and share the where actually the file is. -- Regards Raghavendra Vijaya Member at *FOSS@Amrita* *Github

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 7 - Fixed!

2019-01-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.12/7/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 26 Jan 2019 08:54:47 + Build duration: 3 min 42 sec and counting

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 6 - Failure!

2019-01-26 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Ben Cooksley
On Sat, Jan 26, 2019 at 10:35 AM Albert Astals Cid wrote: > > El dilluns, 21 de gener de 2019, a les 6:46:32 CET, Ben Cooksley va escriure: > > Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. > > Committed on 21/01/2019 at 05:46. > > Pushed by bcooksley into branch 'master'.