KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 29 Jan 2019 04:38:16 + Build duration: 2 hr 32 min and counting CONSOLE OUTPUT [...truncated

D18579: Rework Sensor Browser

argonel added inline comments. INLINE COMMENTS > SensorBrowser.cpp:51 > +const int id; > +KSGRD::SensorAgent * sensorAgent; > +const QString hostName; This one caused me to notice the style issues. The rule is "For pointers or references, use a single space before '*' or '&', but

D18571: Add "apply on double-click" feature to most other recent ported KCMs

pino added a comment. -1 for this: - hidden feature - it does not make sense when the general paradigm is OK/Apply/Cancel, so we are teaching users that options are applied only when OK/Apply is pressed (and thus they are left free to play with options as they fit) - if an user

D18395: Use new toolbox icon for "Tools" dropdown menu button

This revision was automatically updated to reflect the committed changes. Closed by commit R111:0ff5b31d5dd9: Use new toolbox icon for Tools dropdown menu button (authored by ngraham). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D18580: Accept commas to separate processes on the Search Edit

ngraham added a comment. One possible avenue for even further improvement: support PIDs in comma-separated lists, too. REPOSITORY R111 KSysguard Library BRANCH acceptCommasSearch REVISION DETAIL https://phabricator.kde.org/D18580 To: tcanabrava, ngraham Cc: rizzitello, plasma-devel,

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham added a comment. In D18571#401567 , @ndavis wrote: > I think having some hidden, non-essential features that speed things up here and there is not a bad idea. It's not an objective reason, but I think a lot of people enjoy finding

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ndavis added a comment. In D18571#401553 , @ngraham wrote: > One of the things I loved about macOS when I was a user was how many little hidden accelerators like this were sprinkled throughout the OS. You don't find them unless you go looking,

D18580: Accept commas to separate processes on the Search Edit

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great! Wanna review D18395 ? REPOSITORY R111 KSysguard Library BRANCH acceptCommasSearch REVISION DETAIL

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham added a comment. One of the things I loved about macOS when I was a user was how many little hidden accelerators like this were sprinkled throughout the OS. You don't find them unless you go looking, but once you've found them, they're indispensable. There was a whole website I used

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17983 To: pino, apol Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18572: [Image wallpaper] Use units from Kirigami rather than PlasmaCore

ngraham abandoned this revision. ngraham added a comment. Whoops, so it is! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18572 To: ngraham, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18575: Remove warning before hidding the MenuBar

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. > No other KDE app does this That's not true. Kate and Gwenview do this too, and for good reason: without this warning, there's no way to know how to get the menu bar back

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:32d76665a694: [plasma-nm/applet] Add right-click context menu to directly customize a… (authored by vpilo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

davidedmundson added a comment. Can we keep this discussion of licenses on "Licensing policy change proposal" on the KDE community thread so info is not split. REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc:

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

jriddell added a comment. > The Unsplash license is CC0 (public domain) with only one exception: the images are not to be used to start or advance that's a competitor of Unsplash. > The Pexels license has more restrictions. These additional restrictions make them non-free. They do

Monday meeting minutes for 2019-01-28 (week 5)

d_ed ‎I did a few little bug fixes, mostly in the cursors KCM ‎In bigger changes, my patch supporting shadows in KWindowSystem is nearly done ‎That reminds me. I had a tiny compositor written in kwayland that used to recreate the firefox issue ‎Firefox now works there ! ‎...but still

D18580: Accept commas to separate processes on the Search Edit

rizzitello added a comment. +1 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D18580 To: tcanabrava Cc: rizzitello, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18580: Accept commas to separate processes on the Search Edit

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R111 KSysguard Library BRANCH acceptCommasSearch REVISION DETAIL https://phabricator.kde.org/D18580 AFFECTED FILES

D18579: Rework Sensor Browser

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Move public classes to Internal Structs Make sure we are not accessing something wrong No need to clear on destruction

D18578: Reduce string objects

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY QStringLiteral cannot deal with duplicates, so each invokation in the same file with the same string will create a

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

rooty added a comment. In D18078#401227 , @jriddell wrote: > Note we cannot ship files under the Pexels License or Unsplash licence as they are non-free and have restrictions. > > We can ship files in the public domain as they are

D18576: Simpe C updates to ksysguardd code

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Use C 11, it has better defaults Simplify if - chain Reduce variable scope Don't check before free REPOSITORY R106

D18575: Remove warning before hidding the MenuBar

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY No other KDE app does this, while also allowing to show / hide the menubar. This actualy seemed quite extreme as there's no

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Budgie as well: https://github.com/UbuntuBudgie/budgie-wallpapers/blob/master/debian/copyright REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: jriddell, lydia, davidedmundson, abetts,

D18489: warnings--

This revision was automatically updated to reflect the committed changes. Closed by commit R124:6c40ed4c42ab: warnings-- (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18489?vs=50158=50417 REVISION DETAIL

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Those licences are basically CC0 with minor additions. Photos are free to use. Where does the issue lie, that they're formally not listed somewhere as free licences? If they're really non-free, how can they ship them in GNOME and Elementary then?

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

jriddell added a comment. Note we cannot ship files under the Pexels License or Unsplash licence as they are non-free and have restrictions. We can ship files in the public domain as they are unrestricted. REPOSITORY R131 Plasma Wallpapers REVISION DETAIL

D18347: [wallpapers/image] Don't use PlasmaCore in desktop themed UI

This revision was automatically updated to reflect the committed changes. Closed by commit R120:98d9f681a37e: [wallpapers/image] Dont use PlasmaCore in desktop themed UI (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18347?vs=49778=50415#toc REPOSITORY

D18571: Add "apply on double-click" feature to most other recent ported KCMs

davidedmundson added a comment. We should definitely be consistent. So either this or removing it from colours. Personally I don't like it, we don't use double click anywhere else throughout all of Plasma, and given there's no visual hint upfront from a user POV it's random behaviour.

D18572: [Image wallpaper] Use units from Kirigami rather than PlasmaCore

davidedmundson added a comment. Isn't this https://phabricator.kde.org/D18347? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18572 To: ngraham, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17983: StatusItemNotifier: fix overlays by name with icons by name

davidedmundson added a comment. > Thanks -- which branch should I push this to? > Plasma/5.12 If there's no risk of regression, yes. That's a judgement call I think you're in the best position to make. (IMHO it should be fine, the absolutely worst case is some slightly wrong