D18867: Remove redundant DNS field per bug 403546

andersonbruce added a comment. Any connection created by the previous version or the basic NetworkManager plugin should continue to work even though the DNS server list will not be viewable in the new interface. I did not provide an automatic conversion from a previously created

D18867: Remove redundant DNS field per bug 403546

andersonbruce created this revision. andersonbruce added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. andersonbruce requested review of this revision. REVISION SUMMARY A DNS field was included on

D18716: Add a TextField component

ognarb added inline comments. INLINE COMMENTS > TextField.qml:101 > +} > +icon.name: root.leftAction != null ? root.rightAction.iconName : "" > +visible: root.leftAction != null && root.leftAction.visible @mart I'm not sure if it's the right way to convert the icon from

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. Just tried again with a clean build directory, and there's no change. :( Maybe @davidedmundson can shed some light on this puzzle? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham Cc:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 5 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/5/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 22:41:37 + Build duration: 6 min 2 sec and counting BUILD ARTIFACTS

D18861: Improve the Fonts KCM UI

ngraham added a comment. The other ordering is more English-like, but your suggestion would probably be fine too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham, rooty, plasma-devel, #vdg,

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/3/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 22:41:36 + Build duration: 3 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/7/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 22:41:36 + Build duration: 3 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/8/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 08 Feb 2019 22:41:38 + Build duration: 3 min 21 sec and counting JUnit Tests

D18861: Improve the Fonts KCM UI

GB_2 added a comment. What about `Noto Sans 10pt`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre marked an inline comment as done. davidre added a comment. In D18809#408175 , @ngraham wrote: > Could be. Since this is going to land on the master branch (because it's a new feature, not a bugfix), ideally should be developing on the

D18861: Improve the Fonts KCM UI

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. All right, let's do that. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham,

D18861: Improve the Fonts KCM UI

ndavis added a comment. In D18861#408286 , @ngraham wrote: > Personally my preference would be for the strings to be like this: `10 pt Noto Sans` That would be fine too since it reads like English. The `|` character makes it seem like

D18861: Improve the Fonts KCM UI

ngraham added a comment. Personally my preference would be for the strings to be like this: `10 pt Noto Sans` REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham, rooty,

D18861: Improve the Fonts KCM UI

ndavis added a comment. I don't like the look of the `|` character between the font name and the font size. I think the existing "Noto Sans 10" format looked better, but I'm not going to formally request changes. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D18859: msvc: First commit

ngraham added a comment. Then it should not have been submitted yet, or it should have [WIP] at the beginning of the title. :) REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelectric Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18859: msvc: First commit

patrickelectric added a comment. thank you @ngraham, but this is not ready to review yet. But be free to review @D18801 and @D18802 REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelectric Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added inline comments. INLINE COMMENTS > davidre wrote in image.cpp:877 > Yes I also saw this method since the backgroundlist uses it but the Header > said to use KRun if you want to open a folder instead of it. Well it just depends on what you want to do. If you want to open the

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre marked an inline comment as done. davidre added inline comments. INLINE COMMENTS > ngraham wrote in image.cpp:877 > This generates a warning (variable `krun` is unused). I would suggest using > `KIO::highlightInFileManager()` instead. For example: >

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51218. davidre added a comment. - Use highlightInFileManager instead of KRun REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51206=51218 BRANCH arcpatch-D18809 REVISION DETAIL

D18859: msvc: First commit

ngraham added a comment. The title and summary sections need to describe what this patch does. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelectric Cc: ngraham,

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:82b904bce54b: [Kickoff] Return Kickoff to Favorites page after running a search (authored by rooty). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18861: Improve the Fonts KCM UI

GB_2 updated this revision to Diff 51213. GB_2 added a comment. Change "Force fonts DPI" checkbox text to "Force font DPI" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18861?vs=51211=51213 BRANCH master REVISION DETAIL

D18859: msvc: First commit

patrickelectric updated this revision to Diff 51209. patrickelectric added a comment. - msvc: Add cdb configuration REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51207=51209 BRANCH msvc REVISION DETAIL https://phabricator.kde.org/D18859

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added inline comments. INLINE COMMENTS > image.cpp:877 > +{ > + KRun* krun = new KRun(QUrl::fromLocalFile(path), nullptr); > +} This generates a warning (variable `krun` is unused). I would suggest using `KIO::highlightInFileManager()` instead. For example:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. Could be. Since this is going to land on the master branch (because it's a new feature, not a bugfix), ideally should be developing on the master branch too. If your distro packages are too old to accommodate this, you can use `kdesrc-build` to build them

D18860: Add comment / description to the translations kcm

jbbgameich created this revision. jbbgameich added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Fixes inconsistency with other kcms TEST PLAN comment is displayed in

D18861: Improve the Fonts KCM UI

rooty added a comment. nice! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg Cc: rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. In D18809#408101 , @davidre wrote: > Are the images added immediately to the Gridview if you add a folder? Yep. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To:

D18859: msvc: First commit

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH msvc REVISION DETAIL

D18716: Add a SearchField component

ognarb updated this revision to Diff 51215. ognarb added a comment. Create a generic TextField instead REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=50813=51215 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18716 AFFECTED

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I don't know why the images aren't removed immediately on your side. I just did a clean build and removed everything from my installation prefix and it still works for me. Are you testing directly on the master branch? Maybe the difference is that I'm building on

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51206. davidre added a comment. - Show Tooltip with the full path REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51202=51206 BRANCH arcpatch-D18809 REVISION DETAIL

D18861: Improve the Fonts KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. No suggestions for improvement! I guess because this has already been discussed for weeks in the IRC channel. :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D18861: Improve the Fonts KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, adding icons and tooltips to

D18861: Improve the Fonts KCM UI

rooty accepted this revision. rooty added a comment. yeah we've been discussing this for weeks you've got my vote :D REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ngraham, rooty,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#408086 , @ngraham wrote: > In D18809#408015 , @davidre wrote: > > > In D18809#407355 , @ngraham wrote: > > > > > -

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51202. davidre added a comment. - Also handle paths not ending with / REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51193=51202 BRANCH slideshow-grid (branched from master) REVISION DETAIL

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. In D18809#408015 , @davidre wrote: > In D18809#407355 , @ngraham wrote: > > > - After removing a folder, the wallpaper grid should update immediately to reflect that >

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty updated this revision to Diff 51197. rooty added a comment. Reorder code instead of adding property changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18848?vs=51176=51197 BRANCH fix-kickoff-initial-aftersearch (branched from master)

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. > Doesn't that mean the code in switchToInitial just needs reordering to set the state (to Normal) first and then do the tab change? (Or alternatively the tab change could be cleaned away from the function.) You're right! That's a lot simpler than adding a

Re: Request for another 5.14 bugfix release

Yes as discussed on IRC right now we're planning on doing a 5.14.5.1 on Monday for the modules which need it. Jonathan On Fri, 8 Feb 2019 at 16:42, Nate Graham wrote: > > Hello release team! > > I would like to request that we consider doing one more Plasma 5.14 > bugfix release. 5.14.5 shipped

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. The video showing that the Gridview updates when I remove a Folder: F6601697: 2019-02-08 15-30-38.mp4 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham Cc:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51193. davidre added a comment. Show only folder name and show remove and open actions on hover REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51120=51193 BRANCH slideshow-grid (branched from

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#407355 , @ngraham wrote: > This is a huge improvement over what we have right now. Very nice job! Thanks! > A few behavioral issues: > > - After removing a folder, the wallpaper grid should

D17706: Fix lock screen focus

This revision was automatically updated to reflect the committed changes. Closed by commit R133:2fdf002b11cf: Fix lock screen focus (authored by andreyby, committed by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=50911=51194

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

hein added a comment. In D18848#407843 , @rooty wrote: > In D18848#407838 , @hein wrote: > > > This is a good change, but it's more worth finding out why it doesn't work already. Looking at the

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. The diff is automatically closed once Phab detects a commit associated with it, so you don't have to do that manually (most of the time at least; sometimes it's a tad buggy). REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff-initial-aftersearch (branched from

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407999 , @ngraham wrote: > The diff is automatically closed once Phab detects a commit associated with it, so you don't have to do that manually (most of the time at least; sometimes it's a tad buggy).

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407997 , @ngraham wrote: > Nah, `arc land` is just a fancy way of saying "take the commits on this branch and commit them onto the parent branch and then push the parent branch and then delete this branch" >

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. Nah, `arc land` is just a fancy way of saying "take the commits on this branch and commit them onto the parent branch and then push the parent branch and then delete this branch" You can always just do those things yourself if you'd like, which the above

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. Wow thanks! And after all is said and done, there's no need to run arc land? REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff-initial-aftersearch (branched from master) REVISION DETAIL https://phabricator.kde.org/D18848 To: rooty, #vdg, #plasma, ngraham Cc:

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. Regardless, let's wait for Eike's approval before landing this. Here's how I would do it, if and when it's time to land this patch: git checkout Plasma/5.12 git cherry-pick 2c3b1ee1995692aaa68e4d3c76e9bf37565741b2 git push git checkout

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. Can I use Kai's suggestion to git checkout Plasma/5.12 then commit then checkout Plasma/5.15 then merge Plasma/5.12, then checkout master then merge Plasma/5.15? Will this work if I cloned it off of anongit.kde.org (and not github.com)? REPOSITORY R119 Plasma

D18805: Workaround for the bug 393630 - SystemTray part

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6fcf9a5e03ba: Fix System Tray popup interactivity after echanging item visiblity (authored by trmdi, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15512: [startplasmacompositor] Add Wayland socket argument

romangg abandoned this revision. romangg added a comment. Superseded by D17122 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15512 To: romangg, #kwin, #plasma Cc: zzag, graesslin, fvogt, plasma-devel, jraleigh, GB_2,

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407897 , @ngraham wrote: > BTW your `FIXED-IN` tag says 5.12.x, but this patch was branched off of master. So if and when this lands, if you don't do anything special, it's currently going to master only. To

D15512: [startplasmacompositor] Add Wayland socket argument

zzag added a comment. In D15512#359309 , @fvogt wrote: > kwin_wayland just needs to make use of `wl_display_add_socket_auto` (other compositors do as well). It looks like now it does that. REPOSITORY R120 Plasma Workspace REVISION

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. BTW your `FIXED-IN` tag says 5.12.x, but this patch was branched off of master. So if and when this lands, if you don't do anything special, it's currently going to master only. To land it on 5.12.8, the easiest thing is to just cherry-pick the commit hash onto

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice fix, seems sensible enough to be explicit. Confirmed the bug and that this fixes it. REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff-initial-aftersearch (branched from

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407838 , @hein wrote: > This is a good change, but it's more worth finding out why it doesn't work already. Looking at the code, when `KickoffItem` is triggered it runs the `switchToInitial()` function in

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

hein added a comment. This is a good change, but it's more worth finding out why it doesn't work already. Looking at the code, when `KickoffItem` is triggered it runs the `switchToInitial()` function in FullRepresentation.qml, which already switches tabs and is also what sets the state back

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

filipf added a comment. Fixes the bug for me. I also reproduced it in 5.12 so you should add: FIXED-IN: 5.12.8 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18848 To: rooty, #vdg, #plasma Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18848: [Kickoff] Return Kickoff to Favorites page after running a search

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch fixes the bug that would make Kickoff retain the contents of the tab that was selected when a search was run from a tab

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

dkardarakos updated this revision to Diff 51172. dkardarakos edited the summary of this revision. dkardarakos added a comment. Changed links that pointed to the kirigami repository, to kirigami-gallery which is more useful for the contributors. REPOSITORY R1014 Kirigami Gallery CHANGES

D18806: bump to cmake requirement to 3.5

This revision was automatically updated to reflect the committed changes. Closed by commit R115:908501f116e7: bump to cmake requirement to 3.5 (authored by sitter). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18806?vs=51083=51166

D18844: Fix opening toolbox button

This revision was automatically updated to reflect the committed changes. Closed by commit R119:67d8ac416ff6: Use Dialogs visibility directly rather than relying on the mainItems (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18785: Use different Font Management KCM "All Fonts" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e5ef9c97e75e: Use different Font Management KCM All Fonts icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18785?vs=51115=51162

D18844: Fix opening toolbox button

davidedmundson added a comment. That framework change is released tomorrow, right? Is it worth reverting? Including this, that's at least the second regression it's caused, which makes me worry there's even more we haven't found. > It should have used Dialog's visiblity from the

D18844: Fix opening toolbox button

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Works. No side effects. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18844 To: broulik, #plasma, lbeltrame Cc: lbeltrame, plasma-devel, jraleigh,

D18844: Fix opening toolbox button

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `Dialog` no longer alters the `mainItem`'s visiblity, so this codepath failed. It should have

D18840: [Containment Actions Configuration] Fix changing plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R119:42fb1de1b3fa: [Containment Actions Configuration] Fix changing plugin (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18840: [Containment Actions Configuration] Fix changing plugin

davidedmundson added inline comments. INLINE COMMENTS > ConfigurationContainmentActions.qml:98 > +// "index" argument of onActivated shadows the model index > +readonly property int pluginIndex: index > Layout.fillWidth: true would just

D18840: [Containment Actions Configuration] Fix changing plugin

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in ConfigurationContainmentActions.qml:98 > would just explicitly using "pluginsCombo.index" also work? No, because `index` is a "magic" context property set by the `Repeater`, there is no "physical" property you can access

D17796: Show accurate checked state for system monitor configuration pages

broulik added a comment. > The call on line 141 looks superfluous - if there's any change to checked we modify cfg_sources which should trigger the reload. QML cannot detect changes within a JS structure, if you `push()` into an `Array` or modify members of an `Object` it doesn't see

D17796: Show accurate checked state for system monitor configuration pages

pavelmos added a comment. I have no commit access. REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D18840: [Containment Actions Configuration] Fix changing plugin

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The `index` argument of the `activated` signal shadows the `index` context property of the

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Info sheet is fed by a single json file that contains extra info and links to

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. In D18805#407599 , @fvogt wrote: > You can select "Abandon revision" as action. Done. Thank you. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi, #plasma,

D18805: Workaround for the bug 393630 - SystemTray part

fvogt added a comment. In D18805#407542 , @trmdi wrote: > Use @davidedmundson 's approach. > > @ngraham Could you please help me to discard D18804 ? This patch does not require it anymore. You can