D18896: [plasma-nm] Refresh wifi networks as fast as possible

jgrulich added inline comments. INLINE COMMENTS > handler.cpp:64 > > +namespace { > +const int wirelessScanRetryInterval = 2000; // Interval (in ms) between > attempts to scan for wifi networks It doesn't need to be in namespace. > handler.cpp:444 > +qCDebug(PLASMA_NM) << "Trying

D18896: [plasma-nm] Refresh wifi networks as fast as possible

jgrulich added a comment. I would keep the 15s interval, everyone does 15s. Also from what I have read, every scan drops your connection for a while, which might be a problem for bad wifi drivers, where the scan can take 15+ seconds so doing this more often is not a good idea. Other thing I

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. I couldn't really sleep last night so i made this one too F6606942: image.png Any and all input regarding the design of the icons is appreciated :D REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51389. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51387=51389 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES app/view/contextmenu.cpp app/view/view.cpp app/view/view.h To: trmdi,

D18918: Make the text of "View Settings" action more specific

trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY If it's a dock -> Dock Settings... If it's a panel -> Panel Settings... REPOSITORY R878 Latte

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. In D18893#409220 , @ngraham wrote: > Yeah, like a line-art representation of the horizontal switcher, and a line-art representation of a username/password prompt. How's this for the switcher? F6606370:

Re: freedesktop.org meeting again?

Am Mo., 11. Feb. 2019 um 00:06 Uhr schrieb Aleix Pol : > > On Sat, Feb 9, 2019 at 1:32 PM David Faure wrote: >> >> Is anyone interested in participating in a technical meeting with other >> desktop environments? >> >> I did that years ago and this is how we came up with various shared >>

Re: freedesktop.org meeting again?

On Sat, Feb 9, 2019 at 1:32 PM David Faure wrote: > Is anyone interested in participating in a technical meeting with other > desktop environments? > > I did that years ago and this is how we came up with various shared > specifications, but at this point it might be more useful for people >

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

ngraham added reviewers: Plasma, romangg, davidedmundson. ngraham added a comment. Sweet! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18912 To: atulbi, ngraham, #plasma, romangg, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY - Added Properties to wayland Backend - User can switch between areas and clickfinger methods if touchpads has no physical

D18801: CMakeLists: Fix bfd.h include path on windows

This revision was automatically updated to reflect the committed changes. Closed by commit R871:3102b477d03d: CMakeLists: Fix bfd.h include path on windows (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51360=51361

D18801: CMakeLists: Fix bfd.h include path on windows

patrickelectric updated this revision to Diff 51360. patrickelectric added a comment. Fix Tomaz REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51256=51360 BRANCH arcpatch-D18801 REVISION DETAIL https://phabricator.kde.org/D18801 AFFECTED

D18908: [SwipeListItem] Use a real toolbutton to improve usability

ngraham added inline comments. INLINE COMMENTS > apol wrote in SwipeListItem.qml:265 > Should move these values to Units, can be done in a separate patch. Sure, will do that after this lands. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18908 To: ngraham, mart,

D18802: Fix pragma once problem with process class

This revision was automatically updated to reflect the committed changes. Closed by commit R871:e01d73c3c3be: Fix pragma once problem with process class (authored by patrickelectric). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18802?vs=51257=51358#toc REPOSITORY R871 DrKonqi

D18908: [SwipeListItem] Use a real toolbutton to improve usability

ngraham updated this revision to Diff 51357. ngraham marked an inline comment as done. ngraham added a comment. Remove unnecessary `hoverEnabled` property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18908?vs=51343=51357 BRANCH use-real-toolbuttons

D18796: [PassiveNotification] Don't start timer until window has focus

ngraham added inline comments. INLINE COMMENTS > mart wrote in PassiveNotification.qml:65 > this will probably mke the timer always running when the window has focus > whether or not there is a notificationshown or not? > something like: > > Connections { > target:root.Window >

D18801: CMakeLists: Fix bfd.h include path on windows

tcanabrava accepted this revision. tcanabrava added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:71 > +find_path(BFD_INCLUDE_DIR bfd.h) > +include_directories("${BFD_INCLUDE_DIR}") > endif() you don't need the quotes here.

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. Sounds good to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I just tested it and it seems we're both right . It seems if a path ends with a slash (i.e. if you typed the path in in the selection dialog) it opens the folder itself while opening the containing folder otherwise. To make this consistent i would like to go back to

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added inline comments. INLINE COMMENTS > config.qml:269 > +icon.name: "document-open-folder" > +tooltip: > i18nd("plasma_wallpaper_org.kde.image", "Open Folder") > +onTriggered:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51348. davidre added a comment. - Change copypasted "Open Containing Folder" to "Open Folder" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51347=51348 BRANCH arcpatch-D18809_1 REVISION DETAIL

D18908: [SwipeListItem] Use a real toolbutton to improve usability

apol added a comment. Overall +1 INLINE COMMENTS > SwipeListItem.qml:264 > } > -MouseArea { > -id: actionMouse > -anchors { > -fill: parent; > -

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#409429 , @davidre wrote: > I have a hard time figuring out how to hide the tooltip if a tooltip of an action is shown. Is there any way to detect this or get to the actions' tooltips to check if they are

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51347. davidre added a comment. - Use attached tooltip REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51218=51347 BRANCH arcpatch-D18809_1 REVISION DETAIL https://phabricator.kde.org/D18809

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I have a hard time figuring out how to hide the tooltip if a tooltip of an action is shown. Is there any way to detect this or get to the actions' tooltips to check if they are visible? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18908: [SwipeListItem] Use a real toolbutton to improve usability

ngraham created this revision. ngraham added reviewers: mart, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Use a real toolbutton instead of a custom icon + mouse area, which provides hovered

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. Actually we can't really put the folder list on the right of the controls because most of that area is not drawn by the wallpaper plugin UI itself, but by the parent UI that allows selecting plugins. I agree that it's a bit wasteful to have a huge tall list for only

D18766: Don't show tooltip when search field has text

ngraham added a comment. Here are the instructions: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 Let me know if anything is unclear. REPOSITORY R134 Discover Software Store BRANCH search REVISION DETAIL

D18903: Make Appearance KCMs' labels consistent

ngraham added a comment. Exactly. Let's not go in circles here. The `comment` field in the desktop file and the KAboutData description are really meant to be tooltips or captions, not titles. Let's not try to awkwardly force them to be titles as a workaround for the fact that our KCMs

D18903: Make Appearance KCMs' labels consistent

broulik added a comment. So you had all these comments changed to be "more natural" and now you change them back to how they were before? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik,

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. Thanks! This is pretty good as-is, and I can confirm that it works just fine. However once the user presses the button, there's no further feedback, which could encourage them to repeatedly press it again--not a good idea. Maybe while the initial index is being

D18903: Make Appearance KCMs' labels consistent

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Why are we doing this? The current one reads like a natural sentence, as a tooltip should; this is more like a title, but it's *not* a title. If we are trying to work around

D18903: Make Appearance KCMs' labels consistent

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Perfect! REPOSITORY R119 Plasma Desktop BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham,

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51329. filipf added a comment. address metadata.desktop files; add another change for app style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51328=51329 BRANCH 516-appearance-header-labels (branched

D18903: Make Appearance KCMs' labels consistent

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As per VDG agreement, change the textual style of Appearance KCMs' labels and make them consistent. REPOSITORY R119 Plasma

D18899: Don't use British English spelling

This revision was automatically updated to reflect the committed changes. Closed by commit R99:de23a94b5beb: Dont use British English spelling (authored by filipf, committed by rooty). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#409270 , @ngraham wrote: > Great! Just one more UI suggestion: use the string "Rebuild Index Database" Updated :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51325. guoyunhe added a comment. - Reset index database button align right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51324=51325 BRANCH master REVISION DETAIL

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. Great! Just one more UI suggestion: use the string "Rebuild Index Database" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov,

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#409258 , @ngraham wrote: > I wish this weren't necessary, but I think it's a good idea for the time being. > > Can you reduce the button width so it doesn't span the entire layout? It should be as small

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51324. guoyunhe added a comment. - Reset index database button align right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51294=51324 BRANCH master REVISION DETAIL

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. I wish this weren't necessary, but I think it's a good idea for the time being. Can you reduce the button width so it doesn't span the entire layout? It should be as small as possible and right-aligned. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

ngraham added a comment. Yeah, like a line-art representation of the horizontal switcher, and a line-art representation of a username/password prompt. REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL

D18860: Add comment / description to the translations kcm

jbbgameich updated this revision to Diff 51321. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=51210=51321 REVISION DETAIL https://phabricator.kde.org/D18860 AFFECTED FILES kcms/translations/kcm_translations.desktop To: jbbgameich, hein, #plasma Cc: apol, plasma-devel,

D18899: Don't use British English spelling

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Use "Behavior", not "Behaviour" for consistency reasons. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH no-behaviour

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. In D18893#409130 , @ngraham wrote: > If we do this, then "List Users" and "Type User" will both be using the same icons. Feels like we should use more appropriate ones that visually suggest what the page it will take you

D18892: Move Look and Feel KCM to top level

ngraham added subscribers: abetts, davidedmundson, ngraham. ngraham accepted this revision. ngraham added reviewers: davidedmundson, abetts. ngraham added a comment. This revision now requires review to proceed. I agree that this makes a lot of sense. However I want to make sure

D18896: [plasma-nm] Refresh wifi networks as fast as possible

vpilo created this revision. vpilo added reviewers: jgrulich, ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. vpilo requested review of this revision. REVISION SUMMARY The current 15s timeout is really

D18766: Don't show tooltip when search field has text

shubham added a comment. In D18766#409139 , @ngraham wrote: > Yes, let's land it. Please land it on the 5.15 branch and then merge to master. If you don't know how to do that, I can help you. Help will be welcome. REPOSITORY R134

D18766: Don't show tooltip when search field has text

ngraham added a comment. Yes, let's land it. Please land it on the 5.15 branch and then merge to master. If you don't know how to do that, I can help you. REPOSITORY R134 Discover Software Store BRANCH search REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol,

D18766: Don't show tooltip when search field has text

shubham added a comment. @ngraham Is it now behaving as it should? REPOSITORY R134 Discover Software Store BRANCH search REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18621: Add again a button to manually scan for wireless networks

vpilo abandoned this revision. vpilo added a comment. I am abandoning this revision, since a button would be useless 95% of the time, thanks to NetworkManager. I'm submitting an automated retry mechanism. Later, I'd like to try adding some status icon showing when a new scan has been

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

ngraham added a comment. If we do this, then "List Users" and "Type User" will both be using the same icons. Feels like we should use more appropriate ones that visually suggest what the page it will take you to actually looks like. REPOSITORY R120 Plasma Workspace BRANCH

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18893 To: rooty, #vdg, #plasma, filipf Cc:

D18860: Add comment / description to the translations kcm

apol added a comment. How about `System and applications language`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

alexde added a comment. In D18809#408482 , @davidre wrote: > Do you mean the Controls on the top? (...) Please correct me if I'm wrong. Exactly, but let's wait for the expertise of Nate and the rest of the VDG team as I am not sure

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds the buttons Suspend, Restart, Shut Down to the username prompt screen that appears once the Type User button is

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Bump(); REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart