D18939: KMenuEdit: add search/filter bar

2019-02-11 Thread Aidan Sojourner
tuxxi updated this revision to Diff 51468. tuxxi added a comment. - Switch to using QTreeView's methods for expand/collapse - Filter threshold is 2 chars like KOpenWithDialog to avoid cluttering - Reverted unnecessary changes (will do a different revision for refactor, error fixing, and

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi updated this revision to Diff 51464. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51459=51464 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18938: Show assigned shortcut in drawer action delegates

2019-02-11 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > apol wrote in ContextDrawerActionItem.qml:75 > this doesn't anchor to the text, won't the text be going over the shortcut if > it's too long? It's a layout (you don't anchor in them) ... did you see the screenshot and description? REPOSITORY

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi updated this revision to Diff 51459. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51458=51459 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi updated this revision to Diff 51458. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51456=51458 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18939: KMenuEdit: add search/filter bar

2019-02-11 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added reviewers: Plasma, cfeck. ngraham added a comment. This revision now requires changes to proceed. Thanks! All of those `.gitignore` changes look unintentional and unrelated and will need to be reverted. REPOSITORY R103 KMenu

D18939: KMenuEdit search/filter

2019-02-11 Thread Aidan Sojourner
tuxxi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tuxxi requested review of this revision. REVISION SUMMARY This diff contains a much-requested feature, adding a search or filter bar to KMenuEdit's application tree view. see: bug 57314

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi updated this revision to Diff 51456. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51431=51456 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp

D18938: Show assigned shortcut in drawer action delegates

2019-02-11 Thread Nathaniel Graham
ngraham added a comment. This makes sense when the drawer is being used as a sort of slide-in context menu. But in Discover for example, we make drawer be always visible (on desktop at least) and abuse it to hold navigation elements. Optional but on-by-default-for-actions would make

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R114:46204a5e2a84: [weather] Fix weather Notices tab not showing (authored by Zren). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18936?vs=51449=51455#toc REPOSITORY R114 Plasma Addons

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D18936#410274 , @Zren wrote: > Ah, `NoticesView.qml` in Plasma 5.12 was slightly different. > > - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml > -

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren added a comment. Ah, `NoticesView.qml` in Plasma 5.12 was slightly different. - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml -

D18938: Show assigned shortcut in drawer action delegates

2019-02-11 Thread Aleix Pol Gonzalez
apol added a comment. Feels a bit in-your-face to me, it can make sense for this application bug for e.g. Discover it would be a bit overwhelming. I'd prefer keeping it in the tooltip for something generic. INLINE COMMENTS > ContextDrawerActionItem.qml:75 > > +QQC2.Label { > +

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D18936#410267 , @Zren wrote: > Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future. Perhaps something

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren added a comment. Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future. Is there any other Ion besides EnvCanada that currently displays "Warnings"? I can definitely push to

D18938: Show assigned shortcut in drawer action delegates

2019-02-11 Thread Eike Hein
hein updated this revision to Diff 51454. hein added a comment. Fix typo. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18938?vs=51453=51454 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18938 AFFECTED FILES

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in NoticesView.qml:46 > Npt sure about this one, in my test data I always had >1 warnings/watches, > and left aligned then somehow looked better. > > But fine to +1 this for now, we can always change it later if we finally get >

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Well spotted. Seemed I had fooled myself as my test data always had both warnings & watches. And I never saw notices from real services when I tested, also not with the BBC service

D18938: Show assigned shortcut in drawer action delegates

2019-02-11 Thread Eike Hein
hein added a comment. Screenshot showing ellision: F6608910: Screenshot_20190212_091135.png @mart wanted me to add this to the desktop style's MenuItem as well, but I found no way to access the action data there and QQC2.MenuItem has no way to

D18938: Show assigned shortcut in drawer action delegates

2019-02-11 Thread Eike Hein
hein created this revision. hein added reviewers: mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY This is a big UI change, I'm not sure if it shouldn't be optional in some way. Some apps have set

Plasma 5.16 Kickoff Meeting poll

2019-02-11 Thread Jonathan Riddell
Plasma 5.16 Kickoff Meeting poll https://doodle.com/poll/p54673rpqsinctp8 Please indicate times you are available for a meeting to discuss plans for Plasma 5.16 cycle Meeting time is usually 1 to 2 hours long Remember to set your local timezone first to adjust Meeting will be on #plasma IRC

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren updated this revision to Diff 51449. Zren edited the summary of this revision. Zren added a comment. Add `Layout.alignment: Qt.AlignHCenter` to the `PlasmaExtras.Heading` F6608836: 2019-02-11___17-47-22.png REPOSITORY R114 Plasma Addons

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren added a comment. I just noticed that the "Warnings Issued" text is left aligned. Might as well center align it while we're at it. Add this as a child of `PlasmaExtras.Heading` to debug: Rectangle { anchors.fill: parent; border.color: "#f00"; border.width: 1; color:

D18936: [weather] Fix weather Notices tab not showing

2019-02-11 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY `Toronto, ON` in the `Env Canada` ion currently has a weather warning. The weather widget's code currently has a bug that will only show

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

2019-02-11 Thread Krešimir Čohar
rooty added a comment. We have to find a way to take care of the spacing now that the "moat" is gone Noto Sans 10 pt looks decent enough F6608742: image.png But some other fonts actually get pushed upward, see Ubuntu 10pt before: F6608745:

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

2019-02-11 Thread Filip Fila
filipf planned changes to this revision. filipf added a comment. Any help, as well as opinions, are appreciated. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18934 To: filipf, ngraham, #vdg, rooty, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen,

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

2019-02-11 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch ports the close button from a PlasmaComponents.Button to an IconItem so as to: 1. achieve better visuals -> the

D16658: Respect the display property of buttons

2019-02-11 Thread Alexander Stippich
astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Yunhe Guo
guoyunhe added a comment. In D18890#410137 , @davidedmundson wrote: > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? It is also possible to move this function to database corruption handler.

D18925: [Icon Applet] Parse jump list actions and open with actions on demand

2019-02-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b884003bebd7: [Icon Applet] Parse jump list actions and open with actions on demand (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread David Edmundson
davidedmundson added a comment. If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: davidedmundson, bruns, ngraham, plasma-devel,

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Yunhe Guo
guoyunhe added inline comments. INLINE COMMENTS > bruns wrote in kcm.cpp:197 > IMHO this whole block should be a single, blocking command in balooctl, i.e. > move the whole logic to balooctl. Will try. > bruns wrote in kcm.cpp:210 > Care to elaborate? If I run "balooctl start" in QProcess,

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > kcm.cpp:197 > +const QString rm = QStandardPaths::findExecutable(QStringLiteral("rm")); > +const QString balooctl = > QStandardPaths::findExecutable(QStringLiteral("balooctl")); > +const QString baloofile = >

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Nathaniel Graham
ngraham added a comment. No, I don't want a dialog window of any kind. Just a spinner on the page that says, "Indexing is in progress" or something was what I had in mind. An inline KMessageWidget is okay too. However my major concern was communicating to the user that something happened so

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Stefan Brüns
bruns added a comment. In D18890#409359 , @ngraham wrote: > Thanks! This is pretty good as-is, and I can confirm that it works just fine. However once the user presses the button, there's no further feedback, which could encourage them to

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Nathaniel Graham
ngraham added a comment. Thanks! 1. Could we use an inline `KMessageWidget` instead of a dialog box? Dialog boxes are annoying. 2. The text should be something more like "Database is now being rebuilt", since if I'm understanding the code, it will be displayed immediately. So it

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Yunhe Guo
guoyunhe updated this revision to Diff 51436. guoyunhe added a comment. - Make message box translatable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51435=51436 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18890

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Yunhe Guo
guoyunhe added a comment. Screenshot: F6608381: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov,

D18890: Add button to reset index database and repair Baloo crashing

2019-02-11 Thread Yunhe Guo
guoyunhe updated this revision to Diff 51435. guoyunhe added a comment. - Add message box for Rebuild Index Database button REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51325=51435 BRANCH master REVISION DETAIL

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Michail Vourlakos
mvourlakos requested changes to this revision. mvourlakos added a comment. This revision now requires changes to proceed. This patch should not touch Latte::View at all. All the code must be in the containmentactions/contextmenu.cpp class REPOSITORY R878 Latte Dock REVISION DETAIL

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi updated this revision to Diff 51431. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51389=51431 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES app/view/contextmenu.cpp app/view/view.cpp app/view/view.h To: trmdi,

D18926: add Type property for Latte::View

2019-02-11 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R878:7772ee2855c6: add Type property for Latte::View (authored by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18926?vs=51415=51430 REVISION DETAIL

D18929: Have task managers follow the desktop for window visibility behavior by default

2019-02-11 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ce2cc6349732: Have task managers follow the desktop for window visibility behavior by default (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi added a comment. In D18918#409852 , @mvourlakos wrote: > ok, just checked the previous mentioned class has access to containment() that means that through its configuration the menu could be informed for the type, so directly access to

D18929: Have task managers follow the desktop for window visibility behavior by default

2019-02-11 Thread Nathaniel Graham
ngraham added a comment. This makes a lot of sense to me, but I don't actually use virtual desktops so I can't really comment on the practical changes in workflow that this would yield. Still, I think it makes sense. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi added a comment. In D18918#409850 , @mvourlakos wrote: > Personally I dont like the approach, this wont work in some cases e.g. when right clicking plasma taskmanager. but when right clicking on plasma taskmanager, there is not

D18929: Have task managers follow the desktop for window visibility behavior by default

2019-02-11 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Only shows the ones in the current desktop, unless configured otherwise. The current default keeps all

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

2019-02-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18893 To: rooty, #vdg, #plasma, filipf Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen,

D18928: Fix warnings

2019-02-11 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Setting undefined to a real value just warns REPOSITORY R119 Plasma Desktop BRANCH master REVISION

D18796: [PassiveNotification] Don't start timer until window has focus

2019-02-11 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R169:0ed491d9d19c: [PassiveNotification] Dont start timer until window has focus (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D18908: [SwipeListItem] Use a real toolbutton to improve usability

2019-02-11 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R169:bdb5465181b6: [SwipeListItem] Use a real toolbutton to improve usability (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D18571: Add "apply on double-click" feature to most other recent ported KCMs

2019-02-11 Thread Nathaniel Graham
ngraham added a comment. That's true, this would be new and unprecedented. But it that necessarily a bad thing? It's just a hidden accelerator, that's all. It feels very natural to me, and IMO it's far nicer than having to click the Apply button after selecting a new

D18926: add Type property for Latte::View

2019-02-11 Thread Michail Vourlakos
mvourlakos created this revision. mvourlakos added a reviewer: trmdi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --this way any part interested to know the real type of Latte::View it can access the

D18646: [Colors KCM] Add search and filter

2019-02-11 Thread Kai Uwe Broulik
broulik added a comment. > It does kind of beg the question of why this is the only grid view that has a search, of course. Dunno, colors has significantly more entries than the other KCMs. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To:

D18514: Drop pre Qt5.12 workarounds

2019-02-11 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:66b734dfc611: Drop pre Qt5.12 workarounds (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18514?vs=50223=51413 REVISION

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

2019-02-11 Thread David Edmundson
davidedmundson added a comment. From my POV, +1 too. INLINE COMMENTS > Main.qml:373 > +text: > i18nd("plasma_lookandfeel_org.kde.lookandfeel","List Users") > onClicked: mainStack.pop() > } should this also have visible:

D18925: [Icon Applet] Parse jump list actions and open with actions on demand

2019-02-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Doing this can easily add up to 20ms startup time for every icon pointing to a file. It is not

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

2019-02-11 Thread Nathaniel Graham
ngraham added a comment. +1 on the concept. Adding here my comments in the #VDG channel regarding the icons: - For the "Type User" icon, I liked the one that was dots/asterisks with an I-Beam cursor at the end. - For the "List Users" icon, my

D18646: [Colors KCM] Add search and filter

2019-02-11 Thread Nathaniel Graham
ngraham added a comment. UI-wise, I think this can go in. It does kind of beg the question of why this is the only grid view that has a search, of course. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To: broulik, #plasma, #vdg Cc:

D17073: Do not crop albumArt

2019-02-11 Thread Krešimir Čohar
rooty added a comment. +1, F6607842: image.png the covers shouldn't get cropped. Them blurry bars are a little too thick/wide for my taste, is there any way to make the preview taller or to get rid of the application title to make more of the album

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Michail Vourlakos
mvourlakos added a comment. ok, just checked the previous mentioned class has access to containment() that means that through its configuration the menu could be informed for the type, so directly access to Latte::View is not needed... REPOSITORY R878 Latte Dock REVISION DETAIL

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Michail Vourlakos
mvourlakos added a comment. Personally I dont like the approach, this wont work in some cases e.g. when right clicking plasma taskmanager. This actions are located at : https://phabricator.kde.org/source/latte-dock/browse/master/containmentactions/contextmenu/menu.cpp I would try

D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface

2019-02-11 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R135:6d6cb17351d1: Bump to Qt5.12 - Drop kwins custom ServerSideDecorationManager interface (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18515?vs=50224=51406#toc

Moday meeting notes for 11/2/2019

2019-02-11 Thread Marco Martin
Eike: * I've been consumed by eV stuff and to be honest a side project (new app to control UAVs) started three things still to be finished: * adding Folder-based places widget to Add Widgets, needs some work in the framework and a few .desktop files * making the screenlocker prompt immediately

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-02-11 Thread David Redondo
davidre updated this revision to Diff 51402. davidre added a comment. - Don't use token for removal and fix include guard REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51396=51402 BRANCH arcpatch-D18809_1 REVISION DETAIL

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-02-11 Thread David Redondo
davidre marked 2 inline comments as done. davidre added inline comments. INLINE COMMENTS > davidedmundson wrote in image.h:184-185 > Why do we need two instances? Can you elaborate on that please? Are you saying I should assign my Model to m_model and then cast it to call the added method?

D18922: [shell] Show kactivies warning only on error

2019-02-11 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY load() is called a few times and different states. After the change I also

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-02-11 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > image.h:184-185 > int m_currentSlide; > BackgroundListModel *m_model; > +SlideModel* m_slideshowModel; > QFileDialog *m_dialog; Why do we need two instances? > slidemodel.cpp:30 > +{ > +if (token !=

D18571: Add "apply on double-click" feature to most other recent ported KCMs

2019-02-11 Thread Marco Martin
mart added a comment. also, as the principle of the feature i agree with Pino I don't recall any non instant apply dialog anywhere which becomes magically instant apply on doubleclick REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18571 To: ngraham, #vdg,

D18571: Add "apply on double-click" feature to most other recent ported KCMs

2019-02-11 Thread Marco Martin
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. if this is going to be used, it should be in the base component (where you can safely assume that kcm.save will exist) and have it as mandatory for every kcm REPOSITORY R119

D18920: Fix and update PCI module

2019-02-11 Thread Konrad Rzepecki
konradr updated this revision to Diff 51397. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18920?vs=51395=51397 REVISION DETAIL https://phabricator.kde.org/D18920 AFFECTED FILES Modules/pci/kpci.cpp Modules/pci/kpci.h Modules/pci/kpci_private.h

D18920: Fix and update PCI module

2019-02-11 Thread Konrad Rzepecki
konradr created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. konradr requested review of this revision. REVISION SUMMARY PCI module work properly only if PCI configuration structures are packed. This commit adds "#pragma pack" preprocessor directive

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-02-11 Thread David Redondo
davidre updated this revision to Diff 51396. davidre added a comment. - Use KRun again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51348=51396 BRANCH arcpatch-D18809_1 REVISION DETAIL https://phabricator.kde.org/D18809 AFFECTED

D18918: Make the text of "View Settings" action more specific

2019-02-11 Thread Tranter Madi
trmdi added inline comments. INLINE COMMENTS > view.cpp:333 > +}; > +const QString viewSettingsText(m_behaveAsPlasmaPanel? > viewSettingsTexts[1] : viewSettingsTexts[2]); > +const QString strippedText(a->text().replace("&", "")); I've found a bug here: when inEditMode,

D18646: [Colors KCM] Add search and filter

2019-02-11 Thread Kai Uwe Broulik
broulik added a comment. Is this good now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To: broulik, #plasma, #vdg Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18718: Support icon on ComboBox

2019-02-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R858:33bd78afd4a8: Support icon on ComboBox (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18718?vs=50824=51394

D18721: [Folder View] Assume root of a protocol is always a folder

2019-02-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca113afa5028: [Folder View] Assume root of a protocol is always a folder (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18886: Remove unused dependencies

2019-02-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:4ae87a3757ca: Remove unused dependencies (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18886?vs=51288=51391 REVISION