D19460: [powerdevil] Correct labels

[Krešimir Čohar]

rooty added a comment.


  Should "Act like" be replaced with "Behave as?"

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch corrects the grammar in certain labels and makes others conform 
with the KDE HIG.

REPOSITORY
  R122 Powerdevil

BRANCH
  powerdevil-hig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19460

AFFECTED FILES
  kcmodule/activities/activityWidget.ui

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19458: [Logout screen] Change labels to match SDDM theme labels

[Krešimir Čohar]

rooty updated this revision to Diff 52937.
rooty added a comment.


  Include data.js

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19458?vs=52935=52937

BRANCH
  rename-reboot-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19458

AFFECTED FILES
  applets/lock_logout/contents/ui/data.js
  lookandfeel/contents/logout/Logout.qml

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19459: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels

[Krešimir Čohar]

rooty added a comment.


  P.S. I'd like to be able to upload screenshots but I wrecked my Arch install 
an hour or so ago so I'm not going to be able to build this for at least a 
couple of hours :D Sorry

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19459

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19459: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch follows patch D19458  and 
applies the same label changes to Kicker/Kickoff/Dash.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  rename-reboot-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19459

AFFECTED FILES
  applets/kicker/plugin/systementry.cpp

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19458: [Logout screen] Change labels to match SDDM theme labels

[Krešimir Čohar]

rooty updated this revision to Diff 52935.
rooty added a comment.


  Remove extra space

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19458?vs=52934=52935

BRANCH
  rename-reboot-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19458

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19458: [Logout screen] Change labels to match SDDM theme labels

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  rename-reboot-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19458

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dd4176d1f669: [sddm-theme/lock screen] Adjust login 
screen and lock screen font sizes (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52932=52933

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/MainBlock.qml
  lookandfeel/contents/logout/Logout.qml
  sddm-theme/Login.qml

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

[Krešimir Čohar]

rooty added a comment.


  In D19433#422829 , @ngraham wrote:
  
  > In D19433#422827 , @rooty wrote:
  >
  > > P.S. I know it's unrelated but shouldn't the logout screen say "Restart" 
(like the SDDM theme)? I just noticed it.
  > >  Also "Log out" (or uppercase?) instead of "Logout"?
  >
  >
  > Yep (in another patch! :) ). And the same changes also need to be made for 
Kicker/Kickoff/Dash/etc., similar to how I did 
360b565d8cab0818f03f773c2675f73a1d6a94d6 

  
  
  I'll get right to it :D

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19433

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D19433#422827 , @rooty wrote:
  
  > P.S. I know it's unrelated but shouldn't the logout screen say "Restart" 
(like the SDDM theme)? I just noticed it.
  >  Also "Log out" (or uppercase?) instead of "Logout"?
  
  
  Yep (in another patch! :) ). And the same changes also need to be made for 
Kicker/Kickoff/Dash/etc., similar to how I did 
360b565d8cab0818f03f773c2675f73a1d6a94d6 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19433

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

[Krešimir Čohar]

rooty added a comment.


  P.S. I know it's unrelated but shouldn't the logout screen say "Restart" 
(like the SDDM theme)? I just noticed it.
  Also "Log out" (or uppercase?) instead of "Logout"?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 52932.
rooty added a comment.


  Introduce font adjustments to logout screen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52928=52932

BRANCH
  arcpatch-D19433

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/MainBlock.qml
  lookandfeel/contents/logout/Logout.qml
  sddm-theme/Login.qml

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2eec8cb1b505: [sddm-theme/lock screen] Adjust login and 
lock screen blur effect (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19409?vs=52930=52931

REVISION DETAIL
  https://phabricator.kde.org/D19409

AFFECTED FILES
  lookandfeel/contents/components/WallpaperFader.qml

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty updated this revision to Diff 52930.
rooty added a comment.


  Roll back preview change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19409?vs=52872=52930

BRANCH
  arcpatch-D19409

REVISION DETAIL
  https://phabricator.kde.org/D19409

AFFECTED FILES
  lookandfeel/contents/components/WallpaperFader.qml

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  In D19409#422811 , @ngraham wrote:
  
  > You know, it occurs to me that we should probably change the previews after 
we're done with all of this, or else each patch will need its own adjusted 
preview images! Sorry to have steered you wrong there. Remove the preview 
change and let's get this landed! Such a big improvement.
  
  
  Haha sure thing, we can just submit a final patch with all the previews?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  You know, it occurs to me that we should probably change the previews after 
we're done with all of this, or else each patch will need its own adjusted 
preview images! Sorry to have steered you wrong there. Remove the preview 
change and let's get this landed! Such a big improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Nathaniel Graham]

ngraham added a comment.


  Wow, it's amazing how much better this makes both the lock and login screen 
look and feel. I love it!
  
  Since this affects components on the Logout screen as well, we should 
probably also make the same size changes to the buttons and text present there 
in this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  Okay, then I'll just update the preview here seeing as there's nothing else 
to be done here

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  Let's do that separately.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty updated this revision to Diff 52928.
rooty added a comment.


  Use pointSize, adjust username/password font sizes as well, adjust lock 
screen font sizes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52883=52928

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/MainBlock.qml
  sddm-theme/Login.qml

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19454: WIP: Fix errors in kirigami example files

[Carl Schwan]

ognarb updated this revision to Diff 52927.
ognarb added a comment.


  More fix

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=52920=52927

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422564 , @ngraham wrote:
  
  > It's probably not the worst thing in the world if we use hardcoded font 
sizes here. We already do for the clock, and the login screen isn't able to 
read user-chosen font sizes anyway, so there's not much point in using a 
`Heading`, one of whose reasons for existance existence is to respect the 
user's font size. So if we use hardcoded sizes, then the login and lock screens 
will both be able to have the same font sizes for everything.
  
  
  Excellent!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  In D19409#422572 , @ngraham wrote:
  
  > Yeah, that doesn't look great. :/
  >
  > For elements like the actionbuttons and the username that will always 
appear over a blur, I guess we should abandon the text shadows. For the clock 
that //sometimes// has a shadow, what we should probably do is make the 
shadow's opacity property public (defaulting to 0.0) and have only the lock 
screen turn it on when there's no blur. Then when the UI controls and blur 
appear, it can set that to off. Then you can add an opacity animator to the 
clock itself so that the shadows's visibility animates when turned on and off.
  
  
  Should I make all of that part of the same patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus optionally scrollable instead of always expanding horizontally

[Kai Uwe Broulik]

broulik added a comment.


  > FWIW, there is a way to do it on a per-menu basis using a combination of
  
  `QProxyStyle` is super heavy as it creates an entire new instance of 
`BreezeStyle`. My approach would have been to bodge `KStyle` to read 
`menu->property("_kde_scroll_menu").toBool()` and than use that in the rare 
instance where we want scrolling (e.g. global menu)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus optionally scrollable instead of always expanding horizontally

[Nathaniel Graham]

ngraham updated this revision to Diff 52924.
ngraham marked an inline comment as done.
ngraham added a comment.


  Simplify the conditional

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19444?vs=52921=52924

BRANCH
  scrollable-humongous-menus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19444

AFFECTED FILES
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus optionally scrollable instead of always expanding horizontally

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> breezestyle.cpp:678
> +case SH_Menu_Scrollable:
> +if (StyleConfigData::overflowingMenusMode() == 
> StyleConfigData::OM_SCROLL) {
> +return true;

if (cond) {
  return true;
  } else {
  return false;
  }

⇒

  return cond ? true : false;

⇒

  return cond;

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Filip Fila]

filipf updated this revision to Diff 52923.
filipf added a comment.


  don't track the .directory file

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19044?vs=52922=52923

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19044

AFFECTED FILES
  src/controls/InlineMessage.qml
  src/controls/templates/InlineMessage.qml
  src/styles/Material/InlineMessage.qml

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, apol, 
davidedmundson, hein

D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham updated this revision to Diff 52921.
ngraham added a comment.


  Make it configurable and don't change the default behavior

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19444?vs=52903=52921

BRANCH
  scrollable-humongous-menus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19444

AFFECTED FILES
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Filip Fila]

filipf updated this revision to Diff 52922.
filipf added a comment.


  move most of InlineMessage into templates, use shadow in /controls, don't use 
a 
  shadow in /styles/Material

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19044?vs=51774=52922

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19044

AFFECTED FILES
  .directory
  src/controls/InlineMessage.qml
  src/controls/templates/InlineMessage.qml
  src/styles/Material/InlineMessage.qml

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, apol, 
davidedmundson, hein

D19044: [InlineMessage] Do not draw shadows around the message

[Filip Fila]

filipf added a comment.


  In D19044#416559 , @mart wrote:
  
  > - whole InlineMessage should be moved into templates
  
  
  I've been trying to do this but there's several properties such as padding 
and contentItem (with a big ColumnLayout attached) that depend on 
T.InlineMessage and I can't import that in templates. Seems I can move very 
little into templates so that only leaves me with adding another 
InlineMessage.qml for Material.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, apol, 
davidedmundson, hein

D19454: WIP: Fix errors in kirigami example files

[Carl Schwan]

ognarb created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Remove deprecation, fix anchors in RowLayout and remove trailing space
  
  **Done:**
  
  - Sidebar.qml
  - MultipleColumnsGallery.qml

TEST PLAN
  Using KWin transparency effect when moving windows, no pixel change found. 
Opening example files with qmlscene from konsole, only 4 error message left 
(before was more than 20)

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml

To: ognarb
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D18438: [Task Manager] When closing apps, resize only when mouse is out.

[Thomas Surrel]

thsurrel added a comment.


  Hi @hein, could you help me finish this patch ? Can you have a look at my 
previous question ? Many thanks in advance.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19309: Improve Unity Indicator

[Michail Vourlakos]

mvourlakos added a comment.


  @trmdi do you have commit access?
  
  If not you can apply for one and you can reference me

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19309

To: trmdi, #latte_dock, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ff0a0e30a28a: [ConfigCategoryDelegate] Add horizontal 
padding to the label (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19275?vs=52443=52910

REVISION DETAIL
  https://phabricator.kde.org/D19275

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Guido Sanchez]

guidosanchez added a comment.


  Maybe making it configurable would make most users happy :)
  
  Another unexpected behavior in this issue is that if you are using the Global 
Menu widget, the emerging menu (that supposedly doesn't fit the screen) 
shouldn't cover the panel that has the Global Menu widget.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Nathaniel Graham]

ngraham added a comment.


  In that case, see 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  You can merge to 5.15 if you want.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Christoph Feck]

cfeck added a comment.


  What he complains about is that items are unreachable. Yes, it should scroll. 
Either horizontally or vertically. A scrollbar would be perfect so you see how 
much you don't see. In addition to multiple columns, if there are 1½ or more.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Nathaniel Graham]

ngraham added a comment.


  Yeah, that doesn't look great. :/
  
  For elements like the actionbuttons and the username that will always appear 
over a blur, I guess we should abandon the text shadows. For the clock that 
//sometimes// has a shadow, what we should probably do is make the shadow's 
opacity property public (defaulting to 0.0) and have only the lock screen turn 
it on when there's no blur. Then when the UI controls and blur appear, it can 
set that to off. Then you can add an opacity animator to the clock itself so 
that the shadows's visibility animates when turned on and off.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Noah Davis]

ndavis added a comment.


  Horizontal menus are fast, but unusable or hard to read if they get too 
large. Scrollable menus with the arrows that you hover over are annoyingly slow 
if you don't use a scroll wheel to scroll, but don't block the entire screen if 
you have a large number of items. In both cases, the best solution from the 
user's end is to make more folders so that the list doesn't overflow.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Nathaniel Graham]

ngraham added a comment.


  It's probably not the worst thing in the world if we use hardcoded font sizes 
here. We already do for the clock, and the login screen isn't able to read 
user-chosen font sizes anyway, so there's not much point in using a `Heading`, 
one of whose reasons for existance existence is to respect the user's font 
size. So if we use hardcoded sizes, then the login and lock screens will both 
be able to have the same font sizes for everything.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> Zren wrote in configAppearance.qml:137
> Was afk today sorry.
> 
> Do we need `visible: KCMShell.authorize("formats.desktop").length > 0` here? 
> It hides the contextmenu item in `main.qml` if the user doesn't have 
> permission.
> 
> https://github.com/KDE/plasma-workspace/blob/master/applets/digital-clock/package/contents/ui/main.qml#L109

Good Idea, I'll push that in a few minutes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: cfeck, totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Nathaniel Graham]

ngraham added a comment.


  I'd say go for it. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham added a comment.


  In D19444#422559 , @cfeck wrote:
  
  > The problem is that adding this property limits to a single column.
  
  
  Yeah, that's the point. :)
  
  In D19444#422559 , @cfeck wrote:
  
  > For a menu that only has a few more items than fit in a column this is 
acceptable, but for the menu in the referenced ticket it is not.
  
  
  Well the person who filed that ticket clearly didn't find the expandable menu 
acceptable, or else they wouldn't have filed it! :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19444: Make long menus scrollable instead of expanding horizontally

[Christoph Feck]

cfeck added a comment.


  The problem is that adding this property limits to a single column. It should 
show all columns, and additionally allow the user to scroll. For a menu that 
only has a few more items than fit in a column this is acceptable, but for the 
menu in the referenced ticket it is not.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham added a comment.


  In D19444#422556 , @davidedmundson 
wrote:
  
  > FWIW, there is a way to do it on a per-menu basis using a combination of
  >
  > QWidget::setStyle and QProxyStyle
  
  
  Not sure that would really help in this specific case since the bug reporter 
wants his bookmarks menu to be scrollable rather than expanding, while @cfeck 
wants the same menu to be expanding rather than scrollable!
  
  I suppose (sigh) I could make it configurable...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19444: Make long menus scrollable instead of expanding horizontally

[David Edmundson]

davidedmundson added a comment.


  FWIW, there is a way to do it on a per-menu basis using a combination of
  
  QWidget::setStyle and QProxyStyle

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Filip Fila]

filipf added a comment.


  Any more thoughts on this?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Michail Vourlakos]

mvourlakos added a comment.


  This issue has an origin from : 
https://github.com/psifidotos/applet-window-appmenu/issues/45
  
  menus  dont respect the available screen size

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Christoph Feck]

cfeck added a comment.


  Please not. I use wide menus extensively, e.g. for bookmarks, and are not 
keen to wait eons to find an item because of the slow scrolling.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Àlex Fiestas]

afiestas added a comment.


  Weirdly enough, I have never seen the veth connections in the KCM.
  
  The way I get to reproduce always this bug is:
  -Start  NetworkMaanger
  -Start Docker
  -Run a container
  -Restart NetworkManager
  
  That would result in veth interfaces in the plasmoid. I do not know why a 
restart is required to reproduce the bug, but it makes me think that I might be 
missing something.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19440

To: afiestas, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Breeze, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 404942
  FIXED-IN: 5.15.03

TEST PLAN
  In a VM, make the screen size tiny, Open Dolphin, and open its Control menu
  
  Before: F6646888: Before.png 
  
  After: F6646890: After.png 

REPOSITORY
  R31 Breeze

BRANCH
  scrollable-humongous-menus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19444

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #breeze, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19417: Panel icon & layout change of webbrowser applet

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I see, didn't get that due to highdpi, fine I guess

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19417

To: iostapenko, ematirov, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  Sure, but I'd like to use the bling in another patch :D
  It seems to transition fine, it doesn't just "pop" into a larger size
  
  But I'm afraid I'm going to have to rebase this too because of D19433 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19441: [File Chooser Portal] Confirm overwrite on saving

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R838:194fb4dee8cb: [File Chooser Portal] Confirm overwrite on 
saving (authored by broulik).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19441?vs=52892=52897

REVISION DETAIL
  https://phabricator.kde.org/D19441

AFFECTED FILES
  src/filechooser.cpp

To: broulik, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Filip Fila]

filipf added a comment.


  In D19409#422453 , @rooty wrote:
  
  > In D19409#422361 , @filipf wrote:
  >
  > > In D19409#422203 , @rooty 
wrote:
  > >
  > > > Should we keep the UserDelegate.qml shadow then? Because it doesn't 
seem necessary considering the blur's here to stay.
  > >
  > >
  > > I think they're unnecessary. There's also a bug they cause in 5.15:
  > >
  > > F6646372: image.png 
  >
  >
  > Ouch, nasty bug
  
  
  Yeah, even if you make the shadow color backgroundColor again it's not good 
to have white "shadows":
  
  F6646619: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Krešimir Čohar]

rooty added a comment.


  In D19409#422361 , @filipf wrote:
  
  > In D19409#422203 , @rooty wrote:
  >
  > > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem 
necessary considering the blur's here to stay.
  >
  >
  > I think they're unnecessary. There's also a bug they cause in 5.15:
  >
  > F6646372: image.png 
  
  
  Ouch, nasty bug

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19364: [sddm-theme/lock screen] Add shadows to action buttons

[Krešimir Čohar]

rooty added a comment.


  In D19364#422438 , @mglb wrote:
  
  > What about adding the same shadow under icons? Otherwise it looks like a 
text floating above flat background.
  
  
  We're actually deliberating on whether to abandon the shadow idea altogether 
in D19433  and D19409 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19364

To: rooty, #vdg, ngraham, filipf
Cc: mglb, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Should be enough I guess, but not sure if this would filter your connections 
also from the kcm, did you check?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19440

To: afiestas, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19364: [sddm-theme/lock screen] Add shadows to action buttons

[Mariusz Glebocki]

mglb added a comment.


  What about adding the same shadow under icons? Otherwise it looks like a text 
floating above flat background.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19364

To: rooty, #vdg, ngraham, filipf
Cc: mglb, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19441: [File Chooser Portal] Confirm overwrite on saving

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 404719
  FIXED-IN: 5.15.3

TEST PLAN
  Chose Save As in Firefox, saved, Chose Save As again, tried to save as same 
filename, it asked before bluntly overwriting

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19441

AFFECTED FILES
  src/filechooser.cpp

To: broulik, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19382: port to ECM's FindCanberra

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:dd7094b49b87: port to ECMs FindCanberra (authored 
by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19382?vs=52711=52887#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19382?vs=52711=52887

REVISION DETAIL
  https://phabricator.kde.org/D19382

AFFECTED FILES
  CMakeLists.txt
  cmake/FindCanberra.cmake
  cmake/FindCanberraPulse.cmake
  src/CMakeLists.txt

To: sitter, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19381: search our cmake dir first

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:3f6a9d90123b: search our cmake dir first (authored by 
sitter).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19381?vs=52710=52886

REVISION DETAIL
  https://phabricator.kde.org/D19381

AFFECTED FILES
  CMakeLists.txt

To: sitter, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Àlex Fiestas]

afiestas created this revision.
afiestas added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
afiestas requested review of this revision.

REVISION SUMMARY
  Some network devices are **not** managed by NetworkManager, for example any 
virtual device created by Docker, any routing devices, etc.
  
  This patch checks if the device is bring managed by NM or not before showing 
it into the applet.
  
  With most certainty, the patch is wrong or the check should be added 
elsewere, but I thought that would be nice to publish it so we can get the 
discussion going.

TEST PLAN
  Load the applet with some 10 containers running. The 10 created veth 
interfaces should not be shown in the applet.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19440

AFFECTED FILES
  libs/models/networkmodel.cpp

To: afiestas, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  The cliff-notes version of the level 4 vs level 3 problem
  
  F6646443: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422367 , @filipf wrote:
  
  > In any case, I'd like to have it like this:
  >
  > - no shadows with blur
  
  
  Even though the shadows are pretty, I'm inclined to agree that no shadows 
might be a better fit.
  
  > - username is 12pt (or level 3)
  
  Ditto.
  
  > - action buttons are 11pt (or level 4)
  
  This sounds good to me, and it looks good
  F6646429: VirtualBox_neon_01_03_2019_11_00_07.png 

  But we'd **have to use pointSize**. Level 4 headings simply come out too 
blurry given different antialiasing settings.
  
  > - the tool buttons at the bottom are 10 pt
  
  Ditto.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Filip Fila]

filipf added a comment.


  In any case, I'd like to have it like this:
  
  - no shadows with blur
  - username is 12pt (or level 3)
  - action buttons are 11pt (or level 4)
  - the tool buttons at the bottom are 10 pt
  
  F6646413: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422364 , @filipf wrote:
  
  > The difference is too jarring with level 3.
  
  
  pointSize then, because the fonts are too hazy if you use level 4. Not to 
belabor the point but take a closer look at the screenshots I posted in my 
comments.
  This neon situation is a very niche usage case that just covers up the 
problem and doesn't resolve it.
  
  That being said, level 3 looks just fine in my opinion, even better than 
level 4.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Filip Fila]

filipf added a comment.


  The difference is too jarring with level 3.
  
  F6646395: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422359 , @filipf wrote:
  
  > From a technical point of view I'm not sure this is the ideal solution. 
It's not hardcoding font sizes, but is changing only 2 labels (to be headings 
when they're actually not headings) while the other ones remain 10pt.
  
  
  But I didn't mean to increase the font size of the clock, the keyboard or 
session buttons, just the username and action buttons (and maybe the 
username/password fields.
  
  > The best solution would be if we had an option for configuring SDDM font 
sizes. At the very least we could adjust font size based on the screen 
resolution. #plasma  people, what do 
you think?
  
  You could change the font DPI.
  
  > If this ends up being the best we can do I would prefer to have level 4 
just so there isn't a big discrepancy between label sizes.
  
  They come out small and blurry. Take a look at my previous comment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

[Filip Fila]

filipf added a comment.


  In D19409#422203 , @rooty wrote:
  
  > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem 
necessary considering the blur's here to stay.
  
  
  I think they're unnecessary. There's also a bug they cause in 5.15:
  
  F6646372: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Filip Fila]

filipf added a comment.


  From a technical point of view I'm not sure this is the ideal solution. It's 
not hardcoding font sizes, but is changing only 2 labels (to be headings when 
they're actually not headings) while the other ones remain 10pt.
  
  The best solution would be if we had an option for configuring SDDM font 
sizes. At the very least we could adjust font size based on the screen 
resolution. #plasma  people, what do 
you think?
  
  If this ends up being the best we can do I would prefer to have level 4 just 
so there isn't a big discrepancy between label sizes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  Should I include this in the preview screenshot for the reduced blur? :D 
Jumping the gun a little?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty updated this revision to Diff 52883.
rooty added a comment.


  Raise level to level 3

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52882=52883

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  There's another problem that might be hard to appreciate with neon's default 
settings (Noto Sans, slight hinting etc.)
  
  This is level 4:
  F6646230: image.png 
  This is level 3:
  F6646233: image.png 
  
  Level 4 just seems blurrier. Level 3's bigger (easier to make out) and the 
letters are sharper so I'm going to bump it up to level 3, let me know if it's 
too big.
  
  P.S. For some reason, the fonts look bigger in sddm-greeter, in case you've 
been using that to test the fonts. They look fine on the login screen.
  
  Also, on an unrelated note, I've seriously been considering dropping the 
username shadow because it makes it look so much different than the action 
button label. That said, it does look nice like you've said, and we could just 
add a shadow to the action buttons and that'd work fine too. I'm mentioning it 
again because it's really easy to appreciate in that screenshot.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19312: Add tooltip for quick search

[Simone Gaiarin]

simgunz added a comment.


  @ngraham Thanks for the guidelines
  
  I landed it, and it seems I have not messed up anything.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D19312

To: simgunz, #plasma, cfeck, broulik, mart
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  How's that look? I used the anchor thing from D19372 
 just without the //embiggening//

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty updated this revision to Diff 52882.
rooty added a comment.


  Increase user avatar size

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52874=52882

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19312: Add tooltip for quick search

[Simone Gaiarin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:839be94eaf7b: Add tooltip for quick search (authored by 
simgunz).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19312?vs=52550=52881

REVISION DETAIL
  https://phabricator.kde.org/D19312

AFFECTED FILES
  processui/ProcessWidgetUI.ui

To: simgunz, #plasma, cfeck, broulik, mart
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart