D19309: Improve Unity Indicator

[Tranter Madi]

trmdi added a comment.


  In D19309#422634 , @mvourlakos 
wrote:
  
  > @trmdi do you have commit access?
  >
  > If not you can apply for one and you can reference me
  
  
  I tried it, but not sure if/when they will accept it.
  So could you please land this for me? :)

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19309

To: trmdi, #latte_dock, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19434: Change entry of Endpoint UI

[Bruce Anderson]

andersonbruce added a comment.


  In D19434#423458 , @jgrulich wrote:
  
  > Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also 
set min and max values so you don't need to validate it.
  
  
  My preference is to only use a spinbox for entries with less than 100 
possible values.  I believe that the up/down arrows give the impression that 
clicking on them is the "proper" method of selecting a value and while some 
people know that you can type in a value into a spinbox, I believe that there 
are others who do not and I really don't want users to be metaphorically 
cursing my name when they are trying to click their way up to a port number of 
say, 23517. Also, using a simple LineEdit with color coding for indicating an 
unacceptable input is consistent with the rest of the interface.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19434

To: andersonbruce, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Krešimir Čohar]

rooty added a comment.


  Actually this works on the logout screen too, at least on my setup:
  
  F6651424: simplescreenrecorder-2019-03-03_04.21.58.mp4 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  P.S. Should we use "live: true" or just delete the line? Because it's true by 
default, but this makes it clear that it shouldn't be live: false

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty updated this revision to Diff 53030.
rooty added a comment.


  Prevent user avatar in focus from becoming blurred

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19372?vs=53028=53030

BRANCH
  arcpatch-D19372

REVISION DETAIL
  https://phabricator.kde.org/D19372

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Alexander Potashev]

aspotashev added a comment.


  Hi Nate,
  
  You missed this one at daemon/actions/bundled/suspendsessionconfig.cpp:88:
  
m_comboBox->addItem(QIcon::fromTheme("system-suspend-hybrid"), i18n("Hybrid 
suspend"), (uint)SuspendSession::SuspendHybridMode);

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19186

To: ngraham, #vdg, #plasma, broulik, filipf, mart
Cc: aspotashev, filipf, mart, ltoscano, abetts, aacid, plasma-devel, 
kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty updated this revision to Diff 53028.
rooty added a comment.


  Rebase; add property animation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19372?vs=52683=53028

BRANCH
  arcpatch-D19372

REVISION DETAIL
  https://phabricator.kde.org/D19372

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  In D19372#421391 , @filipf wrote:
  
  > In D19372#421381 , 
@davidedmundson wrote:
  >
  > > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There 
was a whole Carousel system.
  >
  >
  > Our old SDDM theme 

 did that as well, right?
  
  
  This seems to be how they did it
  
source: visible ? "user-identity" : undefined
visible: (face.status == Image.Error || face.status == Image.Null)
  
  Which isn't all that different from how this diff.
  It still looks fairly animated to me :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19301: Use Kirigami.ActionTextField for the SearchField

[Carl Schwan]

ognarb added a comment.


  In D19301#423523 , @ngraham wrote:
  
  > Also it would be nice to port Discover itself to use this.
  
  
  I'm not sure, I understand your comment. What do you mean with this? Discover 
already implement the actionSearchField.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Filip Fila]

filipf updated this revision to Diff 53027.
filipf added a comment.


  Add circle with animation in preparation for changes in the logout screen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53026=53027

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Filip Fila]

filipf updated this revision to Diff 53026.
filipf added a comment.


  For now copy the OpacityAnimator from LogoutButton.qml

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53010=53026

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19301: Use Kirigami.ActionTextField for the SearchField

[Nathaniel Graham]

ngraham added a comment.


  Also it would be nice to port Discover itself to use this.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Filip Fila]

filipf added a comment.


  In D19479#423518 , @ngraham wrote:
  
  > That sounds suspiciously like my approach in D16034 
 that we decided not to implement. :)
  
  
  Yep, it's more or less the same, but the background color needs to be 
different so we can't use those icons.
  
  As a draft, here's what we could do in SDDM to match the logout screen 
behavior:
  
  F6650249: ABhover2-2019-03-02_23.14.27 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Nathaniel Graham]

ngraham added a comment.


  That sounds suspiciously like my approach in D16034 
 that we decided not to implement. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Filip Fila]

filipf added a comment.


  Okay so the logout screen is the bigger issue, I propose we make icons with 
the equivalent of:
  
  color: PlasmaCore.ColorScope.textColor // because doing backgroundColor would 
add little to no contrast, unless we add a light border
  opacity: 0.15 or 0.2
  
  They would look like this. Light theme, text is white:
  
  F6650219: Screenshot_20190302_225939.png 

  Dark theme, text is black:
  F6650218: Screenshot_20190302_225908.png 

  
  Then add them to Logout.qml, making sure they can fallback on regular icons 
with other themes.
  
  Finally we adjust SDDM's action buttons to get a QML circle equivalent (as 
close as possible) of those icons and behavior in the logout screen.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Filip Fila]

filipf added a comment.


  Very interesting and tricky issue which we should try to solve.
  
  Two differences between the logout screen and SDDM though: the former is 
darker. (unlike 5.15, in master it now fades to pitch black, bug?)  That's why 
it allows for the opacity of unselected items to be 0.5. That would be too 
faint in SDDM.
  
  But thinking outside the box, we could have other mechanisms. Embiggening 
though, I think would look tacky. That leaves background circles.
  
  In the logout screen shouldn't do QML circles because it will interfere with 
other themes;  at first glance seems messy to implement as well. I think it 
would be best if we made icons with background, but this time with a major 
difference: the background circle would take on textColor and could then be 
pretty faint.
  
  Example of what that would look like, 0.2 opacity:
  
  F6650174: image.png 
  
  Then for SDDM we would try to match as much as possible.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16034: Improve logout screen button appearance and contrast

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  We're going in another direction with this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16034

To: ngraham, #vdg, #plasma, mart
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This is fine. It makes it even more important that we make the current user's 
avatar bigger though. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Nathaniel Graham]

ngraham added a comment.


  +1  conceptually. But there may be a more elegant way to do this...
  
  Specifically, perhaps we should just migrate the opacity logic implemented in 
the the Logout screen's `ActionButton` subclass to the base item itself, and 
then remove the subclass. That way all `ActionButton` users would get the same 
hover behavior.
  
  Also, if you implement the selected/hovered appearance cleverly enough, it 
would fix https://bugs.kde.org/show_bug.cgi?id=393048.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19306: send a signal over dbus when the wrong password is provided

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Good idea to remove the failed connection.

INLINE COMMENTS

> secretagent.cpp:412
>  sendError(SecretAgent::NoSecrets, "Cannot authenticate", 
> request.message);
> +emit secretsError(request.connection_path.path(), 
> i18n("Authentication to %1 failed. Wrong password?", 
> request.connection.value("connection").value("id").toString()));
>  return true;

I'm not sure this assumption is currect, it's not that the password is wrong 
all the time, NM might be just asking for additional passwords or for passwords 
which are marked not to be stored (e.g. VPN, or WPA2 EAP). But I guess for your 
usecase we can leave it as it is, we just need to make sure that 
Configuration::showPasswordDialog() will be true only on plasma-mobile.

> handler.h:107
>  void initKdedModule();
> +void secretAgentError(const QString , const QString );
>  void replyFinished(QDBusPendingCallWatcher *watcher);

void secretAgentError(const QString , const QString )

so we know on first look what are these params?

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  phab/errorSignal

REVISION DETAIL
  https://phabricator.kde.org/D19306

To: mart, #plasma, jgrulich, bshah
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Krešimir Čohar]

rooty accepted this revision as: rooty.
rooty added a comment.
This revision is now accepted and ready to land.


  Very elegant

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19434: Change entry of Endpoint UI

[Jan Grulich]

jgrulich added a comment.


  Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also 
set min and max values so you don't need to validate it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19434

To: andersonbruce, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Jan Grulich]

jgrulich added a comment.


  Can you attach output from:
  
  1. nmcli -f all connection
  2. nmcli -f all device show
  
  I wonder why those veth connections are shown in the applet for unmanaged 
devices, because we show only "available connections" and I would expect NM to 
ignore them, but this patch makes sense so feel free to push it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19440

To: afiestas, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Filip Fila]

filipf added a comment.


  There's a little bit of fringing around the white border so I can subtract 2 
from the width?
  
  F6649343: image.png 
  
  Left is before, right after. Doesn't quite solve it, but is a bit better.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add opacity on hover to action buttons

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Unlike in the logout screen, our action buttons in the SDDM theme currently 
offer no
  visual feedback when hovered over. This patch adds a minimal yet effective 
amount of
  opacity shifting, keeping in mind that the buttons need to stay legible when 
used with light
  wallpapers.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Added in D16879 , the background circle 
was designed to work on a blurless login
  screen. Since we have abandoned that idea, it's good to adjust it to our 
present
  needs. This patch lowers the opacity of the circle and removes the double 
border it created.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 367696] breeze dark: konsole icon is barely visible

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=367696

Patrick Silva  changed:

   What|Removed |Added

Summary|konsole icon is almost  |breeze dark: konsole icon
   |invisible when I use breeze |is barely visible
   |dark theme  |
Version|5.13.5  |5.15.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

D19467: [colors-kcm] Fix blurry previews

[Filip Fila]

filipf updated this revision to Diff 52986.
filipf added a comment.


  don't round numbers unnecessarily

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19467?vs=52951=52986

BRANCH
  fix-blurry-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19467

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't understand
  
  Kirigami.gridUnit is a whole number 
  13 is a a whole number
  
  Why does Math.round fix anything?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[Krešimir Čohar]

rooty accepted this revision as: rooty.
rooty added a comment.
This revision is now accepted and ready to land.


  Looks good to me. You might want to wait for someone else's say-so too tho

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-blurry-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19475: Only match service text strings once

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Minor optimisation, should behave identically.

TEST PLAN
  Ran krunner
  Searched for some apps

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/ksession

REVISION DETAIL
  https://phabricator.kde.org/D19475

AFFECTED FILES
  runners/services/servicerunner.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fd7b359f8461: [Task Manager] Make sure 
Alternatives... context menu item is always available (authored by 
ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19472?vs=52980=52983

REVISION DETAIL
  https://phabricator.kde.org/D19472

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  You have no idea how much of a headache not having this option has been 
huge +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  task-manager-alternatives-in-item-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, the Task Manager does not show the Alternatives... item in the 
context
  menu for tasks, so it's inaccessible when the Task Manager is full. This 
patch fixes
  that.
  
  BUG: 404969
  FIXED-IN: 5.15.3

TEST PLAN
  - Menu item is visible in the context menu for individual tasks when widgets 
are unlocked
  - Menu item is hidden when widgets are locked
  - Menu item works, and shows the Alternatives panel when clicked
  - No duplication in context menu for an empty area of the Task Manager

REPOSITORY
  R119 Plasma Desktop

BRANCH
  task-manager-alternatives-in-item-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19472

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: ngraham, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Krešimir Čohar]

rooty updated this revision to Diff 52978.
rooty added a comment.


  Correct typographical error

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19468?vs=52976=52978

BRANCH
  shadows-only-when-inactive (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19468

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Krešimir Čohar]

rooty added a comment.


  In D19468#423093 , @ngraham wrote:
  
  > Won't the outlines get drawn when blurred if software rendering is in use?
  
  
  I can't get any blur with software rendering though?
  Another problem too - forcing software rendering leaves the username with an 
outline, but the action buttons without any shadow or outline (and no blur)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19468

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Krešimir Čohar]

rooty updated this revision to Diff 52976.
rooty added a comment.


  Disable shadows with softwareRendering enabled

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19468?vs=52954=52976

BRANCH
  shadows-only-when-inactive (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19468

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> rooty wrote in activityWidget.ui:72
> Haha I had the idea to use turn off too, because you don't really ever "shut 
> down" a screen

Eh, let's make the English teachers happy. :)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Won't the outlines get drawn when blurred if software rendering is in use?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19468

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

[Krešimir Čohar]

rooty added a comment.


  I wonder if people would notice if it ended in a preposition (ironically 
"Never turn the screen off" sounds nicer to me)

INLINE COMMENTS

> ngraham wrote in activityWidget.ui:72
> While we're touching this, I think "Never turn off the screen" would sound 
> more natural here.

Haha I had the idea to use turn off too, because you don't really ever "shut 
down" a screen

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

[Krešimir Čohar]

rooty updated this revision to Diff 52958.
rooty marked an inline comment as done.
rooty added a comment.


  Shut down --> turn off

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19460?vs=52938=52958

BRANCH
  powerdevil-hig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19460

AFFECTED FILES
  kcmodule/activities/activityWidget.ui

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19458: [Logout screen] Change labels to match SDDM theme labels

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d8a7443605bd: [Logout screen] Change labels to match SDDM 
theme labels (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19458?vs=52937=52956

REVISION DETAIL
  https://phabricator.kde.org/D19458

AFFECTED FILES
  applets/lock_logout/contents/ui/data.js
  lookandfeel/contents/logout/Logout.qml

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19459: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:604244b6cb66: [Kicker, Kickoff  Dash] Change labels 
to match SDDM theme labels (authored by rooty).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19459?vs=52936=52957

REVISION DETAIL
  https://phabricator.kde.org/D19459

AFFECTED FILES
  applets/kicker/plugin/systementry.cpp

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Filip Fila]

filipf added a comment.


  Good work, but let's wait a bit with this since D19214 
 hasn't landed yet. I was also thinking of 
tweaking the background circle behind the user avatar.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  update-preview-image (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when opaque

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch removes the shadow from the usernames on the login and lock 
screens. It also restricts the clock shadow to just the opaque versions of 
either screen.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shadows-only-when-inactive (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19468

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[Filip Fila]

filipf added a comment.


  If this is too small the next number that doesn't result in blurry previews 
is multiplying with 16:
  
  F6648523: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  With the current settings text in color scheme previews is blurry. This patch 
aims to
  fix that and as a side-effect also creates more room in the grid layout now 
fitting
  4 rows instead of 3 in minimum window size.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-blurry-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19467

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

[Nathaniel Graham]

ngraham added a comment.


  In D19460#422873 , @rooty wrote:
  
  > Should "Act like" be replaced with "Behave as?"
  
  
  Is the control associated with this string actually used anywhere? I can't 
even find it.

INLINE COMMENTS

> activityWidget.ui:72
>   
> -  Never shutdown the screen
> +  Never shut down the screen
>   

While we're touching this, I think "Never turn off the screen" would sound more 
natural here.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19465: Port to ECM's component/imported target based FindXCB

[Volker Krause]

vkrause created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19465

AFFECTED FILES
  kcms/touchpad/cmake/modules/COPYING-CMAKE-SCRIPTS
  kcms/touchpad/cmake/modules/FindXCB.cmake
  kcms/touchpad/src/backends/x11.cmake

To: vkrause
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19463: Use FindGLIB2 from ECM

[Volker Krause]

vkrause created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19463

AFFECTED FILES
  cmake/FindGLIB2.cmake

To: vkrause
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19370: [sddm-theme] Add circles behind action buttons

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Parent dependency was abandoned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19370

To: filipf, #vdg, ngraham, rooty, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19379: [sddm-theme] Add a bottom panel

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Parent dependency was abandoned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19379

To: filipf, #vdg, #plasma, ngraham, rooty
Cc: abetts, broulik, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart