D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:aca7fd387307: [sddm-theme/lock screen] Improve appearance 
in software rendering mode… (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19609?vs=53490=53496

REVISION DETAIL
  https://phabricator.kde.org/D19609

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right, makes sense and looks good!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19609

REVISION DETAIL
  https://phabricator.kde.org/D19609

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Krešimir Čohar]

rooty marked 3 inline comments as done.
rooty added a comment.


  I know it sounds strange but no value other than undefined causes the D19577 
 error... we could technically put "red" 
there because there's no outline to begin with and it'd look the same haha
  
  I'm still not sure about the margin change, but it looks a too close for 
comfort without the margin if the circle's right from the start

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19609

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Krešimir Čohar]

rooty updated this revision to Diff 53490.
rooty marked 2 inline comments as done and an inline comment as not done.
rooty added a comment.


  Use less of a margin, rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19609?vs=53436=53490

BRANCH
  arcpatch-D19609

REVISION DETAIL
  https://phabricator.kde.org/D19609

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Krešimir Čohar]

rooty marked 3 inline comments as done.
rooty added inline comments.

INLINE COMMENTS

> ngraham wrote in ActionButton.qml:85
> Why do we need to change this when using software rendering?

Because I feel that the icon looks too stuck-on if the margin's too great.

> ngraham wrote in ActionButton.qml:90
> Instead of `"transparent"`, perhaps `undefined` would be better because there 
> won't be a style for it anyway.

That causes an error, see D19577 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19609

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Nathaniel Graham]

ngraham added a comment.


  In D19472#427046 , @broulik wrote:
  
  > This suffers from the same bug as the action in the D17410 
. The action doesn't show up unless the 
real applet context menu was opened once.
  
  
  So I see. :(
  
  I guess we really gotta figure out how to call 
`plasmoid.contextualActionsAboutToShow();` before a different context menu 
appears.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: abetts, broulik, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  In D18809#427602 , @filipf wrote:
  
  > First and foremost I thank you as a user for giving this bit of code much 
needed love.
  >
  > If you'll have more interest in the slideshow in the future, implementing 
this might also be useful: https://bugs.kde.org/show_bug.cgi?id=186181
  
  
  FWIW the Image Frame widget allows toggling between random and alphabetical 
ordering for its slideshow, so that might be useful as a template.
  
  For that matter, it might make sense to use this view in the Image Frame 
widget directly--after porting that feature over of course. Less code 
duplication for two views that are doing the same thing.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18809_2

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham, davidedmundson
Cc: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Filip Fila]

filipf added a comment.


  First and foremost I thank you as a user for giving this bit of code much 
needed love.
  
  If you'll have more interest in the slideshow in the future, implementing 
this might also be useful: https://bugs.kde.org/show_bug.cgi?id=186181

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18809_2

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham, davidedmundson
Cc: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Good stuff! I'm hoping we see more of your commits in the future

INLINE COMMENTS

> slidemodel.cpp:41
> +{
> +Q_FOREACH (QString file, paths) {
> +removeBackground(file);

const 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18809_2

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham, davidedmundson
Cc: mart, alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19603: Fix colours of header bar for active and inactive windows

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  +1 for adding the focused state to KWin so this works on X11!

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ActionButton.qml:85
>  top: icon.bottom
> -topMargin: units.smallSpacing
> +topMargin: (softwareRendering ? 2 : 1) * units.smallSpacing
>  left: parent.left

Why do we need to change this when using software rendering?

> ActionButton.qml:90
> +style: softwareRendering ? Text.Outline : Text.Normal
> +styleColor: softwareRendering ? 
> PlasmaCore.ColorScope.backgroundColor : "transparent" //no outline, doesn't 
> matter
>  horizontalAlignment: Text.AlignHCenter

Instead of `"transparent"`, perhaps `undefined` would be better because there 
won't be a style for it anyway.

> UserDelegate.qml:187
>  style: softwareRendering ? Text.Outline : Text.Normal
> -styleColor: softwareRendering ? ColorScope.backgroundColor : 
> "transparent" //no outline, doesn't matter
> +styleColor: softwareRendering ? 
> PlasmaCore.ColorScope.backgroundColor : "transparent" //no outline, doesn't 
> matter
>  elide: Text.ElideRight

Ditto

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19609

To: rooty, #plasma, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:28a6ef22350d: [sddm-theme/lock screen] Remove username 
shadow and show clock shadow only when… (authored by rooty, committed by 
filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19468?vs=53452=53481

REVISION DETAIL
  https://phabricator.kde.org/D19468

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty, #vdg, ngraham, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All good!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19468

REVISION DETAIL
  https://phabricator.kde.org/D19468

To: rooty, #vdg, ngraham, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Everything appears to be in order.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19468

To: rooty, #vdg, ngraham, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Finally, this latest version works for me! #plasma 
 folks?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham, davidedmundson
Cc: mart, alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:245677bfb31a: Update documentation for kcontrol desktop 
theme (now plasma theme) (authored by ognarb).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19618?vs=53465=53466

REVISION DETAIL
  https://phabricator.kde.org/D19618

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/edit-delete.png
  doc/kcontrol/desktopthemedetails/edit-undo.png
  doc/kcontrol/desktopthemedetails/get-new-theme.png
  doc/kcontrol/desktopthemedetails/index.docbook
  doc/kcontrol/desktopthemedetails/main.png

To: ognarb, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

[Carl Schwan]

ognarb updated this revision to Diff 53465.
ognarb marked 4 inline comments as done.
ognarb added a comment.


  Fix typos and use entites
  
  Thanks yuri :D

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19618?vs=53463=53465

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19618

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/edit-delete.png
  doc/kcontrol/desktopthemedetails/edit-undo.png
  doc/kcontrol/desktopthemedetails/get-new-theme.png
  doc/kcontrol/desktopthemedetails/index.docbook
  doc/kcontrol/desktopthemedetails/main.png

To: ognarb, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

[Yuri Chornoivan]

yurchor requested changes to this revision.
yurchor added a comment.
This revision now requires changes to proceed.


  Thanks in advance for fixing this.

INLINE COMMENTS

> index.docbook:34
> +
> +   comes with multiple theme. The plasma theme define how the 
> different
> +  components of  are displayed (e.g Plasmoids, panels, widgets).

Typo: multiple theme -> multiple themes
Typo: define -> defines
Entity: plasma -> 

> index.docbook:35
> +   comes with multiple theme. The plasma theme define how the 
> different
> +  components of  are displayed (e.g Plasmoids, panels, widgets).
> +

Entity: e.g -> 

> index.docbook:86
> +  You need to be connected to the Internet to use it. Clicking on this 
> button will
> +  display a dialog where you can choose a new plasma theme. Clicking on
> +  Install in the dialog will install the chosen 
> plasma theme

Entity: plasma -> 

> index.docbook:112
> +location of those newly downloaded themes. Clicking on this button 
> will bring you the
> +file dialog to point to the plasma theme tarball you have on your 
> disk.
> +

Entity: plasma -> 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19618

To: ognarb, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

[Carl Schwan]

ognarb created this revision.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Some part were copied from kcontrol icons. Need proofreading

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19618

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/edit-delete.png
  doc/kcontrol/desktopthemedetails/edit-undo.png
  doc/kcontrol/desktopthemedetails/get-new-theme.png
  doc/kcontrol/desktopthemedetails/index.docbook
  doc/kcontrol/desktopthemedetails/main.png

To: ognarb
Cc: plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, 
ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Nathaniel Graham]

ngraham updated this revision to Diff 53462.
ngraham marked 5 inline comments as done.
ngraham added a comment.


  Address all review comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19606?vs=53409=53462

BRANCH
  reorganize-task-manager-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19606

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/plugin/backend.cpp

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19096: Improvements for long label items in Application Dashboard

[Tranter Madi]

trmdi abandoned this revision.
trmdi added a comment.


  In D19096#427329 , @hein wrote:
  
  > I'm sorry, but I can't accept this patch as-is - the hoverArea-related 
changes are just wrong, it's not OK to couple a delegate to the view by making 
it set tons of property on an item i its parent. I'll need to set some time 
aside to analyze what you're trying to achieve there and propose an alternative.
  
  
  I just want 2 things:
  
  1. Display 2 lines for long labels.
  2. For labels need more than 2 lines -> display a tooltip that has the full 
label when hovering on it.
  
  That's all, no matter how you do it.
  Basically, I don't want to add any new feature, just want to make the existed 
stuff usable. (Currently it's not usable while it's existing)
  
  Thank you!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Eike Hein]

hein added a comment.


  I'm concerned that having title labels on everything could be overdoing it a 
bit? It makes the context menu very large and have a lot of dead space, and 
adds to the noise. Isn't that rather a detriment to utility on repeated use? 
It's sometimes important to remember new users don't stay new users for very 
long, and first-time use isn't the only experience to optimize for.
  
  Also, I do get a lot of user reports every time the window title bar menu and 
the task context menu diverge. Personally I've never felt that they need to 
match because tasks aren't windpw title bars, but it's worth keeping in mind.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Eike Hein]

hein added a comment.


  I'm sorry, but I can't accept this patch as-is - the hoverArea-related 
changes are just wrong, it's not OK to couple a delegate to the view by making 
it set tons of property on an item i its parent. I'll need to set some time 
aside to analyze what you're trying to achieve there and propose an alternative.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19548: [Media frame] Modernize and improve settings window

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:d0c5e541d767: [Media frame] Modernize and improve 
settings window (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19548?vs=53408=53459

REVISION DETAIL
  https://phabricator.kde.org/D19548

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19548: [Media frame] Modernize and improve settings window

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  In D19548#426961 , @ngraham wrote:
  
  > We kinda sorta have a convention to use the app/widget's own icon for its 
"general" category, so I think this makes sense.
  >
  > The widget probably needs a better icon though than just this generic image 
mimetype.
  
  
  Agreed!

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-media-frame-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19548

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Nathaniel Graham]

ngraham added a comment.


  In D19606#426997 , @broulik wrote:
  
  > Overall I must say I'm quite a fan.
  >
  > I don't like the Settings and Alternatives entries at the top, they draw 
most attention to them for actions that should rather be least intrusive.
  
  
  I tried putting them at the bottom, but the problem there is that then the 
Close action isn't right at the bottom anymore, which didn't feel right.
  
  > Did you test how media controls behave in this scenario? Also please make 
sure keyboard accelerators (Alt key, the `&` stuff) are sane.
  
  Yeah, it works fine:
  F6674030: Screenshot_20190308_085516.png 

  
  Maybe we should give that section its own Media Playback header that's 
separate from the other actions? Or maybe we should remove the separator so 
those items are a full-fledged part of the action settings? Open to opinions.
  
  > Also keep in mind to adjust KWin's title bar menu to use the new icons as 
well.
  
  Will do!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Nathaniel Graham]

ngraham added a comment.


  In D19606#427269 , @abetts wrote:
  
  > Would it be possible for the header labels to be a bit different? Not sure 
what would look best, bold, italics, a lighter shade of gray
  >
  > F6674017: Screen Shot 2019-03-08 at 8.49.54 AM.png 

  
  
  Yes, I agree that we need to improve the header appearance, but that needs to 
be done elsewhere in the theme style itself, not here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Andres Betts]

abetts added a comment.


  Would it be possible for the header labels to be a bit different? Not sure 
what would look best, bold, italics, a lighter shade of gray
  
  F6674017: Screen Shot 2019-03-08 at 8.49.54 AM.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Andres Betts]

abetts added a comment.


  Can it be more descriptive? Using two words might help it be extra clear what 
the button is about.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: abetts, broulik, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19605

To: ndavis, #vdg, #breeze, zzag, davidedmundson
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Krešimir Čohar]

rooty updated this revision to Diff 53452.
rooty added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19468?vs=53451=53452

BRANCH
  arcpatch-D19468

REVISION DETAIL
  https://phabricator.kde.org/D19468

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty, #vdg, ngraham
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Krešimir Čohar]

rooty updated this revision to Diff 53451.
rooty added a comment.


  Refresh

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19468?vs=53402=53451

BRANCH
  arcpatch-D19468

REVISION DETAIL
  https://phabricator.kde.org/D19468

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty, #vdg, ngraham
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:408c6d6319ee: [Login, Lock, and Logout Screen] Make the 
avatar background circle more subtle (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19478?vs=53434=53450

REVISION DETAIL
  https://phabricator.kde.org/D19478

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19612: RFC port to bugzilla REST API

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  I'd love some feedback on the lib api especially. this is the first REST
  wrapper I wrote using cpp, so it feels all a bit clunky to me.
  
  https://bugzilla.readthedocs.io/en/5.0/api/
  
  - new internal lib wrapping the REST API
  - some testing on the lib, should probably be a bit more comprehensive
  - xmlrpc use gone
  - BugzillaManager continues to be a singleton manager for the API
  - ancient cookie system for login is entirely gone, this has been deprecated 
(or perhaps even removed?) for years
  
  this is functional, but still requires todo cleanups at the very least.
  also duplicate querying is pretty inefficient, needs porting to pagination
  really.
  
  some of the files are also overloaded with stuff (connection.cpp brrr)
  
  the lib api is split in three pieces:
  
  1. the connection containing protocol logic
  2. the clients containing routing logic
  3. the models modeling the json blobs into cpp
  
  the clients especially feel a bit awkward, but I think separating endpoint
  handling from the models is a worthwhile thing.
  
  clients get a request, give back a job and the intended use is for
  the consumer to then connect to the finished signal of the job to then
  ask the clients for the final return value of the job.
  this is a bit 'meh'. what I really wanted was a Future to be returned
  and the caller to connect to the future. unfortunately qfuture is fairly
  limited and since qtbase has no Promise implementation I'm rather opting
  for the double-function-approach than doing it like we did in the previous
  decade and have a gazillion signals.
  this way the handling of the job is always uniform and all specific
  "handling code" is inside the connected slot rather than the actual
  connection.
  
  error handling has been put entirely into exceptions which get raised
  when trying to access a finished job. in BugzillaManager they get rescued
  and turned into the already existing signals. this simplifies error
  handling a fair amount and also makes the error handling code
  look uniform across the various API calls we have.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19612

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/duplicatefinderjob.cpp
  src/bugzillaintegration/duplicatefinderjob.h
  src/bugzillaintegration/libbugzilla/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/attachment.cpp
  src/bugzillaintegration/libbugzilla/attachment.h
  src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp
  src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/error.http
  src/bugzillaintegration/libbugzilla/autotests/data/hi.http
  src/bugzillaintegration/libbugzilla/autotests/data/product.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/put.http
  src/bugzillaintegration/libbugzilla/autotests/producttest.cpp
  src/bugzillaintegration/libbugzilla/bug.cpp
  src/bugzillaintegration/libbugzilla/bug.h
  src/bugzillaintegration/libbugzilla/bugzilla.cpp
  src/bugzillaintegration/libbugzilla/bugzilla.h
  src/bugzillaintegration/libbugzilla/comment.cpp
  src/bugzillaintegration/libbugzilla/comment.h
  src/bugzillaintegration/libbugzilla/connection.cpp
  src/bugzillaintegration/libbugzilla/connection.h
  src/bugzillaintegration/libbugzilla/product.cpp
  src/bugzillaintegration/libbugzilla/product.h
  src/bugzillaintegration/parsebugbacktraces.cpp
  src/bugzillaintegration/parsebugbacktraces.h
  src/bugzillaintegration/productmapping.cpp
  src/bugzillaintegration/productmapping.h
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.h
  src/bugzillaintegration/reportinterface.cpp
  src/bugzillaintegration/reportinterface.h
  src/drkonqi.cpp

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19596: color monochrome icons to tooltip colors

[Marco Martin]

mart added a comment.


  In D19596#427074 , @sitter wrote:
  
  > Following Kai's question... wouldn't KIconLoader::global make the entire 
static obsolete?
  
  
  we need a second one, not the one used by the app, because we are altering 
how it colores the icons

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D19596

To: mart, #plasma, sitter
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19607: Remove unused dependencies

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R994:58beeb4837da: Remove unused dependencies (authored by 
arojas).

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19607?vs=53418=53443

REVISION DETAIL
  https://phabricator.kde.org/D19607

AFFECTED FILES
  CMakeLists.txt

To: arojas, nicolasfella, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19454: Fix errors in kirigami example files

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> apol wrote in AbstractApplicationWindow.qml:105
> Why's that?

Without I get the errror: TypeError: Property 'goBack' of object 
QQuickStackView_QML_91(0x55ea59443ee0) is not a function

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19454

To: ognarb, #kirigami
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Noah Davis]

ndavis added a comment.


  In D19605#427037 , @zzag wrote:
  
  > This patch makes buttons sharp only for one particular button size and font 
size.
  
  
  You're right, but this makes it sharper at the default button+font size. 
Smaller sizes suffer, but larger sizes are OK for the most part. Considering 
how the lowest common display resolution right now is 1366x768 and the most 
common display size is 1920x1080, I think that's a fair trade off.
  
  Ideally, it should be sharp at all sizes, but I don't know how to do that and 
our window buttons don't seem to be setup in a way that would allow that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19605

To: ndavis, #vdg, #breeze, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19609: [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch improves the appearance of the sddm theme and the lock screen with 
software rendering in place (QT_QUICK_BACKEND=software) by adding an outline to 
the action buttons, correcting the error that prevented the username outline 
from working and by adding a background to the action buttons that are 
otherwise impossible to see on top of a very bright background in software 
rendering mode.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  better-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19609

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Filip Fila]

filipf updated this revision to Diff 53434.
filipf added a comment.


  Subtract 2 from width so we don't get fringing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19478?vs=52994=53434

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  There doesn't seem to be anything else to be done here

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19603: Fix colours of header bar for acitve and inactive windows

[David Edmundson]

davidedmundson added a comment.


  > Are GTK developers aware of this problem?
  
  There's an old bug report, I've just added some info to it.
  https://gitlab.gnome.org/GNOME/gtk/issues/499
  
  I'm not 100% against adding the focus state in kwin.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19603: Fix colours of header bar for acitve and inactive windows

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in _headerbar.scss:14
> This is probably redundant.

Argh, please ignore this comment. It looks like background-image: none, 
background-color: ..., is used throughout the theme.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Krešimir Čohar]

rooty added a comment.


  i vote for no 2 / current diff

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Filip Fila]

filipf added a comment.


  Now that the other patch is done, I come offering 2 solutions.
  
  **Solution 1: Mimic the action button circles' appearance**
  F6673176: Screenshot_20190308_122953.png 

  
  F6673180: Screenshot_20190308_122851.png 

  
  F6673182: Screenshot_20190308_122755.png 

  
  **Solution 2: Current diff**
  
  F6673172: Screenshot_20190308_123023.png 

  
  F6673185: Screenshot_20190308_122638.png 

  
  F6673187: Screenshot_20190308_122412.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19603: Fix colours of header bar for acitve and inactive windows

[David Edmundson]

davidedmundson added a comment.


  > Are GTK developers aware of this problem?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19603: Fix colours of header bar for acitve and inactive windows

[Vlad Zagorodniy]

zzag added a comment.


  > On X11, gtk isn't selecting the backdrop class. Probably because kwin 
doesn't support one of their new activation flags which would be a GTK bug for 
not following their fallback correctly.
  
  If this is the case, then it's a bit awkward because GTK doesn't follow spec 
they wrote.
  
  > Might be worth not committing this till then.
  
  Are GTK developers aware of this problem?
  
  > But I think you're right that breeze technically should change slightly.
  
  Given that Breeze kdecoration settings are not synchronized with GTK theme, I 
think it's fine to have solid background color.

INLINE COMMENTS

> _headerbar.scss:14
>color: t_color(text);
> -  background-image: linear-gradient(to 
> bottom,t_color(background-light),t_color(background));
> +  background-image: none;
> +  background-color: t_color(background);

This is probably redundant.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19603: Fix colours of header bar for acitve and inactive windows

[David Edmundson]

davidedmundson added a comment.


  > What's the reason for removing the linear gradient?
  
  In the old code it was a gradient between $WindowBackgroundNormal and 
$WindowBackgroundNormal which obviously did nothing so I removed it.
  
  But I think you're right that breeze technically should change slightly.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19596: color monochrome icons to tooltip colors

[Harald Sitter]

sitter added a comment.


  Following Kai's question... wouldn't KIconLoader::global make the entire 
static obsolete?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D19596

To: mart, #plasma, sitter
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Kai Uwe Broulik]

broulik added a comment.


  This suffers from the same bug as the action in the D17410 
. The action doesn't show up unless the 
real applet context menu was opened once.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: broulik, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18646: [Colors KCM] Add search and filter

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a1fbeb96dc6c: [Colors KCM] Add search and filter 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18646?vs=53304=53422#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18646?vs=53304=53422

REVISION DETAIL
  https://phabricator.kde.org/D18646

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorsmodel.cpp
  kcms/colors/colorsmodel.h
  kcms/colors/filterproxymodel.cpp
  kcms/colors/filterproxymodel.h
  kcms/colors/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, hein, mart
Cc: hein, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18640: Reset tooltip delegate label height to defaults

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ef06af7c01a9: Reset tooltip delegate label height to 
defaults (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18640?vs=50635=53420

REVISION DETAIL
  https://phabricator.kde.org/D18640

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  containments/desktop/package/contents/ui/AppletHandle.qml

To: broulik, #plasma, #vdg, mart
Cc: mart, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19572: [kcolorschemeditor] Don't re-add existing tab

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:45f10322b8f3: [kcolorschemeditor] Dont re-add 
existing tab (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19572?vs=53306=53419#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19572?vs=53306=53419

REVISION DETAIL
  https://phabricator.kde.org/D19572

AFFECTED FILES
  kcms/colors/scmeditordialog.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Vlad Zagorodniy]

zzag added a comment.


  This patch makes buttons sharp only for one particular button size and font 
size.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19605

To: ndavis, #vdg, #breeze, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19607: Remove unused dependencies

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  These seem to be leftovers from plasma-pa

TEST PLAN
  Builds

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D19607

AFFECTED FILES
  CMakeLists.txt

To: arojas, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19603: Fix colours of header bar for acitve and inactive windows

[Vlad Zagorodniy]

zzag added a comment.


  (also, it would be enough just to add a group reviewer)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19603: Fix colours of header bar for acitve and inactive windows

[Vlad Zagorodniy]

zzag added a comment.


  What's the reason for removing the linear gradient?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19603

To: davidedmundson, #breeze, zzag, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Kai Uwe Broulik]

broulik added a comment.


  Overall I must say I'm quite a fan.
  
  I don't like the Settings and Alternatives entries at the top, they draw most 
attention to them for actions that should rather be least intrusive.
  I would prefer the jump list actions stuff at the top but grouping them with 
the other window/application actions is an interesting approach.
  While I personally don't use the Minimize/Maximize actions in the menu I've 
seen people get quite passionate about them.
  
  Did you test how media controls behave in this scenario? Also please make 
sure keyboard accelerators (Alt key, the `&` stuff) are sane.
  
  Also keep in mind to adjust KWin's title bar menu to use the new icons as 
well.

INLINE COMMENTS

> ContextMenu.qml:99
>  var lists = [
> -backend.jumpListActions(launcherUrl, menu),
> -backend.placesActions(launcherUrl, showAllPlaces, menu),
> -backend.recentDocumentActions(launcherUrl, menu)
> +[i18n("Places"), backend.placesActions(launcherUrl, 
> showAllPlaces, menu)],
> +[i18n("Recent Documents"), 
> backend.recentDocumentActions(launcherUrl, menu)],

Please use a JS object for that instead of using just numbered indices

  var list = [
  {title: i18n("Places"), actions: backend. ...},
  {title: i18n("Recent Documents"), actions: ...}
  ...
  ];

> ContextMenu.qml:112
> +// This section with the one beneath it that shows universal 
> actions
> +if (list[1].length > 0 || list[0] == i18n("Actions")) {
> +var sectionHeader = newMenuItem(menu);

Comparing translated strings is usually bad style, please use my idea above, 
and then perhaps add a third `group: "actions"` or similar string for 
identification

> ContextMenu.qml:119
> +
> +for (var key in list)
> +for (var i = 0; i < list[1].length; ++i) {

Remove

> ContextMenu.qml:320
>  text: i18n("Move To ")
> +icon: "go-next"
>  

I don't see the point of this icon, it adds visual noise for no better 
identification

> ContextMenu.qml:711
>  
> -text: i18nc("Remove launcher button for application shown while it 
> is not running", "Unpin")
> +text: i18nc("Remove launcher button for application shown while it 
> is not running", "Unpin from %1", plasmoid.title)
> +icon: "window-pin"

Perhaps add some context explaining %1 is plasmoid title?

However, I can already see this becoming quite awful in German in case of icon 
tasks "An Fensterleiste nur mit Symbolen anheften" :/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis
Cc: broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19580: Use high dpi pixmaps

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R838:90f655a146d1: Use high dpi pixmaps (authored by broulik).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19580?vs=53334=53414

REVISION DETAIL
  https://phabricator.kde.org/D19580

AFFECTED FILES
  src/xdg-desktop-portal-kde.cpp

To: broulik, #plasma, jgrulich, davidedmundson, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19596: color monochrome icons to tooltip colors

[Kai Uwe Broulik]

broulik added a comment.


  What's the need for this wrapper class rather than just making the 
`KIconLoader` global static?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D19596

To: mart, #plasma, sitter
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart