D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#428236 , @hein wrote: > I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 53632. rooty added a comment. Use Math.max instead of OR (works with other distros now) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53577=53632 BRANCH arcpatch-D19631 REVISION DETAIL

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham added inline comments. INLINE COMMENTS > configGeneral.qml:21 > > -import QtQuick 2.0 > -import QtQuick.Controls 1.0 as Controls > -import QtQuick.Layouts 1.1 as Layouts > +import QtQuick 2.12 > +import QtQuick.Controls 2.5 Is going that far actually required by anything? >

D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels

rooty added a comment. Sure thing REPOSITORY R120 Plasma Workspace BRANCH dont-crop-the-clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D19647 To: rooty, #plasma, #vdg, filipf, ngraham Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham added a comment. In D19669#428757 , @filipf wrote: > F6682649: Screenshot_20190311_011501.png I vote for this one, or else for putting the color wells below their text and slightly

D17073: Do not crop albumArt

ngraham added a comment. I don't think anyone'll object if you wanna grab this! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19670: [appmenu] Port to QQC2 and Kirigami.FormLayout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19670 AFFECTED FILES

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added a comment. Alternative looks: F6682650: Screenshot_20190311_012333.png F6682649: Screenshot_20190311_011501.png REPOSITORY R114 Plasma Addons REVISION DETAIL

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19669 AFFECTED FILES

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Awesome thanks! REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 To: filipf, #vdg, #plasma,

D19654: Add lazy instantiation for submenus

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Actually let's get this in and see how it works. REPOSITORY R169 Kirigami BRANCH lazyGenerationOfMenus REVISION DETAIL https://phabricator.kde.org/D19654 To: cordlandwehr, apol, mart

D19654: Add lazy instantiation for submenus

apol added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19654 To: cordlandwehr, apol, mart Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664

D19662: Fix Qmake based build

ognarb created this revision. ognarb added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY This patch should resolve

D17073: Do not crop albumArt

filipf added a comment. If there's no objections and because I'd really like for this to end up in 5.16, we could do that yeah. I agree that we're still obfuscating a non-negligible portion of the album art: F6682163: Screenshot_20190310_205631.png

D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels

ngraham accepted this revision. ngraham added subscribers: davidedmundson, mart. ngraham added a comment. This revision is now accepted and ready to land. Conceptually and practically, this makes sense. However before we land this, I'd like to get confirmation that this is okay from @mart,

D19656: Comparisson has a typo, === and not = ==.

rooty accepted this revision. rooty added a comment. This revision is now accepted and ready to land. That commit truly is the gift that keeps on giving REPOSITORY R119 Plasma Desktop BRANCH fixMouseHandlerLoading REVISION DETAIL https://phabricator.kde.org/D19656 To: tcanabrava,

D19656: Comparisson has a typo, === and not = ==.

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fixMouseHandlerLoading REVISION DETAIL https://phabricator.kde.org/D19656 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428458 , @ndavis wrote: > Can it have the same default width as the toolbar text location comboboxes? Yeah, I can do that. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

ndavis added a comment. Can it have the same default width as the toolbar text location comboboxes? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428453 , @ndavis wrote: > Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"? Yes, it adjusts itself to the width of the longest item automatically.

D19651: Improve the look of the Application Style KCM UI

ndavis added a comment. Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh,

D19654: Add lazy instantiation for submenus

cordlandwehr created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Items of submenus are only required when the respective submenu is becoming visible. Setting the intantiator to

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53592. GB_2 added a comment. Rename style preview checkbox from "Check box" to "Checkbox" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53591=53592 BRANCH master REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53591. GB_2 added a comment. Clean up style preview UI file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53589=53591 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, merge the two tabs into one page and make the KCM look better. F6680804:

D19631: [sddm-theme/lock screen] Overhaul font sizes

filipf added a comment. Looks good now, but let's see if we could simply change SDDM to default to 10pt like the desktop instead of 9pt. @davidedmundson do you perhaps know where we could change this setting? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 53577. rooty added a comment. Missed one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53576=53577 BRANCH revert-more (branched from master) REVISION DETAIL https://phabricator.kde.org/D19631

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 53576. rooty added a comment. Simplify REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53561=53576 BRANCH revert-more (branched from master) REVISION DETAIL https://phabricator.kde.org/D19631

D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels

filipf added a comment. I'd like to first see if we can fix Components, but if not this is probably a better fix than using QtRendering. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19647 To: rooty, #plasma, #vdg, filipf, ngraham Cc: plasma-devel,