D19606: [Task Manager] Reorganize and improve presentation of context menu

2019-03-10 Thread Nathaniel Graham 
ngraham added a comment.


  In D19606#428236 , @hein wrote:
  
  > I'm concerned that having title labels on everything could be overdoing it 
a bit? It makes the context menu very large and have a lot of dead space, and 
adds to the noise. Isn't that rather a detriment to utility on repeated use? 
It's sometimes important to remember new users don't stay new users for very 
long, and first-time use isn't the only experience to optimize for.
  
  
  Yeah, I do understand the criticism that this makes it really tall. 
Originally I had the three-item Task Manager section in a sub-menu, saving two 
slots. But it didn't look and feel as good in the end. Ultimately I'd like to 
see us put some more work into defining just when Widgets should actually be 
configurable and replaceable, because the three-mode system we have right now 
is kind of awkward. See T10190: (Re)define modes when editing panels and 
widgets .
  
  That said, I really like the logical separation between sections that this 
patch produces and I'd like to keep that.
  
  > Also, I do get a lot of user reports every time the window title bar menu 
and the task context menu diverge. Personally I've never felt that they need to 
match because tasks aren't windpw title bars, but it's worth keeping in mind.
  
  I can submit a patch to make it as close as possible if and when this lands 
(well, the parts of it that are duplicated here, that is).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Krešimir Čohar 
rooty updated this revision to Diff 53632.
rooty added a comment.


  Use Math.max instead of OR (works with other distros now)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53577=53632

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-10 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> configGeneral.qml:21
>  
> -import QtQuick 2.0
> -import QtQuick.Controls 1.0 as Controls
> -import QtQuick.Layouts 1.1 as Layouts
> +import QtQuick 2.12
> +import QtQuick.Controls 2.5

Is going that far actually required by anything?

> configGeneral.qml:28
>  
> -Layouts.ColumnLayout {
> -id: configGeneral
> +Item {
> +width: childrenRect.width

Why use a top level `Item`? Was there a problem with using the `FormLayout` as 
the top-level object?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19670

To: filipf, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels

2019-03-10 Thread Krešimir Čohar 
rooty added a comment.


  Sure thing

REPOSITORY
  R120 Plasma Workspace

BRANCH
  dont-crop-the-clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19647

To: rooty, #plasma, #vdg, filipf, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-10 Thread Nathaniel Graham 
ngraham added a comment.


  In D19669#428757 , @filipf wrote:
  
  > F6682649: Screenshot_20190311_011501.png 

  
  
  I vote for this one, or else for putting the color wells below their text and 
slightly indented.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

2019-03-10 Thread Nathaniel Graham 
ngraham added a comment.


  I don't think anyone'll object if you wanna grab this!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19670: [appmenu] Port to QQC2 and Kirigami.FormLayout

2019-03-10 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19670

AFFECTED FILES
  applets/appmenu/package/contents/config/config.qml
  applets/appmenu/package/contents/ui/configGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-10 Thread Filip Fila 
filipf added a comment.


  Alternative looks:
  
  F6682650: Screenshot_20190311_012333.png 

  
  F6682649: Screenshot_20190311_011501.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-10 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19669

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-10 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Awesome thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-quickshare-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19664

To: filipf, #vdg, #plasma, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19654: Add lazy instantiation for submenus

2019-03-10 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Actually let's get this in and see how it works.

REPOSITORY
  R169 Kirigami

BRANCH
  lazyGenerationOfMenus

REVISION DETAIL
  https://phabricator.kde.org/D19654

To: cordlandwehr, apol, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19654: Add lazy instantiation for submenus

2019-03-10 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19654

To: cordlandwehr, apol, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

2019-03-10 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-quickshare-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19664

AFFECTED FILES
  applets/quickshare/plasmoid/contents/config/config.qml
  applets/quickshare/plasmoid/contents/ui/settingsGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19662: Fix Qmake based build

2019-03-10 Thread Carl Schwan 
ognarb created this revision.
ognarb added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  This patch should resolve 
https://www.reddit.com/r/kde/comments/azgfbj/cant_compile_kirigami_for_android/
  
  Also fix a warning duplicate entry in qrc

TEST PLAN
  Build with cmake and qmake works

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19662

AFFECTED FILES
  kirigami.qrc

To: ognarb, #kirigami
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D17073: Do not crop albumArt

2019-03-10 Thread Filip Fila 
filipf added a comment.


  If there's no objections and because I'd really like for this to end up in 
5.16, we could do that yeah.
  
  I agree that we're still obfuscating a non-negligible portion of the album 
art:
  
  F6682163: Screenshot_20190310_205631.png 

  
  Maybe the thumbnail should be bottom anchored to the player controls in the 
case of `hasPlayer` but I'm sure if we can have popups taller when using a 
player.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels

2019-03-10 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added subscribers: davidedmundson, mart.
ngraham added a comment.
This revision is now accepted and ready to land.


  Conceptually and practically, this makes sense. However before we land this, 
I'd like to get confirmation that this is okay from @mart, @davidedmundson, or 
another #plasma  person familiar with 
this code.
  
  Also, damn this is looking good.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  dont-crop-the-clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19647

To: rooty, #plasma, #vdg, filipf, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19656: Comparisson has a typo, === and not = ==.

2019-03-10 Thread Krešimir Čohar 
rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  That commit truly is the gift that keeps on giving

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixMouseHandlerLoading

REVISION DETAIL
  https://phabricator.kde.org/D19656

To: tcanabrava, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19656: Comparisson has a typo, === and not = ==.

2019-03-10 Thread Tomaz Canabrava 
tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixMouseHandlerLoading

REVISION DETAIL
  https://phabricator.kde.org/D19656

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

To: tcanabrava
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber 
GB_2 added a comment.


  In D19651#428458 , @ndavis wrote:
  
  > Can it have the same default width as the toolbar text location comboboxes?
  
  
  Yeah, I can do that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Noah Davis 
ndavis added a comment.


  Can it have the same default width as the toolbar text location comboboxes?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber 
GB_2 added a comment.


  In D19651#428453 , @ndavis wrote:
  
  > Is that "Application style" combobox long enough to accommodate longer 
strings like "MS Windows 9x"?
  
  
  Yes, it adjusts itself to the width of the longest item automatically.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Noah Davis 
ndavis added a comment.


  Is that "Application style" combobox long enough to accommodate longer 
strings like "MS Windows 9x"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19654: Add lazy instantiation for submenus

2019-03-10 Thread Andreas Cord-Landwehr 
cordlandwehr created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Items of submenus are only required when the respective submenu is
  becoming visible. Setting the intantiator to active only when the
  menu is visible avoids loading all submenus at once.

REPOSITORY
  R169 Kirigami

BRANCH
  lazyGenerationOfMenus

REVISION DETAIL
  https://phabricator.kde.org/D19654

AFFECTED FILES
  src/controls/private/ActionsMenu.qml

To: cordlandwehr
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber 
GB_2 updated this revision to Diff 53592.
GB_2 added a comment.


  Rename style preview checkbox from "Check box" to "Checkbox"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19651?vs=53591=53592

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber 
GB_2 updated this revision to Diff 53591.
GB_2 added a comment.


  Clean up style preview UI file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19651?vs=53589=53591

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Apply the KDE HIG, merge the two tabs into one page and make the KCM look 
better.
  F6680804: Improved Application Style KCM UI.png 


TEST PLAN
  Open the Application Style KCM.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Filip Fila 
filipf added a comment.


  Looks good now, but let's see if we could simply change SDDM to default to 
10pt like the desktop instead of 9pt. @davidedmundson do you perhaps know where 
we could change this setting?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Krešimir Čohar 
rooty updated this revision to Diff 53577.
rooty added a comment.


  Missed one

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53576=53577

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Krešimir Čohar 
rooty updated this revision to Diff 53576.
rooty added a comment.


  Simplify

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53561=53576

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels

2019-03-10 Thread Filip Fila 
filipf added a comment.


  I'd like to first see if we can fix Components, but if not this is probably a 
better fix than using QtRendering.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19647

To: rooty, #plasma, #vdg, filipf, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart