D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[visha wa]

vishaw abandoned this revision.
vishaw added a comment.


  abondon because its a duplicate.

REVISION DETAIL
  https://phabricator.kde.org/D19678

To: vishaw, #plasma, ngraham
Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Noah Davis]

ndavis added a comment.


  > Though the icons are indeed pretty, and the
  
  problem with small monochrome icons has been resolved, the information 
density is now
  quite low.
  
  When? I still get a mix of color and monochrome icons in System Settings with 
the git master versions of it and its dependencies.
  
  I agree that the side bar looks better with shorter items, but I don't think 
we should make a change like this before the problem is really solved.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[David Redondo]

davidre added a comment.


  In D19687#429332 , @ngraham wrote:
  
  > Also, this has nothing to do with your patch specifically, but seeing so 
many checkesd checkboxes in the slideshow's preview pane makes me realize just 
how much I want the Breeze style checkbox to actually look like a checkbox, 
with a checkmark instead of just a filled in roundrect.
  
  
  Yeah also not a fan of that. I had the idea to give it maybe a small grey 
rectangle like the action icons as the empty checkboxes or the blue blob can be 
hard to spot. See the empty checkbox in the last row or the checkbox on Cascade 
in the screenshot.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[David Redondo]

davidre added a comment.


  In D19687#429367 , @abetts wrote:
  
  > How would the folders on the folder list on the left be removed as sources?
  
  
  In D18809  I changedthe ListItems to 
Kirigami  SwipeListItems. This changed the remove icon from always visible to 
visible on hover

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[Andres Betts]

abetts added a comment.


  How would the folders on the folder list on the left be removed as sources?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[David Redondo]

davidre updated this revision to Diff 53697.
davidre added a comment.


  Set checked to false if checkboxes are not visible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19687?vs=53696=53697

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[David Redondo]

davidre updated this revision to Diff 53696.
davidre added a comment.


  Sorry for that.  Actually these warnings were the reason why the checkboxes 
were visible everywhere. Even if the checkboxes are not visible I got these 
warnings. In an attempt to get rid of them I tried enabled.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19687?vs=53672=53696

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[Thomas Surrel]

thsurrel added a comment.


  And I could guide you around the kernel except in the graphic area ...

REVISION DETAIL
  https://phabricator.kde.org/D19678

To: vishaw, #plasma, ngraham
Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[Nathaniel Graham]

ngraham added a comment.


  Well I've got one! Unfortunately my kernel-fu is non-existent, but I can 
follow instructions and commands like a trained monkey pretty well. :)

REVISION DETAIL
  https://phabricator.kde.org/D19678

To: vishaw, #plasma, ngraham
Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

ngraham added a comment.


  In D19694#429341 , @broulik wrote:
  
  > Not a huge fan of going back and forth with design decisions all the time 
but +1 I preferred the smaller icons we used to habe
  
  
  //Technically// this isn't actually going back to anything because in the 
past we had small icons with tall list items--the worst of both worlds. Now we 
have tall list items with large icons, and this turns it into short list items 
with small icons. Also this hasn't been released to customers yet. If you can't 
do your experimenting in git master, where can you do it? :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[Thomas Surrel]

thsurrel added a comment.


  Yeah, that would help if I had a laptop that has this behavior, but I 
couldn't find any.

REVISION DETAIL
  https://phabricator.kde.org/D19678

To: vishaw, #plasma, ngraham
Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[Nathaniel Graham]

ngraham added a comment.


  In D19678#429348 , @thsurrel wrote:
  
  > I would love to see something like this getting in somehow, but as Nate 
described, we run into a problem with literally the first person that tested 
the patch. That sounds statistically bad.
  >
  > I did not find a way to ensure that a given minimal step would turn on the 
screen when starting from 0. My guess is that there are some graphical cards 
out there that will behave weird and turn on the screen at an arbitrary level. 
Unless testing this first on a LOT of hardware, it seems difficult to find a 
value suitable for all.
  
  
  Maybe we should look a level deeper and figure out why we're getting nonzero 
values that still have the backlight off? Could be a kernel bug.

REVISION DETAIL
  https://phabricator.kde.org/D19678

To: vishaw, #plasma, ngraham
Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[Thomas Surrel]

thsurrel added a comment.


  I would love to see something like this getting in somehow, but as Nate 
described, we run into a problem with literally the first person that tested 
the patch. That sounds statistically bad.
  
  I did not find a way to ensure that a given minimal step would turn on the 
screen when starting from 0. My guess is that there are some graphical cards 
out there that will behave weird and turn on the screen at an arbitrary level. 
Unless testing this first on a LOT of hardware, it seems difficult to find a 
value suitable for all.

REVISION DETAIL
  https://phabricator.kde.org/D19678

To: vishaw, #plasma, ngraham
Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Kai Uwe Broulik]

broulik added a comment.


  Not a huge fan of going back and forth with design decisions all the time but 
+1 I preferred the smaller icons we used to habe

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a subscriber: thsurrel.
ngraham added a comment.
This revision now requires changes to proceed.


  -1 for making this user-configurable, sorry. The brightness curve is an 
implementation detail and I don't think exposing it to the user makes sense. 
With a string like "Use quadratic curve for brightness keys:", that's just 
gonna confuse users. Most Regular People™ don't even know what the word 
"quadratic" means.
  
  I would support improving the curve without making it user-configurable. 
//However:// the last time someone proposed this in D13095: Scren brightness 
follow a quatratic progression  it ran into 
a problem where for certain screens (including mine), two keypresses were 
required to get the backlight to turn on again after reducing the brightness to 
the lowest level. If you can solve that, then I'll be happy. :) Maybe you and 
@thsurrel can put your heads together and figure out a solution!

REVISION DETAIL
  https://phabricator.kde.org/D19678

To: vishaw, #plasma, ngraham
Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This puts permanently disabled checkboxes on the wallpaper delegates that 
aren't used in the slideshow version, possibly related to a flood of warnings 
that gets printed to the console:
  

file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/WallpaperDelegate.qml:123:13:
 Unable to assign [undefined] to bool

file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/WallpaperDelegate.qml:123:13:
 Unable to assign [undefined] to bool

file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/WallpaperDelegate.qml:123:13:
 Unable to assign [undefined] to bool
  
  Let's not show the checkboxes at all unless we're in the slideshow view.
  
  ---
  
  Also, this has nothing to do with your patch specifically, but seeing so many 
checkesd checkboxes in the slideshow's preview pane makes me realize just how 
much I want the Breeze style checkbox to actually look like a checkbox, with a 
checkmark instead of just a filled in roundrect.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  The KMessageWidget within the group box is only weird because there's a group 
box IMO. This KCM is a good candidate for being re-laid-out with a FormLayout 
so it looks and feels like everything else these days. I can do that after this 
lands. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

To: broulik, #plasma, #vdg, sitter, ngraham
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Ever since increasing the list item size to accommodate 32px icons, System 
Settings'
  sidebar has felt somehow //wrong// to me. Though the icons are indeed pretty, 
and the
  problem with small monochrome icons has been resolved, the information 
density is now
  quite low. Since the list is very long, the amount of scrolliness is 
increased and
  there's a low of whitespace.
  
  This RFC patch explores the impact of reducing the icon size down to the 
default value
  for Kirigami list items. The information density increases and the whole 
thing feels
  better to me. On the other hand, the icons don't look as good because they're 
scaled to
  fit in a 22px size. Also, touch-friendliness is reduced.
  
  I'm not married to this idea but I thought I'd throw it out there. Comments 
are welcome.

TEST PLAN
  Before: F6685010: Before.png 
  After: F6685009: After.png 

REPOSITORY
  R124 System Settings

BRANCH
  reduce-sidebar-icon-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19694

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: ngraham, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19654: Add lazy instantiation for submenus

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d06e7280045d: Add lazy instantiation for submenus 
(authored by cordlandwehr).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19654?vs=53596=53688

REVISION DETAIL
  https://phabricator.kde.org/D19654

AFFECTED FILES
  src/controls/private/ActionsMenu.qml

To: cordlandwehr, apol, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added a comment.


  Okay so I checked additionally and the top level Item doesn't seem necessary. 
I guess I copied that style by looking at the systemtray and folderview icon 
configuration window code, which has an Item as a top level element. #plasma 
 is there any reason for using it or 
is it fine to just start off with Kirigami.FormLayout instantly?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19670

To: filipf, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Lukas Ba.]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #20 from Lukas Ba.  ---
> 2.) Add option to reduce turn off timeout when screen is locked (to e.g. 30 
> seconds or 1 minute) ← would be my preference

Here is how to implement this behaviour with the event workaround.
I added two commands. To reduce the delay until the screen is turned off, when
the screen is locked.
/usr/bin/xset dpms 69
To reset the delay until the screen is turned off to the longer value, when the
screen is unlocked.
/usr/bin/xset dpms 420

-- 
You are receiving this mail because:
You are the assignee for the bug.

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Noah Davis]

ndavis added a comment.


  @zzag Is there anything you want me to change?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19605

To: ndavis, #vdg, #breeze, zzag, davidedmundson
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:53290043796c: [Task Manager] Fix sorting of tasks on last 
desktop in sort-by-desktop mode (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19259?vs=53131=53677

REVISION DETAIL
  https://phabricator.kde.org/D19259

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

To: hein, #plasma, mart
Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4d0f1a3e6ec7: Make Ctrl+A work regardless of focus and 
visualize active selection in search… (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19518?vs=53135=53676

REVISION DETAIL
  https://phabricator.kde.org/D19518

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/plugin/dashboardwindow.cpp

To: hein, #plasma, mart
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d769b7aa8838: [Task Manager] Fix virtual desktops subtext 
on task tooltip (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19257?vs=52388=53675

REVISION DETAIL
  https://phabricator.kde.org/D19257

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: hein, #plasma, mart
Cc: apol, Fuchs, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19688: kirigami_package_breeze_icons: Search among size 16 icons as well

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:31e91fbbf7f5: kirigami_package_breeze_icons: Search among 
size 16 icons as well (authored by hein).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19688?vs=53673=53674

REVISION DETAIL
  https://phabricator.kde.org/D19688

AFFECTED FILES
  KF5Kirigami2Macros.cmake

To: hein, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19688: kirigami_package_breeze_icons: Search among size 16 icons as well

[Eike Hein]

hein created this revision.
hein added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19688

AFFECTED FILES
  KF5Kirigami2Macros.cmake

To: hein, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19687: Allow single images to be excluded from the slideshow

[David Redondo]

davidre updated this revision to Diff 53672.
davidre added a comment.


  - Remove debug statement

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19687?vs=53671=53672

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[David Redondo]

davidre created this revision.
davidre added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  This allows to exlude single images from the slideshow by unchecking the 
little checkbox in the top right corner.
  Feature or todo?: If a folder is removed I don't touch the unchecked Slides. 
So the list could get very big but if a formerly removed folder is 
  added again an excluded image will be excluded again.

TEST PLAN
  - Uncheck some images
  - They don't appear in the slideshow

REPOSITORY
  R120 Plasma Workspace

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM.
  
  I'll put it on the record that I still think the "yo you wanna restart now" 
message should be at the top of the KCM and not inside the groupbox.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

To: broulik, #plasma, #vdg, sitter
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19612: RFC port to bugzilla REST API

[Harald Sitter]

sitter updated this revision to Diff 53669.
sitter added a comment.


  - repair dupe detection - was running on empty list
  - refactor bug fetching to not include comment fetching and port all users of 
it
  - stop holding all comments of all bugs in memory. we have no use for like 
99% of them after parsing
  - rebase on master
  
  considering there's a default connection and the report dialog is bugzilla 
specific anyway I am kinda leaning towards doing away with bugzillalib 
entirely. we have little to no advantage from its singletonness

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19612?vs=53447=53669

BRANCH
  webservice

REVISION DETAIL
  https://phabricator.kde.org/D19612

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/duplicatefinderjob.cpp
  src/bugzillaintegration/duplicatefinderjob.h
  src/bugzillaintegration/libbugzilla/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/attachment.cpp
  src/bugzillaintegration/libbugzilla/attachment.h
  src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp
  src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/error.http
  src/bugzillaintegration/libbugzilla/autotests/data/hi.http
  src/bugzillaintegration/libbugzilla/autotests/data/product.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/put.http
  src/bugzillaintegration/libbugzilla/autotests/producttest.cpp
  src/bugzillaintegration/libbugzilla/bug.cpp
  src/bugzillaintegration/libbugzilla/bug.h
  src/bugzillaintegration/libbugzilla/bugzilla.cpp
  src/bugzillaintegration/libbugzilla/bugzilla.h
  src/bugzillaintegration/libbugzilla/comment.cpp
  src/bugzillaintegration/libbugzilla/comment.h
  src/bugzillaintegration/libbugzilla/connection.cpp
  src/bugzillaintegration/libbugzilla/connection.h
  src/bugzillaintegration/libbugzilla/product.cpp
  src/bugzillaintegration/libbugzilla/product.h
  src/bugzillaintegration/parsebugbacktraces.cpp
  src/bugzillaintegration/parsebugbacktraces.h
  src/bugzillaintegration/productmapping.cpp
  src/bugzillaintegration/productmapping.h
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.h
  src/bugzillaintegration/reportinterface.cpp
  src/bugzillaintegration/reportinterface.h
  src/config-drkonqi.h.cmake
  src/data/debuggers/external/cdbrc
  src/data/debuggers/internal/cdbrc
  src/data/mappings
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/drkonqi.cpp
  src/drkonqibackends.cpp
  src/kdbgwin/CMakeLists.txt
  src/kdbgwin/abstract_generator.h
  src/kdbgwin/kdbgwin_process.cpp
  src/kdbgwin/kdbgwin_process.h
  src/kdbgwin/main.cpp
  src/kdbgwin/mingw_generator.cpp
  src/kdbgwin/msvc_generator.cpp
  src/kdbgwin/process.cpp
  src/kdbgwin/process.h
  src/main.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19662: Fix Qmake based build

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f7100e2c9ca6: Fix Qmake based build (authored by ognarb).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19662?vs=53621=53664

REVISION DETAIL
  https://phabricator.kde.org/D19662

AFFECTED FILES
  kirigami.qrc

To: ognarb, #kirigami, mart
Cc: mart, plasma-devel, domson, dkardarakos, apol, davidedmundson, hein

D19684: drop explicit disconnect in dtor

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:f7fbcff86ac4: drop explicit disconnect in dtor (authored 
by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19684?vs=53662=53663

REVISION DETAIL
  https://phabricator.kde.org/D19684

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp

To: sitter, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19662: Fix Qmake based build

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kirigami.qrc:21
>   alias="ActionTextField.qml">src/controls/ActionTextField.qml
> - alias="private/PrivateActionToolButton.qml">src/controls/private/PrivateActionToolButton.qml
>   alias="private/GlobalDrawerActionItem.qml">src/controls/private/GlobalDrawerActionItem.qml

this file still exists

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19662

To: ognarb, #kirigami, mart
Cc: mart, plasma-devel, domson, dkardarakos, apol, davidedmundson, hein

D19684: drop explicit disconnect in dtor

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  when this is getting destroyed the qobject dtor will automatically
  disconnect everything. the explicit disconnect calls serve no purpose and
  aren't done in any other dtors.

TEST PLAN
  it doesn't crash

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19684

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp

To: sitter, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Kai Uwe Broulik]

broulik updated this revision to Diff 53661.
broulik added a comment.


  - Enable word wrap for message widget

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19560?vs=53659=53661

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.desktop
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/org.freedesktop.login1.Manager.xml
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp

To: broulik, #plasma, #vdg, sitter
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Kai Uwe Broulik]

broulik updated this revision to Diff 53660.
broulik added a comment.


  - Restore QML

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19562?vs=53654=53660

REVISION DETAIL
  https://phabricator.kde.org/D19562

AFFECTED FILES
  logout-greeter/shutdowndlg.cpp
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg, ngraham
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Kai Uwe Broulik]

broulik updated this revision to Diff 53659.
broulik added a comment.


  - Fix xml
  - Better init dbus iface

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19560?vs=53652=53659

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.desktop
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/org.freedesktop.login1.Manager.xml
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp

To: broulik, #plasma, #vdg, sitter
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Harald Sitter]

sitter added a comment.


  I think you lost the QML part of the diff.
  
  LGTM, can't really comment on the qml side though. Haven't worked with qml in 
years.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19562

To: broulik, #plasma, #vdg, ngraham
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19682: Set colorSet on categories header

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:441697ca9b81: Set colorSet on categories header (authored 
by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19682?vs=53656=53657#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19682?vs=53656=53657

REVISION DETAIL
  https://phabricator.kde.org/D19682

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: broulik, #plasma, #vdg, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19682: Set colorSet on categories header

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  After a recent Kirigami change, the header behind the search box became white 
whereas the back button on the sub categories page did not.
  This adds an explicit color set like was done on the sub categories page.

TEST PLAN
  Should probably go into 5.12 since the code was there for the sub categories 
page already and distros tend to ship newer Frameworks with Plasma LTS
  Before
  F6683843: Screenshot_20190311_151340.png 

  After
  F6683844: Screenshot_20190311_151310.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19682

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19670

To: filipf, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

[Andres Betts]

abetts added a comment.


  Is there any way that we can make the preview window have more right and left 
margins? When presented like this, it seems like it is actually another module 
that users interact with.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  XML broken.
  
  The KMessageWidget being inside the groupbox looks a bit weird to me. Don't 
we usually put the messages at the top of the KCM?

INLINE COMMENTS

> kcmsmserver.cpp:70
>  
> +m_login1Manager = new 
> OrgFreedesktopLogin1ManagerInterface(QStringLiteral("org.freedesktop.login1"),
> +   
> QStringLiteral("/org/freedesktop/login1"),

possibly should be up in the member initializer list?

> kcmsmserver.h:48
> +
> +  OrgFreedesktopLogin1ManagerInterface *m_login1Manager;
> +

`= nullptr`

> org.freedesktop.login1.Manager.xml:13
> +  
> +
> +

interface end tag missing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

To: broulik, #plasma, #vdg, sitter
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Kai Uwe Broulik]

broulik updated this revision to Diff 53654.
broulik added a comment.


  - Async call

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19562?vs=53265=53654

REVISION DETAIL
  https://phabricator.kde.org/D19562

AFFECTED FILES
  logout-greeter/shutdowndlg.cpp

To: broulik, #plasma, #vdg, ngraham
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Harald Sitter]

sitter added a comment.


  I think it's bad practice to do blocking dbus calls.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19562

To: broulik, #plasma, #vdg, ngraham
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Kai Uwe Broulik]

broulik updated this revision to Diff 53652.
broulik added a comment.


  - Use introspected DBus stuff; used the nicer synchronous APIs, should be 
fine since this isn't a background service that we must not block

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19560?vs=53290=53652

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.desktop
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/org.freedesktop.login1.Manager.xml
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp

To: broulik, #plasma, #vdg
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19675: Do not use SYSTEM when including header paths

[Hannah Kiekens]

hannahk added a comment.


  I don't have commit access
  Plz push this with: Hannah Kiekens hannahkiek...@gmail.com

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D19675

To: hannahk, #plasma, drosca, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19675: Do not use SYSTEM when including header paths

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:9ee6488290a8: Do not use SYSTEM when including header 
paths (authored by hannahk, committed by nicolasfella).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19675?vs=53641=53649

REVISION DETAIL
  https://phabricator.kde.org/D19675

AFFECTED FILES
  src/kio/bluetooth/CMakeLists.txt

To: hannahk, #plasma, drosca, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[visha wa]

vishaw updated this revision to Diff 53645.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19678?vs=53644=53645

REVISION DETAIL
  https://phabricator.kde.org/D19678

AFFECTED FILES
  PowerDevilSettings.kcfg
  daemon/powerdevilbrightnesslogic.cpp
  kcmodule/global/GeneralPage.cpp
  kcmodule/global/generalPage.ui

To: vishaw, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

[visha wa]

vishaw created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vishaw requested review of this revision.

REVISION SUMMARY
  Add an option to make brightness up / brightness down key increase/decrease 
brightness along a quadratic curve instead of the usual linear curve.
  This allows much finer tuning at low brightness. Very useful in total 
darkness, when the smallest change in brightness makes huge difference.

TEST PLAN
  Tested on the latest git version of powerdevil.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19678

AFFECTED FILES
  PowerDevilSettings.kcfg
  daemon/powerdevilbrightnesslogic.cpp
  kcmodule/global/GeneralPage.cpp
  kcmodule/global/generalPage.ui

To: vishaw
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Notes for Monday Plasma meeting of 11/03/2019

[Marco Martin]

Eike:
* I have D19259 and D19518 waiting on review and would like to clear out my 
review queue before a trip this Friday if anyone has time.
  Diff 19259 "[Task Manager] Fix sorting of tasks on last desktop in sort-by-
desktop mode" [Needs Review] https://phabricator.kde.org/D19259
  Diff 19518 "Make Ctrl+A work regardless of focus and visualize active 
selection in search heading" [Needs Review] https://phabricator.kde.org/D19518

Kai Uwe:
 Work done:
 - Added search and filter to Colors KCM, can now filter by All, Light, Dark 
schemes
 - Fixed my Solid UDisks2 ObjectManager rewrite to work with CD drives (for 
lack of hardware only tested in vbox)
 -- Please give branch broulik/objectmanager of Solid a try! Might just put it 
on Phab soon for some more visibility
 - Fixed KWin's "screenshot window under cursor" not working
 - Fixed crash in PowerDevil caused by unreviewed "clazy says so it must be 
true" patch that went in a few months ago...
 - Started improving job finished notifications a bit
 -- Instead of showing "Copying: Finished: Some random file that happened to 
be copied last"
 -- it should show "Copying: Finished: xyz files to $destination folder"
 -- including preview/thumbnail with drag and drop etc etc
 -- Had to fix loads of stuff all over the stack for this: D19583 D19585 
D19586 D19588 D19589
 Diff 19583 "[KUiServerJobTracker] Update destUrl before finishing the job" 
[Needs Review] https://phabricator.kde.org/D19583
 Diff 19585 "[CopyJob] Report results after finishing copy" [Needs Revision] 
https://phabricator.kde.org/D19585
 Diff 19586 "[CopyJob] Treat URL as dirty when renaming file as conflict 
resolution" [Closed] https://phabricator.kde.org/D19586
 Diff 19588 "[Notifications] Improve finished notification" [Needs Revision] 
https://phabricator.kde.org/D19588
 Diff 19589 "[DownloadJob] Set destUrl and total amount" [Accepted] https://
phabricator.kde.org/D19589
 - Implemented "Reboot to firmware setup" feature to Sessions KCM, please 
review: D19560 D19562
 Diff 19560 "[Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox" [Needs 
Review] https://phabricator.kde.org/D19560
 Diff 19562 "[Logout Screen] Show info that rebooting will enter firmware 
setup" [Accepted] https://phabricator.kde.org/D19562
 Work todo:
 - Continue on the notification stuff
 - General bugfixing

Vlad:
* Fixed https://bugs.kde.org/390295
* Fixed https://bugs.kde.org/399572
* Currently, investigating https://bugs.kde.org/show_bug.cgi?id=404856. It 
seems to be modifiers related
 KDE bug 404856 in plasmashell (generic-wayland) "[Wayland] Right click on 
desktop stops working after desktop grid effect" [normal,] https://
bugs.kde.org/show_bug.cgi?id=404856

Marco:
Kirigami
* fixed icons that sometimes appeared disabled when they aren't
* fixed header higing/revealing on scrolling
* fixed several terminal warnings
* possibility for custom header and footer contents in ContextDrawer
* some fixes on "special toolbar case" pages
* in PageRow the columnview is a layer in itself, can even be not the first 
layer
* some fixes in the custom headers property behavior
* a singnal when the contextualactions menu is about to show
* fixed a regression that broke ruqola (as a bonus improved ruqola ui a bit)

qqc2-desktop-style:
* listitem delegates base on the scrollbar visibility for their default right 
padding
* make icons work in the RoundButton component

Plasma's QQC1 style:
* a fix for BUG399155



-- 
Marco Martin

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Harald Sitter]

sitter added a comment.


  I feel like this would be nicer a dbus interface class thingy.

INLINE COMMENTS

> kcmsmserver.cpp:118
> +
> +if (enable) {
> +
> dialog->firmwareSetupMessageWidget->setMessageType(KMessageWidget::Information);

Perhaps reduce the nesting by returning early `if (!enable) { return; }`?

> smserverconfigimpl.cpp:20
>  
> +#include 
> +

Not needed? .h includes ui_.h and that would include kmessagewidget.h

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

To: broulik, #plasma, #vdg
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #19 from goodmi...@goodmirek.com ---
arne anka: The issue seems to be there is not enough people able to contribute
their manpower or money to buy such a manpower.
If I create an issue for this bug on bountysource.com and add $50 bounty, how
much will you contribute?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D19676: Fix out of bounds access error in SystemLoadViewer.qml

[Stefan Tüx]

stefantux created this revision.
stefantux added a project: Plasma.
Herald added a subscriber: plasma-devel.
stefantux requested review of this revision.

REVISION SUMMARY
  Fixes bugs on startup of plasmashell if the widget is loaded by the user
  
  BUG: 405346

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19676

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: stefantux
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19675: Do not use SYSTEM when including header paths

[Hannah Kiekens]

hannahk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hannahk requested review of this revision.

REVISION SUMMARY
  Using SYSTEM here forces CMake to pass -isystem to gcc.
  This breaks crosscompiling on multiple occasions
  This incorrectly tells gcc that BluezQt include dir is of system inportance

TEST PLAN
  Crosscompiling with KDE Yocto project to raspberrypi3

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D19675

AFFECTED FILES
  src/kio/bluetooth/CMakeLists.txt

To: hannahk
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #18 from Kai Uwe Broulik  ---
If it were trivially implemented, I would have long done it. Feel free to poke
the code and submit a patch, relevant code can be found in
powerdevil/daemon/actions/dpms

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[arne anka]

https://bugs.kde.org/show_bug.cgi?id=348529

arne anka  changed:

   What|Removed |Added

 CC||kde-b...@ginguppin.de

--- Comment #17 from arne anka  ---
surprising such a trivial but vital feature is still missing - and nothing
happened after almost 4 years.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D19651: Improve the look of the Application Style KCM UI

[Björn Feber]

GB_2 added a comment.


  In D19651#428459 , @GB_2 wrote:
  
  > In D19651#428458 , @ndavis wrote:
  >
  > > Can it have the same default width as the toolbar text location 
comboboxes?
  >
  >
  > Yeah, I can try that.
  
  
  For some reason I couldn't get it to work, I'll just leave it how it is now, 
I think it looks fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 53635.
GB_2 added a comment.


  Check if configure button should be enabled after clicking "Defaults" and 
rename "cbStyle" to "comboStyle"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19651?vs=53592=53635

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19651

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylepreview.ui

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ngraham wrote in configGeneral.qml:21
> Is going that far actually required by anything?

Probably not but I'm always checking Qt documentation and simply using the 
import they recommend. Because 5.16 will depend on Qt 5.12 it shouldn't be a 
problem, but I can leave things as they are.

> ngraham wrote in configGeneral.qml:28
> Why use a top level `Item`? Was there a problem with using the `FormLayout` 
> as the top-level object?

I'm seeing this consistently, properties don't work at all if placed in 
Kirigami.FormLayout. In this case if put there you can click on the options but 
the Apply button will just stay shaded.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19670

To: filipf, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19656: Comparisson has a typo, === and not = ==.

[Luca Beltrame]

lbeltrame added a comment.


  This was already fixed by 0d5c93b7c5318600f53d214efca2a060c0f0eea7 
.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixMouseHandlerLoading

REVISION DETAIL
  https://phabricator.kde.org/D19656

To: tcanabrava, rooty
Cc: lbeltrame, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart