D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54168.
rooty added a comment.


  Activity...

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54167=54168

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54167.
rooty added a comment.


  Remove unnecessary comment

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54166=54167

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54166.
rooty added a comment.


  Missed one

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54165=54166

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54165.
rooty marked 9 inline comments as done.
rooty added a comment.


  Implement inline comment suggestions

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54137=54165

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty marked 7 inline comments as done.
rooty added inline comments.

INLINE COMMENTS

> ngraham wrote in powerdevilcore.cpp:330
> Remove "the profile"

Hmm sure

> ngraham wrote in powerdevilcore.cpp:367
> "or the action is not supported" -> "or the action not being supported"

"or because the action is not supported", "This is due to the action not being 
supported" sounds too elaborate for my taste and I'd rather have a disconnected 
clause here

> ngraham wrote in powerdevilcore.cpp:541
> Are we 100% sure that `name` will always be a good enough string that the 
> user will recognize it as their mouse? (not a rhetorical question, I really 
> am wondering :) )
> 
> Same for other instances below too.

I thought about that, then realized that the heading says "Mouse" (Mouse 
Battery Low)  "Keyboard" etc. so it seems redundant too (to repeat it in the 
body text)

> ngraham wrote in powerdevilcore.cpp:607
> "go into" -> "enter" ?

Better, yes. We could use just "enter hibernation" without mode too

> ngraham wrote in powerdevilcore.cpp:612
> "go to sleep" is just fine here

Not very fancy tho 藍

> ngraham wrote in powerdevilcore.cpp:643
> Not sure this comment is really necessary :)

:)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19837: Add support for applications in KNSBackend

[Nathaniel Graham]

ngraham added a comment.


  Can you edit the test plan to indicate the name of an app from the store that 
now appears in Discover's Applications section? A quick test of this patch 
didn't reveal ExeQt or Treeline in Discover, which are visible on 
http://opendesktop.org.

INLINE COMMENTS

> KNSBackend.cpp:125
> +m_engine->setPageSize(100);
> +m_engine->init(m_name);
>  

Is this intentional? Don't we want to initialize it right after creating it?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19837

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19842: Port to the new install directory for knsrc files

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:67f0c43a3ad1: Port to the new install directory for knsrc 
files (authored by apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19842?vs=54140=54157

REVISION DETAIL
  https://phabricator.kde.org/D19842

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/cursortheme/CMakeLists.txt
  kcms/desktoptheme/CMakeLists.txt
  kcms/emoticons/CMakeLists.txt
  kcms/icons/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/ksplash/CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt

To: apol, #plasma, #knewstuff, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Nathaniel Graham]

ngraham updated this revision to Diff 54155.
ngraham marked an inline comment as done.
ngraham added a comment.


  Have the timer off by default so it only fires while resizing

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19550?vs=53310=54155

BRANCH
  use-mipmapping-for-higher-quality (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19550

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: ngraham, #plasma, broulik
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:183
>  
> +// Don't reload the image in the middle of a resize operation to
> +// minimize re-reading the file on disk

Isn't this doing the opposite of the comment and /always/ reloading an image 
after 250ms with a new source size?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19550

To: ngraham, #plasma, broulik
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Michail Vourlakos]

mvourlakos added a comment.


  I don't know if this can be of any help but this is supported by Latte dock, 
including scroll wheel to increase/decrease the specific audio stream volume

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg
Cc: mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham added a comment.


  In D19822#433103 , @faridb wrote:
  
  > - Use a smaller icon for the audio indicator and place it in one of the 
corners of the task button and not in the centre
  
  
  I would like this, especially if we put it inside an attractive circular 
background or something, like the notification badges. Feels like we could use 
another emblem icon for this, maybe?
  
  +1 for the concept too since this is now something that web browser tabs 
have, so "click on the audio playing icon to mute it" is a pretty common 
interaction metaphor nowadays.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Mostly good, just a new nitpicks and suggestions:

INLINE COMMENTS

> powerdevilcore.cpp:256
>  QString activity = m_activityConsumer->currentActivity();
> -qCDebug(POWERDEVIL) << "We are now into activity " << activity;
> +qCDebug(POWERDEVIL) << "We are now in activity " << activity; // into? 
> direction?
>  KConfigGroup activitiesConfig(m_profilesConfig, "Activities");

I'd say "using activity "

> powerdevilcore.cpp:330
> +emitNotification(QStringLiteral("powerdevilerror"), i18n("Profile 
> \"%1\" has been selected, "
> + "but the profile does not exist.\nPlease check your 
> PowerDevil configuration.",
>   profileId));

Remove "the profile"

> powerdevilcore.cpp:367
>  << actionName << "a non-existent action. 
> This is usually due to an installation problem,"
> -" or to a configuration problem, or simply 
> the action is not supported";
> +" a configuration problem, or the action is 
> not supported";
>  }

"or the action is not supported" -> "or the action not being supported"

> powerdevilcore.cpp:541
>  msg = i18nc("Placeholder is device name",
> -"The battery in your mouse (\"%1\") is low, and 
> the device may turn itself off at any time. "
> -"Please replace or charge the battery as soon as 
> possible.", name);
> +"The battery in (\"%1\") is running low, and the 
> device may turn off at any time. "
> +"Please recharge or replace the battery.", name);

Are we 100% sure that `name` will always be a good enough string that the user 
will recognize it as their mouse? (not a rhetorical question, I really am 
wondering :) )

Same for other instances below too.

> powerdevilcore.cpp:607
>  case PowerDevil::BundledActions::SuspendSession::ToDiskMode:
> -m_criticalBatteryNotification->setText(i18n("Your battery level is 
> critical, the computer will be hibernated in 60 seconds."));
> +m_criticalBatteryNotification->setText(i18n("Battery level critical. 
> Your computer will go into hibernation mode in 60 seconds."));
>  m_criticalBatteryNotification->setActions(actions);

"go into" -> "enter" ?

> powerdevilcore.cpp:612
>  case PowerDevil::BundledActions::SuspendSession::ToRamMode:
> -m_criticalBatteryNotification->setText(i18n("Your battery level is 
> critical, the computer will be suspended in 60 seconds."));
> +m_criticalBatteryNotification->setText(i18n("Battery level critical. 
> Your computer will go to sleep in 60 seconds.")); // go into sleep mode?
>  m_criticalBatteryNotification->setActions(actions);

"go to sleep" is just fine here

> powerdevilcore.cpp:643
>  } else {
> -emitRichNotification(QStringLiteral("pluggedin"), i18n("Running 
> on AC power"), i18n("The power adaptor has been plugged in."));
> +emitRichNotification(QStringLiteral("pluggedin"), i18n("Running 
> on AC power"), i18n("The power adapter has been plugged in.")); //uniform 
> spelling throughout (either -er or -or, not both)
>  }

Not sure this comment is really necessary :)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[Nathaniel Graham]

ngraham added a comment.


  While you're in the mood to think about the Media Frame widget (a most 
scintillating topic, I know), would you like to review D19550: [Media Frame] 
Set sourceSize for higher quality and lower memory consumption 
? :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[Nathaniel Graham]

ngraham added a comment.


  Yep, in D19548 .

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18438: [Task Manager] When closing apps, resize only when mouse is out.

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2861ae7cc675: [Task Manager] When closing apps, resize 
only when mouse is out. (authored by thsurrel).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18438?vs=53394=54147#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18438?vs=53394=54147

REVISION DETAIL
  https://phabricator.kde.org/D18438

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18438: [Task Manager] When closing apps, resize only when mouse is out.

[Thomas Surrel]

thsurrel added a comment.


  I can land this myself.
  Thank you again for all your help.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt updated this revision to Diff 54143.
fvogt added a comment.


  Keep the style element, but assign id and type. Fix tooltip.svgz as well.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19821?vs=54076=54143

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz
  src/desktoptheme/breeze/widgets/tooltip.svgz

To: fvogt, #plasma
Cc: rooty, Zren, arojas, rikmills, asturmlechner, kde-frameworks-devel, 
plasma-devel, michaelh, ngraham, bruns

D19842: Port to the new install directory for knsrc files

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Ought to do the trick! :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19842

To: apol, #plasma, #knewstuff, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Sorry, I forgot about this. AFAIK Nate rewrote media frame to QQC2 anyway.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19842: Port to the new install directory for knsrc files

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, KNewStuff.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  See https://phabricator.kde.org/D19338

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19842

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/cursortheme/CMakeLists.txt
  kcms/desktoptheme/CMakeLists.txt
  kcms/emoticons/CMakeLists.txt
  kcms/icons/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/ksplash/CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt

To: apol, #plasma, #knewstuff
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19823: Port to the new install directory for knsrc files

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:806a044da1d5: Port to the new install directory for knsrc 
files (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19823?vs=54079=54139#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19823?vs=54079=54139

REVISION DETAIL
  https://phabricator.kde.org/D19823

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  wallpapers/image/CMakeLists.txt

To: apol, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54137.
rooty added a comment.


  Bring back the posessive pronouns

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54135=54137

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54135.
rooty added a comment.


  Drop unnecessary pronouns

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54132=54135

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54132.
rooty added a comment.


  Touch up some more

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54129=54132

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Farid Boudedja]

faridb added a comment.


  Yes, you could accidentally mute an application when using Icons-Only Task 
Manager.
  As you can see below, the audio indicator is pretty close to the centre of 
the task button, which is where you would usually click to activate that task:
  F6698588: Screenshot_20190317_175907.png 

  
  That could be circumvented by doing one of the following:
  
  - Enable this behaviour only when the task label is shown
  - Add the ability to enable this feature through the Task Manager settings, 
disable it by default and assume that users will not accidentally click on the 
audio icon
  - Use a smaller icon for the audio indicator and place it in one of the 
corners of the task button and not in the centre
  
  Any suggestions?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54129.
rooty added a comment.


  Add the verb run (because... why not)

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54123=54129

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty added a comment.


  > Looks good. I'd avoid using pronouns, I think it would sound better and 
whose else's is the battery if not yours?
  
  Haha yeah. 
  Granted, even these pronouns are wy better than the prompt saying "I am 
going to sleep."
  Outright creepy :D

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19454: Fix errors in kirigami example files

[Carl Schwan]

ognarb updated this revision to Diff 54124.
ognarb added a comment.


  Remove goBack funtion, and I repported the bug 
https://bugs.kde.org/show_bug.cgi?id=405571 :)

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=52927=54124

BRANCH
  arcpatch-D19454

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb, #kirigami
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19838: [powerdevil] Touch up messages/prompts

[Filip Fila]

filipf added a comment.


  Looks good. I'd avoid using pronouns, I think it would sound better and whose 
else's is the battery if not yours?
  
  Don't have a better idea for planned sleep, maybe just planned sleep actions?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54123.
rooty added a comment.


  Make sleep prompt more natural-sounding

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54121=54123

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54121.
rooty added a comment.


  Fix "be go"

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54118=54121

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty added a comment.


  I'm not sold on the use of pronouns here, we could actually do without them
  If we agree to keep the pronouns, I'm not going to object but... we can sound 
both non-technical and professional at the same time :D
  
  P.S. I could use input on "All planned sleep", it's less technical but it's 
plain weird :D

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb updated this revision to Diff 54119.
ognarb added a comment.


  Rebase

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=54117=54119

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54118.
rooty added a comment.


  Remove "as soon as possible" (less anxiety-inducing)

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54116=54118

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb updated this revision to Diff 54117.
ognarb added a comment.


  - Use qsTr instead of i18n
  - Kirigami version 2.7 -> 2.8

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=53106=54117

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19825: Improve update states' UI

[Krešimir Čohar]

rooty added a comment.


  Hey I know this has landed already but how do you feel about the word 
Retrieving instead of Fetching?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19825

To: ngraham, apol, #vdg, #discover_software_store
Cc: rooty, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19825: Improve update states' UI

[Andres Betts]

abetts added a comment.


  +1
  
  Maybe the icon can be smaller, but in principle, yes!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19825

To: ngraham, apol, #vdg, #discover_software_store
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Filip Fila]

filipf added a comment.


  In D19044#432878 , @mart wrote:
  
  > In D19044#432875 , @filipf wrote:
  >
  > > In D19044#432853 , @mart wrote:
  > >
  > > > uuh, no, this duplicates more, i meant moving things from the control 
to the template
  > >
  > >
  > > But I moved most of things from `src/controls/InlineMessage.qml` to 
`src/controls/templates/InlineMessage.qml`?
  >
  >
  > i was put off by phabricator being stupid and telling 
src/controls/templates/InlineMessage.qml (173 lines)
  >  Copied to src/styles/Material/InlineMessage.qml
  >
  > however yeah, it seems alright, sorry, go for it =)
  
  
  No problem, thanks :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, 
apol, davidedmundson, hein

D19044: [InlineMessage] Do not draw shadows around the message

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:56ca5702d8a6: [InlineMessage] Do not draw shadows around 
the message (authored by filipf).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19044?vs=52923=54113

REVISION DETAIL
  https://phabricator.kde.org/D19044

AFFECTED FILES
  src/controls/InlineMessage.qml
  src/controls/templates/InlineMessage.qml
  src/styles/Material/InlineMessage.qml

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, 
apol, davidedmundson, hein

D19837: Add support for applications in KNSBackend

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: apol, ngraham, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Prior to this patch, when loading a knsrc file which would show applications 
from the KDE Store, the entries would be shown in the Application Addons menu. 
This patch adds functionality to put those into the Application category, and 
further adds filtering on architecture for those packages (so we only show 
entries with downloadable content supported by the machine we are running on).

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19837

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp
  libdiscover/backends/KNSBackend/KNSBackend.h

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19825: Improve update states' UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:95c39a6f7f2b: Improve update states UI (authored by 
ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19825?vs=54107=54111

REVISION DETAIL
  https://phabricator.kde.org/D19825

AFFECTED FILES
  discover/qml/DiscoverWindow.qml
  discover/qml/UpdatesPage.qml

To: ngraham, apol, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19825: Improve update states' UI

[Nathaniel Graham]

ngraham updated this revision to Diff 54107.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Improve a string and find the property properly

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19825?vs=54087=54107

BRANCH
  improve-update-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19825

AFFECTED FILES
  discover/qml/DiscoverWindow.qml
  discover/qml/UpdatesPage.qml

To: ngraham, apol, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  In D19821#432780 , @Zren wrote:
  
  > Another option I believe is to keep the 

D19825: Improve update states' UI

[Aleix Pol Gonzalez]

apol added a comment.


  conceptual +1

INLINE COMMENTS

> UpdatesPage.qml:152
> +Layout.maximumHeight: Layout.minimumHeight
> +visible: isBusy
> +}

use `page.isBusy` so it doesn't have to start looking for the symbol all over 
the place

> UpdatesPage.qml:318
>  name: "fetching"
> -PropertyChanges { target: page; title: i18nc("@info", 
> "Fetching...") }
> -PropertyChanges { target: page; footerLabel: i18nc("@info", 
> "Checking for updates...") }
> +PropertyChanges { target: page; footerLabel: i18nc("@info", 
> "Gathering updates...") }
> +PropertyChanges { target: page; isBusy: true }

Gathering reads super weird to me.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19825

To: ngraham, apol, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19834: Fix monochrome icons in tooltips

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a comment.


  This landed, not sure why Phab didn't notice.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19834

To: ngraham, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  In D19044#432875 , @filipf wrote:
  
  > In D19044#432853 , @mart wrote:
  >
  > > uuh, no, this duplicates more, i meant moving things from the control to 
the template
  >
  >
  > But I moved most of things from `src/controls/InlineMessage.qml` to 
`src/controls/templates/InlineMessage.qml`?
  
  
  i was put off by phabricator being stupid and telling 
src/controls/templates/InlineMessage.qml (173 lines)
  Copied to src/styles/Material/InlineMessage.qml
  
  however yeah, it seems alright, sorry, go for it =)

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, 
apol, davidedmundson, hein

D19044: [InlineMessage] Do not draw shadows around the message

[Filip Fila]

filipf added a comment.


  In D19044#432853 , @mart wrote:
  
  > uuh, no, this duplicates more, i meant moving things from the control to 
the template
  
  
  But I moved most of things from `src/controls/InlineMessage.qml` to 
`src/controls/templates/InlineMessage.qml`?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, 
apol, davidedmundson, hein

D19834: Fix monochrome icons in tooltips

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch is shamelessly stolen from Marco Martin's work in KInfoCenter 
(23fa369831709f43a3100476b00ced10a1123f7f 
) 
and does the same thing for System Settings' tooltips.
  
  Now Monochrome icons are displayed properly.
  
  BUG: F6698413 
  FIXED-IN: 5.15.4

TEST PLAN
  F6698413: Correct icons.jpeg 

REPOSITORY
  R124 System Settings

BRANCH
  fix-monochrome-icons-in-tooltips (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19834

AFFECTED FILES
  sidebar/ToolTips/tooltipmanager.cpp

To: ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Marco Martin]

mart added a comment.


  uuh, no, this duplicates more, i meant moving things from the control to the 
template

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, 
apol, davidedmundson, hein

D19829: kicker: add option to make root level icons visible

[Aleksei Nikiforov]

i.Dark_Templar added a comment.


  Favorite icons are much larger, it's hard to confuse them with root level 
menu icons. If it's deemed as informational noise, it's disabled by default. 
But in case it's not, it may be enabled if this change is applied. And in my 
opinion it looks more consistent in style with 'modern menu' since 'modern 
menu' has those icons enabled.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19790: Improve the look of the GTK Application Style KCM UI

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:36dd29f8b65a: Improve the look of the GTK Application 
Style KCM UI (authored by GB_2).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19790?vs=54033=54101

REVISION DETAIL
  https://phabricator.kde.org/D19790

AFFECTED FILES
  kde-gtk-config.desktop
  src/gtkconfigkcmodule.cpp
  src/ui/dialog_installer.ui
  src/ui/gui.ui

To: GB_2, #plasma, #vdg, apol, ngraham
Cc: ngraham, apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 39 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/39/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 16:33:46 +
 Build duration:
4 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.discover Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.discover.autotests.updateandinstallName: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 0 test(s), Skipped: 2 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 0 test(s), Skipped: 1 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report56%
(10/18)66%
(68/103)66%
(68/103)51%
(2844/5623)37%
(1317/3584)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover100%
(12/12)100%
(12/12)70%
(547/779)48%
(216/454)discover.autotests100%
(1/1)100%
(1/1)100%
(92/92)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/65)0%
(0/40)libdiscover83%
(5/6)83%
(5/6)75%
(185/246)57%
(104/181)libdiscover.Category100%
(5/5)100%
(5/5)65%
(148/228)47%
(105/224)libdiscover.ReviewsBackend100%
(7/7)100%
(7/7)76%
(168/220)65%
(47/72)libdiscover.Transaction88%
(7/8)88%
(7/8)78%
(232/298)68%
(98/144)libdiscover.UpdateModel100%
(3/3)100%
(3/3)72%
(171/236)58%
(73/125)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/216)0%
(0/110)libdiscover.backends.DummyBackend82%
(9/11)82%
(9/11)79%
(245/312)61%
(99/162)libdiscover.backends.DummyBackend.tests0%
(0/2)0%
(0/2)0%
(0/257)0%
(0/268)libdiscover.backends.FwupdBackend0%
(0/8)0%
(0/8)0%
(0/540)0%
(0/255)libdiscover.backends.KNSBackend0%
(0/5)0%
(0/5)0%
(0/504)0%
(0/263)libdiscover.backends.KNSBackend.tests0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/7)0%
(0/2)libdiscover.resources94%
(17/18)94%
  

D19454: Fix errors in kirigami example files

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ognarb wrote in AbstractApplicationWindow.qml:105
> Without I get the errror: TypeError: Property 'goBack' of object 
> QQuickStackView_QML_91(0x55ea59443ee0) is not a function

yeah, i think it's actually a kirigmai bug, let's not do it in the examples

an you report it to bugzilla?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19454

To: ognarb, #kirigami
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19502: Add a SearchField and PasswordField component

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ognarb wrote in SearchField.qml:44
> Are you sure? It would mean that Kirigami should then depends on ki18n. And 
> them Kirigami wouldn't be a Tier 1 KDE framework anymore.
> 
> @mart should I move this in the example code or it is fine with a translation 
> domain?

no, it can't depend from ki18n.
here we can onlt use qsTr

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D18438: [Task Manager] When closing apps, resize only when mouse is out.

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Looks good now!
  
  Do you need help landing this or do you have a dev account?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19744: [taskmanager] Fix desktop file mapping for some apps

[Nicolas Fella]

nicolasfella added a comment.


  The desktop files are called org.gnome.Nautilus.desktop and 
org.gnome.gedit.desktop
  
  The problem seems gone with Nautilus and Gedit from master though

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19744

To: nicolasfella, #plasma, hein, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

[Eike Hein]

hein added a comment.


  Kicker intentionally doesn't have icons on the root level to not conflict 
with the favorites column and reduce visual noise.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

[Aleksei Nikiforov]

i.Dark_Templar added a comment.


  Attaching screenshot with current look of menu (or with disabled option) and 
new look with enabled option and also a configuration widget.
  F6698363: kde-menu-changes.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

[Nathaniel Graham]

ngraham added reviewers: Plasma, VDG.
ngraham added a comment.


  Screenshots are always appreciated for changes to the UI. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Chris Holland]

Zren added a comment.


  Another option I believe is to keep the 

D19829: kicker: add option to make root level icons visible

[Aleksei Nikiforov]

i.Dark_Templar created this revision.
i.Dark_Templar added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
i.Dark_Templar requested review of this revision.

REVISION SUMMARY
  In file applets/kicker/package/contents/config/main.xml an option 
'showIconsRootLevel' is mentioned. It has following description:
  "Whether to show icons on the root level of the menu."
  
  This change provides implementation for this option.

TEST PLAN
  Manual test:
  
  1. Change menu to 'classic menu' (kicker), notice root level menu items have 
no icons
  2. Open menu settings widget
  3. Notice new checkbox 'Show icons on the root level of the menu'
  4. Check that checkbox and hit 'Apply' button
  5. Root menu items should now have icons similar which look similar to icons 
in 'modern menu' (kickoff)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

AFFECTED FILES
  applets/kicker/package/contents/ui/ConfigGeneral.qml
  applets/kicker/plugin/rootmodel.cpp

To: i.Dark_Templar, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Antonio Rojas]

arojas added a comment.


  Apparently tooltips need a fix too 
https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma
Cc: arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel, 
michaelh, ngraham, bruns

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #24 from Nate Graham  ---
*** Bug 405344 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D19825: Improve update states' UI

[Nathaniel Graham]

ngraham updated this revision to Diff 54087.
ngraham added a comment.


  Don't show the icon when there are any updates

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19825?vs=54084=54087

BRANCH
  improve-update-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19825

AFFECTED FILES
  discover/qml/DiscoverWindow.qml
  discover/qml/UpdatesPage.qml

To: ngraham, apol, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19826: kns: Show subcategories for things that have one

[Dan Leinir Turthra Jensen]

leinir requested changes to this revision.
leinir added a comment.


  The rest looks nice and solid :)

INLINE COMMENTS

> KNSBackend.cpp:161
> +if (cats.count() > 1) {
> +m_categories += cats;
> +for(const auto : cats) {

Don't think we need this, already creating the categories as Category instances 
just below, and we set the category on the Resource instance when we create 
that in ::resourceForEntry... With it we'd end up duplicating those categories 
in the list of categories for all resources, from what i can tell this line 
just isn't needed :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19826

To: apol, #discover_software_store, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19826: kns: Show subcategories for things that have one

[Aleix Pol Gonzalez]

apol planned changes to this revision.
apol added a comment.


  Should look into whether it works for installed packages.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19826

To: apol, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19826: kns: Show subcategories for things that have one

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Show subcategories for KNS resources that have more than 1 Category inside. 
At the moment it just is Wallpapers.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19826

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: apol, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 38 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/38/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 13:34:20 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 323 lines...][2019-03-17T13:35:10.873Z] -- Checking for module 'flatpak>=0.11.8'[2019-03-17T13:35:10.873Z] --   No package 'flatpak' found[2019-03-17T13:35:10.873Z] -- Checking for module 'fwupd>=1.0.6'[2019-03-17T13:35:10.873Z] --   Found fwupd, version 1.1.2[2019-03-17T13:35:10.873Z] -- Checking for module 'libmarkdown'[2019-03-17T13:35:10.873Z] --   No package 'libmarkdown' found[2019-03-17T13:35:10.873Z] CMake Error at libdiscover/backends/KNSBackend/CMakeLists.txt:11 (install):[2019-03-17T13:35:10.873Z]   install FILES given no DESTINATION![2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z] CMake Warning at libdiscover/backends/CMakeLists.txt:28 (message):[2019-03-17T13:35:10.873Z]   BUILD_FlatpakBackend enabled but Flatpak= or AppStreamQt=1 not found[2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z] CMake Warning at libdiscover/backends/CMakeLists.txt:31 (find_package):[2019-03-17T13:35:10.873Z]   By not providing "FindSnapd.cmake" in CMAKE_MODULE_PATH this project has[2019-03-17T13:35:10.873Z]   asked CMake to find a package configuration file provided by "Snapd", but[2019-03-17T13:35:10.873Z]   CMake did not find one.[2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z]   Could not find a package configuration file provided by "Snapd" with any of[2019-03-17T13:35:10.873Z]   the following names:[2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z] SnapdConfig.cmake[2019-03-17T13:35:10.873Z] snapd-config.cmake[2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z]   Add the installation prefix of "Snapd" to CMAKE_PREFIX_PATH or set[2019-03-17T13:35:10.873Z]   "Snapd_DIR" to a directory containing one of the above files.  If "Snapd"[2019-03-17T13:35:10.873Z]   provides a separate development package or SDK, be sure it has been[2019-03-17T13:35:10.873Z]   installed.[2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z] [2019-03-17T13:35:10.873Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-03-17T13:35:10.873Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-03-17T13:35:10.873Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-03-17T13:35:11.129Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-03-17T13:35:11.129Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-03-17T13:35:11.129Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-03-17T13:35:11.129Z] -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.57.0") [2019-03-17T13:35:11.129Z] -- Found KF5: success (found version "5.57.0") found components:  Notifications KIO [2019-03-17T13:35:11.385Z] -- The following RUNTIME packages have been found:[2019-03-17T13:35:11.385Z] [2019-03-17T13:35:11.385Z]  * KF5Kirigami2 (required version >= 2.7.0), KDE's lightweight user interface framework for mobile and convergent applications, [2019-03-17T13:35:11.385Z]Required by discover qml components[2019-03-17T13:35:11.385Z] [2019-03-17T13:35:11.385Z] -- The following OPTIONAL packages have been found:[2019-03-17T13:35:11.385Z] [2019-03-17T13:35:11.385Z]  * AppStreamQt (required version >= 0.11.1), Library that lists Appstream resources, [2019-03-17T13:35:11.385Z]Required to build the PackageKit and Flatpak backends[2019-03-17T13:35:11.385Z]  * KF5Attica (required version >= 5.23), KDE Framework that implements the Open Collaboration Services API[2019-03-17T13:35:11.385Z]Required to build the KNewStuff3 backend[2019-03-17T13:35:11.385Z]  * KF5NewStuff (required version >= 5.53), Qt library that allows to interact with KNewStuff implementations[2019-03-17T13:35:11.385Z]Required to build the KNS backend[2019-03-17T13:35:11.385Z]  * KF5Plasma[2019-03-17T13:35:11.385Z] [2019-03-17T13:35:11.385Z] -- The following REQUIRED packages have been found:[2019-03-17T13:35:11.385Z] [2019-03-17T13:35:11.385Z]  * Qt5Gui (required version >= 5.12.0)[2019-03-17T13:35:11.385Z]  * Qt5Widgets[2019-03-17T13:35:11.385Z]  * Qt5Test[2019-03-17T13:35:11.385Z]  * Qt5Network[2019-03-17T13:35:11.385Z]  * Qt5Xml[2019-03-17T13:35:11.385Z]  * Qt5Concurrent[2019-03-17T13:35:11.385Z]  * Qt5DBus[2019-03-17T13:35:11.385Z]  * Qt5Qml (required version >= 5.12.0)[2019-03-17T13:35:11.385Z]  * Qt5Quick[2019-03-17T13:35:11.385Z]  * Qt5 (required version >= 5.11.0)[2019-03-17T13:35:11.385Z]  * PkgConfig[2019-03-17T13:35:11.385Z]  * KF5CoreAddons (required version >= 5.56.0)[2019-03-17T13:35:11.385Z]  * KF5Config (required version >= 5.56.0)[2019-03-17T13:35:11.385Z]  * KF5Crash (required version >= 5.56.0)[2019-03-17T13:35:11.385Z]  * KF5DBusAddons (required version >= 

D19825: Improve update states' UI

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, VDG, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Add a busy indicator when something is refreshing or checking
  - Update strings to be a bit more user-friendly
  - Don't change the Update page's title; status is adequately indicated by the 
footer text already

TEST PLAN
  For example:
  F6698086: busy indicator.gif 

REPOSITORY
  R134 Discover Software Store

BRANCH
  improve-update-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19825

AFFECTED FILES
  discover/qml/DiscoverWindow.qml
  discover/qml/UpdatesPage.qml

To: ngraham, apol, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19823: Port to the new install directory for knsrc files

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  See https://phabricator.kde.org/D19338

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19823

AFFECTED FILES
  components/shellprivate/CMakeLists.txt

To: apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham added a comment.


  On the other hand, the radio is infinite when the indicator isn't visible on 
an IOTM due to https://bugs.kde.org/show_bug.cgi?id=381656
  
  :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/37/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 12:50:26 +
 Build duration:
1 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 323 lines...][2019-03-17T12:51:37.819Z] -- Checking for module 'flatpak>=0.11.8'[2019-03-17T12:51:37.819Z] --   No package 'flatpak' found[2019-03-17T12:51:37.819Z] -- Checking for module 'fwupd>=1.0.6'[2019-03-17T12:51:37.819Z] --   Found fwupd, version 1.1.2[2019-03-17T12:51:37.819Z] -- Checking for module 'libmarkdown'[2019-03-17T12:51:37.819Z] --   No package 'libmarkdown' found[2019-03-17T12:51:37.819Z] CMake Error at libdiscover/backends/KNSBackend/CMakeLists.txt:11 (install):[2019-03-17T12:51:37.819Z]   install FILES given no DESTINATION![2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z] CMake Warning at libdiscover/backends/CMakeLists.txt:28 (message):[2019-03-17T12:51:37.819Z]   BUILD_FlatpakBackend enabled but Flatpak= or AppStreamQt=1 not found[2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z] CMake Warning at libdiscover/backends/CMakeLists.txt:31 (find_package):[2019-03-17T12:51:37.819Z]   By not providing "FindSnapd.cmake" in CMAKE_MODULE_PATH this project has[2019-03-17T12:51:37.819Z]   asked CMake to find a package configuration file provided by "Snapd", but[2019-03-17T12:51:37.819Z]   CMake did not find one.[2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z]   Could not find a package configuration file provided by "Snapd" with any of[2019-03-17T12:51:37.819Z]   the following names:[2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z] SnapdConfig.cmake[2019-03-17T12:51:37.819Z] snapd-config.cmake[2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z]   Add the installation prefix of "Snapd" to CMAKE_PREFIX_PATH or set[2019-03-17T12:51:37.819Z]   "Snapd_DIR" to a directory containing one of the above files.  If "Snapd"[2019-03-17T12:51:37.819Z]   provides a separate development package or SDK, be sure it has been[2019-03-17T12:51:37.819Z]   installed.[2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z] [2019-03-17T12:51:37.819Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-03-17T12:51:38.090Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-03-17T12:51:38.090Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-03-17T12:51:38.362Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-03-17T12:51:38.362Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-03-17T12:51:38.620Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-03-17T12:51:38.620Z] -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.57.0") [2019-03-17T12:51:38.620Z] -- Found KF5: success (found version "5.57.0") found components:  Notifications KIO [2019-03-17T12:51:38.882Z] -- The following RUNTIME packages have been found:[2019-03-17T12:51:38.882Z] [2019-03-17T12:51:38.882Z]  * KF5Kirigami2 (required version >= 2.7.0), KDE's lightweight user interface framework for mobile and convergent applications, [2019-03-17T12:51:38.882Z]Required by discover qml components[2019-03-17T12:51:38.882Z] [2019-03-17T12:51:38.882Z] -- The following OPTIONAL packages have been found:[2019-03-17T12:51:38.882Z] [2019-03-17T12:51:38.882Z]  * AppStreamQt (required version >= 0.11.1), Library that lists Appstream resources, [2019-03-17T12:51:38.882Z]Required to build the PackageKit and Flatpak backends[2019-03-17T12:51:38.882Z]  * KF5Attica (required version >= 5.23), KDE Framework that implements the Open Collaboration Services API[2019-03-17T12:51:38.882Z]Required to build the KNewStuff3 backend[2019-03-17T12:51:38.882Z]  * KF5NewStuff (required version >= 5.53), Qt library that allows to interact with KNewStuff implementations[2019-03-17T12:51:38.882Z]Required to build the KNS backend[2019-03-17T12:51:38.882Z]  * KF5Plasma[2019-03-17T12:51:38.882Z] [2019-03-17T12:51:38.882Z] -- The following REQUIRED packages have been found:[2019-03-17T12:51:38.882Z] [2019-03-17T12:51:38.882Z]  * Qt5Gui (required version >= 5.12.0)[2019-03-17T12:51:38.882Z]  * Qt5Widgets[2019-03-17T12:51:38.882Z]  * Qt5Test[2019-03-17T12:51:38.882Z]  * Qt5Network[2019-03-17T12:51:38.882Z]  * Qt5Xml[2019-03-17T12:51:38.882Z]  * Qt5Concurrent[2019-03-17T12:51:38.882Z]  * Qt5DBus[2019-03-17T12:51:38.882Z]  * Qt5Qml (required version >= 5.12.0)[2019-03-17T12:51:38.882Z]  * Qt5Quick[2019-03-17T12:51:38.882Z]  * Qt5 (required version >= 5.11.0)[2019-03-17T12:51:38.882Z]  * PkgConfig[2019-03-17T12:51:38.882Z]  * KF5CoreAddons (required version >= 5.56.0)[2019-03-17T12:51:38.882Z]  * KF5Config (required version >= 5.56.0)[2019-03-17T12:51:38.882Z]  * KF5Crash (required version >= 5.56.0)[2019-03-17T12:51:38.882Z]  * KF5DBusAddons (required version >= 

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 65 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/65/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 17 Mar 2019 09:51:19 +
 Build duration:
1 hr 54 min and counting
   JUnit Tests
  Name: projectroot.discover Failed: 2 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.discover.autotests.categoryargFailed: projectroot.discover.autotests.updateandinstallName: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 0 test(s), Skipped: 2 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 0 test(s), Skipped: 1 test(s), Total: 1 test(s)

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Kai Uwe Broulik]

broulik added a comment.


  Not sure, it might be accidentally triggered which is why I didn't implement 
this. Especially in icon tasks where the audio icon to task item ratio is quite 
large.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Farid Boudedja]

faridb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
faridb requested review of this revision.

REVISION SUMMARY
  The task manager shows an indicator on tasks playing audio (when 
  enabled in the settings). This patch adds the ability to mute/unmute 
  an application playing audio by clicking on the audio indicator in 
  the task manager.

TEST PLAN
  - Check "Mark applications that play audio" in the Task Manager
  
  Settings
  
  - Open an application that plays audio
  - Click on the audio indicator and it should toggle the mute state

REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: faridb
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  style elements without type="text/css" were ignored before, but now they act 
as
  if type was set. Remove the style element to restore the working behaviour.

TEST PLAN
  Installed new files on a system with Qt 5.12.2, wiped the SVG cache
  and it looks fine again.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz

To: fvogt, #plasma
Cc: kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 11:07:42 +
 Build duration:
8 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 457 lines...][2019-03-17T11:14:43.719Z] [ 10%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[2019-03-17T11:14:44.768Z] [ 10%] Built target DiscoverCommon_autogen[2019-03-17T11:14:44.768Z] [ 11%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[2019-03-17T11:14:45.267Z] [ 11%] Linking CXX shared library ../../bin/libDiscoverNotifiers.so[2019-03-17T11:14:45.267Z] [ 11%] Built target DiscoverNotifiers[2019-03-17T11:14:46.934Z] Scanning dependencies of target DiscoverCommon[2019-03-17T11:14:46.934Z] [ 12%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[2019-03-17T11:14:47.433Z] Scanning dependencies of target DummyNotifier_autogen[2019-03-17T11:14:47.433Z] [ 12%] Automatic MOC for target DummyNotifier[2019-03-17T11:14:47.932Z] [ 12%] Built target DummyNotifier_autogen[2019-03-17T11:14:47.932Z] [ 12%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[2019-03-17T11:14:48.432Z] In file included from /usr/include/qt5/QtCore/QtCore:4,[2019-03-17T11:14:48.432Z]  from /usr/include/qt5/QtGui/QtGuiDepends:3,[2019-03-17T11:14:48.432Z]  from /usr/include/qt5/QtGui/QtGui:3,[2019-03-17T11:14:48.432Z]  from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/libdiscover/tests/modeltest.cpp:43:[2019-03-17T11:14:48.432Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/libdiscover/tests/modeltest.cpp: In member function ���void ModelTest::data()���:[2019-03-17T11:14:48.432Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/libdiscover/tests/modeltest.cpp:429:30: warning: comparison of integer expressions of different signedness: ���int��� and ���QFlags::Int��� {aka ���unsigned int���} [-Wsign-compare][2019-03-17T11:14:48.432Z]  Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );[2019-03-17T11:14:48.432Z] ~~^~~~[2019-03-17T11:14:48.930Z] [ 13%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[2019-03-17T11:14:49.428Z] Scanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[2019-03-17T11:14:49.428Z] [ 14%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[2019-03-17T11:14:51.760Z] [ 15%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[2019-03-17T11:14:52.258Z] [ 15%] Built target DiscoverNotifierDeclarativePlugin_autogen[2019-03-17T11:14:53.303Z] [ 16%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[2019-03-17T11:14:53.303Z] [ 16%] Linking CXX executable ../../bin/PaginateModelTest[2019-03-17T11:14:54.350Z] Scanning dependencies of target DummyNotifier[2019-03-17T11:14:54.350Z] [ 17%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[2019-03-17T11:14:56.006Z] Scanning dependencies of target DiscoverNotifierDeclarativePlugin[2019-03-17T11:14:56.006Z] [ 18%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[2019-03-17T11:14:57.060Z] [ 18%] Built target PaginateModelTest[2019-03-17T11:14:58.104Z] [ 19%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[2019-03-17T11:14:59.148Z] [ 20%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[2019-03-17T11:14:59.645Z] [ 20%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[2019-03-17T11:15:00.148Z] [ 21%] Linking CXX shared module ../../../bin/DummyNotifier.so[2019-03-17T11:15:00.649Z] [ 21%] Built target DummyNotifier[2019-03-17T11:15:01.696Z] [ 21%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[2019-03-17T11:15:01.696Z] [ 22%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[2019-03-17T11:15:03.251Z] [ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[2019-03-17T11:15:03.251Z] [ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[2019-03-17T11:15:03.833Z] [ 25%] Building CXX object 

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 09:51:19 +
 Build duration:
36 min and counting
   CONSOLE OUTPUT
  [...truncated 497 lines...][2019-03-17T10:26:06.446Z] [ 27%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[2019-03-17T10:26:06.446Z] [ 28%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[2019-03-17T10:26:08.103Z] [ 29%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[2019-03-17T10:26:09.155Z] [ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesUpdatesModel.cpp.o[2019-03-17T10:26:09.654Z] [ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StandardBackendUpdater.cpp.o[2019-03-17T10:26:10.707Z] [ 31%] Built target PaginateModelTest[2019-03-17T10:26:11.215Z] [ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/SourcesModel.cpp.o[2019-03-17T10:26:11.718Z] [ 32%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[2019-03-17T10:26:11.718Z] [ 33%] Linking CXX shared module ../../../bin/DummyNotifier.so[2019-03-17T10:26:12.219Z] [ 33%] Built target DummyNotifier[2019-03-17T10:26:12.219Z] [ 34%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[2019-03-17T10:26:13.270Z] [ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResourcesBackend.cpp.o[2019-03-17T10:26:14.319Z] [ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResource.cpp.o[2019-03-17T10:26:14.820Z] [ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractBackendUpdater.cpp.o[2019-03-17T10:26:15.318Z] [ 37%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractSourcesBackend.cpp.o[2019-03-17T10:26:16.979Z] [ 38%] Linking CXX shared library ../bin/libDiscoverNotifierDeclarativePlugin.so[2019-03-17T10:26:16.979Z] [ 39%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[2019-03-17T10:26:17.483Z] [ 39%] Built target DiscoverNotifierDeclarativePlugin[2019-03-17T10:26:17.483Z] [ 39%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[2019-03-17T10:26:18.544Z] [ 40%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[2019-03-17T10:26:19.044Z] [ 41%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[2019-03-17T10:26:19.044Z] [ 42%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[2019-03-17T10:26:19.548Z] [ 43%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/libdiscover_debug.cpp.o[2019-03-17T10:26:19.548Z] [ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/OdrsReviewsBackend.cpp.o[2019-03-17T10:26:20.599Z] [ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/AppStreamIntegration.cpp.o[2019-03-17T10:26:21.101Z] [ 45%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[2019-03-17T10:26:26.070Z] [ 46%] Linking CXX shared library ../bin/libDiscoverCommon.so[2019-03-17T10:26:27.119Z] [ 46%] Built target DiscoverCommon[2019-03-17T10:26:27.119Z] Scanning dependencies of target dummy-backend_autogen[2019-03-17T10:26:27.119Z] Scanning dependencies of target knsbackendtest_autogen[2019-03-17T10:26:27.119Z] Scanning dependencies of target kns-backend_autogen[2019-03-17T10:26:27.119Z] [ 47%] Automatic MOC for target dummy-backend[2019-03-17T10:26:27.119Z] [ 48%] Automatic MOC for target knsbackendtest[2019-03-17T10:26:27.119Z] [ 48%] Automatic MOC for target kns-backend[2019-03-17T10:26:27.622Z] Scanning dependencies of target fwupd-backend_autogen[2019-03-17T10:26:27.622Z] [ 48%] Built target knsbackendtest_autogen[2019-03-17T10:26:27.622Z] [ 48%] Automatic MOC for target fwupd-backend[2019-03-17T10:26:27.622Z] Scanning dependencies of target dummytest_autogen[2019-03-17T10:26:27.622Z] [ 50%] Automatic MOC for target dummytest[2019-03-17T10:26:27.622Z] [ 50%] Built target dummy-backend_autogen[2019-03-17T10:26:27.622Z] Scanning dependencies of target CategoriesTest_autogen[2019-03-17T10:26:27.622Z] [ 51%] Automatic MOC for target CategoriesTest[2019-03-17T10:26:27.622Z] [ 51%] Built target dummytest_autogen[2019-03-17T10:26:27.622Z] Scanning dependencies of target plasma-discover_autogen[2019-03-17T10:26:27.622Z] [ 51%] Automatic MOC for target plasma-discover[2019-03-17T10:26:27.622Z] [ 51%] Built target 

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 15 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/15/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 09:32:19 +
 Build duration:
6 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/23)0%
(0/23)0%
(0/1820)0%
(0/706)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/273)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/189)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/505)0%
(0/238)icons0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/48)sidebar0%
(0/4)0%
(0/4)0%
(0/426)0%
(0/202)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 34 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/34/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 09:33:44 +
 Build duration:
1 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 511 lines...][2019-03-17T09:35:02.551Z] [ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[2019-03-17T09:35:02.551Z] [ 38%] Built target DummyNotifier[2019-03-17T09:35:02.551Z] [ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[2019-03-17T09:35:02.551Z] [ 39%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[2019-03-17T09:35:02.551Z] [ 40%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[2019-03-17T09:35:02.551Z] [ 41%] Linking CXX shared library ../bin/libDiscoverNotifierDeclarativePlugin.so[2019-03-17T09:35:02.809Z] [ 42%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[2019-03-17T09:35:03.739Z] [ 42%] Built target DiscoverNotifierDeclarativePlugin[2019-03-17T09:35:03.996Z] [ 43%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/libdiscover_debug.cpp.o[2019-03-17T09:35:03.996Z] [ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/OdrsReviewsBackend.cpp.o[2019-03-17T09:35:03.996Z] [ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/AppStreamIntegration.cpp.o[2019-03-17T09:35:03.996Z] [ 45%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[2019-03-17T09:35:06.524Z] [ 46%] Linking CXX shared library ../bin/libDiscoverCommon.so[2019-03-17T09:35:06.784Z] [ 46%] Built target DiscoverCommon[2019-03-17T09:35:06.784Z] Scanning dependencies of target fwupd-backend_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target knsbackendtest_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target dummytest_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target dummy-backend_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target kns-backend_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target CategoriesTest_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target updatedummytest_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target plasma-discover_autogen[2019-03-17T09:35:06.784Z] Scanning dependencies of target plasma-discover-exporter_autogen[2019-03-17T09:35:06.784Z] [ 47%] Automatic MOC for target knsbackendtest[2019-03-17T09:35:06.784Z] [ 47%] Automatic MOC for target kns-backend[2019-03-17T09:35:06.784Z] [ 47%] Automatic MOC for target fwupd-backend[2019-03-17T09:35:06.784Z] [ 47%] Automatic MOC for target plasma-discover[2019-03-17T09:35:06.784Z] [ 48%] Automatic MOC for target dummytest[2019-03-17T09:35:06.784Z] [ 50%] Automatic MOC for target CategoriesTest[2019-03-17T09:35:06.784Z] [ 51%] Automatic MOC for target updatedummytest[2019-03-17T09:35:06.784Z] [ 52%] Automatic MOC for target plasma-discover-exporter[2019-03-17T09:35:06.784Z] [ 53%] Automatic MOC for target dummy-backend[2019-03-17T09:35:06.784Z] [ 53%] Built target knsbackendtest_autogen[2019-03-17T09:35:06.784Z] [ 53%] Built target plasma-discover-exporter_autogen[2019-03-17T09:35:07.044Z] [ 53%] Built target dummytest_autogen[2019-03-17T09:35:07.044Z] Scanning dependencies of target knsbackendtest[2019-03-17T09:35:07.044Z] [ 53%] Built target kns-backend_autogen[2019-03-17T09:35:07.044Z] Scanning dependencies of target plasma-discover-exporter[2019-03-17T09:35:07.044Z] [ 54%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[2019-03-17T09:35:07.044Z] [ 54%] Built target dummy-backend_autogen[2019-03-17T09:35:07.044Z] [ 55%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o[2019-03-17T09:35:07.044Z] [ 55%] Built target CategoriesTest_autogen[2019-03-17T09:35:07.044Z] Scanning dependencies of target dummytest[2019-03-17T09:35:07.044Z] Scanning dependencies of target kns-backend[2019-03-17T09:35:07.044Z] [ 56%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[2019-03-17T09:35:07.044Z] [ 56%] Built target plasma-discover_autogen[2019-03-17T09:35:07.044Z] [ 56%] Built target updatedummytest_autogen[2019-03-17T09:35:07.044Z] [ 57%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.o[2019-03-17T09:35:07.044Z] [ 58%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[2019-03-17T09:35:07.044Z] Scanning dependencies of target dummy-backend[2019-03-17T09:35:07.044Z] [ 59%] Building CXX object 

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 64 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/64/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 17 Mar 2019 09:33:44 +
 Build duration:
1 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 451 lines...][2019-03-17T09:34:46.222Z] Scanning dependencies of target dummy-backend_autogen[2019-03-17T09:34:46.222Z] Scanning dependencies of target updatedummytest_autogen[2019-03-17T09:34:46.222Z] Scanning dependencies of target CategoriesTest_autogen[2019-03-17T09:34:46.222Z] Scanning dependencies of target dummytest_autogen[2019-03-17T09:34:46.222Z] Scanning dependencies of target plasma-discover_autogen[2019-03-17T09:34:46.222Z] Scanning dependencies of target plasma-discover-exporter_autogen[2019-03-17T09:34:46.222Z] [ 52%] Automatic MOC for target CategoriesTest[2019-03-17T09:34:46.222Z] [ 52%] Automatic MOC for target plasma-discover-exporter[2019-03-17T09:34:46.222Z] [ 52%] Automatic MOC for target plasma-discover[2019-03-17T09:34:46.222Z] [ 53%] Automatic MOC for target updatedummytest[2019-03-17T09:34:46.222Z] [ 55%] Automatic MOC for target dummy-backend[2019-03-17T09:34:46.222Z] [ 55%] Automatic MOC for target dummytest[2019-03-17T09:34:46.222Z] [ 57%] Automatic MOC for target knsbackendtest[2019-03-17T09:34:46.222Z] [ 57%] Automatic MOC for target kns-backend[2019-03-17T09:34:46.787Z] [ 57%] Built target dummytest_autogen[2019-03-17T09:34:46.787Z] [ 57%] Built target plasma-discover-exporter_autogen[2019-03-17T09:34:46.787Z] [ 57%] Built target knsbackendtest_autogen[2019-03-17T09:34:47.046Z] [ 57%] Built target dummy-backend_autogen[2019-03-17T09:34:47.046Z] [ 57%] Built target kns-backend_autogen[2019-03-17T09:34:47.046Z] Scanning dependencies of target plasma-discover-exporter[2019-03-17T09:34:47.046Z] [ 58%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o[2019-03-17T09:34:47.046Z] [ 58%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[2019-03-17T09:34:47.046Z] [ 58%] Built target CategoriesTest_autogen[2019-03-17T09:34:47.046Z] [ 59%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[2019-03-17T09:34:47.046Z] Scanning dependencies of target knsbackendtest[2019-03-17T09:34:47.046Z] Scanning dependencies of target kns-backend[2019-03-17T09:34:47.046Z] Scanning dependencies of target dummy-backend[2019-03-17T09:34:47.046Z] [ 60%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[2019-03-17T09:34:47.046Z] [ 61%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[2019-03-17T09:34:47.046Z] [ 62%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[2019-03-17T09:34:47.046Z] Scanning dependencies of target dummytest[2019-03-17T09:34:47.046Z] [ 62%] Built target updatedummytest_autogen[2019-03-17T09:34:47.046Z] [ 62%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.o[2019-03-17T09:34:47.046Z] Scanning dependencies of target CategoriesTest[2019-03-17T09:34:47.312Z] [ 62%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest.cpp.o[2019-03-17T09:34:47.312Z] [ 62%] Built target plasma-discover_autogen[2019-03-17T09:34:47.312Z] [ 63%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[2019-03-17T09:34:47.899Z] [ 64%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[2019-03-17T09:34:47.899Z] /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.12/libdiscover/backends/KNSBackend/KNSBackend.cpp:69:54: error: no member named 'configSearchLocations' in 'KNSCore::Engine'[2019-03-17T09:34:47.899Z] QStringList locations = KNSCore::Engine::configSearchLocations();[2019-03-17T09:34:47.899Z] ~^[2019-03-17T09:34:47.899Z] /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.12/libdiscover/backends/KNSBackend/KNSBackend.cpp:229:75: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2019-03-17T09:34:47.899Z] const auto filtered = kFilter(entries, [this](const KNSCore::EntryInternal& entry){ return entry.isValid(); });[2019-03-17T09:34:47.899Z]   ^[2019-03-17T09:34:47.899Z] [ 65%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.o[2019-03-17T09:34:47.899Z] [ 66%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[2019-03-17T09:34:48.167Z] [ 67%] Linking CXX executable 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 12 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/12/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 09:32:10 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2554)14%
(212/1483)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1247)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/232)0%
(0/118)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/12/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Mar 2019 09:32:17 +
 Build duration:
2 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4005)0%
(0/2740)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1413)0%
(0/1116)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/470)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/114)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1018)0%
(0/759)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/15/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 17 Mar 2019 09:32:12 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D19340: Search new knsrc locations

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d617dd8e6a1e: Search new knsrc locations (authored by 
leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19340?vs=53876=54070

REVISION DETAIL
  https://phabricator.kde.org/D19340

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19500: [KDirModel] Fix job urls change signal connection

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  If there was a unittest for this code, it wouldn't remain broken for so 
long... Feel free to add one :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19500

To: broulik, #frameworks, dfaure, jtamate
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  I'll post one

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Seems like a nice-to-have, not a must-have. :) Is there a patch for it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: welcome plasma-active-window-control

[Jonathan Riddell]

On Sat, Mar 16, 2019 at 07:55:16PM +0100, Roman Gilg wrote:
> On Sat, Mar 16, 2019 at 6:53 PM Jonathan Riddell  wrote:
> >
> > Just passed kdereview and moved into extra/base is Plasma Active Window 
> > Control.
> >
> > Plasma Active Window Control is a plasma widget that you can embed in
> > your panel to control your active window with e.g. close or maximise
> > operations.  Useful for decorationless window management.
> >
> > New maintainer is Chris Holland.  Do say hello.
> >
> > Jonathan
> 
> Hello,
> 
> do you have a link with some more information? Sounds neat.

Just the git repo and screenshot so far

https://cgit.kde.org/plasma-active-window-control.git/

https://cdn.kde.org/screenshots/plasma-active-window-control/active-window-control.png

Jonathan

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  In D19469#432282 , @ngraham wrote:
  
  > I do believe that this is the very last patch for T10325: 5.16 Login screen 
improvements . :)
  
  
  There is one last thing we might want to do for the login and lock screens - 
make them slightly more centered, vertically
  
  before:
  F6697617: image.png 
  after:
  F6697619: image.png 
  
  If not, then this actually is the last patch (and it's up to date and 
landable too) :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart