D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

gepardo added a comment. Nice :) I have some suggestions to prevent such errors in the future: - `sass` (but not `sassc`) has `-E` option to set the encoding for building - it may be a good idea to add such lines to all the SCSS files BTW, where does the build error happen?

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

filipf added a comment. In D19873#434949 , @mart wrote: > So, > FormLayout has api to align two or more of them with each other, which is the list property FormLayout.twinFormLayouts > > I wonder if there is a way to make the parent and

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf updated this revision to Diff 54460. filipf added a comment. Initial implementation of twinFormLayouts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54288=54460 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch does the groundwork for indvidual wallpaper plugins to be able to use Kirigami FormLayout with twinFormLayouts, finally

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19931 AFFECTED FILES src/gtk318/widgets/_notebook.scss

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

broulik added a comment. +1 Nice and clean, no real complaints. INLINE COMMENTS > kworkspace.cpp:70 > > +void requestShutDown(KWorkSpace::ShutdownConfirm, KWorkSpace::ShutdownType, > KWorkSpace::ShutdownMode) > +{ :) > sessionmanagement.cpp:32 > + > +// add a constructor with the

D19890: Changes the drawing of QToolButton inline indicator arrows

ngraham added a comment. Thanks very much for this patch! I will review sometime in the next 48 hours. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 172 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/172/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Mar 2019 10:05:31 + Build duration: 11 hr and counting JUnit Tests Name: projectroot

D19802: [comic] Modernize configuration windows

abetts added a comment. > You mean "General", "Appearance" etc. right? Yeah that happens when windows are stretched horizontally, but the window wouldn't be much narrower IRL tbh. Kirigami's FormLayout is center aligned and the category's title always remains left aligned. They're pretty

D19802: [comic] Modernize configuration windows

filipf added a comment. In D19802#435421 , @abetts wrote: > The title labels appear to be very far from the content. Is that just the size on the images or does it actually look very far when the config screen is full size? You mean

D19802: [comic] Modernize configuration windows

abetts added a comment. The title labels appear to be very far from the content. Is that just the size on the images or does it actually look very far when the config screen is full size? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19802 To: filipf,

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54453. filipf marked an inline comment as done. filipf added a comment. Change strings according to Nate's suggestions REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54254=54453 BRANCH

D19857: [DownloadJob] Report total size only if known

broulik added a comment. It should just hide the total if unknown but that's an issue in the notification view REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D19857 To: broulik, #plasma Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau added a comment. In D19748#434289 , @kossebau wrote: > In D19748#432027 , @broulik wrote: > > > F6696238: Screenshot_20190316_121442.png > > Seems

D19925: Split up subcategories for KNS categories

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This adds

D19469: [sddm-theme] Update login screen preview image

This revision was automatically updated to reflect the committed changes. Closed by commit R120:94dcbf0500aa: [sddm-theme] Update login screen preview image (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=54430=54443

D19469: [sddm-theme] Update login screen preview image

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Beautiful. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19469 REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: GB_2, davidedmundson,

D19924: [TabBar] Update height when TabButtons are added dynamically

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When using a `Repeater` with an asynchronously populated model `TabBar` fails to initially

D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position

This revision was automatically updated to reflect the committed changes. Closed by commit R120:154637e69119: [sddm-theme/lock screen] Move main stack to a more vertically centered position (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19894: Use https for links in the UI

This revision was automatically updated to reflect the committed changes. Closed by commit R871:f6eb9ba3dd92: Use https for links in the UI (authored by vkrause). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19894?vs=54355=54432 REVISION DETAIL

D19469: [sddm-theme] Update login screen preview image

rooty updated this revision to Diff 54430. rooty added a comment. Deselect password field REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=54427=54430 BRANCH arcpatch-D19469 REVISION DETAIL https://phabricator.kde.org/D19469 AFFECTED

D19469: [sddm-theme] Update login screen preview image

rooty updated this revision to Diff 54427. rooty added a comment. Use correct Desktop Sesion setting and use Konqi and Katie mascot avatars REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=54424=54427 BRANCH arcpatch-D19469 REVISION

D19469: [sddm-theme] Update login screen preview image

rooty added a comment. I'll be retaking this shortly - it says Openbox instead of Plasma (sorry) and yeah I'll be replacing the avatars The blurry thing - don't look at me (or flipwise and me) because we're about as certain as a person can get that it's //not// sddm's (or the theme's)

D19469: [sddm-theme] Update login screen preview image

rooty updated this revision to Diff 54424. rooty added a comment. Use color avatars and 16:9 aspect ratio REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=54421=54424 BRANCH arcpatch-D19469 REVISION DETAIL

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. In D19469#435220 , @rooty wrote: > F6703853: image.png > > This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. In D19469#435216 , @rooty wrote: > In D19469#435215 , @GB_2 wrote: > > > BTW, it's still not 1920x1080. > > > Noted. (Why is that relevant though?) Much more

D19469: [sddm-theme] Update login screen preview image

rooty added a comment. F6703853: image.png This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for originally - are you sure you want to use this? REPOSITORY R120 Plasma Workspace

D19469: [sddm-theme] Update login screen preview image

rooty added a comment. In D19469#435215 , @GB_2 wrote: > BTW, it's still not 1920x1080. Noted. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: GB_2,

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. BTW, it's still not 1920x1080. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19915: [Mnemonic Handling] Replace only first occurrence

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Actually REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19915 To: broulik, #plasma, mart, apol Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart,

D19915: [Mnemonic Handling] Replace only first occurrence

apol added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19915 To: broulik, #plasma, mart Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19469: [sddm-theme] Update login screen preview image

rooty added a comment. In D19469#435184 , @GB_2 wrote: > In D19469#435183 , @rooty wrote: > > > In D19469#435175 , @GB_2 wrote: > > > > > The file size

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. In D19469#435183 , @rooty wrote: > In D19469#435175 , @GB_2 wrote: > > > The file size is quite big (you can change the compression in Spectacle) and I think the resolution

D19469: [sddm-theme] Update login screen preview image

rooty added a comment. In D19469#435175 , @GB_2 wrote: > The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080. > Please also change the user images to the colorful Konqi and

D19469: [sddm-theme] Update login screen preview image

rooty updated this revision to Diff 54421. rooty added a comment. Compress image REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=54418=54421 BRANCH arcpatch-D19469 REVISION DETAIL https://phabricator.kde.org/D19469 AFFECTED FILES

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080. Please also change the user images to the colorful Konqi and Katie ones. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19916 AFFECTED FILES

D19469: [sddm-theme] Update login screen preview image

rooty added a comment. Okay so, scrot and xwd kinda drove me nuts, so I decided to open up sddm-greeter, cut off its titlebar, hide the panel and it looks identical to the login screen so :D Voila REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To:

D19469: [sddm-theme] Update login screen preview image

rooty updated this revision to Diff 54418. rooty added a comment. Update preview image REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=53570=54418 BRANCH arcpatch-D19469 REVISION DETAIL https://phabricator.kde.org/D19469 AFFECTED

D19915: [Mnemonic Handling] Replace only first occurrence

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Noticed my KCM checkboxes and labels all had all the mnemonic letters highlighted, now it's only

D19096: [Kicker] Fix "Tooltip can not be displayed"

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Yeah, this looks fine, thanks! REPOSITORY R119 Plasma Desktop BRANCH fix-tooltip (branched from master) REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein,

D19166: Add application path as valid path for debuggers

This revision was automatically updated to reflect the committed changes. Closed by commit R871:8c74d90e28fb: Add application path as valid path for debuggers (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=54345=54412

D19469: [sddm-theme] Update login screen preview image

davidedmundson added a comment. > Sorry it's been taking so long, I've been having the hardest time getting virtualbox to work... FWIW, you can run qmlscene Main.qml inside the plasma-workspace/sddm-theme directly It'll load the data from the testdata folder which makes

D19909: Enable blurbehind for panels only if theme sets it

kossebau added a comment. In D19909#435065 , @zzag wrote: > What about plasma::dialog? Actually, this was done in plasma-frrameworks. I overlooked that as I had stashed this away with other WIP changes when doing D19907

D19909: Enable blurbehind for panels only if theme sets it

kossebau added a comment. In D19909#435065 , @zzag wrote: > What about plasma::dialog? Good catch, that slipped from the uploaded patch. Will update later today. REPOSITORY R120 Plasma Workspace BRANCH supportblurBehindEnabled

D19909: Enable blurbehind for panels only if theme sets it

zzag added a comment. What about plasma::dialog? REPOSITORY R120 Plasma Workspace BRANCH supportblurBehindEnabled REVISION DETAIL https://phabricator.kde.org/D19909 To: kossebau, #plasma, davidedmundson Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19909: Enable blurbehind for panels only if theme sets it

kossebau added a comment. Depends on D19907 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19909 To: kossebau, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19909: Enable blurbehind for panels only if theme sets it

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH supportblurBehindEnabled REVISION DETAIL

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

mart added a comment. So, FormLayout has api to align two or more of them with each other, which is the list property FormLayout.twinFormLayouts I wonder if there is a way to make the parent and child formlayouts visible ot each other to use such property. the parent is in

D19799: QNetworkReply was not deleted

mlaurent updated this revision to Diff 54387. mlaurent added a comment. Fix QScopedPointer REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19799?vs=54015=54387 BRANCH delete_qnetwork_reply (branched from master) REVISION DETAIL

D19469: [sddm-theme] Update login screen preview image

rooty added a comment. Sure thing Sorry it's been taking so long, I've been having the hardest time getting virtualbox to work... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: plasma-devel, jraleigh, GB_2,