D19963: Avoid serializing base64 encoded favicon data twice

bruns created this revision. bruns added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The URL is ignored in case the image data is available. Avoid pushing it twice via DBus.

D19962: plasmoid: Make it possible to connect to a device using a touchscreen

apol created this revision. apol added reviewers: Plasma, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment the button was only shown on hover. Now it will also be shown when the details are

D19940: always support all command line options

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Sounds good to me. REPOSITORY R871 DrKonqi BRANCH arbitrary-options REVISION DETAIL https://phabricator.kde.org/D19940 To: sitter, #plasma, apol Cc: apol, plasma-devel, jraleigh, GB_2,

D19959: Fixed issue causing changed signal to be called with false argument

tigrang created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tigrang requested review of this revision. REVISION SUMMARY AdvanceConfig::changed signal is called with changed=false arguement when QGroupBox::clicked is called with checked=false causing

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 added a comment. I added the explicit charset to all scss files. REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 updated this revision to Diff 54514. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19931?vs=54457=54514 REVISION DETAIL https://phabricator.kde.org/D19931 AFFECTED FILES src/_colors.scss src/_functions.scss src/gtk318/gtk.scss src/gtk318/widgets/_app_notifications.scss

D19838: [powerdevil] Touch up messages/prompts

broulik added inline comments. INLINE COMMENTS > powerdevilcore.cpp:541 > msg = i18nc("Placeholder is device name", > -"The battery in your mouse (\"%1\") is low, and > the device may turn itself off at any time. " > -

D19947: systray: show a small animation on the icons when activated

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Both for plasmoids and SNI TEST PLAN Now there's some kind of feedback when pressing the icons

D19946: systray: show a the context menu upon press an hold on the icon

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This way we can open the context menu from touch TEST PLAN Tapped and hold on my screen REPOSITORY

D19011: Thunderbolt KCM and KDED module

yurchor added a comment. What should happen when the "Help" button at the bottom of KCM page is pressed? Thanks in advance for your answer. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti,

D19852: Change default Klipper behavior to accept images

davidedmundson added a comment. This is definitely better. The part with the history saving is neat and that part is all good to go. But it still does a huge image copy to plasma every time you copy and paste an image around in gimp. It's very expensive, both in memory and the blocking

D19852: Change default Klipper behavior to accept images

kdautovic added a comment. Is this good enough to merge? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19852 To: kdautovic, #plasma_workspaces, davidedmundson Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. Ping, VDG folks are OK with this, how about Plasma :)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mvourlakos added a comment. In D19822#435735 , @filipf wrote: > This is a good feature. I'd definitely add an option so it can be turned on/off regardless of how well we fix up the icon. Sometimes you need to dummy-proof installs so all that

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. This is a good feature. I'd definitely add an option so it can be turned on/off regardless of how well we fix up the icon. Sometimes you need to dummy-proof installs so all that matters is that it can be configured; by default it could be turned on IMO. REPOSITORY

D19802: [comic] Modernize configuration windows

This revision was automatically updated to reflect the committed changes. Closed by commit R114:f2647deeeac7: [comic] Modernize configuration windows (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54453=54486 REVISION

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf added a comment. I've done a lot of clean up because: (1) some code is not needed for the FormLayout; (2) things worked the same without some code; (3) ported the combobox to QQC2 because the main layout is also using QQC2 comboboxes and everything still fits with normal scaling.

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

filipf updated this revision to Diff 54485. filipf added a comment. remove line: twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : [] REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19932?vs=54459=54485 BRANCH

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 54484. filipf added a comment. port everything REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54460=54484 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

filipf added a comment. Second line results in a `stack` not defined error. I'm actually seeing it's enough to just have the id at line 82 and then in the wallpaper plugins do `twinFormLayouts: parentLayout`. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19940: always support all command line options

sitter added a comment. I should add for the record that I'd actually find stricter versioning better, but arg handling in kcrash is already a bit tricky because of signal-safety restrictions and adding versioning complexity on top would probably do nothing for how easy the code base is to

D19940: always support all command line options

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY with the current way options are handled we'd always have a tight lock between kcrash and drkonqi making it unnecessarily difficult

D19390: adjust the size of the window after the labels sizes were changed

This revision was automatically updated to reflect the committed changes. Closed by commit R871:cc640cea3e9c: adjust the size of the window after the labels sizes were changed (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D19937: don't connect to lambdas and call slots when you can just call the slots

This revision was automatically updated to reflect the committed changes. Closed by commit R871:d0974fdc18b4: dont connect to lambdas and call slots when you can just call the slots (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D19937: don't connect to lambdas and call slots when you can just call the slots

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the lambdas were really unnecessary. both deleteLater and restart are losts, and arg-less ones at that, so instead of using a

D19390: adjust the size of the window after the labels sizes were changed

sitter added a comment. ping REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19390 To: sitter, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

davidre added a comment. Great! I see that also fixes the issue that the label vanished when the window got to narrow. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham, mart Cc: davidre, mart, abetts, plasma-devel,

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

luc4 added a comment. Happened on KDE Neon in docker. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart