D20086: Fix window height of Screen Locking KCM

ngraham added a comment. @tigrang would you like this landed now, or do you wanna try @davidedmundson's idea? Thanks for the patch! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20086 To: tigrang, davidedmundson Cc: ngraham, abetts, filipf,

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote: > I and others tried to get more reviews done in the past, but actually I > merged more than once stuff that I reviewed but it did break the CI. That I hope we'll get fixed at some point. It's a big big advantage

Re: CI system maintainability

+1 for this. I think running tests before merging is more acceptable than having mandatory reviews. On 29 March 2019 11:10:52 GMT+00:00, Ovidiu-Florin Bogdan wrote: >Hello, > >A Merge Request in GitLab does not necessarily imply the need for a >review by e person. It can just run a pipeline to

Re: CI system maintainability

On Fri, Mar 29, 2019 at 9:56 PM Kevin Ottens wrote: > > Hello, > > On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote: > > I and others tried to get more reviews done in the past, but actually I > > merged more than once stuff that I reviewed but it did break the CI. > >

Re: CI system maintainability

Hello, A Merge Request in GitLab does not necessarily imply the need for a review by e person. It can just run a pipeline to validate that the code isn't broken. If the pipeline fails, the merge button is not available. We use GitLab at work and we have it set up like this: * Main branches

Re: CI system maintainability

On Fri, Mar 29, 2019 at 10:33 PM Friedrich W. H. Kossebau wrote: > > Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > > Le

Re: CI system maintainability

On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl wrote: > > Hi, Hi, > > (Sorry for top-posting) > > I fear that a mandatory reviews would add too juch strain on smaller teams. > If there's just one person with an intimate knowledge of the code-base, plus > two co-developers, then who

D19963: Avoid serializing base64 encoded favicon data twice

bruns added a comment. Ping! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D19963 To: bruns, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options

kossebau added a comment. See D20112 for the same change for the applet. To test, you can download the Unicorn theme from store.kde.org, then edit the .local/share/plasma/desktoptheme/unicorn/widgets/clock.svg and append this before the final ``:

D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options

kossebau created this revision. kossebau added reviewers: Plasma, VDG, mart, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The new hints - hint-hourhand-rotation-center-offset

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

kossebau added a comment. To test, you can download the Unicorn theme from store.kde.org, then edit the .local/share/plasma/desktoptheme/unicorn/widgets/clock.svg and append this before the final ``: Reloading the theme will then fix the clock to look like

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

kossebau created this revision. kossebau added reviewers: Plasma, VDG, mart, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Currently the shadow offset of the hands as well as the

D19687: Allow single images to be excluded from the slideshow

davidre added a comment. almost weekly ping REPOSITORY R120 Plasma Workspace BRANCH toggleSlides REVISION DETAIL https://phabricator.kde.org/D19687 To: davidre, #plasma, #vdg, ngraham Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > > >

Re: CI system maintainability

Hello, On Friday, 29 March 2019 09:43:44 CET Volker Krause wrote: > On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > > Having mandatory reviews for a central and complex component like > > > akonadi > > > looks

Re: CI system maintainability

On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > Having mandatory reviews for a central and complex component like akonadi > > looks like a very good and obvious idea. > > Yep. Looking at the 18.12 -> 19.04

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > On 2019 M03 28, Thu 16:04:01 CET Boudhayan Gupta wrote: > > As a user, I simply do not want unreviewed crap running on my computer. > > Yes, crap, because no software engineer writes bug-free code all the time, > > and if