D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. Ping? @progwolff? I just tried this out again in a fresh Neon dev unstable VM after rebasing on master and fixing the merge conflicts and got the same result: the settings in the KCM accurately depict the fontconfig's default settings, but they're not actually

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55251. atulbi added a comment. - Avoid Setup Backend two times REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55234=55251 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186

D20188: [Cuttlefish] Port toolbar to QQC2 which fixes combobox text being corrupted or invisible

This revision was automatically updated to reflect the committed changes. Closed by commit R118:6e6b8da30a9c: [Cuttlefish] Port toolbar to QQC2 which fixes combobox text being corrupted or… (authored by ngraham). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D20188: [Cuttlefish] Port toolbar to QQC2 and fix combobox text being corrupted or invisible

davidedmundson added a comment. Ah, you meant "Port to QQC2 which fixes blah" Not that this patch contains two separate things. Explains why I couldn't find it. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D20188 To: ngraham, sitter, hein, #plasma

D20188: [Cuttlefish] Port toolbar to QQC2 and fix combobox text being corrupted or invisible

ngraham added a comment. Check out the bug report. It's also easily reproducible for me with the current version: F6743541: Screenshot_20190401_155508.png REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D20188 To:

D20188: [Cuttlefish] Port toolbar to QQC2 and fix combobox text being corrupted or invisible

davidedmundson added a comment. > and fix combobox text being corrupted or invisible where? REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D20188 To: ngraham, sitter, hein, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20188: [Cuttlefish] Port toolbar to QQC2 and fix combobox text being corrupted or invisible

ngraham created this revision. ngraham added reviewers: sitter, hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 366543 FIXED-IN: 5.16.0 TEST PLAN F6743453: Fixit.png

D20182: Compute correct position of drag button press on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R31:1915c484dc9e: Compute correct position of drag button press on X11 (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20182?vs=55221=55236 REVISION

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#441892 , @ngraham wrote: > Thanks so much for this! Got to Know a lot about how X works with input handling. XD REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To:

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added reviewers: romangg, davidedmundson, Plasma. ngraham added a comment. Thanks so much for this! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55234. atulbi added a comment. - Minor changes to optimise code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55230=55234 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY Earlier when libinput was used on X11, XInput specific UI was shown, due to which most of the options were grayed out. Now we show

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.gridUnit` between them? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel,

D18979: foldermodel: store information about screen used

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks! Do you need help landing this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18979 To: McPain, broulik, hein, #plasma Cc: cfeck, plasma-devel,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 updated this revision to Diff 55225. GB_2 added a comment. Add separator and spacer between the two buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20144?vs=55139=55225 BRANCH master REVISION DETAIL

D20182: Compute correct move-resize position on X11

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY While dimensions of QScreen are in logical pixels, the origin is not. As result, computed native

D20178: Add Meta+L shortcut for "Lock Session"

This revision was automatically updated to reflect the committed changes. Closed by commit R133:505fedc37d7e: Add Meta+L shortcut for Lock Session (authored by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20178?vs=55213=55220 REVISION

D20179: Add icon for "Resume Stopped Process" action

broulik closed this revision. broulik added a comment. https://cgit.kde.org/libksysguard.git/commit/?id=574e0b7d6c005403f66372a9b9c9d80fc33972d0 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20179 To: broulik, #plasma, #vdg, ngraham Cc: plasma-devel,

D20155: [SpinBox] Improve mouse wheel behavior

broulik updated this revision to Diff 55216. broulik added a comment. - Only use y delta, which is what `QAbstractSpinBox` does REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20155?vs=55170=55216 REVISION DETAIL

D20178: Add Meta+L shortcut for "Lock Session"

broulik added a comment. +1 I get asked a lot how to change the keyboard shortcut to Meta+L REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20178 To: ngraham, #plasma, #vdg, broulik Cc: nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20179: Add icon for "Resume Stopped Process" action

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it easier to find TEST PLAN F6742925: Screenshot_20190401_191529.png

D20178: Add Meta+L shortcut for "Lock Session"

ngraham created this revision. ngraham added reviewers: Plasma, VDG, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This shortcut is used by default on Windows and it's also nice to have global

D18979: foldermodel: store information about screen used

McPain added a comment. In D18979#428230 , @hein wrote: > Can you explain more what this is trying to achieve / what it solves with an example? https://bugsfiles.kde.org/attachment.cgi?id=117630 REPOSITORY R119 Plasma Desktop

D20155: [SpinBox] Improve mouse wheel behavior

abetts added a comment. Can you add a before/after video maybe? Just to see the changes REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D20155 To: broulik, #plasma Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19687: Allow single images to be excluded from the slideshow

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b1ae890a6ee6: Allow single images to be excluded from the slideshow (authored by davidre, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20051: Do not try to set shadows for panels if theme does not provide elements

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2a63696f57f4: Do not try to set shadows for panels if theme does not provide elements (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19977: Prevent context drawer from disappearing

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b897b37b254b: Prevent context drawer from disappearing (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19977?vs=54565=55192 REVISION

D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options

ngraham accepted this revision. ngraham added a comment. Very nice work! REPOSITORY R119 Plasma Desktop BRANCH fixclockshadowhandcenter REVISION DETAIL https://phabricator.kde.org/D20113 To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham Cc: plasma-devel, jraleigh, GB_2,

D19994: Add microphone indicator

broulik added inline comments. INLINE COMMENTS > drosca wrote in plugin.cpp:67 > Any reason why you used singleton? So that we don't end up with multiple Status Notifier Items. This makes the indicator shared between all applets REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D20161: Fix showing update notification

This revision was automatically updated to reflect the committed changes. Closed by commit R134:ace22790d632: Fix showing update notification (authored by broulik). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20161?vs=55178=55190 REVISION

D19977: Prevent context drawer from disappearing

dkardarakos added a comment. Any comments? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19977 To: dkardarakos, mart Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20161: Fix showing update notification

broulik created this revision. broulik added reviewers: Plasma, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Updates variables first before checking `state()` which depends on them

D20157: Remove critical error

This revision was automatically updated to reflect the committed changes. Closed by commit R122:a796d7862581: Remove critical error notification (authored by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20157?vs=55172=55174 REVISION DETAIL

D20155: [SpinBox] Improve mouse wheel behavior

davidedmundson added inline comments. INLINE COMMENTS > SpinBox.qml:74 > onWheel: { > -if (wheel.pixelDelta.y < 0 || wheel.angleDelta.y < 0) { > -controlRoot.decrease(); > -} else { > +var delta = wheel.angleDelta.y

D20157: Remove critical error

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY None of the backends emit it the signal anymore. It is unlikely for the `connect()` to

D20132: Actually make the network list view show up

jgrulich added a comment. It works for me even in plasma-settings. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D20155: [SpinBox] Improve mouse wheel behavior

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Emit `valueChanged` signal since this is an explicit user interaction. Also, enforce "steps"

D19687: Allow single images to be excluded from the slideshow

davidre updated this revision to Diff 55164. davidre added a comment. - Change default of cfg_UncheckedSlides to [] - Change toggled to checked REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19687?vs=54010=55164 BRANCH toggleSlides REVISION

D20132: Actually make the network list view show up

vkrause added a comment. Maybe that's the relevant difference already, I have only been testing within plasma-settings, need to retest with kcmshell directly. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich Cc:

D20132: Actually make the network list view show up

jgrulich added a comment. I cannot confirm, if I run "kcmshell5 wifisettings" it works just fine. I'm now on Qt 5.12, but I'm pretty sure it worked even before. Let's wait if someone else can confirm this. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D20132: Actually make the network list view show up

vkrause added a comment. With that the network list had 0 width and was thus invisible for me, both on desktop and on yocto/rpi, using Qt 5.11 and latest Kirigami. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich