[Powerdevil] [Bug 348529] Turn off screen after lock screen

2019-04-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #28 from goodmi...@goodmirek.com --- (In reply to arne anka from comment #27) > (In reply to goodmirek from comment #25) > > (In reply to arne anka from comment #22) > > > (In reply to goodmirek from comment #19) > > > > arne anka: The issue

D20612: [RFC] [Kickoff] Modernize settings window layout

2019-04-16 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY In this patch, the settings window is modernized in the following ways: - Adopt

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Méven Car
meven added a comment. After last patch : F6776301: energy-information-after-3.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik, filipf Cc: filipf, davidre, broulik, plasma-devel,

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Méven Car
meven updated this revision to Diff 56376. meven added a comment. Fix FormLayout alignment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56369=56376 BRANCH arcpatch-D20598 REVISION DETAIL https://phabricator.kde.org/D20598 AFFECTED

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2019-04-16 Thread arne anka
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #27 from arne anka --- (In reply to goodmirek from comment #25) > (In reply to arne anka from comment #22) > > (In reply to goodmirek from comment #19) > > > arne anka: The issue seems to be there is not enough people able to > > >

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Lungten Wangchuk
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #10 from Lungten Wangchuk --- (In reply to Christoph Feck from comment #9) > > So, I should be switching to Wayland then? > > For this bug, yes. Wayland has other regressions, though. I guess I just have to be mindful of the bug and

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-16 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham, broulik, #vdg Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Méven Car
meven added a comment. New State: F6776169: energy-information-after-2.png QtControls port is not done. It is just a step. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik, filipf

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=383327 Christoph Feck changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Méven Car
meven updated this revision to Diff 56369. meven added a comment. Port to QtQuickControls 2 and proper FormLayout REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56359=56369 BRANCH arcpatch-D20598 REVISION DETAIL

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #8 from Christoph Feck --- > I can't find the relevant bug report Bug 70063 -- You are receiving this mail because: You are the assignee for the bug.

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-16 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:143 > if (batterymonitor.kcmsAuthorized) { > +plasmoid.setAction("energyinformationkcm", i18n(" > Information..."), "battery"); > plasmoid.setAction("powerdevilkcm", i18n(" Power >

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-16 Thread Méven Car
meven planned changes to this revision. meven added a comment. In D20533#450777 , @ngraham wrote: > In D20533#450711 , @broulik wrote: > > > -1 please let's cleanup / rewrite the energy info kcm

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Filip Fila
filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. Here's what works: Repeater { id: helloThere // I'll leave the naming up to you :) model: root.details Kirigami.FormLayout {

D20576: Add new notifications KCM

2019-04-16 Thread Nathaniel Graham
ngraham added a comment. In D20576#451149 , @broulik wrote: > In D20576#450778 , @ngraham wrote: > > > The trash icons in the app list make me think that it's going to uninstall those apps lol >

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Lungten Wangchuk
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #7 from Lungten Wangchuk --- (In reply to Kai Uwe Broulik from comment #6) > > Has this issue been discussed somewhere and declared to be unfixable at all? > > Of course, over and over again. I can't find the relevant bug report right >

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Filip Fila
filipf added a comment. Looks like you'll need to use twinFormLayouts. One unfortunate thing is you can go "ha, I'll have all the layouts adjust to this specific one (with the longest label)". You'll need to have them all interlinked with one another because label length can change based on

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #6 from Kai Uwe Broulik --- > Has this issue been discussed somewhere and declared to be unfixable at all? Of course, over and over again. I can't find the relevant bug report right now, however. > Anyway, I just tried taking screenshot

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

2019-04-16 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Obsoleted by new notification system which has a better history overall REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9878 To: broulik, #plasma, hein, graesslin, #vdg, fabianr Cc: ngraham, fabianr,

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Lungten Wangchuk
https://bugs.kde.org/show_bug.cgi?id=383327 Lungten Wangchuk changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Lungten Wangchuk
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #5 from Lungten Wangchuk --- (In reply to Kai Uwe Broulik from comment #4) > I'm afraid that is unfixable on X. The context menu grabs the mouse and > keyboard and as such the lock screen cannot. The same reason print screen > button does

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=383327 Kai Uwe Broulik changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|---

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Lungten Wangchuk
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #3 from Lungten Wangchuk --- Yes, it happens when laptop lid is closed with an open context menu on X. -- You are receiving this mail because: You are the assignee for the bug.

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=383327 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #2 from

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Lungten Wangchuk
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #1 from Lungten Wangchuk --- I am running KDE Neon with Plasma 5.15.4 (latest user edition) and this bug still exists. This bug has been reported on Launchpad for Ubuntu packages here:

[plasmashell] [Bug 383327] Screen not locking on resume from suspend

2019-04-16 Thread Lungten Wangchuk
https://bugs.kde.org/show_bug.cgi?id=383327 Lungten Wangchuk changed: What|Removed |Added Platform|Debian stable |Neon Packages Version|5.8.7

D20576: Add new notifications KCM

2019-04-16 Thread Kai Uwe Broulik
broulik added a comment. In D20576#450778 , @ngraham wrote: > The trash icons in the app list make me think that it's going to uninstall those apps lol Suggestions welcome. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20445: signalplotter: Add highdpi support

2019-04-16 Thread Alexander Volkov
volkov added a comment. Beams look ugly when their width is >= 4 pixels. The idea is to draw them with the same width regardless of DPI. Another option is to not set Qt::FlatCap for thick pens, but I prefer this one. REPOSITORY R111 KSysguard Library REVISION DETAIL

D20582: Only consider player gone if really no longer part of the visible DOM

2019-04-16 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:999e790c1eeb: Only consider player gone if really no longer part of the visible DOM (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Méven Car
meven added inline comments. INLINE COMMENTS > broulik wrote in main.qml:459 > Shouldn't be neccessary as it's `QQC2.Label` For breeze dark this makes the label, dark gray on a dark background. See before screenshot. Could it be a breeze dark bug ? REPOSITORY R102 KInfoCenter REVISION

D20582: Only consider player gone if really no longer part of the visible DOM

2019-04-16 Thread Kai Uwe Broulik
broulik updated this revision to Diff 56361. broulik added a comment. - Rebase REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20582?vs=56319=56361 REVISION DETAIL https://phabricator.kde.org/D20582 AFFECTED FILES

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread David Redondo
davidre added a comment. > I haven't found a way to align Kirigami.FormLayout together in a repeater. Maybe you could use twinFormLayouts like in D19873 and D19932 ? REPOSITORY R102 KInfoCenter REVISION DETAIL

D20593: Minimize code duplication between node and its children

2019-04-16 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:7cd776720613: Minimize code duplication between node and its children (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Kai Uwe Broulik
broulik added a comment. > way to align Kirigami.FormLayout together in a repeater. Check out the `twinFormLayouts` property where you can have it manage multiple different `FormLayout` instances as a single layout INLINE COMMENTS > main.qml:21 > +import QtQuick 2.5 > import

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread Méven Car
meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Just a beginning. I haven't found a way to align Kirigami.FormLayout together in a repeater. There is still room for improvement.

D20596: Set Breeze scrollbars only on HTML tag

2019-04-16 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:2a8ac45707bd: Set Breeze scrollbars only on HTML tag (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20596?vs=56354=56358

D20596: Set Breeze scrollbars only on HTML tag

2019-04-16 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. No idea about CSS - as this commit is about breaking the style for most cases though it's probably fine. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D20596: Set Breeze scrollbars only on HTML tag

2019-04-16 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This ensures we don't mess with the website's internal scrollbars. TEST PLAN YouTube can

D20593: Minimize code duplication between node and its children

2019-04-16 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Put them into the same `Array` and operate on that. TEST PLAN In preparation for D20582

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-16 Thread Méven Car
meven added a comment. In D20492#450712 , @broulik wrote: > I think remaining time is way too unreliable for this. We first need a way to calculate a moving average before showing it i this context imho How come this be be good enough