D19011: Thunderbolt KCM and KDED module

[Nathaniel Graham]

ngraham added a comment.


  `plasma-thunderbolt` sounds fine to me FWIW.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, 
abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, 
plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham updated this revision to Diff 57692.
ngraham marked 3 inline comments as done.
ngraham added a comment.


  - Fix Units typo
  - Just put everything in one FormLayout; it's simpler

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21056?vs=57687=57692

BRANCH
  monitor-modernize-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21056

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ColorSettings.qml:45
> +
> +Kirigami.FormLayout {
> +anchors.left: parent.left

To better align the checkbox in this layout with the other layout you can set 
`twinFormLayouts` so the first one points to the second one and get:
F6813267: image.png 

Or you could go all the way and also make the second one point to the first one 
and get:
F6813269: image.png 

Personally I like solution no.1 more.

> ColorSettings.qml:60
> +anchors.right: parent.right
> +
> +enabled: setColorsManually.checked

We're having weird resizing behavior because we haven't anchored the two forms 
to each other:

F6813276: image.png 

We need to anchor the bottom layout to the top one so just assign an ID to the 
first layout and then do something like: `anchors.top: manualColors.bottom`

> GeneralSettings.qml:59
> +Item {
> +width: units.GridUnit
>  }

Indentation is not working due to uppercase typo. Just change to 
`Kirigami.Units.gridUnit` and it works!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21056

To: ngraham, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21026: Fix ToolButton remaining in a pressed state after press

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Nice little papercut fix!

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  no-highlight-color-after-press (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21026

To: filipf, mart, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20797: [dict] Modernize configuration window

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added subscribers: broulik, mart.
ngraham added a comment.
This revision is now accepted and ready to land.


  @broulik or @mart, any idea how we get Keyboard navigation working here? The 
Tab key just goes straight to the buttons and ignores the dictionary list view. 
Maybe a `FocusScope` would help?

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-dictionary-configuration-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20797

To: filipf, dfaure, ngraham, #vdg, #plasma, davidedmundson
Cc: mart, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham added a comment.


  Skeleton of a QQC2 SpinBox implementation: P381 

  
  The number in the box wasn't mouse-selectable and I wasn't able to get the 
suffix working properly. In the end I opted to stay with the QQC1 version for 
now.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21056

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21056: [System Monitor] [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot 
handle decimal values well in the QQC2 version
  - Use standard import names
  - Adjust some strings to sound a bit more natural

TEST PLAN
  - All features still work
  - Settings loaded correctly when the window appears and saved correctly
  
  F6813206: Monitor.png 
  F6813205: Colors, automatic.png 
  F6813204: Colors, Manual.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  monitor-modernize-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21056

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 57680.
filipf added a comment.


  Kirigami.Theme.viewBackgroundColor is deprecated so set the colorSet to 
Theme.View instead

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=57255=57680

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21049: [wizard] Enable 1-finger touch scrolling

[Nathaniel Graham]

ngraham added a comment.


  In D21049#461799 , @apol wrote:
  
  > Would it maybe be possible to find a more generic way to tackle this? Maybe 
at Breeze or KStyle level, this is an issue on every QListView :(.
  
  
  +1, that would be super awesome if we can find a way to provide touch 
scrolling to a bunch of QWidgets components all at once.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D21049

To: nicolasfella, #plasma, drosca
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21030: [WidgetExplorer] Fix blurry previews

[Filip Fila]

filipf added a comment.


  In D21030#461696 , @ngraham wrote:
  
  > Looks like you cherry-picked the commit onto each branch, is that right? In 
general it's preferred to land the commit onto the oldest branch and then merge 
forward. See 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
  >
  > I can help with this in the future. It can be tricky.
  
  
  Yeah, so next time start with the oldest and then merge. Got it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21030

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21049: [wizard] Enable 1-finger touch scrolling

[Aleix Pol Gonzalez]

apol added a comment.


  Would it maybe be possible to find a more generic way to tackle this? Maybe 
at Breeze or KStyle level, this is an issue on every QListView :(.
  
  Also this will be needed on different kind of devices, would it make sense to 
consider porting this to QQC2?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D21049

To: nicolasfella, #plasma, drosca
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  In D20867#461499 , @mart wrote:
  
  > In D20867#457580 , @hallas wrote:
  >
  > > In D20867#457575 , 
@davidedmundson wrote:
  > >
  > > > QToolButton::setArrowType?
  > >
  > >
  > > I just tried that, but it doesn't seem like Breeze honors this property - 
at least not for the `QToolButton` produced by `KToolBarPopupAction`. So adding
  >
  >
  > That's probably a breeze bug and that's where it should be addressed.
  >  an application can't link to breeze, especially if is private api. (and 
would explode dependencies in distros package managers)
  
  
  @mart  - I am not sure I follow? I think the QToolButton::ArrowType is 
intended for something else then what we are trying to do here. I am not trying 
to make any application depend directly on breeze. Instead these properties are 
loosely coupled, so an application setting a property doesn't impose that the 
application needs to link with breeze. It is simply a hint to the style.
  
  With that being said, I am certainly open to other ways of solving this 
problem, so feel free to pinch in ;)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21049: [wizard] Enable 1-finger touch scrolling

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Set a QScroller on the ListView

TEST PLAN
  Scrolling with touchpad: No change
  Drag one finger on a touchscreen on the devicelist: List moves

REPOSITORY
  R97 Bluedevil

BRANCH
  touchscroll

REVISION DETAIL
  https://phabricator.kde.org/D21049

AFFECTED FILES
  src/wizard/pages/discover.cpp

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16997: [kcm] Expose interface to control output property retention

[Roman Gilg]

romangg planned changes to this revision.
romangg added a comment.


  Changes still need to go back in other diffs in the series.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D16997

To: romangg, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16997: [kcm] Expose interface to control output property retention

[Roman Gilg]

romangg updated this revision to Diff 57671.
romangg added a comment.


  Rebase on series changes.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16997?vs=45768=57671

BRANCH
  1controlKcm

REVISION DETAIL
  https://phabricator.kde.org/D16997

AFFECTED FILES
  common/control.cpp
  common/control.h
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/config.cpp
  kded/output.cpp
  kded/output.h
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16996: Add method to write retention to configuration control files

[Roman Gilg]

romangg updated this revision to Diff 57670.
romangg added a comment.


  Rebase on series changes.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16996?vs=45767=57670

BRANCH
  1controlWrite

REVISION DETAIL
  https://phabricator.kde.org/D16996

AFFECTED FILES
  common/control.cpp
  common/control.h

To: romangg, #plasma, mart
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D16995: Consider identical display models in ControlConfig

[Roman Gilg]

romangg updated this revision to Diff 57667.
romangg added a comment.


  Rebase on series changes.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16995?vs=45766=57667

BRANCH
  1controlNameSpecific

REVISION DETAIL
  https://phabricator.kde.org/D16995

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp
  kded/output.cpp
  kded/output.h

To: romangg, #plasma
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D20871: Don't delete profiles and ports on update

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R994:1c30a34ba622: Dont delete profiles and ports on 
update (authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20871?vs=57110=57666#toc

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20871?vs=57110=57666

REVISION DETAIL
  https://phabricator.kde.org/D20871

AFFECTED FILES
  CMakeLists.txt
  src/card.cpp
  src/card.h
  src/card_p.h
  src/device.cpp
  src/device_p.h

To: nicolasfella, drosca
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16994: Split Control class into configurations and outputs control classes

[Roman Gilg]

romangg updated this revision to Diff 57665.
romangg added a comment.


  Rebase on series changes.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16994?vs=45764=57665

BRANCH
  1controlClass

REVISION DETAIL
  https://phabricator.kde.org/D16994

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16992: Introduce secondary control channel of the KScreen daemon

[Roman Gilg]

romangg updated this revision to Diff 57662.
romangg added a comment.


  Rebase on series changes.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16992?vs=45762=57662

BRANCH
  1controlRetention

REVISION DETAIL
  https://phabricator.kde.org/D16992

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/229fa9e8a378cb151d7302df42666774
  tests/kded/serializerdata/control/configs/8684e883209d7644eb76feea2081c431
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16993: Add a common directory for functionality being used by kcm and daemon

[Roman Gilg]

romangg updated this revision to Diff 57663.
romangg added a comment.


  Rebase on series changes.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16993?vs=45763=57663

BRANCH
  1commonInterfacesWithClass

REVISION DETAIL
  https://phabricator.kde.org/D16993

AFFECTED FILES
  common/control.cpp
  common/control.h
  common/globals.cpp
  common/globals.h
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16991: Introduce concept of global and individual output data retention

[Roman Gilg]

romangg updated this revision to Diff 57661.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16991?vs=45760=57661

BRANCH
  1dirIndividualOutputs

REVISION DETAIL
  https://phabricator.kde.org/D16991

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt

To: romangg, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16990: [kded] Change configuration storage path

[Roman Gilg]

romangg updated this revision to Diff 57660.
romangg added a comment.


  - Fix rebase error

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16990?vs=57659=57660

BRANCH
  1configsLocation

REVISION DETAIL
  https://phabricator.kde.org/D16990

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  tests/kded/configtest.cpp

To: romangg, #plasma
Cc: davidedmundson, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16990: [kded] Change configuration storage path

[Roman Gilg]

romangg updated this revision to Diff 57659.
romangg added a comment.


  - Rebase on master.
  - Prepare changing the configuration path for KDE6.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16990?vs=45758=57659

BRANCH
  1configsLocation

REVISION DETAIL
  https://phabricator.kde.org/D16990

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  tests/kded/configtest.cpp

To: romangg, #plasma
Cc: davidedmundson, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21030: [WidgetExplorer] Fix blurry previews

[Nathaniel Graham]

ngraham added a comment.


  Looks like you cherry-picked the commit onto each branch, is that right? In 
general it's preferred to land the commit onto the oldest branch and then merge 
forward. See 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
  
  I can help with this in the future. It can be tricky.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21030

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16989: [kded] Introduce Config wrapper class

[Roman Gilg]

romangg updated this revision to Diff 57655.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16989?vs=45756=57655

BRANCH
  1configClass

REVISION DETAIL
  https://phabricator.kde.org/D16989

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializertest.cpp

To: romangg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/30/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 06 May 2019 15:37:47 +
 Build duration:
34 sec and counting
   CONSOLE OUTPUT
  [...truncated 372 lines...][2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[ru]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[sk]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[sl]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[sr]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[sv]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[tr]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[uk]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[x-test]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to string[2019-05-06T15:38:14.093Z] Unknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to string[2019-05-06T15:38:14.093Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-pa/kf5-qt5 FreeBSDQt5.12/build/src/kcm/kcm_pulseaudio.json" [2019-05-06T15:38:14.093Z] [2019-05-06T15:38:14.093Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-API" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-RootPath" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-MainScript" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-NotificationArea" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-DBusActivationService" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-KDE-ParentApp" with type "QString"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-Provides" with type "QStringList"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-PreloadWeight" with type "int"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-StandAloneApp" with type "bool"[2019-05-06T15:38:14.093Z] Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"[2019-05-06T15:38:14.093Z] Found property definition "NoDisplay" with type "bool"[2019-05-06T15:38:14.093Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-pa/kf5-qt5 FreeBSDQt5.12/build/applet/org.kde.plasma.volume-plasmoids-metadata.json" [2019-05-06T15:38:14.093Z] [2019-05-06T15:38:14.093Z] [ 11%] Built target kcm_pulseaudio-kcms-metadata-json[2019-05-06T15:38:14.093Z] [ 13%] Built target org.kde.plasma.volume-plasmoids-metadata-json[2019-05-06T15:38:14.093Z] [ 13%] Automatic MOC for target kcm_pulseaudio[2019-05-06T15:38:14.093Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-qrc[2019-05-06T15:38:14.093Z] [ 13%] Built target org.kde.plasma.volume-plasmoids-qrc[2019-05-06T15:38:14.093Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-06T15:38:14.093Z] [ 16%] Generating org.kde.plasma.volume-contents.rcc[2019-05-06T15:38:14.093Z] [ 16%] Built target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-06T15:38:15.466Z] [ 16%] Built target doc-kcontrol-plasma-pa-index-cache-bz2[2019-05-06T15:38:15.466Z] [ 16%] Built target kcm_pulseaudio_autogen[2019-05-06T15:38:15.466Z] Scanning dependencies of target kcm_pulseaudio[2019-05-06T15:38:15.466Z] [ 18%] Building CXX object src/kcm/CMakeFiles/kcm_pulseaudio.dir/kcm_pulseaudio_autogen/mocs_compilation.cpp.o[2019-05-06T15:38:15.466Z] [ 20%] Building CXX object 

D21048: There's no virtual sources, just source outputs

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:cde3ecde25c7: [Microphone Indicator] Theres no 
virtual sources, just source outputs (authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21048?vs=57651=57653

REVISION DETAIL
  https://phabricator.kde.org/D21048

AFFECTED FILES
  src/qml/microphoneindicator.cpp

To: broulik, #plasma, drosca, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21047: [Microphone Indicator] Schedule update initially

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:2225ea1570f2: [Microphone Indicator] Schedule update 
initially (authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21047?vs=57649=57654

REVISION DETAIL
  https://phabricator.kde.org/D21047

AFFECTED FILES
  src/qml/microphoneindicator.cpp

To: broulik, #plasma, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20576: Add new notifications KCM

[Kai Uwe Broulik]

broulik updated this revision to Diff 57652.
broulik added a comment.


  - Load source model only on sources page but do so immediately there when 
needed
  - Don't set width inside layout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20576?vs=57047=57652

REVISION DETAIL
  https://phabricator.kde.org/D20576

AFFECTED FILES
  CMakeLists.txt
  kcms/notifications/CMakeLists.txt
  kcms/notifications/Messages.sh
  kcms/notifications/filterproxymodel.cpp
  kcms/notifications/filterproxymodel.h
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/kcm_notifications.desktop
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/PopupPositionPage.qml
  kcms/notifications/package/contents/ui/ScreenPositionSelector.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/package/metadata.desktop
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: broulik, #plasma, #vdg
Cc: davidedmundson, mart, ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20871: Don't delete profiles and ports on update

[David Rosca]

drosca accepted this revision.
drosca added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> card.cpp:78
> +const QList profileKeys = m_profiles.keys();
> +for (const QString& profileKey : profileKeys) {
> +if (!newProfiles.contains(profileKey)) {

`const QString `

> card.cpp:99
> +const QList portKeys = m_ports.keys();
> +for (const QString& portKey : profileKeys) {
> +if (!newPorts.contains(portKey)) {

coding style

> device.cpp:53
>  {
> -return d->m_ports;
> +return QVector::fromList(d->m_ports.values());
>  }

This is not ideal, but other than keeping and updating the vector with the hash 
there is no other way.

> device_p.h:94
> +const QList keys = m_ports.keys();
> +for (const QString& portKey : keys) {
> +if (!newPorts.contains(portKey)) {

coding style

REPOSITORY
  R994 Pulseaudio Qt Bindings

BRANCH
  keep

REVISION DETAIL
  https://phabricator.kde.org/D20871

To: nicolasfella, drosca
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21029: UpdatesPage: Don't try to translate version numbers

[Nathaniel Graham]

ngraham added a comment.


  In D21029#461379 , @apol wrote:
  
  > Yep, change isn't correct. A solution would be to ad an installedVersion && 
availableVersion ? i18n(...) : "".
  
  
  +1

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21029

To: jbbgameich, #discover_software_store
Cc: ngraham, apol, pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20871: Don't delete profiles and ports on update

[Nicolas Fella]

nicolasfella added a comment.


  @drosca Does this look good to you?

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D20871

To: nicolasfella, drosca
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21048: There's no virtual sources, just source outputs

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Still get microphone indicator. Not tested this "virtual" thing for a lack of 
knowledge what this is

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D21048

AFFECTED FILES
  src/qml/microphoneindicator.cpp

To: broulik, #plasma, drosca, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21030: [WidgetExplorer] Fix blurry previews

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:29f0bea89889: [WidgetExplorer] Fix blurry previews 
(authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21030?vs=57617=57650

REVISION DETAIL
  https://phabricator.kde.org/D21030

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21047: [Microphone Indicator] Schedule update initially

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Catches recording streams running before plasma started.

TEST PLAN
  Ran `arecord`, restarted plasmashell, got a microphone indicator right away. 
Previously it went unnoticed.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D21047

AFFECTED FILES
  src/qml/microphoneindicator.cpp

To: broulik, #plasma, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  In D20908#461487 , @mart wrote:
  
  > from the screenshots, i like it a lot,the code seems clean enough.
  >
  > However, to continue with that i think some attempt should be done to make 
qwidget based apps follow this as well. (I think we should go on a campaign to 
remove unnecessary frames here too)
  
  
  I absolutely agree 100% on both points.
  
  > with qwidget is perhaps slightly harder to do, but should be totally 
possible
  >  F6811626: Screenshot_20190506_123026.png 

  
  Boom, awesome! How hard would it be to clean up the code to make that 
submittable?
  
  > another issue is that (as kirigami apps) this may look a bit bad with the 
window borders which unfortunately are still default on
  
  That's in progress right now. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21013: [PanelView] remove outdated hack to support mask without compositing

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1f37ba3b81f2: [PanelView] remove outdated hack to support 
mask without compositing (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21013?vs=57541=57645

REVISION DETAIL
  https://phabricator.kde.org/D21013

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma, mart
Cc: davidedmundson, mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Andres Betts]

abetts added a comment.


  Love it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20265: Introduce libnotificationmanager

[Kai Uwe Broulik]

broulik updated this revision to Diff 57643.
broulik added a comment.


  - Update patch to include changes in repo, 
4269a3b407f339a60b0ccee017278650d2681352 
 and 
86260aba9a49adeb1f02c0ce108752ba42d8f811 


REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20265?vs=56056=57643

REVISION DETAIL
  https://phabricator.kde.org/D20265

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/LibNotificationManagerConfig.cmake.in
  libnotificationmanager/autotests/CMakeLists.txt
  libnotificationmanager/autotests/notifications_test.cpp
  libnotificationmanager/dbus/org.freedesktop.Notifications.xml
  libnotificationmanager/dbus/org.kde.JobViewServer.xml
  libnotificationmanager/dbus/org.kde.JobViewServerV2.xml
  libnotificationmanager/dbus/org.kde.JobViewV2.xml
  libnotificationmanager/dbus/org.kde.JobViewV3.xml
  libnotificationmanager/dbus/org.kde.kuiserver.xml
  libnotificationmanager/declarative/CMakeLists.txt
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/declarative/notificationmanagerplugin.h
  libnotificationmanager/declarative/qmldir
  libnotificationmanager/job.cpp
  libnotificationmanager/job.h
  libnotificationmanager/job_p.cpp
  libnotificationmanager/job_p.h
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/jobsmodel.h
  libnotificationmanager/jobsmodel_p.cpp
  libnotificationmanager/jobsmodel_p.h
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/libnotificationmanager.categories
  libnotificationmanager/limitedrowcountproxymodel.cpp
  libnotificationmanager/limitedrowcountproxymodel_p.h
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/notificationfilterproxymodel_p.h
  libnotificationmanager/notificationgroupcollapsingproxymodel.cpp
  libnotificationmanager/notificationgroupcollapsingproxymodel_p.h
  libnotificationmanager/notificationgroupingproxymodel.cpp
  libnotificationmanager/notificationgroupingproxymodel_p.h
  libnotificationmanager/notifications.cpp
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/notificationsortproxymodel.cpp
  libnotificationmanager/notificationsortproxymodel_p.h
  libnotificationmanager/plasmanotifyrc
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h
  libnotificationmanager/utils.cpp
  libnotificationmanager/utils_p.h

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D21030: [WidgetExplorer] Fix blurry previews

[Nathaniel Graham]

ngraham added a comment.


  I was thinking 5.15 only, but 5.12 too is probably fine for a focused change 
like this.
  
  
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-blurry-previews-widget-explorer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21030

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21030: [WidgetExplorer] Fix blurry previews

[Filip Fila]

filipf added a comment.


  In D21030#461363 , @ngraham wrote:
  
  > Nice! Stable branch please.
  
  
  So both 5.12 and 5.15?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-blurry-previews-widget-explorer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21030

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20265: Introduce libnotificationmanager

[Kai Uwe Broulik]

broulik marked 8 inline comments as done.
broulik added inline comments.

INLINE COMMENTS

> hein wrote in notifications.cpp:76
> Have you considered using `KModelIndexProxyMapper` from KF5::ItemModels?

I have, it doesn't work for this usecase. It can only map a tree via a single 
model, we have it the other way round, we have a single proxy chain diverging 
into two. Also, `KConcatenateRowsProxyModel` isn't a proper proxy model, so it 
completely breaks `KModelIndexProxyMapper`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20265: Introduce libnotificationmanager

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> job.cpp:30
> +
> +#include 
> +

Unused?

> notificationgroupcollapsingproxymodel.cpp:194
> +{
> +if (source_parent.isValid() && m_limit > 0) {
> +if (!m_expandedGroups.isEmpty() && 
> m_expandedGroups.contains(source_parent)) {

Check m_limit first for a tiny speedup.

> notifications.cpp:76
> +static uint notificationId(const QModelIndex );
> +QModelIndex mapFromModel(const QModelIndex ) const;
> +

Have you considered using `KModelIndexProxyMapper` from KF5::ItemModels?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  that's a veeery quick and dirty attempt: (so hacky that there is not really 
usable code i'm afraid)
  F6811626: Screenshot_20190506_123026.png 

  
  apart the lack of right margin, that should be easily fixable, the worst 
parts seem to be the repositioning of bottom buttons, putting the help button 
where it is in the screenshot was really an ugly and unreliable hack.
  also that remaining 2 pixels margins around the sidebar doesn't seem to be 
easily killable
  
  if somebody wants to do more research, is very welcome

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

monday meeting notes for 6/5/2019

[Marco Martin]

Kai Uwe:
Work done:
 - Added DesktopEntry to various application notifyrc files so they can be 
identified as apps by the new KCM
 -- kget, discover, kdevelop
 - Merged KWin patches for critical notifications (show on top of fullscreen 
windows)
 - plasma-browser-integration:
 -- Handles "muted" property on player now, unfortunately MPRIS has no concept 
of "Muted"
 -- Made patch to handle iframes better: D21038
Diff 21038 "Also store the player's frame ID" [Needs Review] https://
phabricator.kde.org/D21038
 - Discussed with Latte Dock maintainer notification/job tracking changes
 - Found Qt bug in QQC2 SpinBox, QTBUG-75605 (luckily doesn't really affect 
us)
 Work todo:
 - Migrate Task Manager to new lib to follow its settings for badges and 
progress

Eike:
$dayjob is still keeping me from Plasma code, which not great because there's 
some bug reports I should really fix
On Sunday I read about half of kbroulik's new notifications lib and wrote some 
review comments. It looks pretty good so far. I'll read some more later today

Marco:
Kirigami:
* fix qmake stuff
* investigating active/inactive colors sync with qquickwidget
Plasma:
* fixed the horizontal scrollbar sometimes appearing in plasmoid config 
dialogs
on a partly related note:
* started a C++ prototype for a plasmoids layout manager, still in 
experimental phase to see if it's worth, hope to get it in standard plasma 
desktop layout in the future
-- 
Marco Martin

D18394: Add OTP support for openconnect VPN

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:8fb5c6192c15: Add OTP support for openconnect VPN 
(authored by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18394?vs=57394=57634#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18394?vs=57394=57634

REVISION DETAIL
  https://phabricator.kde.org/D18394

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/nm-openconnect-service.h
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauth.h
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectauthworkerthread.h
  vpn/openconnect/openconnectprop.ui
  vpn/openconnect/openconnecttoken.ui
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/openconnectwidget.h

To: enriquem, jgrulich
Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20576: Add new notifications KCM

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SourcesPage.qml:60
> Can you talk me through all this:
> 
> We have a listview with a filtered model with a selected item
> We change the filter
> 
> As long as the proxies are working correctly and track a movement as a 
> movement, the currentIndex of the listview should adjust.
> 
> What does happen?

When I enter a query for which there is no result, the view gets empty and 
`ListView` gets all confused and loses the index or sets it to some random item

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20576

To: broulik, #plasma, #vdg
Cc: davidedmundson, mart, ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20576: Add new notifications KCM

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ApplicationConfiguration.qml:103
> you shouldn't specify a width inside a layout.

implicitWidth or Layout.preferredWidth

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20576

To: broulik, #plasma, #vdg
Cc: davidedmundson, mart, ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D21038: Also store the player's frame ID

[Kai Uwe Broulik]

broulik updated this revision to Diff 57633.
broulik added a comment.


  - Don't mutate while iterating

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21038?vs=57613=57633

REVISION DETAIL
  https://phabricator.kde.org/D21038

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[Marco Martin]

mart added a comment.


  In D20867#457580 , @hallas wrote:
  
  > In D20867#457575 , 
@davidedmundson wrote:
  >
  > > QToolButton::setArrowType?
  >
  >
  > I just tried that, but it doesn't seem like Breeze honors this property - 
at least not for the `QToolButton` produced by `KToolBarPopupAction`. So adding
  
  
  That's probably a breeze bug and that's where it should be addressed.
  an application can't link to breeze, especially if is private api. (and would 
explode dependencies in distros package managers)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  In D20908#458426 , @broulik wrote:
  
  > I was wondering, wouldn't it also make sense to change the layout to be 
Icon left of text to make it even more consistent with System Settings? Or will 
that eat too much horizontal space?
  
  
  I think a config window is different enough to a dedicated config app to 
justify the difference and there is better to optimize the size

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  from the screenshots, i like it a lot,the code seems clean enough.
  
  However, to continue with that i think some attempt should be done to make 
qwidget based apps follow this as well. (I think we should go on a campaign to 
remove unnecessary frames here too)
  
  with qwidget is perhaps slightly harder to do, but should be totally possible
  F6811509: Screenshot_20190506_110307.png 

  
  another issue is that (as kirigami apps) this may look a bit bad with the 
window borders which unfortunately are still default on

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/29/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 06 May 2019 08:48:31 +
 Build duration:
38 sec and counting
   CONSOLE OUTPUT
  [...truncated 372 lines...][2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[el]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[es]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[et]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[eu]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[fi]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[fr]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[gl]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[he]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[hu]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[id]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[it]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[ko]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[lt]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[nl]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[nn]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[pa]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[pl]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[pt]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[ru]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[sk]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[sl]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[sr]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[sv]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[tr]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[uk]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[x-test]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to string[2019-05-06T08:49:00.304Z] Unknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to string[2019-05-06T08:49:00.304Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-pa/kf5-qt5 FreeBSDQt5.12/build/src/kcm/kcm_pulseaudio.json" [2019-05-06T08:49:00.304Z] [2019-05-06T08:49:00.304Z] [ 11%] Built target kcm_pulseaudio-kcms-metadata-json[2019-05-06T08:49:00.304Z] [ 11%] Built target org.kde.plasma.volume-plasmoids-metadata-json[2019-05-06T08:49:00.304Z] [ 13%] Automatic MOC for target kcm_pulseaudio[2019-05-06T08:49:00.304Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-qrc[2019-05-06T08:49:00.304Z] [ 13%] Built target org.kde.plasma.volume-plasmoids-qrc[2019-05-06T08:49:00.304Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-06T08:49:00.304Z] [ 16%] Generating org.kde.plasma.volume-contents.rcc[2019-05-06T08:49:00.304Z] [ 16%] Built target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-06T08:49:01.692Z] [ 16%] Built target doc-kcontrol-plasma-pa-index-cache-bz2[2019-05-06T08:49:01.692Z] [ 16%] Built target kcm_pulseaudio_autogen[2019-05-06T08:49:01.692Z] Scanning dependencies of target kcm_pulseaudio[2019-05-06T08:49:01.692Z] [ 18%] Building CXX object 

D21045: Don't play sound when muting

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:ada2f9c75019: Dont play sound when muting (authored 
by nicolasfella).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21045?vs=57631=57632

REVISION DETAIL
  https://phabricator.kde.org/D21045

AFFECTED FILES
  applet/contents/ui/main.qml

To: nicolasfella, drosca, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21045: Don't play sound when muting

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When the user presses the mute key to mute the sound they explicitely don't 
want sound. E.g. when they are in a public place and mute their system playing 
a sound is awkward

TEST PLAN
  On an unmuted system press mute button -> no sound played
  Press mute button again -> sound is played

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  nosound

REVISION DETAIL
  https://phabricator.kde.org/D21045

AFFECTED FILES
  applet/contents/ui/main.qml

To: nicolasfella, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21044: Remove kde connect context menu entries when host dies

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  They don't work without a host and up on (re)starting we get a `deviceAdded` 
signal for every device leading to duplicate menu id errors.

TEST PLAN
  killed `plasma-browser-integration-host` process, didn't get a warning about 
duplicate ids on extension console anymore
  Disabling and enabling kde connect integration properly adds and removes the 
entries

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21044

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20925: Also handle muted property on player

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:1ce07b1cec31: Also handle muted property on player 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20925?vs=57286=57627

REVISION DETAIL
  https://phabricator.kde.org/D20925

AFFECTED FILES
  extension/content-script.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt
Cc: nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=348529

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||brai1...@gmail.com

--- Comment #29 from Kai Uwe Broulik  ---
*** Bug 407261 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.